Skip to contentSkip to conversation

package/lzo: switch to cmake

PATCH New Bernd Kuhls 4 participants 5 messages Aug 20, 2017 – Aug 21, 2017

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH v2 1/1 package/lzo: switch to cmake

autoreconf for the host package is broken after bumping to 2.10:
http://lists.busybox.net/pipermail/buildroot/2017-August/200634.html

To solve the problem we switch to cmake.

Signed-off-by Bernd Kuhls <[email protected]>

---
v2: patch is for next branch

 package/lzo/lzo.mk | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
package/lzo/lzo.mk +3 -5
index 5b8efdd54..dba965fcd 100644
@@ -9,9 +9,7 @@ LZO_SITE = http://www.oberhumer.com/opensource/lzo/download
 LZO_LICENSE = GPL-2.0+
 LZO_LICENSE_FILES = COPYING
 LZO_INSTALL_STAGING = YES
-# Ships a beta libtool version hence our patch doesn't apply.
-# Run autoreconf to regenerate ltmain.sh.
-LZO_AUTORECONF = YES
+LZO_SUPPORTS_IN_SOURCE_BUILD = NO
 
-$(eval $(autotools-package))
-$(eval $(host-autotools-package))
+$(eval $(cmake-package))
+$(eval $(host-cmake-package))
Signature · 1 line
2.11.0
#1 lore raw

PATCH v2 1/1 package/lzo: switch to cmake

Hello,

Quoted 6 lines · Bernd Kuhls

autoreconf for the host package is broken after bumping to 2.10:
http://lists.busybox.net/pipermail/buildroot/2017-August/200634.html

To solve the problem we switch to cmake.

Signed-off-by Bernd Kuhls <[email protected]>

[It fixes the scenarios tested by the test infra in the next branch
https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/29798693 ]

Tested-by Ricardo Martincoski <[email protected]>

Regards,
Ricardo

#2 lore raw

PATCH v2 1/1 package/lzo: switch to cmake

In reply to Bernd Kuhls
Quoted 1 line · Bernd Kuhls

+LZO_SUPPORTS_IN_SOURCE_BUILD = NO

Why doesn't it support in-source build? Best to explain that in the commit message.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#3 lore raw

PATCH v2 1/1 package/lzo: switch to cmake

Hello,

Quoted 4 lines · Arnout Vandecappelle
Quoted 1 line · Bernd Kuhls

+LZO_SUPPORTS_IN_SOURCE_BUILD = NO

Why doesn't it support in-source build? Best to explain that in the commit message.

It's actually quite common for cmake packages to not support in-tree build:

package/gnuradio/gnuradio.mk:GNURADIO_SUPPORTS_IN_SOURCE_BUILD = NO package/gr-osmosdr/gr-osmosdr.mk:GR_OSMOSDR_SUPPORTS_IN_SOURCE_BUILD = NO package/jasper/jasper.mk:JASPER_SUPPORTS_IN_SOURCE_BUILD = NO package/lapack/lapack.mk:LAPACK_SUPPORTS_IN_SOURCE_BUILD = NO package/lensfun/lensfun.mk:LENSFUN_SUPPORTS_IN_SOURCE_BUILD = NO package/libcodec2/libcodec2.mk:LIBCODEC2_SUPPORTS_IN_SOURCE_BUILD = NO package/libssh/libssh.mk:LIBSSH_SUPPORTS_IN_SOURCE_BUILD = NO package/lzo/lzo.mk:LZO_SUPPORTS_IN_SOURCE_BUILD = NO package/racehound/racehound.mk:RACEHOUND_SUPPORTS_IN_SOURCE_BUILD = NO package/sysdig/sysdig.mk:SYSDIG_SUPPORTS_IN_SOURCE_BUILD = NO package/zxing-cpp/zxing-cpp.mk:ZXING_CPP_SUPPORTS_IN_SOURCE_BUILD = NO

and we've never really asked people to explain why. I wouldn't mind a comment on top of the SUPPORTS_IN_SOURCE_BUILD = NO line in the .mk file, but I'm not sure I want to make this absolutely necessary.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Applied
#4 lore raw

PATCH v2 1/1 package/lzo: switch to cmake

In reply to Bernd Kuhls

Hello,

Quoted 8 lines · Bernd Kuhls

autoreconf for the host package is broken after bumping to 2.10:
http://lists.busybox.net/pipermail/buildroot/2017-August/200634.html

To solve the problem we switch to cmake.

Signed-off-by Bernd Kuhls <[email protected]>

---
v2: patch is for next branch

Applied to next, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com