Skip to contentSkip to conversation

package/x11r7/xlib_libXpm: needs host-gettext

PATCH New Bernd Kuhls 2 participants 3 messages Aug 22, 2017 – Jan 7, 2018

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH 1/1 package/x11r7/xlib_libXpm: needs host-gettext

https://git.buildroot.net/buildroot/commit/package/x11r7?id=e398ec92e9ad04e5bbae32f03cd18a53b5761517
removed the host-gettext dependency. Since then building the package fails on hosts without the xgettext binary:

/bin/sh: xgettext: command not found

Fixes
http://autobuild.buildroot.net/results/75c/75c50e617349d327713cba9bc97163bb2c9a6943/

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/x11r7/xlib_libXpm/xlib_libXpm.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/x11r7/xlib_libXpm/xlib_libXpm.mk +1 -1
index e781a8b518..ec50a42228 100644
@@ -14,6 +14,6 @@ XLIB_LIBXPM_INSTALL_STAGING = YES
 XLIB_LIBXPM_AUTORECONF = YES
 XLIB_LIBXPM_DEPENDENCIES = xlib_libX11 xlib_libXext xlib_libXt xproto_xproto \
 	$(if $(BR2_PACKAGE_LIBICONV),libiconv) \
-	$(TARGET_NLS_DEPENDENCIES)
+	host-gettext $(TARGET_NLS_DEPENDENCIES)
 
 $(eval $(autotools-package))
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 package/x11r7/xlib_libXpm: needs host-gettext

Hello,

Quoted 19 lines · Bernd Kuhls

https://git.buildroot.net/buildroot/commit/package/x11r7?id=e398ec92e9ad04e5bbae32f03cd18a53b5761517
removed the host-gettext dependency. Since then building the package fails on hosts without the xgettext binary:

/bin/sh: xgettext: command not found

Fixes
http://autobuild.buildroot.net/results/75c/75c50e617349d327713cba9bc97163bb2c9a6943/

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/x11r7/xlib_libXpm/xlib_libXpm.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/x11r7/xlib_libXpm/xlib_libXpm.mk +0 -0
index e781a8b518..ec50a42228 100644

package/x11r7/xlib_libXpm/xlib_libXpm.mk XLIB_LIBXPM_INSTALL_STAGING = YES · line 17

Quoted 5 lines
package/x11r7/xlib_libXpm/xlib_libXpm.mk +1 -1
@@ -14,6 +14,6 @@ XLIB_LIBXPM_INSTALL_STAGING = YES
 XLIB_LIBXPM_AUTORECONF = YES
 XLIB_LIBXPM_DEPENDENCIES = xlib_libX11 xlib_libXext xlib_libXt xproto_xproto \
 	$(if $(BR2_PACKAGE_LIBICONV),libiconv) \
-	$(TARGET_NLS_DEPENDENCIES)
+	host-gettext $(TARGET_NLS_DEPENDENCIES)

This is not a great fix. Indeed, TARGET_NLS_DEPENDENCIES already contains host-gettext, but only if BR2_ENABLE_SYSTEM_NLS=y.

So instead, what we need, is to make sure xlib_libXpm doesn't build its PO files if --disable-nls is passed.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 package/x11r7/xlib_libXpm: needs host-gettext

Am Tue, 22 Aug 2017 23:01:52 +0200 schrieb Thomas Petazzoni:

Quoted 4 lines

Hello,

Quoted 1 line · Bernd Kuhls

https://git.buildroot.net/buildroot/commit/package/x11r7?

id=e398ec92e9ad04e5bbae32f03cd18a53b5761517

Quoted 4 lines
Quoted 4 lines

removed the host-gettext dependency. Since then building the package fails on hosts without the xgettext binary:

/bin/sh: xgettext: command not found

Hi,

superseded by http://patchwork.ozlabs.org/patch/856573/

Regards, Bernd