drm/i915/dp: Don't invalidate intel_dp_detect result
Subsystems (2)
PATCH 1/1 drm/i915/dp: Don't invalidate intel_dp_detect result
If the full detect is already done, we shouldn't need to do it again.
This fixes the screen blinking issue that happen when calling DRM_IOCTL_MODE_GETCONNECTOR while PSR is active. The blinking is caused by full dp detect in intel_dp_long_pulse().
--- drivers/gpu/drm/i915/intel_dp.c | 2 -- 1 file changed, 2 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +0 -2
@@ -4834,8 +4834,6 @@ intel_dp_detect(struct drm_connector *connector,if (!intel_dp->detect_done) status =intel_dp_long_pulse (intel_dp->attached_connector); - intel_dp->detect_done = false; -return status; }
Signature · 6 lines
2.14.1.342.g6490525c54-goog _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/dp: Don't invalidate intel_dp_detect result
== Series Details ==
== Series Details ==
Series: drm/i915/dp: Don't invalidate intel_dp_detect result
URL : https://patchwork.freedesktop.org/series/29247/
State : success
== Summary ==
Series 29247v1 drm/i915/dp: Don't invalidate intel_dp_detect result
https://patchwork.freedesktop.org/api/1.0/series/29247/revisions/1/mbox/
Test kms_flip:
Subgroup basic-flip-vs-modeset:
skip -> PASS (fi-skl-x1585l) fdo#101781
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-n2820) fdo#101705
Subgroup suspend-read-crc-pipe-c:
fail -> PASS (fi-skl-6700k) fdo#100367fdo#101781 https://bugs.freedesktop.org/show_bug.cgi?id=101781
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fdo#100367 https://bugs.freedesktop.org/show_bug.cgi?id=100367
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:456s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:438s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:365s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:559s fi-bwr-2160 total:279 pass:184 dwarn:0 dfail:0 fail:0 skip:95 time:253s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:526s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:526s fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:513s fi-elk-e7500 total:279 pass:230 dwarn:0 dfail:0 fail:0 skip:49 time:435s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:611s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:447s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:419s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:418s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:499s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:475s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:478s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:598s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:591s fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:527s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:468s fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:485s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:484s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:439s fi-skl-x1585l total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:501s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:547s fi-snb-2600 total:279 pass:250 dwarn:0 dfail:0 fail:0 skip:29 time:410s
3adc9e3cacefe82619fc56ec78a0ca3a67a4b00c drm-tip: 2017y-08m-23d-21h-35m-35s UTC integration manifest 8066b1a7436d drm/i915/dp: Don't invalidate intel_dp_detect result
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5481/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 17 lines · Puthikorn Voravootivat
If the full detect is already done, we shouldn't need to do it again.
This fixes the screen blinking issue that happen when calling
DRM_IOCTL_MODE_GETCONNECTORwhile PSR is active. The blinking is caused by full dp detect inintel_dp_long_pulse().Signed-off-by Puthikorn Voravootivat <[email protected]>--- drivers/gpu/drm/i915/intel_dp.c | 2 -- 1 file changed, 2 deletions(-)drivers/gpu/drm/i915/intel_dp.c +0
-0
drivers/gpu/drm/i915/intel_dp.c intel_dp_detect(struct drm_connector *connector, · line 4838
Quoted 5 lines
drivers/gpu/drm/i915/intel_dp.c +0
-2@@ -4834,8 +4834,6 @@ intel_dp_detect(struct drm_connector *connector,if (!intel_dp->detect_done) status =intel_dp_long_pulse (intel_dp->attached_connector); - intel_dp->detect_done = false; -
something tells me that this will break other existent cases... one case I imagine is changing the DP panel... maybe the MST case as well..
what about instead of removing this "detect_done=false" like we move to another place like whenever conector is disconected?
looking to original commit:
commit 7d23e3c37bb3fc6952dc84007ee60cb533fd2d5c
Author: Shubhangi Shrivastava <[email protected]>
let's cc few people here to see if they have something to say...
Quoted 10 lines
drivers/gpu/drm/i915/intel_dp.c +0
-1return status; } --2.14.1.342.g6490525c54-goog
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 2 lines
what about instead of removing this "detect_done=false" like we move to another place like whenever conector is disconected?
Look like that is already done in
https://patchwork.freedesktop.org/patch/113363/
Quoted 52 lines · Rodrigo Vivi
Quoted 17 lines · Puthikorn Voravootivat
If the full detect is already done, we shouldn't need to do it again.
This fixes the screen blinking issue that happen when calling
DRM_IOCTL_MODE_GETCONNECTORwhile PSR is active. The blinking is caused by full dp detect inintel_dp_long_pulse().Signed-off-by Puthikorn Voravootivat <[email protected]>--- drivers/gpu/drm/i915/intel_dp.c | 2 -- 1 file changed, 2 deletions(-)drivers/gpu/drm/i915/intel_dp.c +0
-0drivers/gpu/drm/i915/intel_dp.c intel_dp_detect(struct drm_connector *connector, · line 4838
Quoted 5 lines
drivers/gpu/drm/i915/intel_dp.c +0
-2@@ -4834,8 +4834,6 @@ intel_dp_detect(struct drm_connector *connector,if (!intel_dp->detect_done) status =intel_dp_long_pulse (intel_dp->attached_connector); - intel_dp->detect_done = false; -something tells me that this will break other existent cases... one case I imagine is changing the DP panel... maybe the MST case as well..
what about instead of removing this "detect_done=false" like we move to another place like whenever conector is disconected?
looking to original commit:
commit7d23e3c37bb3fc6952dc84007ee60cb533fd2d5c
Author: Shubhangi Shrivastava <[email protected]>let's cc few people here to see if they have something to say...
Quoted 10 lines
drivers/gpu/drm/i915/intel_dp.c +0
-1return status; } --2.14.1.342.g6490525c54-goog
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 3 lines
--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 5 lines · Puthikorn Voravootivat
Quoted 2 lines
what about instead of removing this "detect_done=false" like we move to another place like whenever conector is disconected?
Look like that is already done in
https://patchwork.freedesktop.org/patch/113363/
hmm indeed that seems to address my first thoughts... but this also shows we need to cc ville as well here...
Quoted 57 lines · Rodrigo Vivi
Quoted 55 lines
Quoted 17 lines · Puthikorn Voravootivat
If the full detect is already done, we shouldn't need to do it again.
This fixes the screen blinking issue that happen when calling
DRM_IOCTL_MODE_GETCONNECTORwhile PSR is active. The blinking is caused by full dp detect inintel_dp_long_pulse().Signed-off-by Puthikorn Voravootivat <[email protected]>--- drivers/gpu/drm/i915/intel_dp.c | 2 -- 1 file changed, 2 deletions(-)drivers/gpu/drm/i915/intel_dp.c +0
-0drivers/gpu/drm/i915/intel_dp.c intel_dp_detect(struct drm_connector *connector, · line 4838
Quoted 5 lines
drivers/gpu/drm/i915/intel_dp.c +0
-2@@ -4834,8 +4834,6 @@ intel_dp_detect(struct drm_connector *connector,if (!intel_dp->detect_done) status =intel_dp_long_pulse (intel_dp->attached_connector); - intel_dp->detect_done = false; -something tells me that this will break other existent cases... one case I imagine is changing the DP panel... maybe the MST case as well..
what about instead of removing this "detect_done=false" like we move to another place like whenever conector is disconected?
looking to original commit:
commit7d23e3c37bb3fc6952dc84007ee60cb533fd2d5c
Author: Shubhangi Shrivastava <[email protected]>let's cc few people here to see if they have something to say...
Quoted 10 lines
drivers/gpu/drm/i915/intel_dp.c +0
-1return status; } --2.14.1.342.g6490525c54-goog
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
Signature · 6 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 7 lines · Puthikorn Voravootivat
If the full detect is already done, we shouldn't need to do it again.
This fixes the screen blinking issue that happen when calling
DRM_IOCTL_MODE_GETCONNECTORwhile PSR is active. The blinking is caused by full dp detect inintel_dp_long_pulse().
Thanks for the patch. Yes I completely agree with this, the main purpose of this flag was to avoid calling long pulse handler multiple times when it was being called from multiple places. Now we do not need this flag since it does a full detect every time get connector IOCTL is called since it calls intel_dp_detect().
This patch needs to remove the detect_done from all the other places where its being set and from intel_dp struct as well.
I had already submitted a patch for this a while ago:
https://patchwork.freedesktop.org/patch/137592/
Please take a look. However if you read the M-L archive, you will find the comments and it never got accepted. Some of the arguments were that since EDID might have changed, we need to always do a full detect each time GET_CONNECTOR IOCTL is called.
Regards
Manasi
Quoted 25 lines
Signed-off-by Puthikorn Voravootivat <[email protected]>--- drivers/gpu/drm/i915/intel_dp.c | 2 -- 1 file changed, 2 deletions(-)drivers/gpu/drm/i915/intel_dp.c +0
-2@@ -4834,8 +4834,6 @@ intel_dp_detect(struct drm_connector *connector,if (!intel_dp->detect_done) status =intel_dp_long_pulse (intel_dp->attached_connector); - intel_dp->detect_done = false; -return status; }Signature · 6 lines
2.14.1.342.g6490525c54-goog _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx