Skip to contentSkip to conversation

Input: ambakmi: constify amba_id

PATCH Applied Arvind Yadav 2 participants 2 messages Aug 23, 2017 – Aug 24, 2017

Subsystems (3)
HID Input drivers Arm primecell kmi PL050 driver
lore
Share & tools
lore

Arvind Yadav

author
#0 lore raw

PATCH 1/1 Input: ambakmi: constify amba_id

amba_id are not supposed to change at runtime. All functions working with const amba_id. So mark the non-const structs as const.

Signed-off-by Arvind Yadav <[email protected]>
---
 drivers/input/serio/ambakmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/serio/ambakmi.c +1 -1
index c6606ca..ff3875c 100644
@@ -187,7 +187,7 @@ static int __maybe_unused amba_kmi_resume(struct device *dev)
 
 static SIMPLE_DEV_PM_OPS(amba_kmi_dev_pm_ops, NULL, amba_kmi_resume);
 
-static struct amba_id amba_kmi_idtable[] = {
+static const struct amba_id amba_kmi_idtable[] = {
 	{
 		.id	= 0x00041050,
 		.mask	= 0x000fffff,
Signature · 1 line
2.7.4
maintainer Applied
#1 lore raw
Quoted 4 lines · Arvind Yadav

amba_id are not supposed to change at runtime. All functions working with const amba_id. So mark the non-const structs as const.

Signed-off-by Arvind Yadav <[email protected]>

Applied, thank you.

Quoted 20 lines
---
 drivers/input/serio/ambakmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/serio/ambakmi.c +1 -1
index c6606ca..ff3875c 100644
@@ -187,7 +187,7 @@ static int __maybe_unused amba_kmi_resume(struct device *dev)
 
 static SIMPLE_DEV_PM_OPS(amba_kmi_dev_pm_ops, NULL, amba_kmi_resume);
 
-static struct amba_id amba_kmi_idtable[] = {
+static const struct amba_id amba_kmi_idtable[] = {
 	{
 		.id	= 0x00041050,
 		.mask	= 0x000fffff,
Signature · 1 line
2.7.4
Signature · 1 line
Dmitry