Skip to contentSkip to conversation

package/rpcbind: Do not mark .service and .socket files executable

PATCH New Andrey Smirnov 2 participants 3 messages Aug 23, 2017 – Aug 24, 2017

lore
Share & tools
lore

Andrey Smirnov

author
#0 lore raw

PATCH 1/1 package/rpcbind: Do not mark .service and .socket files executable

Do not mark .service and .socket files executable, otherwise systemd will give us a warning about it.

Signed-off-by Andrey Smirnov <[email protected]>
---
 package/rpcbind/rpcbind.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/rpcbind/rpcbind.mk +2 -2
index cf2e81dbbf..5c216afc93 100644
@@ -22,9 +22,9 @@ RPCBIND_CONF_OPTS += --with-systemdsystemunitdir=no
 endif
 
 define RPCBIND_INSTALL_INIT_SYSTEMD
-	$(INSTALL) -m 0755 -D package/rpcbind/rpcbind.service \
+	$(INSTALL) -m 0644 -D package/rpcbind/rpcbind.service \
 		$(TARGET_DIR)/usr/lib/systemd/system/rpcbind.service
-	$(INSTALL) -m 0755 -D package/rpcbind/rpcbind.socket \
+	$(INSTALL) -m 0644 -D package/rpcbind/rpcbind.socket \
 		$(TARGET_DIR)/usr/lib/systemd/system/rpcbind.socket
 	mkdir -p $(TARGET_DIR)/etc/systemd/system/sockets.target.wants
 	ln -fs ../../../../usr/lib/systemd/system/rpcbind.socket \
Signature · 1 line
2.13.5
Applied
#1 lore raw

PATCH 1/1 package/rpcbind: Do not mark .service and .socket files executable

Hello,

Quoted 7 lines · Andrey Smirnov

Do not mark .service and .socket files executable, otherwise systemd will give us a warning about it.

Signed-off-by Andrey Smirnov <[email protected]>
---
 package/rpcbind/rpcbind.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks. However, we have a few other packages also installing .service as 755:

package/minidlna/minidlna.mk: $(INSTALL) -D -m 0755 package/minidlna/minidlnad.service \
package/nss-pam-ldapd/nss-pam-ldapd.mk: $(INSTALL) -m 755 -D package/nss-pam-ldapd/nslcd.service \
package/transmission/transmission.mk: $(INSTALL) -D -m 0755 $(@D)/daemon/transmission-daemon.service \

Perhaps we want to fix those as well ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 package/rpcbind: Do not mark .service and .socket files executable

Quoted 11 lines · Thomas Petazzoni

Hello,

Quoted 7 lines · Andrey Smirnov

Do not mark .service and .socket files executable, otherwise systemd will give us a warning about it.

Signed-off-by Andrey Smirnov <[email protected]>
---
 package/rpcbind/rpcbind.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 8 lines

Applied to master, thanks. However, we have a few other packages also installing .service as 755:

package/minidlna/minidlna.mk: $(INSTALL) -D -m 0755 package/minidlna/minidlnad.service \
package/nss-pam-ldapd/nss-pam-ldapd.mk: $(INSTALL) -m 755 -D package/nss-pam-ldapd/nslcd.service \
package/transmission/transmission.mk: $(INSTALL) -D -m 0755 $(@D)/daemon/transmission-daemon.service \

Perhaps we want to fix those as well ?

Yeah, makes sense. I wasn't using any of those packages so I missed them. I'll send follow up patches shortly.

Thanks,
Andrey Smirnov