fs/xfs/kmem.c: fix coding style, using 'unsigned int' instead of 'unsigned'

PATCH In review Achilles Gaikwad 2 participants 2 messages Aug 25, 2017 XFS filesystem

lore

Share & tools

lore

Achilles Gaikwad

author

2017-08-25 05:27 UTC #0 lore raw

PATCH 1/1 fs/xfs/kmem.c: fix coding style, using 'unsigned int' instead of 'unsigned'

Fixes a warning given by checkpatch.pl to use 'unsigned int' instead of just 'unsigned'.

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
+ unsigned nofs_flag = 0;

Signed-off-by Achilles Gaikwad <[email protected]>

---
 fs/xfs/kmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

fs/xfs/kmem.c +1 -1

index 393b6849aeb3..a20909087e5e 100644
@@ -48,7 +48,7 @@ kmem_alloc(size_t size, xfs_km_flags_t flags)
 void *
 kmem_zalloc_large(size_t size, xfs_km_flags_t flags)
 {
-	unsigned nofs_flag = 0;
+	unsigned int nofs_flag = 0;
 	void	*ptr;
 	gfp_t	lflags;

Signature · 1 line

2.13.5

Christoph Hellwig

2017-08-25 07:45 UTC #1 lore raw

Review

Quoted 5 lines · Achilles Gaikwad

Fixes a warning given by checkpatch.pl to use 'unsigned int' instead of just 'unsigned'.
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
(quoted diff) +1 -0
+	unsigned nofs_flag = 0;

NAK. This is churn for a totally pointless warnings - there is not quantifiable benefit of 'unsigned int' which unigned has one clear advantage: it's shorter.