bcusdk: enable tpuarts support in eibd
PATCH 1/1 bcusdk: enable tpuarts support in eibd
Hey,
Please find my patch below.
It enables an extra interface type for eibd.
I don't understand why it wasn't there.
Kind regards,
Kurt
--
commit e62160001f09bff9be8e74b6d47da11c349bb2a6
Author: Kurt Van Dijck <[email protected]> Date: Thu Aug 24 09:16:36 2017
bcusdk: enable tpuarts support in eibd
This commit will enable tpuarts in eibd as well. tpuarts is equally important to FT1.2.
It makes no sense to enable only some interfaces.
package/bcusdk/bcusdk.mk +1 -0
@@ -14,6 +14,7 @@ BCUSDK_CONF_OPTS = \ --enable-onlyeibd \ --enable-ft12 \ --enable-pei16 \ + --enable-tpuarts \ --enable-eibnetip \ --enable-eibnetipserver \ --enable-eibnetiptunnel \
PATCH 1/1 bcusdk: enable tpuarts support in eibd
Hello,
Quoted 14 lines · Kurt Van Dijck
Hey,
Please find my patch below.
It enables an extra interface type for eibd.
I don't understand why it wasn't there.Kind regards,
Kurt--
commite62160001f09bff9be8e74b6d47da11c349bb2a6Author: Kurt Van Dijck <[email protected]> Date: Thu Aug 24 09:16:36 2017
Quoted 7 lines
bcusdk: enable tpuarts support in eibd
This commit will enable tpuarts in eibd as well. tpuarts is equally important to FT1.2.
It makes no sense to enable only some interfaces.Signed-off-by Kurt Van Dijck <[email protected]>
Thanks, I've applied your patch to the next branch. However, I have a few comments/questions:
- Could you use "git send-email" next time to send your patch? Indeed the formatting of your patch was not correct, so I had to fix it up manually. I.e you shouldn't be adding a "personal" message at the top of the patch, but just e-mail out the output of "git format-patch", which is exactly what "git send-email" guarantees to do correctly.
- I've added to the commit log some information about the size increase caused by this new option. Since it's just 8 KB, it doesn't justify adding a new Buildroot Config.in option.
- Our DEVELOPERS file doesn't list anyone looking after the bcusdk package. Would you be willing to take care of this package, since you're using it? Basically, it only means that you would be receiving notifications when there are build failures on this package, and potentially be CC'ed on patches touching this package.
Thanks a lot for your contribution!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 bcusdk: enable tpuarts support in eibd
Quoted 29 lines
Hello,
Quoted 14 lines · Kurt Van Dijck
Hey,
Please find my patch below.
It enables an extra interface type for eibd.
I don't understand why it wasn't there.Kind regards,
Kurt--
commite62160001f09bff9be8e74b6d47da11c349bb2a6Author: Kurt Van Dijck <[email protected]> Date: Thu Aug 24 09:16:36 2017Quoted 7 lines
bcusdk: enable tpuarts support in eibd
This commit will enable tpuarts in eibd as well. tpuarts is equally important to FT1.2.
It makes no sense to enable only some interfaces.Signed-off-by Kurt Van Dijck <[email protected]>Thanks, I've applied your patch to the next branch. However, I have a few comments/questions:
Quoted 6 lines
- Could you use "git send-email" next time to send your patch? Indeed the formatting of your patch was not correct, so I had to fix it up manually. I.e you shouldn't be adding a "personal" message at the top of the patch, but just e-mail out the output of "git format-patch", which is exactly what "git send-email" guarantees to do correctly.
Well, there has not been much reason to change, but since you're asking, I'll give it a try.
Quoted 4 lines
- I've added to the commit log some information about the size increase caused by this new option. Since it's just 8 KB, it doesn't justify adding a new Buildroot Config.in option.
I didn't understand why the different backends didn't have config options. Now I know.
Quoted 6 lines
- Our DEVELOPERS file doesn't list anyone looking after the bcusdk package. Would you be willing to take care of this package, since you're using it? Basically, it only means that you would be receiving notifications when there are build failures on this package, and potentially be CC'ed on patches touching this package.
This basically implies this has been unmaintained for a while, which explains a few things.
Well, I think that it's good idea I start to take care for the package, as I'm indeed using it.
Will you add my name in the DEVELOPERS file, or do I need to take action myself?
Kind regards,
Kurt
PATCH 1/1 bcusdk: enable tpuarts support in eibd
Hello,
Quoted 9 lines · Kurt Van Dijck
Quoted 6 lines
- Could you use "git send-email" next time to send your patch? Indeed the formatting of your patch was not correct, so I had to fix it up manually. I.e you shouldn't be adding a "personal" message at the top of the patch, but just e-mail out the output of "git format-patch", which is exactly what "git send-email" guarantees to do correctly.
Well, there has not been much reason to change, but since you're asking, I'll give it a try.
Well, your e-mail contained the personal message at the top, which gets included in the commit log by git when doing "git am". If you want to include personal messages, put them below a "---" at the end of the commit log.
Quoted 6 lines
Quoted 3 lines
- I've added to the commit log some information about the size increase caused by this new option. Since it's just 8 KB, it doesn't justify adding a new Buildroot Config.in option.
I didn't understand why the different backends didn't have config options. Now I know.
Well, it's all a matter of whether it makes sense to add gazillions of Buildroot options. For 8 KB of additional size, it doesn't make much sense.
Quoted 6 lines
This basically implies this has been unmaintained for a while, which explains a few things.
Well, I think that it's good idea I start to take care for the package, as I'm indeed using it.
Will you add my name in the DEVELOPERS file, or do I need to take action myself?
Please send a patch that adds yourself to the DEVELOPERS file for this package. Thanks a lot for adopting it!
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com