tests: chamelium: Eliminate reset when preparing output
PATCH 1/1 tests: chamelium: Eliminate reset when preparing output
Resetting the Chamelium when preparing the video output is unnecessary and significant increases the tests run-time. Since all video-related tests work just as well without it, eliminate it.
This also adds a call to reset_test in the analog frame dump test, that was missing before, although the chamelium was still reset by the call to prepare_output.
--- tests/chamelium.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tests/chamelium.c +2 -2
@@ -417,8 +417,6 @@ prepare_output(data_t *data,drmModeConnector *connector =chamelium_port_get_connector (data->chamelium, port, false); -chamelium_reset (data->chamelium); -igt_assert (res =drmModeGetResources (data->drm_fd));kmstest_unset_all_crtcs (data->drm_fd, res);
@@ -626,6 +624,8 @@ test_analog_frame_dump(data_t *data, struct chamelium_port *port)int fb_id, i;bool bridge; +reset_state (data, port); + output =prepare_output (data, &display, port); connector =chamelium_port_get_connector (data->chamelium, port, false); primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY );
Signature · 6 lines
2.14.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for tests: chamelium: Eliminate reset when preparing output
== Series Details ==
== Series Details ==
Series: tests: chamelium: Eliminate reset when preparing output
URL : https://patchwork.freedesktop.org/series/29346/
State : success
== Summary ==
IGT patchset tested on top of latest successful build 29d488034a50cd6fbad792cae61321995f0ab51c aubdump: Log some information about the execbuf calls
with latest DRM-Tip kernel build CI_DRM_3003f22dadc265b3 drm-tip: 2017y-08m-25d-11h-48m-56s UTC integration manifest
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-atomic:
fail -> PASS (fi-snb-2600) fdo#100215
Test kms_frontbuffer_tracking:
Subgroup basic:
dmesg-warn -> PASS (fi-bdw-5557u)fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:457s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:442s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:364s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:557s fi-bwr-2160 total:279 pass:184 dwarn:0 dfail:0 fail:0 skip:95 time:254s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:518s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:529s fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:515s fi-elk-e7500 total:279 pass:230 dwarn:0 dfail:0 fail:0 skip:49 time:438s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:614s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:445s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:431s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:428s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:497s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:474s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:482s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:599s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:594s fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:522s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:477s fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:479s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:494s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:443s fi-skl-x1585l total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:497s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:546s fi-snb-2600 total:279 pass:249 dwarn:0 dfail:0 fail:1 skip:29 time:406s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_100/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for tests: chamelium: Eliminate reset when preparing output
In reply to Paul Kocialkowski== Series Details ==
== Series Details ==
Series: tests: chamelium: Eliminate reset when preparing output
URL : https://patchwork.freedesktop.org/series/29346/
State : success
== Summary ==
Test perf:
Subgroup blocking:
fail -> PASS (shard-hsw) fdo#102252
Test vgem_basic:
Subgroup unload:
skip -> PASS (shard-hsw)fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
shard-hsw total:2230 pass:1232 dwarn:0 dfail:0 fail:17 skip:981 time:9643s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_100/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
R-B'd and pushed, thanks!
Quoted 42 lines · Paul Kocialkowski
Resetting the Chamelium when preparing the video output is unnecessary
and significant increases the tests run-time. Since all video-related tests work just as well without it, eliminate it.This also adds a call to
reset_testin the analog frame dump test, that
was missing before, although the chamelium was still reset by the call
toprepare_output.Signed-off-by Paul Kocialkowski <[email protected]>--- tests/chamelium.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tests/chamelium.c +2
-2@@ -417,8 +417,6 @@ prepare_output(data_t *data,drmModeConnector *connector =chamelium_port_get_connector (data->chamelium, port, false); -chamelium_reset (data->chamelium); -igt_assert (res =drmModeGetResources (data->drm_fd));kmstest_unset_all_crtcs (data->drm_fd, res);@@ -626,6 +624,8 @@ test_analog_frame_dump(data_t *data, struct chamelium_port *port)int fb_id, i;bool bridge; +reset_state (data, port); + output =prepare_output (data, &display, port); connector = chamelium_port_get_connector(data->chamelium,port, false);
primary = igt_output_get_plane_type(output,DRM_PLANE_TYPE_PRIMARY);
Signature · 6 lines
Cheers, Lyude _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx