modem-manager: update dependencies

The dbus-glib package isn't a dependency since ModemManager 1.0, which is based on libglib2's GDBus implementation.

Also, explicitly set libglib2 as dependency, which currently was being implicitly included by libgudev. The next major ModemManager release will have udev/libgudev as optional packages, while libglib2 is definitely not going to be ever optional.

Signed-off-by Aleksander Morgado <[email protected]>

---
 package/modem-manager/modem-manager.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

package/modem-manager/modem-manager.mk +0 -0

index 1eea355f5..c2999dc2e 100644

Hello,

Thanks for your contribution!

Quoted 2 lines · Aleksander Morgado

The dbus-glib package isn't a dependency since ModemManager 1.0, which is based on libglib2's GDBus implementation.

And libglib2 GDBus implementation is built unconditionally, regardless of whether the DBus package is enabled or not ?

Quoted 15 lines

Also, explicitly set libglib2 as dependency, which currently was being implicitly included by libgudev. The next major ModemManager release will have udev/libgudev as optional packages, while libglib2 is definitely not going to be ever optional.

Signed-off-by Aleksander Morgado <[email protected]>

---
 package/modem-manager/modem-manager.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

package/modem-manager/modem-manager.mk +0 -0

index 1eea355f5..c2999dc2e 100644

package/modem-manager/modem-manager.mk MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz · line 12

Quoted 5 lines

package/modem-manager/modem-manager.mk +1 -1

@@ -9,7 +9,7 @@ MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
 MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
 MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
 MODEM_MANAGER_LICENSE_FILES = COPYING
-MODEM_MANAGER_DEPENDENCIES = host-pkgconf udev dbus-glib host-intltool libgudev
+MODEM_MANAGER_DEPENDENCIES = host-pkgconf udev host-intltool libglib2 libgudev

Then you also need to:

1. Remove select BR2_PACKAGE_DBUS_GLIB from Config.in

2. add select BR2_PACKAGE_LIBGLIB2 in Config.in

The dbus-glib package isn't a dependency since ModemManager 1.0, which is based on libglib2's GDBus implementation.

Also, explicitly set libglib2 as dependency, which currently was being implicitly included by libgudev. The next major ModemManager release will have udev/libgudev as optional packages, while libglib2 is definitely not going to be ever optional.

Finally, also set dbus as a dependency, as ModemManager won't work without a system DBus available.

Quoted 10 lines

The dbus-glib package isn't a dependency since ModemManager 1.0, which is based on libglib2's GDBus implementation.

Also, explicitly set libglib2 as dependency, which currently was being implicitly included by libgudev. The next major ModemManager release will have udev/libgudev as optional packages, while libglib2 is definitely not going to be ever optional.

Finally, also set dbus as a dependency, as ModemManager won't work without a system DBus available.

I was about to apply this, but this last part seems wrong: if DBus is only needed at runtime (and not build time), then having the select BR2_PACKAGE_DBUS in Config.in is enough: it ensures DBus will be built, it's just that you don't have the guarantee it will be built before modem-manager.

So:

- If DBus is only a runtime dependency, don't add dbus do MODEM_MANAGER_DEPENDENCIES, and instead add a comment above select BR2_PACKAGE_DBUS that says "# runtime dependency"

- If DBus is a build-time dependency, then your change is correct, but your commit log is unclear.

Understood; yes DBus is only runtime dependency, so the Config.in change would be enough.

I guess the same happens with udev then? MM
doesn't build-depend on udev, only on gudev (although it seems that gudev itself depends on udev).

Quoted 2 lines

Understood; yes DBus is only runtime dependency, so the Config.in change would be enough.

Well, the package already has "select BR2_PACKAGE_DBUS", so that shouldn't require any change.

Quoted 3 lines

I guess the same happens with udev then? MM
doesn't build-depend on udev, only on gudev (although it seems that gudev itself depends on udev).

Then yes, having "udev" in MODEM_MANAGER_DEPENDENCIES is useless.

These are the changes implemented:

* Remove dbus-glib as a dependency, as it isn't required since ModemManager 1.0, which is based on libglib2's GDBus implementation.

* Remove udev as a dependency, as the ModemManager build only needs the libgudev package.

* Explicitly set libglib2 as dependency, which currently was being implicitly included by libgudev. The next major ModemManager release will have udev/libgudev as optional packages, while libglib2 is definitely not going to be ever optional.

* Add a comment explaining that dbus is only a runtime dependency.

Signed-off-by Aleksander Morgado <[email protected]>

---
 package/modem-manager/Config.in        | 4 ++--
 package/modem-manager/modem-manager.mk | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)