Skip to contentSkip to conversation

Documentation: fix little inconsistencies

PATCH In review Pavel Machek 3 participants 6 messages Aug 28, 2017 – Aug 29, 2017

Subsystems (3)
Networking Network drivers Documentation
lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

PATCH 1/1 Documentation: fix little inconsistencies

Fix little inconsistencies in Documentation: make case and spacing match surrounding text, fix ascii-art.

Signed-off-by Pavel Machek <[email protected]>
Documentation/filesystems/ext4.txt +4 -4
index 5a8f7f4..75236c0 100644
@@ -94,10 +94,10 @@ Note: More extensive information for getting started with ext4 can be
 * ability to pack bitmaps and inode tables into larger virtual groups via the
   flex_bg feature
 * large file support
-* Inode allocation using large virtual block groups via flex_bg
+* inode allocation using large virtual block groups via flex_bg
 * delayed allocation
 * large block (up to pagesize) support
-* efficient new ordered mode in JBD2 and ext4(avoid using buffer head to force
+* efficient new ordered mode in JBD2 and ext4 (avoid using buffer head to force
   the ordering)
 
 [1] Filesystems with a block size of 1k may see a limit imposed by the

@@ -105,7 +105,7 @@ directory hash tree having a maximum depth of two.
 
 2.2 Candidate features for future inclusion
 
-* Online defrag (patches available but not well tested)
+* online defrag (patches available but not well tested)
 * reduced mke2fs time via lazy itable initialization in conjunction with
   the uninit_bg feature (capability to do this is available in e2fsprogs
   but a kernel thread to do lazy zeroing of unused inode table blocks

@@ -602,7 +602,7 @@ Table of Ext4 specific ioctls
 			      bitmaps and inode table, the userspace tool thus
 			      just passes the new number of blocks.
 
-EXT4_IOC_SWAP_BOOT	      Swap i_blocks and associated attributes
+ EXT4_IOC_SWAP_BOOT	      Swap i_blocks and associated attributes
 			      (like i_blocks, i_size, i_flags, ...) from
 			      the specified inode with inode
 			      EXT4_BOOT_LOADER_INO (#5). This is typically
Documentation/networking/switchdev.txt +1 -1
index 5e40e1f..6309e90 100644
@@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
                       sw1p1  +  sw1p3  +  sw1p5  +          eth1
                         +    |    +    |    +    |            +
                         |    |    |    |    |    |            |
-                     +--+----+----+----+-+--+----+---+  +-----+-----+
+                     +--+----+----+----+----+----+---+  +-----+-----+
                      |         Switch driver         |  |    mgmt   |
                      |        (this document)        |  |   driver  |
                      |                               |  |           |
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Reviewed-by on v1 1/1
#1 lore raw
Quoted 45 lines · Pavel Machek

Fix little inconsistencies in Documentation: make case and spacing match surrounding text, fix ascii-art.

Signed-off-by Pavel Machek <[email protected]>
Documentation/filesystems/ext4.txt +4 -4
index 5a8f7f4..75236c0 100644
@@ -94,10 +94,10 @@ Note: More extensive information for getting started with ext4 can be
 * ability to pack bitmaps and inode tables into larger virtual groups via the
   flex_bg feature
 * large file support
-* Inode allocation using large virtual block groups via flex_bg
+* inode allocation using large virtual block groups via flex_bg
 * delayed allocation
 * large block (up to pagesize) support
-* efficient new ordered mode in JBD2 and ext4(avoid using buffer head to force
+* efficient new ordered mode in JBD2 and ext4 (avoid using buffer head to force
   the ordering)
 
 [1] Filesystems with a block size of 1k may see a limit imposed by the

@@ -105,7 +105,7 @@ directory hash tree having a maximum depth of two.
 
 2.2 Candidate features for future inclusion
 
-* Online defrag (patches available but not well tested)
+* online defrag (patches available but not well tested)
 * reduced mke2fs time via lazy itable initialization in conjunction with
   the uninit_bg feature (capability to do this is available in e2fsprogs
   but a kernel thread to do lazy zeroing of unused inode table blocks

@@ -602,7 +602,7 @@ Table of Ext4 specific ioctls
 			      bitmaps and inode table, the userspace tool thus
 			      just passes the new number of blocks.
 
-EXT4_IOC_SWAP_BOOT	      Swap i_blocks and associated attributes
+ EXT4_IOC_SWAP_BOOT	      Swap i_blocks and associated attributes
 			      (like i_blocks, i_size, i_flags, ...) from
 			      the specified inode with inode
 			      EXT4_BOOT_LOADER_INO (#5). This is typically
Documentation/networking/switchdev.txt +0 -0
index 5e40e1f..6309e90 100644

Documentation/networking/switchdev.txt with SR-IOV or soft switches, such as OVS, are possible. · line 32

Quoted 5 lines
Documentation/networking/switchdev.txt +1 -1
@@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
                       sw1p1  +  sw1p3  +  sw1p5  +          eth1
                         +    |    +    |    +    |            +
                         |    |    |    |    |    |            |
-                     +--+----+----+----+-+--+----+---+  +-----+-----+
+                     +--+----+----+----+----+----+---+  +-----+-----+

Except for this last part, looks ok.

Reviewed-by Darrick J. Wong <[email protected]>

--D

Quoted 7 lines
Documentation/networking/switchdev.txt +0 -0
                      |         Switch driver         |  |    mgmt   |
                      |        (this document)        |  |   driver  |
                      |                               |  |           |
Signature · 3 lines
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
author
#2 lore raw
Quoted 13 lines

Documentation/networking/switchdev.txt with SR-IOV or soft switches, such as OVS, are possible. · line 32

Quoted 11 lines

index 5e40e1f..6309e90 100644

Documentation/networking/switchdev.txt +1 -1
@@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
                       sw1p1  +  sw1p3  +  sw1p5  +          eth1
                         +    |    +    |    +    |            +
                         |    |    |    |    |    |            |
-                     +--+----+----+----+-+--+----+---+  +-----+-----+
+                     +--+----+----+----+----+----+---+  +-----+-----+

Except for this last part, looks ok.

Anything wrong here? It is fixing extra '+' in the ascii art...
Pavel

Quoted 12 lines
Reviewed-by Darrick J. Wong <[email protected]>

--D

Quoted 7 lines
Documentation/networking/switchdev.txt +0 -0
                      |         Switch driver         |  |    mgmt   |
                      |        (this document)        |  |   driver  |
                      |                               |  |           |
Signature · 3 lines
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#3 lore raw
Quoted 14 lines · Pavel Machek
Quoted 13 lines

Documentation/networking/switchdev.txt with SR-IOV or soft switches, such as OVS, are possible. · line 32

Quoted 11 lines

index 5e40e1f..6309e90 100644

Documentation/networking/switchdev.txt +1 -1
@@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
                       sw1p1  +  sw1p3  +  sw1p5  +          eth1
                         +    |    +    |    +    |            +
                         |    |    |    |    |    |            |
-                     +--+----+----+----+-+--+----+---+  +-----+-----+
+                     +--+----+----+----+----+----+---+  +-----+-----+

Except for this last part, looks ok.

Quoted 1 line

Anything wrong here? It is fixing extra '+' in the ascii art...

There's nothing incorrect here, I merely thought it odd to send a fix for networking documentation to the ext4 list, but not netdev?

--D

Quoted 18 lines

Pavel

Quoted 12 lines
Reviewed-by Darrick J. Wong <[email protected]>

--D

Quoted 7 lines
Documentation/networking/switchdev.txt +0 -0
                      |         Switch driver         |  |    mgmt   |
                      |        (this document)        |  |   driver  |
                      |                               |  |           |
Signature · 3 lines
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
maintainer
#4 lore raw
Quoted 4 lines · On Tue, 29 Aug 2017 09:50:57 -0700 "Darrick J. Wong" <[email protected]>…
Quoted 1 line

Anything wrong here? It is fixing extra '+' in the ascii art...

There's nothing incorrect here, I merely thought it odd to send a fix for networking documentation to the ext4 list, but not netdev?

In fact, davem likes to handle networking documentation patches himself, so resending this one to netdev would be a good idea.

Thanks,

jon

author
#5 lore raw
Quoted 10 lines · Jonathan Corbet
Quoted 4 lines · On Tue, 29 Aug 2017 09:50:57 -0700 "Darrick J. Wong" <[email protected]>…
Quoted 1 line

Anything wrong here? It is fixing extra '+' in the ascii art...

There's nothing incorrect here, I merely thought it odd to send a fix for networking documentation to the ext4 list, but not netdev?

In fact, davem likes to handle networking documentation patches himself, so resending this one to netdev would be a good idea.

Its a typo in documentation, do we really need to waste any more time with it? Dave, can you just ack it?

Quoted 10 lines
Quoted 10 lines

index 5e40e1f..6309e90 100644

Documentation/networking/switchdev.txt +0 -0
@@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are

possible.

                       sw1p1  +  sw1p3  +  sw1p5  +          eth1
                         +    |    +    |    +    |            +
                         |    |    |    |    |    |            |

-                     +--+----+----+----+-+--+----+---+  +-----+-----+ +                     +--+----+----+----+----+----+---+  +-----+-----+

Besides, if documentation fixes should go to Davem/netdev, getmaintainer.pl should say so:

pavel@duo:/data/l/linux-n900$ scripts/get_maintainer.pl -f
Documentation/networking
Jonathan Corbet <[email protected]> (maintainer:DOCUMENTATION)
"David S. Miller" <[email protected]> (commit_signer:52/87=60%)
David Howells <[email protected]>
(commit_signer:7/87=8%,authored:8/87=9%)
Florian Fainelli <[email protected]> (commit_signer:6/87=7%)
Mauro Carvalho Chehab <[email protected]>
(commit_signer:6/87=7%,authored:5/87=6%)
Yuchung Cheng <[email protected]> (commit_signer:6/87=7%)
Hangbin Liu <[email protected]> (authored:5/87=6%)
[email protected] (open list:DOCUMENTATION)
[email protected] (open list)
pavel@duo:/data/l/linux-n900$

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html