android: pty01: Fix pty01 test for Android.
PATCH v2 1/1 android: pty01: Fix pty01 test for Android.
The test fails because 'grantpt()' is a no-op in bionic and doesn't set the /dev/pts/X mode to '020600' as expected by the test. The change skips that check if __BIONIC__ is defined so the rest of the test(s) can proceed and detect other failures if any.
--- testcases/kernel/pty/pty01.c | 3 +++ 1 file changed, 3 insertions(+)
testcases/kernel/pty/pty01.c +3 -0
@@ -99,9 +99,12 @@ static int test1(void)tst_brkm (TBROK ,NULL ,"uid mismatch" ); } +/* grantpt() is a no-op in bionic. */ +#ifndef __BIONIC__if (st.st_mode != (S_IFCHR |S_IRUSR |S_IWUSR |S_IWGRP )) {tst_brkm (TBROK ,NULL ,"mode mismatch (mode=%o)" , st.st_mode); } +#endif slavefd =open (slavename,O_RDWR );if (slavefd >=0 ) {
Signature · 1 line
2.14.1.342.g6490525c54-goog
PATCH v2 1/1 android: pty01: Fix pty01 test for Android.
(I have no idea why this didn't go out as a -v2, apologies, please disregard)
- ssp
Quoted 28 lines · Sandeep Patil
The test fails because '
grantpt()' is a no-op in bionic and doesn't set the/dev/pts/Xmode to '020600' as expected by the test. The change skips that check if__BIONIC__is defined so the rest of the test(s) can proceed and detect other failures if any.Signed-off-by Sandeep Patil <[email protected]>--- testcases/kernel/pty/pty01.c | 3 +++ 1 file changed, 3 insertions(+)testcases/kernel/pty/pty01.c +3
-0@@ -99,9 +99,12 @@ static int test1(void)tst_brkm (TBROK ,NULL ,"uid mismatch" ); } +/* grantpt() is a no-op in bionic. */ +#ifndef __BIONIC__if (st.st_mode != (S_IFCHR |S_IRUSR |S_IWUSR |S_IWGRP )) {tst_brkm (TBROK ,NULL ,"mode mismatch (mode=%o)" , st.st_mode); } +#endif slavefd =open (slavename,O_RDWR );if (slavefd >= 0) {
Quoted 4 lines
--
2.14.1.342.g6490525c54-goog
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20170828/97cde888/attachment.html>