Skip to contentSkip to conversation

package/strongswan: Install libraries to /usr/lib

PATCH Superseded Sam Voss 2 participants 3 messages Aug 29, 2017

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Sam Voss

author
#0 lore raw

PATCH 1/1 package/strongswan: Install libraries to /usr/lib

Install strongswan ipsec libraries into /usr/lib instead of /usr/lib/ipsec in an effort to not need a custom RPATH for this package.

---
 package/strongswan/strongswan.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/strongswan/strongswan.mk +2 -1
index 1070eea..febb33f 100644
@@ -36,7 +36,8 @@ STRONGSWAN_CONF_OPTS += \
 	--enable-scepclient=$(if $(BR2_PACKAGE_STRONGSWAN_SCEP),yes,no) \
 	--enable-scripts=$(if $(BR2_PACKAGE_STRONGSWAN_SCRIPTS),yes,no) \
 	--enable-vici=$(if $(BR2_PACKAGE_STRONGSWAN_VICI),yes,no) \
-	--enable-swanctl=$(if $(BR2_PACKAGE_STRONGSWAN_VICI),yes,no)
+	--enable-swanctl=$(if $(BR2_PACKAGE_STRONGSWAN_VICI),yes,no) \
+	--with-ipseclibdir=/usr/lib
 
 ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
 STRONGSWAN_CONF_ENV += LIBS='-latomic'
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 package/strongswan: Install libraries to /usr/lib

Sam, All,

On 2017-08-29 16:30 -0500, Sam Voss spake thusly:

Quoted 13 lines

Install strongswan ipsec libraries into /usr/lib instead of /usr/lib/ipsec in an effort to not need a custom RPATH for this package.

---
 package/strongswan/strongswan.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/strongswan/strongswan.mk +0 -0
index 1070eea..febb33f 100644

package/strongswan/strongswan.mk STRONGSWAN_CONF_OPTS += \ · line 40

Quoted 6 lines
package/strongswan/strongswan.mk +2 -1
@@ -36,7 +36,8 @@ STRONGSWAN_CONF_OPTS += \
 	--enable-scepclient=$(if $(BR2_PACKAGE_STRONGSWAN_SCEP),yes,no) \
 	--enable-scripts=$(if $(BR2_PACKAGE_STRONGSWAN_SCRIPTS),yes,no) \
 	--enable-vici=$(if $(BR2_PACKAGE_STRONGSWAN_VICI),yes,no) \
-	--enable-swanctl=$(if $(BR2_PACKAGE_STRONGSWAN_VICI),yes,no)
+	--enable-swanctl=$(if $(BR2_PACKAGE_STRONGSWAN_VICI),yes,no) \
+	--with-ipseclibdir=/usr/lib

The issue behind that, is that this directory is also used to derive the location where to store plugins and the "IMC and IMV dynamic librariers" (typo not mine for once!).

So, the plugins would end up in /usr/lib/plugins and the libs in /usr/lib/imcvs.

This is not satifactory (at least the plugins stuff), so I'd suggest we also force those locations (to their original values):

--with-plugindir=/usr/lib/ipsec/plugins
--with-imcvdir=/usr/lib/ipsec/imcvs

Could you check that, please? ;-)

Regards,
Yann E. MORIN.

Quoted 9 lines
package/strongswan/strongswan.mk +0 -0
 ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
 STRONGSWAN_CONF_ENV += LIBS='-latomic'
Signature · 6 lines
1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author
#2 lore raw

PATCH 1/1 package/strongswan: Install libraries to /usr/lib

Yann, All,

Quoted 1 line · Yann E. MORIN

Sam, All,

[..]

Quoted 14 lines

package/strongswan/strongswan.mk STRONGSWAN_CONF_OPTS += \ · line 40

Quoted 9 lines
package/strongswan/strongswan.mk +2 -1
@@ -36,7 +36,8 @@ STRONGSWAN_CONF_OPTS += \
      --enable-scepclient=$(if $(BR2_PACKAGE_STRONGSWAN_SCEP),yes,no) \
      --enable-scripts=$(if $(BR2_PACKAGE_STRONGSWAN_SCRIPTS),yes,no) \
      --enable-vici=$(if $(BR2_PACKAGE_STRONGSWAN_VICI),yes,no) \
-     --enable-swanctl=$(if $(BR2_PACKAGE_STRONGSWAN_VICI),yes,no)
+     --enable-swanctl=$(if $(BR2_PACKAGE_STRONGSWAN_VICI),yes,no) \
+     --with-ipseclibdir=/usr/lib

The issue behind that, is that this directory is also used to derive the location where to store plugins and the "IMC and IMV dynamic librariers" (typo not mine for once!).

Quoted 2 lines

So, the plugins would end up in /usr/lib/plugins and the libs in /usr/lib/imcvs.

Good point, I didn't realize this propagates that way!

Quoted 7 lines

This is not satifactory (at least the plugins stuff), so I'd suggest we also force those locations (to their original values):

--with-plugindir=/usr/lib/ipsec/plugins
--with-imcvdir=/usr/lib/ipsec/imcvs

Could you check that, please? ;-)

Absolutely, I will submit a v2 after testing