Skip to contentSkip to conversation

nvme: fix the definition of Amin doorbell buffer config support

PATCH Superseded Changpeng Liu 3 participants 4 messages Aug 30, 2017 – Aug 31, 2017 NVMe

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Changpeng Liu

author
#0 lore raw

PATCH 1/1 nvme: fix the definition of Amin doorbell buffer config support

NVMe 1.3 specification defines the Optioal Admin Command Support feature flags, bit 8 set to '1' then the controller supports the Doorbell Buffer Config command. Bit 7 is used for Virtualization Mangement command.

Signed-off-by Changpeng Liu <changpeng.liu at intel.com>
---
 include/linux/nvme.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/nvme.h +1 -1
index 25d8225..8efff88 100644
@@ -254,7 +254,7 @@ enum {
 	NVME_CTRL_VWC_PRESENT			= 1 << 0,
 	NVME_CTRL_OACS_SEC_SUPP                 = 1 << 0,
 	NVME_CTRL_OACS_DIRECTIVES		= 1 << 5,
-	NVME_CTRL_OACS_DBBUF_SUPP		= 1 << 7,
+	NVME_CTRL_OACS_DBBUF_SUPP		= 1 << 8,
 };
 
 struct nvme_lbaf {
Signature · 1 line
1.9.3
maintainer
#1 lore raw

PATCH 1/1 nvme: fix the definition of Amin doorbell buffer config support

Thanks!

#2 lore raw

PATCH 1/1 nvme: fix the definition of Amin doorbell buffer config support

In reply to Changpeng Liu

include/linux/nvme.h

Quoted 11 lines · Changpeng Liu

NVMe 1.3 specification defines the Optioal Admin Command Support feature flags, bit 8 set to '1' then the controller supports the Doorbell Buffer Config command. Bit 7 is used for Virtualization Mangement command.

Signed-off-by Changpeng Liu <changpeng.liu at intel.com>
---
  include/linux/nvme.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/nvme.h +0 -0

Looks good (need to update the typo Optioal -> Optional during the merge),

Reviewed-by Max Gurtovoy <maxg at mellanox.com>
author
#3 lore raw

PATCH 1/1 nvme: fix the definition of Amin doorbell buffer config support

Quoted 19 lines

-----Original Message-----
From: Max Gurtovoy [mailto:maxg at mellanox.com]
Sent: Wednesday, August 30, 2017 3:18 PM
To: Liu, Changpeng <changpeng.liu at intel.com>; linux-nvme at lists.infradead.org; Busch, Keith <keith.busch at intel.com>; axboe at fb.com; hch at lst.de; sagi at grimberg.me
Subject: Re: [PATCH] nvme: fix the definition of Amin doorbell buffer config support

Quoted 5 lines · Changpeng Liu

NVMe 1.3 specification defines the Optioal Admin Command Support feature flags, bit 8 set to '1' then the controller supports the Doorbell Buffer Config command. Bit 7 is used for Virtualization Mangement command.

Quoted 8 lines

include/linux/nvme.h

Quoted 6 lines
Signed-off-by Changpeng Liu <changpeng.liu at intel.com>
---
  include/linux/nvme.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/nvme.h +0 -0

Looks good (need to update the typo Optioal -> Optional during the merge),

Thanks, will send v2 to fix the typo.

Quoted 2 lines
Reviewed-by Max Gurtovoy <maxg at mellanox.com>