Skip to contentSkip to conversation

nvme/host: generate spec-compliant UUID NQNs

PATCH New Daniel Verkamp 4 participants 4 messages Aug 30, 2017 – Sep 3, 2017 NVMe

lore
Share & tools
lore

Daniel Verkamp

author
#0 lore raw

PATCH 1/1 nvme/host: generate spec-compliant UUID NQNs

The default host NQN, which is generated based on the host's UUID, does not follow the UUID-based NQN format laid out in the NVMe 1.3 specification. Remove the "NVMf:" portion of the NQN to match the spec.

Signed-off-by Daniel Verkamp <daniel.verkamp at intel.com>
---
 drivers/nvme/host/fabrics.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/fabrics.c +1 -1
index 5f5cd306f76d..ffa7191ddfa5 100644
@@ -75,7 +75,7 @@ static struct nvmf_host *nvmf_host_default(void)
 
 	kref_init(&host->ref);
 	snprintf(host->nqn, NVMF_NQN_SIZE,
-		"nqn.2014-08.org.nvmexpress:NVMf:uuid:%pUb", &host->id);
+		"nqn.2014-08.org.nvmexpress:uuid:%pUb", &host->id);
 
 	mutex_lock(&nvmf_hosts_mutex);
 	list_add_tail(&host->list, &nvmf_hosts);
Signature · 1 line
2.13.5
#1 lore raw

PATCH 1/1 nvme/host: generate spec-compliant UUID NQNs

Looks good,

Reviewed-by Christoph Hellwig <hch at lst.de>
#2 lore raw

PATCH 1/1 nvme/host: generate spec-compliant UUID NQNs

In reply to Daniel Verkamp

drivers/nvme/host/fabrics.c

Quoted 13 lines · Daniel Verkamp

The default host NQN, which is generated based on the host's UUID, does not follow the UUID-based NQN format laid out in the NVMe 1.3 specification. Remove the "NVMf:" portion of the NQN to match the spec.

Signed-off-by Daniel Verkamp <daniel.verkamp at intel.com>
---
  drivers/nvme/host/fabrics.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/fabrics.c +0 -0
index 5f5cd306f76d..ffa7191ddfa5 100644

Looks good,

Reviewed-by Max Gurtovoy <maxg at mellanox.com>