Skip to contentSkip to conversation

perf tools: Fix syntax in documentation of intel-pt config option

PATCH In review Jack Henschel 3 participants 3 messages Aug 31, 2017 – Sep 5, 2017 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf tools: Fix syntax in documentation of intel-pt config option

As specified in tools/perf/Documentation/perf-config.txt, perf configuration items must be in 'key = value' format, otherwise the following error message occurs:

$ perf record -e intel_pt//u -- ls
bad config file line 2 in ~/.perfconfig
$ cat .perfconfig
[intel-pt]
    mispred-all

Changing assigning a value to the key 'mispred-all' fixes the issue:

$ perf record -e intel_pt//u -- ls
[ perf record: Woken up 1 times to write data ]
[ perf record: Capured and wrote 0.031 MB perf.data]
$ cat .perfconfig
[intel-pt]
    mispred-all = true
---
 tools/perf/Documentation/intel-pt.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/Documentation/intel-pt.txt +1 -1
index 4b6cdbf8f935..a47d845b9b61 100644
@@ -873,7 +873,7 @@ amended to take the number of elements as a parameter.
 
 	$ cat ~/.perfconfig
 	[intel-pt]
-		mispred-all
+		mispred-all = on
 
 	$ perf record -e intel_pt//u ./sort 3000
 	Bubble sorting array of 3000 elements
Signature · 1 line
2.14.1
#1 lore raw

Em Thu, Aug 31, 2017 at 10:05:35AM +0200, Jack Henschel escreveu:

Quoted 10 lines

As specified in tools/perf/Documentation/perf-config.txt, perf configuration items must be in 'key = value' format, otherwise the following error message occurs:

$ perf record -e intel_pt//u -- ls
bad config file line 2 in ~/.perfconfig
$ cat .perfconfig
[intel-pt]
    mispred-all
Quoted 7 lines

Changing assigning a value to the key 'mispred-all' fixes the issue:

$ perf record -e intel_pt//u -- ls
[ perf record: Woken up 1 times to write data ]
[ perf record: Capured and wrote 0.031 MB perf.data]
$ cat .perfconfig
[intel-pt]
    mispred-all = true

You forgot to add your:

I'm assuming you intended it, so I'm adding it to my local repository, please ack this.

- Arnaldo

Quoted 19 lines
---
 tools/perf/Documentation/intel-pt.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/Documentation/intel-pt.txt +1 -1
index 4b6cdbf8f935..a47d845b9b61 100644
@@ -873,7 +873,7 @@ amended to take the number of elements as a parameter.
 
 	$ cat ~/.perfconfig
 	[intel-pt]
-		mispred-all
+		mispred-all = on
 
 	$ perf record -e intel_pt//u ./sort 3000
 	Bubble sorting array of 3000 elements
Signature · 1 line
2.14.1
#2 lore raw

[tip:perf/urgent] perf intel-pt: Fix syntax in documentation of config option

In reply to Jack Henschel
perf intel-pt: Fix syntax in documentation of config option
Commit-ID:  4fb205392022ba99a45dd01a62c6e2df046e400a
Gitweb:     http://git.kernel.org/tip/4fb205392022ba99a45dd01a62c6e2df046e400a
Author:     Jack Henschel <[email protected]>
AuthorDate: Thu, 31 Aug 2017 10:05:35 +0200
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Fri, 1 Sep 2017 14:45:59 -0300

perf intel-pt: Fix syntax in documentation of config option

As specified in tools/perf/Documentation/perf-config.txt, perf configuration items must be in 'key = value' format, otherwise the following error message occurs:

  $ perf record -e intel_pt//u -- ls
  bad config file line 2 in ~/.perfconfig
  $ cat .perfconfig
  [intel-pt]
      mispred-all

Changing to assigning a value to the key 'mispred-all' fixes the issue:

  $ perf record -e intel_pt//u -- ls
  [ perf record: Woken up 1 times to write data ]
  [ perf record: Capured and wrote 0.031 MB perf.data]
  $ cat .perfconfig
  [intel-pt]
      mispred-all = true
---
 tools/perf/Documentation/intel-pt.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/Documentation/intel-pt.txt +1 -1
index ab1b082..76971d2 100644
@@ -873,7 +873,7 @@ amended to take the number of elements as a parameter.
 
 	$ cat ~/.perfconfig
 	[intel-pt]
-		mispred-all
+		mispred-all = on
 
 	$ perf record -e intel_pt//u ./sort 3000
 	Bubble sorting array of 3000 elements