Please pull JSON files for POWER9 PMU events
Hi Arnaldo,
Please pull an update to the JSON files for POWER9 PMU events. This removes alternate event codes from the JSON files which seem to confuse perf.
The following changes since commit 1b2f76d77a277bb70d38ad0991ed7f16bbc115a9:
Merge tag 'perf-core-for-mingo-4.14-20170829' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2017-08-29 23:13:56 +0200)
are available in the git repository at:
https://github.com/sukadev/linux/ p9-json-v3
Sukadev Bhattiprolu (1):
perf vendor events powerpc: remove duplicate events
.../pmu-events/arch/powerpc/power9/frontend.json | 7 +- .../perf/pmu-events/arch/powerpc/power9/other.json | 120 -------------------- .../pmu-events/arch/powerpc/power9/pipeline.json | 7 +- tools/perf/pmu-events/arch/powerpc/power9/pmc.json | 7 +- 4 files changed, 3 insertions(+), 138 deletions(-)
Em Wed, Aug 30, 2017 at 04:15:06PM -0700, Sukadev Bhattiprolu escreveu:
Quoted 8 lines
Hi Arnaldo,
Please pull an update to the JSON files for POWER9 PMU events. This removes alternate event codes from the JSON files which seem to confuse perf.
The following changes since commit
1b2f76d77a277bb70d38ad0991ed7f16bbc115a9:
Thanks, applied and added the CCed people to CC lines in the cset comment, also added Andi to that CC list.
- Arnaldo
Quoted 14 lines
Merge tag 'perf-core-for-mingo-4.14-20170829' of
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linuxinto perf/core (2017-08-29 23:13:56 +0200)are available in the git repository at:
https://github.com/sukadev/linux/ p9-json-v3
Sukadev Bhattiprolu (1):
perf vendor events powerpc: remove duplicate events.../pmu-events/arch/powerpc/power9/frontend.json | 7 +- .../perf/pmu-events/arch/powerpc/power9/other.json | 120 -------------------- .../pmu-events/arch/powerpc/power9/pipeline.json | 7 +- tools/perf/pmu-events/arch/powerpc/power9/pmc.json | 7 +- 4 files changed, 3 insertions(+), 138 deletions(-)
tip-bot for Sukadev Bhattiprolu
merge bot[tip:perf/urgent] perf vendor events powerpc: Remove duplicate events
In reply to Sukadev Bhattiproluperf vendor events powerpc: Remove duplicate events
Commit-ID: 2a118e1bd22cad57318520d37e3a184b8846c6a2 Gitweb: http://git.kernel.org/tip/2a118e1bd22cad57318520d37e3a184b8846c6a2 Author: Sukadev Bhattiprolu <[email protected]> AuthorDate: Wed, 30 Aug 2017 21:42:23 -0400 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Fri, 1 Sep 2017 14:46:00 -0300
perf vendor events powerpc: Remove duplicate events
Some POWER PMU event names have multiple/alternate event codes. These alternate event codes were listed in the POWER9 JSON files for reference.
But the perf tool does not seem to handle duplicates cleanly. 'perf list' shows such duplicate events only once, but 'perf stat' ends up counting the first event code twice, multiplexing if necessary and we end up with double the event counts.
Remove the duplicate event codes from the JSON files for now.
--- .../pmu-events/arch/powerpc/power9/frontend.json | 7 +- .../perf/pmu-events/arch/powerpc/power9/other.json | 120 --------------------- .../pmu-events/arch/powerpc/power9/pipeline.json | 7 +- tools/perf/pmu-events/arch/powerpc/power9/pmc.json | 7 +- 4 files changed, 3 insertions(+), 138 deletions(-)
tools/perf/pmu-events/arch/powerpc/power9/frontend.json +1 -6
@@ -80,11 +80,6 @@ "BriefDescription": "Load Missed L1, counted at execution time (can be greater than loads finished). LMQ merges are not included in this count. i.e. if a load instruction misses on an address that is already allocated on the LMQ, this event will not increment for that load). Note that this count is per slice, so if a load spans multiple slices this event will increment multiple times for a single load." }, {, - "EventCode": "0x400F0", - "EventName": "PM_LD_MISS_L1", - "BriefDescription": "Load Missed L1, counted at execution time (can be greater than loads finished). LMQ merges are not included in this count. i.e. if a load instruction misses on an address that is already allocated on the LMQ, this event will not increment for that load). Note that this count is per slice, so if a load spans multiple slices this event will increment multiple times for a single load." - }, - {, "EventCode": "0x2E01A", "EventName": "PM_CMPLU_STALL_LSU_FLUSH_NEXT", "BriefDescription": "Completion stall of one cycle because the LSU requested to flush the next iop in the sequence. It takes 1 cycle for the ISU to process this request before the LSU instruction is allowed to complete"
@@ -374,4 +369,4 @@ "EventName": "PM_IPTEG_FROM_L31_ECO_MOD", "BriefDescription": "A Page Table Entry was loaded into the TLB with Modified (M) data from another core's ECO L3 on the same chip due to a instruction side request" } -] +]
tools/perf/pmu-events/arch/powerpc/power9/other.json +0 -120
254 lines not on this page · raw message
tools/perf/pmu-events/arch/powerpc/power9/pipeline.json +1 -6
@@ -420,11 +420,6 @@ "BriefDescription": "Final Pump Scope (Group) ended up larger than Initial Pump Scope (Chip) for an instruction fetch" }, {, - "EventCode": "0x10016", - "EventName": "PM_DSLB_MISS", - "BriefDescription": "Data SLB Miss - Total of all segment sizes" - }, - {, "EventCode": "0xD0A8", "EventName": "PM_DSLB_MISS", "BriefDescription": "Data SLB Miss - Total of all segment sizes"
@@ -554,4 +549,4 @@ "EventName": "PM_MRK_DATA_FROM_L21_SHR_CYC", "BriefDescription": "Duration in cycles to reload with Shared (S) data from another core's L2 on the same chip due to a marked load" } -] +]
tools/perf/pmu-events/arch/powerpc/power9/pmc.json +1 -6
@@ -5,11 +5,6 @@ "BriefDescription": "Branches that are not strongly biased" }, {, - "EventCode": "0x40036", - "EventName": "PM_BR_2PATH", - "BriefDescription": "Branches that are not strongly biased" - }, - {, "EventCode": "0x40056", "EventName": "PM_MEM_LOC_THRESH_LSU_HIGH", "BriefDescription": "Local memory above threshold for LSU medium"
@@ -124,4 +119,4 @@ "EventName": "PM_1FLOP_CMPL", "BriefDescription": "one flop (fadd, fmul, fsub, fcmp, fsel, fabs, fnabs, fres, fsqrte, fneg) operation completed" } -] +]