Skip to contentSkip to conversation

nvme-cli: generate spec-compliant UUID NQNs

PATCH New Daniel Verkamp 3 participants 3 messages Aug 30, 2017 – Aug 31, 2017

Subsystems (2)
Documentation NVMe
lore
Share & tools
lore

Daniel Verkamp

author
#0 lore raw

PATCH 1/1 nvme-cli: generate spec-compliant UUID NQNs

The gen-hostnqn command previously generated UUID NQNs in a format that does not match the NVMe specification.

Signed-off-by Daniel Verkamp <daniel.verkamp at intel.com>
---
 Documentation/nvme-gen-hostnqn.txt | 2 +-
 nvme.c                             | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Documentation/nvme-gen-hostnqn.txt +1 -1
index 6d5346f..9efefb5 100644
@@ -13,7 +13,7 @@ SYNOPSIS
 DESCRIPTION
 -----------
 Generate a random host NQN in the form:
-nqn.2014-08.org.nvmexpress:NVMf:uuid:1b4e28ba-2fa1-11d2-883f-0016d3cca427
+nqn.2014-08.org.nvmexpress:uuid:1b4e28ba-2fa1-11d2-883f-0016d3cca427
 and prints it to stdout.
 
 OPTIONS
nvme.c +1 -1
index 676e8bf..f1d6d65 100644
@@ -3217,7 +3217,7 @@ static int gen_hostnqn_cmd(int argc, char **argv, struct command *command, struc
 
 	uuid_generate_random(uuid);
 	uuid_unparse_lower(uuid, uuid_str);
-	printf("nqn.2014-08.org.nvmexpress:NVMf:uuid:%s\n", uuid_str);
+	printf("nqn.2014-08.org.nvmexpress:uuid:%s\n", uuid_str);
 	return 0;
 }
 #else
Signature · 1 line
2.13.5
#1 lore raw

PATCH 1/1 nvme-cli: generate spec-compliant UUID NQNs

Looks good,

Reviewed-by Christoph Hellwig <hch at lst.de>
Applied
#2 lore raw

PATCH 1/1 nvme-cli: generate spec-compliant UUID NQNs

In reply to Daniel Verkamp
Quoted 4 lines · Daniel Verkamp

The gen-hostnqn command previously generated UUID NQNs in a format that does not match the NVMe specification.

Signed-off-by Daniel Verkamp <daniel.verkamp at intel.com>

Applied, thanks for the fix!