Skip to contentSkip to conversation

ARM: Kconfig: fix example for ARM_APPENDED_DTB

PATCH New Vladimir Murzin 2 participants 3 messages Sep 1, 2017 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: Kconfig: fix example for ARM_APPENDED_DTB

Help message for config ARM_APPENDED_DTB suggests following example to append dtb to zImage:

cat zImage <filename>.dtb > zImage_w_dtb

and that makes unaware user wondering why Linux doesn't boot.

So fix example with ">>". Unfortunately, the same example is present in message to commit e2a6a3aafa98 ("ARM: zImage: Allow the appending of a device tree binary").

---
 arch/arm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/Kconfig +1 -1
index 61a0cb1..756f50f 100644
@@ -1893,7 +1893,7 @@ config ARM_APPENDED_DTB
 	help
 	  With this option, the boot code will look for a device tree binary
 	  (DTB) appended to zImage
-	  (e.g. cat zImage <filename>.dtb > zImage_w_dtb).
+	  (e.g. cat zImage <filename>.dtb >> zImage_w_dtb).
 
 	  This is meant as a backward compatibility convenience for those
 	  systems with a bootloader that can't be upgraded to accommodate
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 ARM: Kconfig: fix example for ARM_APPENDED_DTB

Hi Vladimir,

Quoted 10 lines · Vladimir Murzin

Help message for config ARM_APPENDED_DTB suggests following example to append dtb to zImage:

cat zImage <filename>.dtb > zImage_w_dtb

and that makes unaware user wondering why Linux doesn't boot.

So fix example with ">>". Unfortunately, the same example is present in message to commit e2a6a3aafa98 ("ARM: zImage: Allow the appending of a device tree binary").

I think that as-is, the example is correct, as zImage_w_dtb is a different file to zImage.

... but perhaps the wording could be updated to make that clearer.

Thanks,
Mark.

Quoted 27 lines
---
 arch/arm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/Kconfig +1 -1
index 61a0cb1..756f50f 100644
@@ -1893,7 +1893,7 @@ config ARM_APPENDED_DTB
 	help
 	  With this option, the boot code will look for a device tree binary
 	  (DTB) appended to zImage
-	  (e.g. cat zImage <filename>.dtb > zImage_w_dtb).
+	  (e.g. cat zImage <filename>.dtb >> zImage_w_dtb).
 
 	  This is meant as a backward compatibility convenience for those
 	  systems with a bootloader that can't be upgraded to accommodate
Signature · 7 lines
1.9.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#2 lore raw

PATCH 1/1 ARM: Kconfig: fix example for ARM_APPENDED_DTB

Quoted 8 lines · Mark Rutland

Hi Vladimir,

Quoted 5 lines · Vladimir Murzin

Help message for config ARM_APPENDED_DTB suggests following example to append dtb to zImage:

cat zImage <filename>.dtb > zImage_w_dtb

Quoted 8 lines
Quoted 5 lines

and that makes unaware user wondering why Linux doesn't boot.

So fix example with ">>". Unfortunately, the same example is present in message to commit e2a6a3aafa98 ("ARM: zImage: Allow the appending of a device tree binary").

I think that as-is, the example is correct, as zImage_w_dtb is a different file to zImage.

You've just convinced me to have unplanned vision check :) sorry for the noise!

Thanks
Vladimir

Quoted 34 lines

... but perhaps the wording could be updated to make that clearer.

Thanks,
Mark.

Quoted 27 lines
---
 arch/arm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/Kconfig +1 -1
index 61a0cb1..756f50f 100644
@@ -1893,7 +1893,7 @@ config ARM_APPENDED_DTB
 	help
 	  With this option, the boot code will look for a device tree binary
 	  (DTB) appended to zImage
-	  (e.g. cat zImage <filename>.dtb > zImage_w_dtb).
+	  (e.g. cat zImage <filename>.dtb >> zImage_w_dtb).
 
 	  This is meant as a backward compatibility convenience for those
 	  systems with a bootloader that can't be upgraded to accommodate
Signature · 7 lines
1.9.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel