drm/scdc-helper: Remove gratuitous blank lines

From: Thierry Reding <[email protected]>

The error messages generated by the SCDC helpers are somewhat inconsistent with other DRM errors and even with other errors in the same file. Fix them all up to use a common format.

Signed-off-by Thierry Reding <[email protected]>

---
  drivers/gpu/drm/drm_scdc_helper.c | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)

drivers/gpu/drm/drm_scdc_helper.c +4 -4

index d66c436a829e..5e6f0709df49 100644
@@ -141,7 +141,7 @@ bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter)
 
  	ret = drm_scdc_readb(adapter, SCDC_SCRAMBLER_STATUS, &status);
  	if (ret < 0) {
-		DRM_ERROR("Failed to read scrambling status, error %d\n", ret);
+		DRM_ERROR("Failed to read scrambling status: %d\n", ret);
  		return false;
  	}
 

@@ -168,7 +168,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable)
 
  	ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config);
  	if (ret < 0) {
-		DRM_ERROR("Failed to read tmds config, err=%d\n", ret);
+		DRM_ERROR("Failed to read tmds config: %d\n", ret);
  		return false;
  	}
 

@@ -179,7 +179,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable)
 
  	ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config);
  	if (ret < 0) {
-		DRM_ERROR("Failed to enable scrambling, error %d\n", ret);
+		DRM_ERROR("Failed to enable scrambling: %d\n", ret);
  		return false;
  	}
 

@@ -223,7 +223,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set)
 
  	ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config);
  	if (ret < 0) {
-		DRM_ERROR("Failed to read tmds config, err=%d\n", ret);
+		DRM_ERROR("Failed to read tmds config: %d\n", ret);
  		return false;
  	}
 

From: Thierry Reding <[email protected]>

The file uses inconsistent capitalization for TMDS. Since it is an abbreviation, all uppercase is correct.

Signed-off-by Thierry Reding <[email protected]>

---
  drivers/gpu/drm/drm_scdc_helper.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

drivers/gpu/drm/drm_scdc_helper.c +1 -1

index 5e6f0709df49..657ea5ab6c3f 100644
@@ -168,7 +168,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable)
 
  	ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config);
  	if (ret < 0) {
-		DRM_ERROR("Failed to read tmds config: %d\n", ret);
+		DRM_ERROR("Failed to read TMDS config: %d\n", ret);
  		return false;
  	}
 

From: Thierry Reding <[email protected]>

It's unusual to separate kerneldoc comments from the functions that they describe by a blank line. Remove them.

Signed-off-by Thierry Reding <[email protected]>

---
 drivers/gpu/drm/drm_scdc_helper.c | 2 --
 1 file changed, 2 deletions(-)

drivers/gpu/drm/drm_scdc_helper.c +0 -2

index 935653eb3616..d66c436a829e 100644
@@ -134,7 +134,6 @@ EXPORT_SYMBOL(drm_scdc_write);
  * Returns:
  * True if the scrambling is enabled, false otherwise.
  */
-
 bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter)
 {
 	u8 status;

@@ -162,7 +161,6 @@ EXPORT_SYMBOL(drm_scdc_get_scrambling_status);
  * Returns:
  * True if scrambling is set/reset successfully, false otherwise.
  */
-
 bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable)
 {
 	u8 config;

Signature · 6 lines

2.13.3

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Quoted 6 lines · Thierry Reding

From: Thierry Reding <[email protected]>

It's unusual to separate kerneldoc comments from the functions that they describe by a blank line. Remove them.

Signed-off-by Thierry Reding <[email protected]>

Series lgtm

Reviewed-by Ville Syrjälä <[email protected]>

From: Thierry Reding <[email protected]>

It's unusual to separate kerneldoc comments from the functions that they describe by a blank line. Remove them.

Signed-off-by Thierry Reding <[email protected]>

---
  drivers/gpu/drm/drm_scdc_helper.c | 2 --
  1 file changed, 2 deletions(-)

drivers/gpu/drm/drm_scdc_helper.c +0 -1

index 935653eb3616..d66c436a829e 100644
@@ -134,7 +134,6 @@ EXPORT_SYMBOL(drm_scdc_write);
   * Returns:
   * True if the scrambling is enabled, false otherwise.
   */
-
  bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter)
  {
  	u8 status;