drm/amdgpu: include percpu.h to fix SPARC build
Subsystems (3)
PATCH 1/1 drm/amdgpu: include percpu.h to fix SPARC build
--- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h +1 -0
@@ -26,6 +26,7 @@#define AMDGPU_AMDKFD_H_INCLUDED #include <linux/types.h> +#include <linux/percpu.h> #include <linux/mmu_context.h> #include <kgd_kfd_interface.h>
Signature · 6 lines
2.13.5 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
But isn't that a bug in the SPARC kernel headers? Shouldn't they handle that dependency rather than putting the responsibility on unsuspecting users of mmu_context.h? I sent a question about this to Pavel Tatashin on Aug 22, but haven't heard back from him.
Regards,
Felix
Quoted 10 lines · Oded Gabbay
Signed-off-by Oded Gabbay <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h line 32
Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h +1
-0@@ -26,6 +26,7 @@#define AMDGPU_AMDKFD_H_INCLUDED #include <linux/types.h> +#include <linux/percpu.h> #include <linux/mmu_context.h> #include <kgd_kfd_interface.h>
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 9f2fc0d4-30bc-1639-d51e-00810fdca03b-5C7GfCeVMHo@public.gmane.org
Quoted 10 lines · Felix Kuehling
Acked-by Felix Kuehling <[email protected]>But isn't that a bug in the SPARC kernel headers? Shouldn't they handle that dependency rather than putting the responsibility on unsuspecting users of
mmu_context.h? I sent a question about this to Pavel Tatashin on Aug 22, but haven't heard back from him.Regards,
Felix
You are probably right, but I because I don't know how much the SPARC people are responsive, I thought that it wouldn't be that bad to fix it in our code.
Oded
Quoted 14 lines · Oded Gabbay
Quoted 12 lines
Signed-off-by Oded Gabbay <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h +0
-0@@ -26,6 +26,7 @@#define AMDGPU_AMDKFD_H_INCLUDED
Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h line 32
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h +1
-0#include <linux/types.h> +#include <linux/percpu.h> #include <linux/mmu_context.h> #include <kgd_kfd_interface.h>
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx