drm/i915/dsi: Fix error on DSI video mode command
Subsystems (2)
cover drm/i915/dsi: Fix error on DSI video mode command
In CI system, the Broxton with DSI display throws an error message with
*ERROR* Video mode command 0x00000041 send failed.
In order to get rid of the error message, we should send SHUTDOWN before MIPI_SEQ_DISPLAY_OFF for VBT's higher than v3.
If we end up sending two or more MIPI commands that are the same, an error message is thrown. The patch suggests to replace this error message with a debug message as it is not that severe failure. With this change the CI system is not flip flopping due to error message in dmesg log.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102404
Mika Kahola (2):
drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's drm/i915/dsi: Replace MIPI command error message with debug message
drivers/gpu/drm/i915/intel_dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/2 drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's
According to spec we should send SHUTDOWN before MIPI_SEQ_DISPLAY_OFF for v3+ VBT's. Testing with VBT v3 the current implementation yields the following error message
*ERROR* Video mode command 0x00000041 send failed.
To get rid of this error message, let's limit SHUTDOWN only for VBT versions 3 or higher.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102404
--- drivers/gpu/drm/i915/intel_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dsi.c +1 -1
@@ -916,7 +916,7 @@ static void intel_dsi_disable(struct intel_encoder *encoder,* MIPI_SEQ_DISPLAY_OFF only for v3+ VBTs, but field testing * has shown that the v3 sequence works for v2 VBTs too */ -if (is_vid_mode (intel_dsi)) { +if (is_vid_mode (intel_dsi) && dev_priv->vbt.dsi.seq_version >3 ) {/* Send Shutdown command to the panel in LP mode */ for_each_dsi_port (port, intel_dsi->ports)dpi_send_cmd (intel_dsi,SHUTDOWN , false, port);
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's
Quoted 8 lines · Mika Kahola
According to spec we should send SHUTDOWN before
MIPI_SEQ_DISPLAY_OFFfor v3+ VBT's. Testing with VBT v3 the current implementation yields the following error message*ERROR* Video mode command
0x00000041send failed.To get rid of this error message, let's limit SHUTDOWN only for VBT versions 3 or higher.
In the patch you limit it to version 4+, which doesn't make sense since AFAIK there is no version 4 of the sequence block.
Quoted 27 lines
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102404
Signed-off-by Mika Kahola <[email protected]>--- drivers/gpu/drm/i915/intel_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dsi.c +1
-1@@ -916,7 +916,7 @@ static void intel_dsi_disable(struct intel_encoder *encoder,* MIPI_SEQ_DISPLAY_OFF only for v3+ VBTs, but field testing * has shown that the v3 sequence works for v2 VBTs too */ -if (is_vid_mode (intel_dsi)) { +if (is_vid_mode (intel_dsi) && dev_priv->vbt.dsi.seq_version >3 ) {/* Send Shutdown command to the panel in LP mode */ for_each_dsi_port (port, intel_dsi->ports)dpi_send_cmd (intel_dsi,SHUTDOWN , false, port);Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's
Quoted 8 lines · Ville Syrjälä
Quoted 7 lines · Mika Kahola
According to spec we should send SHUTDOWN before
MIPI_SEQ_DISPLAY_OFFfor
v3+ VBT's. Testing with VBT v3 the current implementation yields the
following error message
Quoted 7 lines
Quoted 4 lines
*ERROR* Video mode command
0x00000041send failed.To get rid of this error message, let's limit SHUTDOWN only for VBT versions 3 or higher.
In the patch you limit it to version 4+, which doesn't make sense since
AFAIK there is no version 4 of the sequence block.
It seems that sending SHUTDOWN signal doesn't make any sense either. Whenever we send that signal it just causes this error message. Do we really need to signal this? From functionality point of view there's no difference.
Quoted 35 lines
Quoted 35 lines
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102404
Signed-off-by Mika Kahola <[email protected]>---
drivers/gpu/drm/i915/intel_dsi.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dsi.c +0
-0@@ -916,7 +916,7 @@ static void intel_dsi_disable(structintel_encoder *encoder, * MIPI_SEQ_DISPLAY_OFF only for v3+ VBTs, but fieldtesting
* has shown that the v3 sequence works for v2 VBTs too */drivers/gpu/drm/i915/intel_dsi.c +1
-1-if (is_vid_mode (intel_dsi)) { + if (is_vid_mode(intel_dsi) && dev_priv-Quoted 1 line
vbt.dsi.seq_version > 3) {
/* Send Shutdown command to the panel in LP mode */
for_each_dsi_port(port, intel_dsi->ports)dpi_send_cmd(intel_dsi, SHUTDOWN, false, port);
--
2.7.4_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Mika Kahola - Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's
Quoted 13 lines · Mika Kahola
Quoted 12 lines · Ville Syrjälä
Quoted 11 lines · Mika Kahola
According to spec we should send SHUTDOWN before
MIPI_SEQ_DISPLAY_OFFfor
v3+ VBT's. Testing with VBT v3 the current implementation yields the
following error message*ERROR* Video mode command
0x00000041send failed.To get rid of this error message, let's limit SHUTDOWN only for VBT versions 3 or higher.
Quoted 7 lines
Quoted 3 lines
In the patch you limit it to version 4+, which doesn't make sense since
AFAIK there is no version 4 of the sequence block.It seems that sending SHUTDOWN signal doesn't make any sense either. Whenever we send that signal it just causes this error message. Do we really need to signal this? From functionality point of view there's no difference.
Well, the spec doesn't even explain what this "shut down" command does. Is it actually the DCS "display off" command, or something else?
Did you try reverting bbdf0b2ff32a ("drm/i915/bxt: Disable device ready before shutdown command")? That looks suspicious to me. But so does about half of the DSI code since it never seems to follow the spec, and we end up doing totally different things on different platforms without any explanation why that is).
Quoted 38 lines
Quoted 36 lines
Quoted 36 lines
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102404
Signed-off-by Mika Kahola <[email protected]>---
drivers/gpu/drm/i915/intel_dsi.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dsi.c +0
-0@@ -916,7 +916,7 @@ static void intel_dsi_disable(structintel_encoder *encoder, * MIPI_SEQ_DISPLAY_OFF only for v3+ VBTs, but fieldtesting
* has shown that the v3 sequence works for v2 VBTs too */drivers/gpu/drm/i915/intel_dsi.c +1
-1-if (is_vid_mode (intel_dsi)) { + if (is_vid_mode(intel_dsi) && dev_priv-Quoted 1 line
vbt.dsi.seq_version > 3) {
/* Send Shutdown command to the panel in LP mode */
for_each_dsi_port(port, intel_dsi->ports)dpi_send_cmd(intel_dsi, SHUTDOWN, false, port);
--
2.7.4_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 1 line
Mika Kahola - Intel OTC
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's
Quoted 29 lines · Ville Syrjälä
Quoted 21 lines · Mika Kahola
Quoted 11 lines · Ville Syrjälä
Quoted 9 lines · Mika Kahola
According to spec we should send SHUTDOWN before
MIPI_SEQ_DISPLAY_OFFfor
v3+ VBT's. Testing with VBT v3 the current implementation yields
the
following error messageQuoted 8 lines
Quoted 5 lines
*ERROR* Video mode command
0x00000041send failed.To get rid of this error message, let's limit SHUTDOWN only for VBT
versions 3 or higher.In the patch you limit it to version 4+, which doesn't make sense since
AFAIK there is no version 4 of the sequence block.Quoted 7 lines
It seems that sending SHUTDOWN signal doesn't make any sense either.
Whenever we send that signal it just causes this error message. Do we
really need to signal this? From functionality point of view there's no
difference.
Quoted 3 lines
Well, the spec doesn't even explain what this "shut down" command does.
Is it actually the DCS "display off" command, or something else?
It seems to do something. At least the intel_wait_for_register() times out when sending SHUTDOWN signal. Maybe it just shuts down display so we can't even read the registers after that.
This brings me to another idea. Maybe we should skip intel_wait_for_register() if we have sent out SHUTDOWN signal?
Quoted 9 lines
Did you try reverting
bbdf0b2ff32a("drm/i915/bxt: Disable device ready
before shutdown command")? That looks suspicious to me. But so does about half of the DSI code since it never seems to follow the spec, and
we end up doing totally different things on different platforms without
any explanation why that is).
I haven't tried that. I will give it a go and see what happens.
Quoted 46 lines
Quoted 46 lines
Quoted 40 lines
Quoted 40 lines
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102404
Signed-off-by Mika Kahola <[email protected]>---
drivers/gpu/drm/i915/intel_dsi.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dsi.c +0
-0@@ -916,7 +916,7 @@ static void intel_dsi_disable(structintel_encoder *encoder, * MIPI_SEQ_DISPLAY_OFF only for v3+ VBTs, but fieldtesting
* has shown that the v3 sequence works for v2 VBTs too
*/drivers/gpu/drm/i915/intel_dsi.c +1
-1-if (is_vid_mode (intel_dsi)) { + if (is_vid_mode(intel_dsi) && dev_priv-Quoted 2 lines
vbt.dsi.seq_version > 3) {
/* Send Shutdown command to the panel in LP mode
*/
for_each_dsi_port(port, intel_dsi->ports)dpi_send_cmd(intel_dsi, SHUTDOWN, false,
port);
--
2.7.4Quoted 4 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx--
Mika Kahola - Intel OTC
Signature · 6 lines
Mika Kahola - Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's
Quoted 46 lines
-----Original Message-----
From: Kahola, Mika
Sent: Tuesday, September 5, 2017 2:03 PM
To: Ville Syrjälä <[email protected]>
Cc: [email protected]; Shankar, Uma <[email protected]>
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT'sQuoted 20 lines · Ville Syrjälä
Quoted 19 lines · Mika Kahola
Quoted 17 lines · Ville Syrjälä
Quoted 9 lines · Mika Kahola
According to spec we should send SHUTDOWN before
MIPI_SEQ_DISPLAY_OFFfor
v3+ VBT's. Testing with VBT v3 the current implementation yields
the
following error messageQuoted 4 lines
*ERROR* Video mode command
0x00000041send failed.To get rid of this error message, let's limit SHUTDOWN only for VBT versions 3 or higher.
In the patch you limit it to version 4+, which doesn't make sense since AFAIK there is no version 4 of the sequence block.
Quoted 7 lines
Quoted 4 lines
It seems that sending SHUTDOWN signal doesn't make any sense either. Whenever we send that signal it just causes this error message. Do we really need to signal this? From functionality point of view there's no difference.
Well, the spec doesn't even explain what this "shut down" command does.
Is it actually the DCS "display off" command, or something else?It seems to do something. At least the
intel_wait_for_register()times out when sending SHUTDOWN signal. Maybe it just shuts down display so we can't even read the registers after that.This brings me to another idea. Maybe we should skip
intel_wait_for_register()if we have sent out SHUTDOWN signal?Quoted 1 line
Quoted 7 lines
Quoted 5 lines
Did you try reverting
bbdf0b2ff32a("drm/i915/bxt: Disable device ready before shutdown command")? That looks suspicious to me. But so does about half of the DSI code since it never seems to follow the spec, and we end up doing totally different things on different platforms without any explanation why that is).I haven't tried that. I will give it a go and see what happens.
The issue is happening due to Device Ready setting. It was added to resolve a DSI split screen issue in dual link DSI panels. Since DSI dual link is not enabled and will require a bit of work in upstream, we should revert this change. Vidya will send the change and also work on enabling dual link support in upstream.
FYI - SHUTDOWN is a short packet peripheral command that turns off the display in a Video Mode display module for power saving.
For DSI, there have been issues with different panels requiring some unconventional changes, and also bspec sometimes doesn't cover everything generically. So, it gets a bit challenging :(
Regards,
Uma Shankar
Quoted 33 lines
Quoted 33 lines
Quoted 33 lines
Quoted 33 lines
Quoted 33 lines
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102404
Signed-off-by Mika Kahola <[email protected]>---
drivers/gpu/drm/i915/intel_dsi.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dsi.c +1
-1@@ -916,7 +916,7 @@ static void intel_dsi_disable(structintel_encoder *encoder, * MIPI_SEQ_DISPLAY_OFF only for v3+ VBTs, but field testing * has shown that the v3 sequence works for v2 VBTs too */ -if (is_vid_mode (intel_dsi)) { + if (is_vid_mode(intel_dsi) && dev_priv-Quoted 2 lines
vbt.dsi.seq_version > 3) {
/* Send Shutdown command to the panel in LP mode */
for_each_dsi_port(port, intel_dsi->ports)dpi_send_cmd(intel_dsi, SHUTDOWN, false, port); --
2.7.4
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx--
Mika Kahola - Intel OTC--
Mika Kahola - Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/1 Revert "drm/i915/bxt: Disable device ready before shutdown command"
From: Uma Shankar <[email protected]>
This reverts commit bbdf0b2ff32aa75c7bd167569130e9391d2e6282.
Disable device ready before shutdown command was added previously to avoid a split screen issue seen on dual link DSI panels. As of now, dual link is not supported and will need some rework in the upstream code. For single link DSI panels, the change is not required. This will cause failure in sending SHUTDOWN packet during disable. Hence reverting the change. Will handle the change as part of dual link enabling in upstream.
--- drivers/gpu/drm/i915/intel_dsi.c | 11 ----------- 1 file changed, 11 deletions(-)
drivers/gpu/drm/i915/intel_dsi.c +0 -11
@@ -892,8 +892,6 @@ static void intel_dsi_disable(struct intel_encoder *encoder,const struct intel_crtc_state *old_crtc_state, const struct drm_connector_state *old_conn_state) { - struct drm_device *dev = encoder->base.dev; -struct drm_i915_private *dev_priv = dev->dev_private; struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);enum port port;
@@ -903,15 +901,6 @@ static void intel_dsi_disable(struct intel_encoder *encoder,intel_panel_disable_backlight (old_conn_state);/* -* Disable Device ready before the port shutdown in order -* to avoid split screen -*/ -if (IS_BROXTON (dev_priv)) { -for_each_dsi_port (port, intel_dsi->ports) -I915_WRITE (MIPI_DEVICE_READY (port),0 ); - } - -/* * According to the spec we should send SHUTDOWN before * MIPI_SEQ_DISPLAY_OFF only for v3+ VBTs, but field testing * has shown that the v3 sequence works for v2 VBTs too
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH] Revert "drm/i915/bxt: Disable device ready before shutdown command"
The revert patch solved the issue
*ERROR* Video mode command 0x00000041 send failed.
on my setup with APL+MIPI/DSI single link combo.
Quoted 57 lines · Vidya Srinivas
From: Uma Shankar <[email protected]>
This reverts commit
bbdf0b2ff32aa75c7bd167569130e9391d2e6282.Disable device ready before shutdown command was added previously to avoid a
split screen issue seen on dual link DSI panels. As of now, dual link is not
supported and will need some rework in the upstream code. For single link DSI
panels, the change is not required. This will cause failure in sending SHUTDOWN
packet during disable. Hence reverting the change. Will handle the change
as part of dual link enabling in upstream.Signed-off-by Uma Shankar <[email protected]>Signed-off-by Vidya Srinivas <[email protected]>---
drivers/gpu/drm/i915/intel_dsi.c | 11 -----------1 file changed, 11 deletions(-)drivers/gpu/drm/i915/intel_dsi.c +0
-0@@ -892,8 +892,6 @@ static void intel_dsi_disable(struct intel_encoder *encoder,const struct
intel_crtc_state*old_crtc_state,
const structdrm_connector_state*old_conn_state)
{drivers/gpu/drm/i915/intel_dsi.c +0
-2-struct drm_device *dev = encoder->base.dev; -struct drm_i915_private *dev_priv = dev->dev_private;struct
intel_dsi*intel_dsi= enc_to_intel_dsi(&encoder-Quoted 1 line
base);
enum port port;
drivers/gpu/drm/i915/intel_dsi.c +0
-0@@ -903,15 +901,6 @@ static void intel_dsi_disable(structintel_encoder *encoder, intel_panel_disable_backlight(old_conn_state);
/*drivers/gpu/drm/i915/intel_dsi.c +0
-9-* Disable Device ready before the port shutdown in order -* to avoid split screen -*/ -if (IS_BROXTON (dev_priv)) { -for_each_dsi_port (port, intel_dsi->ports) -I915_WRITE (MIPI_DEVICE_READY (port),0 ); - } - -/* * According to the spec we should send SHUTDOWN before
*MIPI_SEQ_DISPLAY_OFFonly for v3+ VBTs, but field testing
* has shown that the v3 sequence works for v2 VBTs too
Signature · 6 lines
Mika Kahola - Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerRe: [PATCH] Revert "drm/i915/bxt: Disable device ready before shutdown command"
Quoted 7 lines · Mika Kahola
The revert patch solved the issue
*ERROR* Video mode command
0x00000041send failed.on my setup with APL+MIPI/DSI single link combo.
Tested-by Mika Kahola <[email protected]>
Pushed to dinq, thanks for the patch and testing. Alas, I failed to add your Tested-by tag, apologies.
BR,
Jani.
Quoted 60 lines · Vidya Srinivas
Quoted 57 lines
From: Uma Shankar <[email protected]>
This reverts commit
bbdf0b2ff32aa75c7bd167569130e9391d2e6282.Disable device ready before shutdown command was added previously to avoid a
split screen issue seen on dual link DSI panels. As of now, dual link is not
supported and will need some rework in the upstream code. For single link DSI
panels, the change is not required. This will cause failure in sending SHUTDOWN
packet during disable. Hence reverting the change. Will handle the change
as part of dual link enabling in upstream.Signed-off-by Uma Shankar <[email protected]>Signed-off-by Vidya Srinivas <[email protected]>---
drivers/gpu/drm/i915/intel_dsi.c | 11 -----------1 file changed, 11 deletions(-)drivers/gpu/drm/i915/intel_dsi.c +0
-0@@ -892,8 +892,6 @@ static void intel_dsi_disable(struct intel_encoder *encoder,const struct
intel_crtc_state*old_crtc_state,
const structdrm_connector_state*old_conn_state)
{drivers/gpu/drm/i915/intel_dsi.c +0
-2-struct drm_device *dev = encoder->base.dev; -struct drm_i915_private *dev_priv = dev->dev_private;struct
intel_dsi*intel_dsi= enc_to_intel_dsi(&encoder-Quoted 1 line
base);
enum port port;
drivers/gpu/drm/i915/intel_dsi.c +0
-0@@ -903,15 +901,6 @@ static void intel_dsi_disable(structintel_encoder *encoder, intel_panel_disable_backlight(old_conn_state);
/*drivers/gpu/drm/i915/intel_dsi.c +0
-9-* Disable Device ready before the port shutdown in order -* to avoid split screen -*/ -if (IS_BROXTON (dev_priv)) { -for_each_dsi_port (port, intel_dsi->ports) -I915_WRITE (MIPI_DEVICE_READY (port),0 ); - } - -/* * According to the spec we should send SHUTDOWN before
*MIPI_SEQ_DISPLAY_OFFonly for v3+ VBTs, but field testing
* has shown that the v3 sequence works for v2 VBTs too
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH] Revert "drm/i915/bxt: Disable device ready before shutdown command"
In reply to Vidya SrinivasQuoted 11 lines
-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Vidya Srinivas
Sent: Tuesday, September 5, 2017 3:15 PM
To: [email protected]
Cc: Srinivas, Vidya <[email protected]>
Subject: [Intel-gfx] [PATCH] Revert "drm/i915/bxt: Disable device ready before shutdown command"From: Uma Shankar <[email protected]>
Quoted 8 lines
This reverts commit
bbdf0b2ff32aa75c7bd167569130e9391d2e6282.Disable device ready before shutdown command was added previously to avoid a split screen issue seen on dual link DSI panels. As of now, dual link is not supported and will need some rework in the upstream code. For single link DSI panels, the change is not required. This will cause failure in sending SHUTDOWN packet during disable. Hence reverting the change. Will handle the change as part of dual link enabling in upstream.
Already there are lot of changes wrt to DSI dual link inside intel_dsi.c. Can't we keep this change as well under the condition if (dual_link && Broxton)?? Might help to fetch dual link changes in future instead of losing it.
Regards,
Madhav
Quoted 42 lines
Signed-off-by Uma Shankar <[email protected]>Signed-off-by Vidya Srinivas <[email protected]>--- drivers/gpu/drm/i915/intel_dsi.c | 11 ----------- 1 file changed, 11 deletions(-)drivers/gpu/drm/i915/intel_dsi.c +0
-11@@ -892,8 +892,6 @@ static void intel_dsi_disable(struct intel_encoder *encoder, const struct intel_crtc_state *old_crtc_state, const struct drm_connector_state *old_conn_state) { - struct drm_device *dev = encoder->base.dev; -struct drm_i915_private *dev_priv = dev->dev_private; struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);enum port port;@@ -903,15 +901,6 @@ static void intel_dsi_disable(struct intel_encoder *encoder,intel_panel_disable_backlight (old_conn_state);/* -* Disable Device ready before the port shutdown in order -* to avoid split screen -*/ -if (IS_BROXTON (dev_priv)) { -for_each_dsi_port (port, intel_dsi->ports) -I915_WRITE (MIPI_DEVICE_READY (port),0 ); - } - -/* * According to the spec we should send SHUTDOWN before * MIPI_SEQ_DISPLAY_OFF only for v3+ VBTs, but field testing * has shown that the v3 sequence works for v2 VBTs too
--
1.9.1
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH] Revert "drm/i915/bxt: Disable device ready before shutdown command"
Quoted 20 lines · Madhav
Quoted 11 lines
-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Vidya Srinivas
Sent: Tuesday, September 5, 2017 3:15 PM
To: [email protected]
Cc: Srinivas, Vidya <[email protected]>
Subject: [Intel-gfx] [PATCH] Revert "drm/i915/bxt: Disable device ready before shutdown command"From: Uma Shankar <[email protected]>
Quoted 8 lines
This reverts commit
bbdf0b2ff32aa75c7bd167569130e9391d2e6282.Disable device ready before shutdown command was added previously to avoid a split screen issue seen on dual link DSI panels. As of now, dual link is not supported and will need some rework in the upstream code. For single link DSI panels, the change is not required. This will cause failure in sending SHUTDOWN packet during disable. Hence reverting the change. Will handle the change as part of dual link enabling in upstream.
Quoted 3 lines
Already there are lot of changes wrt to DSI dual link inside
intel_dsi.c. Can't we keep this change as well under the condition if (dual_link&& Broxton)?? Might help to fetch dual link changes in future instead of losing it.
I've pushed the patch as-is. I don't think there are grounds to keep it even with dual_link. As Uma says, these things may be panel specific too.
BR,
Jani.
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH] Revert "drm/i915/bxt: Disable device ready before shutdown command"
Quoted 31 lines
-----Original Message-----
From: Nikula, Jani
Sent: Wednesday, September 13, 2017 1:39 PM
To: Chauhan, Madhav <[email protected]>; Srinivas, Vidya <[email protected]>; [email protected]
Subject: RE: [Intel-gfx] [PATCH] Revert "drm/i915/bxt: Disable device ready before shutdown command"Quoted 11 lines · Madhav
Quoted 11 lines
-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Vidya Srinivas
Sent: Tuesday, September 5, 2017 3:15 PM
To: [email protected]
Cc: Srinivas, Vidya <[email protected]>
Subject: [Intel-gfx] [PATCH] Revert "drm/i915/bxt: Disable device ready before shutdown command"From: Uma Shankar <[email protected]>
Quoted 8 lines
Quoted 8 lines
This reverts commit
bbdf0b2ff32aa75c7bd167569130e9391d2e6282.Disable device ready before shutdown command was added previously to avoid a split screen issue seen on dual link DSI panels. As of now, dual link is not supported and will need some rework in the upstream code. For single link DSI panels, the change is not required. This will cause failure in sending SHUTDOWN packet during disable. Hence reverting the change. Will handle the change as part of dual link enabling
in upstream.
Quoted 1 line
Quoted 7 lines
Quoted 2 lines
Already there are lot of changes wrt to DSI dual link inside
intel_dsi.c. Can't we keep this change as well under the condition if (dual_link&&Broxton)??
Quoted 1 line
Might help to fetch dual link changes in future instead of losing it.
I've pushed the patch as-is. I don't think there are grounds to keep it even with
dual_link. As Uma says, these things may be panel specific too.
Hmm..Ok Thanks for clarification.
Regards,
Madhav
Quoted 7 lines
BR,
Jani.--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's
In reply to Shankar, UmaQuoted 54 lines · Uma
Quoted 46 lines
-----Original Message-----
From: Kahola, Mika
Sent: Tuesday, September 5, 2017 2:03 PM
To: Ville Syrjälä <[email protected]>
Cc: [email protected]; Shankar, Uma <[email protected]>
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT'sQuoted 20 lines · Ville Syrjälä
Quoted 19 lines · Mika Kahola
Quoted 17 lines · Ville Syrjälä
Quoted 9 lines · Mika Kahola
According to spec we should send SHUTDOWN before
MIPI_SEQ_DISPLAY_OFFfor
v3+ VBT's. Testing with VBT v3 the current implementation yields
the
following error messageQuoted 4 lines
*ERROR* Video mode command
0x00000041send failed.To get rid of this error message, let's limit SHUTDOWN only for VBT versions 3 or higher.
In the patch you limit it to version 4+, which doesn't make sense since AFAIK there is no version 4 of the sequence block.
Quoted 7 lines
Quoted 4 lines
It seems that sending SHUTDOWN signal doesn't make any sense either. Whenever we send that signal it just causes this error message. Do we really need to signal this? From functionality point of view there's no difference.
Well, the spec doesn't even explain what this "shut down" command does.
Is it actually the DCS "display off" command, or something else?It seems to do something. At least the
intel_wait_for_register()times out when sending SHUTDOWN signal. Maybe it just shuts down display so we can't even read the registers after that.This brings me to another idea. Maybe we should skip
intel_wait_for_register()if we have sent out SHUTDOWN signal?Quoted 1 line
Quoted 7 lines
Quoted 5 lines
Did you try reverting
bbdf0b2ff32a("drm/i915/bxt: Disable device ready before shutdown command")? That looks suspicious to me. But so does about half of the DSI code since it never seems to follow the spec, and we end up doing totally different things on different platforms without any explanation why that is).I haven't tried that. I will give it a go and see what happens.
Quoted 7 lines
The issue is happening due to Device Ready setting. It was added to resolve a DSI split screen issue in dual link DSI panels. Since DSI dual link is not enabled and will require a bit of work in upstream, we should revert this change. Vidya will send the change and also work on enabling dual link support in upstream.
FYI - SHUTDOWN is a short packet peripheral command that turns off the display in a Video Mode display module for power saving.
There is no SHUTDOWN comamnd in the DCS spec that I can find.
Quoted 49 lines
For DSI, there have been issues with different panels requiring some unconventional changes, and also bspec sometimes doesn't cover everything generically. So, it gets a bit challenging :(
Regards,
Uma ShankarQuoted 41 lines
Quoted 33 lines
Quoted 33 lines
Quoted 33 lines
Quoted 33 lines
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102404
Signed-off-by Mika Kahola <[email protected]>---
drivers/gpu/drm/i915/intel_dsi.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dsi.c +1
-1@@ -916,7 +916,7 @@ static void intel_dsi_disable(structintel_encoder *encoder, * MIPI_SEQ_DISPLAY_OFF only for v3+ VBTs, but field testing * has shown that the v3 sequence works for v2 VBTs too */ -if (is_vid_mode (intel_dsi)) { + if (is_vid_mode(intel_dsi) && dev_priv-Quoted 2 lines
vbt.dsi.seq_version > 3) {
/* Send Shutdown command to the panel in LP mode */
for_each_dsi_port(port, intel_dsi->ports)dpi_send_cmd(intel_dsi, SHUTDOWN, false, port); --
2.7.4Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx--
Mika Kahola - Intel OTC--
Mika Kahola - Intel OTC
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's
Quoted 71 lines
-----Original Message-----
From: Ville Syrjälä [mailto:[email protected]]
Sent: Tuesday, September 5, 2017 6:46 PM
To: Shankar, Uma <[email protected]>
Cc: Kahola, Mika <[email protected]>; Srinivas, Vidya <[email protected]>; [email protected]
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT'sQuoted 52 lines · Uma
Quoted 52 lines
-----Original Message-----
From: Kahola, Mika
Sent: Tuesday, September 5, 2017 2:03 PM
To: Ville Syrjälä <[email protected]>
Cc: [email protected]; Shankar, Uma <[email protected]>
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT'sQuoted 20 lines · Ville Syrjälä
Quoted 19 lines · Mika Kahola
Quoted 17 lines · Ville Syrjälä
Quoted 9 lines · Mika Kahola
According to spec we should send SHUTDOWN before
MIPI_SEQ_DISPLAY_OFFfor
v3+ VBT's. Testing with VBT v3 the current implementation yields
the
following error messageQuoted 4 lines
*ERROR* Video mode command
0x00000041send failed.To get rid of this error message, let's limit SHUTDOWN only for VBT versions 3 or higher.
In the patch you limit it to version 4+, which doesn't make sense since AFAIK there is no version 4 of the sequence block.
Quoted 7 lines
Quoted 4 lines
It seems that sending SHUTDOWN signal doesn't make any sense either. Whenever we send that signal it just causes this error message. Do we really need to signal this? From functionality point of view there's no difference.
Well, the spec doesn't even explain what this "shut down" command does.
Is it actually the DCS "display off" command, or something else?It seems to do something. At least the
intel_wait_for_register()times out when sending SHUTDOWN signal. Maybe it just shuts down display so we can't even read the registers after that.This brings me to another idea. Maybe we should skip
intel_wait_for_register()if we have sent out SHUTDOWN signal?Quoted 6 lines
Did you try reverting
bbdf0b2ff32a("drm/i915/bxt: Disable device ready before shutdown command")? That looks suspicious to me. But so does about half of the DSI code since it never seems to follow the spec, and we end up doing totally different things on different platforms without any explanation why that is).Quoted 7 lines
Quoted 2 lines
I haven't tried that. I will give it a go and see what happens.
The issue is happening due to Device Ready setting. It was added to resolve a DSI split screen issue in dual link DSI panels. Since DSI dual link is not enabled and will require a bit of work in upstream, we should revert this change. Vidya will send the change and also work on
Quoted 7 lines
enabling dual link support in upstream.
Quoted 3 lines
FYI - SHUTDOWN is a short packet peripheral command that turns off the display in a Video Mode display module for power saving.
There is no SHUTDOWN comamnd in the DCS spec that I can find.
Hi Ville,
It's part of MIPI_DSI_specification - (v1-3 is the latest)
8.8.5 Shutdown Peripheral Command, Data Type = 10 0010 (0x22)
Shutdown Peripheral command is a Short packet command that turns off the display in a Video Mode display module for power saving. Note the interface shall remain powered in order to receive the turn-on, or wake-up, command.
Regards,
Uma Shankar
Quoted 48 lines
Quoted 38 lines
For DSI, there have been issues with different panels requiring some unconventional changes, and also bspec sometimes doesn't cover everything generically. So, it gets a bit challenging :(
Regards,
Uma ShankarQuoted 30 lines
Quoted 30 lines
Quoted 30 lines
Quoted 30 lines
Quoted 30 lines
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102404
Signed-off-by Mika Kahola <[email protected]>---
drivers/gpu/drm/i915/intel_dsi.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dsi.c +1
-1@@ -916,7 +916,7 @@ static void intel_dsi_disable(structintel_encoder *encoder, * MIPI_SEQ_DISPLAY_OFF only for v3+ VBTs, but field testing * has shown that the v3 sequence works for v2 VBTs too */ -if (is_vid_mode (intel_dsi)) { + if (is_vid_mode(intel_dsi) && dev_priv-Quoted 2 lines
vbt.dsi.seq_version > 3) {
/* Send Shutdown command to the panel in LP mode */
for_each_dsi_port(port, intel_dsi->ports)dpi_send_cmd(intel_dsi, SHUTDOWN, false,port);
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 7 lines
Quoted 7 lines
--
2.7.4_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx--
Mika Kahola - Intel OTC
Quoted 7 lines
Quoted 3 lines
Quoted 2 lines
--
Mika Kahola - Intel OTC--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's
Quoted 79 lines · Uma
Quoted 71 lines
-----Original Message-----
From: Ville Syrjälä [mailto:[email protected]]
Sent: Tuesday, September 5, 2017 6:46 PM
To: Shankar, Uma <[email protected]>
Cc: Kahola, Mika <[email protected]>; Srinivas, Vidya <[email protected]>; [email protected]
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT'sQuoted 52 lines · Uma
Quoted 52 lines
-----Original Message-----
From: Kahola, Mika
Sent: Tuesday, September 5, 2017 2:03 PM
To: Ville Syrjälä <[email protected]>
Cc: [email protected]; Shankar, Uma <[email protected]>
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT'sQuoted 20 lines · Ville Syrjälä
Quoted 19 lines · Mika Kahola
Quoted 17 lines · Ville Syrjälä
Quoted 9 lines · Mika Kahola
According to spec we should send SHUTDOWN before
MIPI_SEQ_DISPLAY_OFFfor
v3+ VBT's. Testing with VBT v3 the current implementation yields
the
following error messageQuoted 4 lines
*ERROR* Video mode command
0x00000041send failed.To get rid of this error message, let's limit SHUTDOWN only for VBT versions 3 or higher.
In the patch you limit it to version 4+, which doesn't make sense since AFAIK there is no version 4 of the sequence block.
Quoted 7 lines
Quoted 4 lines
It seems that sending SHUTDOWN signal doesn't make any sense either. Whenever we send that signal it just causes this error message. Do we really need to signal this? From functionality point of view there's no difference.
Well, the spec doesn't even explain what this "shut down" command does.
Is it actually the DCS "display off" command, or something else?It seems to do something. At least the
intel_wait_for_register()times out when sending SHUTDOWN signal. Maybe it just shuts down display so we can't even read the registers after that.This brings me to another idea. Maybe we should skip
intel_wait_for_register()if we have sent out SHUTDOWN signal?Quoted 6 lines
Did you try reverting
bbdf0b2ff32a("drm/i915/bxt: Disable device ready before shutdown command")? That looks suspicious to me. But so does about half of the DSI code since it never seems to follow the spec, and we end up doing totally different things on different platforms without any explanation why that is).Quoted 7 lines
Quoted 2 lines
I haven't tried that. I will give it a go and see what happens.
The issue is happening due to Device Ready setting. It was added to resolve a DSI split screen issue in dual link DSI panels. Since DSI dual link is not enabled and will require a bit of work in upstream, we should revert this change. Vidya will send the change and also work on
Quoted 7 lines
enabling dual link support in upstream.
Quoted 3 lines
FYI - SHUTDOWN is a short packet peripheral command that turns off the display in a Video Mode display module for power saving.
There is no SHUTDOWN comamnd in the DCS spec that I can find.
Quoted 6 lines
Hi Ville,
It's part ofMIPI_DSI_specification- (v1-3 is the latest)
8.8.5 Shutdown Peripheral Command, Data Type = 10 0010 (0x22)
Shutdown Peripheral command is a Short packet command that turns off the display in a Video Mode display module for power saving. Note the interface shall remain powered in order to receive the turn-on, or wake-up, command.
Ah, thanks. I was only looking at the DCS spec.
Quoted 59 lines
Regards,
Uma ShankarQuoted 55 lines
Quoted 38 lines
For DSI, there have been issues with different panels requiring some unconventional changes, and also bspec sometimes doesn't cover everything generically. So, it gets a bit challenging :(
Regards,
Uma ShankarQuoted 30 lines
Quoted 30 lines
Quoted 30 lines
Quoted 30 lines
Quoted 30 lines
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102404
Signed-off-by Mika Kahola <[email protected]>---
drivers/gpu/drm/i915/intel_dsi.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dsi.c +1
-1@@ -916,7 +916,7 @@ static void intel_dsi_disable(structintel_encoder *encoder, * MIPI_SEQ_DISPLAY_OFF only for v3+ VBTs, but field testing * has shown that the v3 sequence works for v2 VBTs too */ -if (is_vid_mode (intel_dsi)) { + if (is_vid_mode(intel_dsi) && dev_priv-Quoted 2 lines
vbt.dsi.seq_version > 3) {
/* Send Shutdown command to the panel in LP mode */
for_each_dsi_port(port, intel_dsi->ports)dpi_send_cmd(intel_dsi, SHUTDOWN, false,port);
Quoted 12 lines
Quoted 11 lines
Quoted 9 lines
Quoted 9 lines
Quoted 7 lines
Quoted 7 lines
--
2.7.4_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx--
Mika Kahola - Intel OTC--
Mika Kahola - Intel OTC--
Ville Syrjälä
Intel OTC
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/2 drm/i915/dsi: Replace MIPI command error message with debug message
In reply to Mika KaholaError message indicating that the same MIPI command is sent consecutively is perhaps too strongly said. Let's replace that as a debug message instead.
--- drivers/gpu/drm/i915/intel_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dsi.c +1 -1
@@ -263,7 +263,7 @@ static int dpi_send_cmd(struct intel_dsi *intel_dsi, u32 cmd, bool hs,/* XXX: old code skips write if control unchanged */ if (cmd ==I915_READ (MIPI_DPI_CONTROL (port))) -DRM_ERROR ("Same special packet %02x twice in a row.\n" , cmd); +DRM_DEBUG_KMS ("Same special packet %02x twice in a row.\n" , cmd);I915_WRITE (MIPI_DPI_CONTROL (port), cmd);
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 2/2] drm/i915/dsi: Replace MIPI command error message with debug message
Quoted 4 lines · Mika Kahola
Error message indicating that the same MIPI command is sent consecutively is perhaps too strongly said. Let's replace that as a debug message instead.
Signed-off-by Mika Kahola <[email protected]>
Pushed to dinq, thanks for the patch.
BR,
Jani.
Quoted 16 lines
--- drivers/gpu/drm/i915/intel_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dsi.c +1
-1@@ -263,7 +263,7 @@ static int dpi_send_cmd(struct intel_dsi *intel_dsi, u32 cmd, bool hs,/* XXX: old code skips write if control unchanged */ if (cmd ==I915_READ (MIPI_DPI_CONTROL (port))) -DRM_ERROR ("Same special packet %02x twice in a row.\n" , cmd); +DRM_DEBUG_KMS ("Same special packet %02x twice in a row.\n" , cmd);I915_WRITE (MIPI_DPI_CONTROL (port), cmd);
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/dsi: Fix error on DSI video mode command
In reply to Mika Kahola== Series Details ==
== Series Details ==
Series: drm/i915/dsi: Fix error on DSI video mode command
URL : https://patchwork.freedesktop.org/series/29658/
State : success
== Summary ==
Series 29658v1 drm/i915/dsi: Fix error on DSI video mode command
https://patchwork.freedesktop.org/api/1.0/series/29658/revisions/1/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
pass -> FAIL (fi-snb-2600) fdo#100007
Test kms_cursor_legacy:
Subgroup basic-flip-after-cursor-varying-size:
fail -> PASS (fi-hsw-4770) fdo#102402 +1fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#102402 https://bugs.freedesktop.org/show_bug.cgi?id=102402
fi-bdw-5557u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:458s fi-bdw-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:439s fi-blb-e6850 total:288 pass:224 dwarn:1 dfail:0 fail:0 skip:63 time:359s fi-bsw-n3050 total:288 pass:243 dwarn:0 dfail:0 fail:0 skip:45 time:567s fi-bwr-2160 total:288 pass:184 dwarn:0 dfail:0 fail:0 skip:104 time:254s fi-bxt-j4205 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:523s fi-byt-j1900 total:288 pass:254 dwarn:1 dfail:0 fail:0 skip:33 time:521s fi-byt-n2820 total:288 pass:250 dwarn:1 dfail:0 fail:0 skip:37 time:516s fi-elk-e7500 total:288 pass:230 dwarn:0 dfail:0 fail:0 skip:58 time:431s fi-glk-2a total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:611s fi-hsw-4770 total:288 pass:263 dwarn:0 dfail:0 fail:0 skip:25 time:444s fi-hsw-4770r total:288 pass:263 dwarn:0 dfail:0 fail:0 skip:25 time:426s fi-ilk-650 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:422s fi-ivb-3520m total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:500s fi-ivb-3770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:476s fi-kbl-7500u total:288 pass:264 dwarn:1 dfail:0 fail:0 skip:23 time:520s fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:594s fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:598s fi-pnv-d510 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:526s fi-skl-6260u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:469s fi-skl-6700k total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:533s fi-skl-6770hq total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:488s fi-skl-gvtdvm total:288 pass:266 dwarn:0 dfail:0 fail:0 skip:22 time:448s fi-skl-x1585l total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:490s fi-snb-2520m total:288 pass:251 dwarn:0 dfail:0 fail:0 skip:37 time:549s fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:2 skip:38 time:413s
ccf4ca2d93383fe1a234aba83df9c21400216433 drm-tip: 2017y-08m-31d-18h-37m-46s UTC integration manifest e48cf2f7195f drm/i915/dsi: Replace MIPI command error message with debug message 3119370c4963 drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5558/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: warning for drm/i915/dsi: Fix error on DSI video mode command
In reply to Mika Kahola== Series Details ==
== Series Details ==
Series: drm/i915/dsi: Fix error on DSI video mode command
URL : https://patchwork.freedesktop.org/series/29658/
State : warning
== Summary ==
Test kms_universal_plane:
Subgroup disable-primary-vs-flip-pipe-C:
pass -> SKIP (shard-hsw)shard-hsw total:2265 pass:1231 dwarn:0 dfail:0 fail:17 skip:1017 time:9630s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5558/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/dsi: Fix error on DSI video mode command (rev2)
In reply to Mika Kahola== Series Details ==
== Series Details ==
Series: drm/i915/dsi: Fix error on DSI video mode command (rev2)
URL : https://patchwork.freedesktop.org/series/29658/
State : success
== Summary ==
Series 29658v2 drm/i915/dsi: Fix error on DSI video mode command
https://patchwork.freedesktop.org/api/1.0/series/29658/revisions/2/mbox/
Test kms_cursor_legacy:
Subgroup basic-flip-after-cursor-varying-size:
pass -> FAIL (fi-hsw-4770) fdo#102402 +1fdo#102402 https://bugs.freedesktop.org/show_bug.cgi?id=102402
fi-bdw-5557u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:457s fi-bdw-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:442s fi-blb-e6850 total:288 pass:224 dwarn:1 dfail:0 fail:0 skip:63 time:368s fi-bsw-n3050 total:288 pass:243 dwarn:0 dfail:0 fail:0 skip:45 time:564s fi-bwr-2160 total:288 pass:184 dwarn:0 dfail:0 fail:0 skip:104 time:254s fi-bxt-j4205 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:519s fi-byt-j1900 total:288 pass:254 dwarn:1 dfail:0 fail:0 skip:33 time:522s fi-byt-n2820 total:288 pass:250 dwarn:1 dfail:0 fail:0 skip:37 time:511s fi-cfl-s total:288 pass:250 dwarn:4 dfail:0 fail:0 skip:34 time:460s fi-elk-e7500 total:288 pass:230 dwarn:0 dfail:0 fail:0 skip:58 time:438s fi-glk-2a total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:617s fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:2 skip:25 time:459s fi-hsw-4770r total:288 pass:263 dwarn:0 dfail:0 fail:0 skip:25 time:425s fi-ilk-650 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:421s fi-ivb-3520m total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:503s fi-ivb-3770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:474s fi-kbl-7500u total:288 pass:264 dwarn:1 dfail:0 fail:0 skip:23 time:509s fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:595s fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:598s fi-pnv-d510 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:524s fi-skl-6260u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:468s fi-skl-6700k total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:534s fi-skl-6770hq total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:516s fi-skl-gvtdvm total:288 pass:266 dwarn:0 dfail:0 fail:0 skip:22 time:442s fi-skl-x1585l total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:489s fi-snb-2520m total:288 pass:251 dwarn:0 dfail:0 fail:0 skip:37 time:546s fi-snb-2600 total:288 pass:249 dwarn:0 dfail:0 fail:1 skip:38 time:402s
9dd459ef87a90495aac4cee73831f4cd694048ca drm-tip: 2017y-09m-04d-19h-10m-24s UTC integration manifest 8c3226fa5a71 drm/i915/dsi: Replace MIPI command error message with debug message 05d0ec5d45a3 Revert "drm/i915/bxt: Disable device ready before shutdown command"
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5579/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: failure for drm/i915/dsi: Fix error on DSI video mode command (rev2)
In reply to Mika Kahola== Series Details ==
== Series Details ==
Series: drm/i915/dsi: Fix error on DSI video mode command (rev2)
URL : https://patchwork.freedesktop.org/series/29658/
State : failure
== Summary ==
Test tools_test:
Subgroup tools_test:
pass -> DMESG-WARN (shard-hsw) fdo#102543
Test perf:
Subgroup blocking:
fail -> PASS (shard-hsw) fdo#102252 +1
Test gem_sync:
Subgroup basic-many-each:
pass -> FAIL (shard-hsw)
Test kms_setmode:
Subgroup basic:
fail -> PASS (shard-hsw) fdo#99912fdo#102543 https://bugs.freedesktop.org/show_bug.cgi?id=102543
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
shard-hsw total:2265 pass:1232 dwarn:1 dfail:0 fail:16 skip:1016 time:9659s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5579/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx