tests/tools_test: check if l3_parity is supported
PATCH 1/1 tests/tools_test: check if l3_parity is supported
This is a wrapper for tools/intel_l3_parity which fails if l3_parity is not supported in the kernel. Check support before executing test.
bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101650
--- tests/tools_test.c | 4 ++++ 1 file changed, 4 insertions(+)
tests/tools_test.c +4 -0
@@ -85,6 +85,10 @@ igt_main igt_subtest("sysfs_l3_parity") {int exec_return; +/* Check if we support l3_parity in the first place */ +igt_skip_on_f (igt_system_quiet ("../tools/intel_l3_parity" ) != +IGT_EXIT_SUCCESS , +"intel_l3_parity not supported\n" );igt_system_cmd (exec_return, "../tools/intel_l3_parity -r 0 -b 0 "
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 14 lines · Abdiel Janulgue
This is a wrapper for
tools/intel_l3_paritywhich fails ifl3_parityis not supported in the kernel. Check support before executing test.bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101650
Signed-off-by Abdiel Janulgue <[email protected]>--- tests/tools_test.c | 4 ++++ 1 file changed, 4 insertions(+)tests/tools_test.c +0
-0
tests/tools_test.c igt_main · line 91
Quoted 7 lines
tests/tools_test.c +4
-0@@ -85,6 +85,10 @@ igt_main igt_subtest("sysfs_l3_parity") {int exec_return; +/* Check if we support l3_parity in the first place */ +igt_skip_on_f (igt_system_quiet ("../tools/intel_l3_parity" ) != +IGT_EXIT_SUCCESS , +"intel_l3_parity not supported\n" );
That's not how the tool works. If you give it no parameters, it will call abort() on all platforms because it wants an action on the command line.
Skipping should only be done if the tool exits with 77 when given correct parameters.
--
Petri Latvala
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for tests/tools_test: check if l3_parity is supported
In reply to Abdiel Janulgue== Series Details ==
== Series Details ==
Series: tests/tools_test: check if l3_parity is supported
URL : https://patchwork.freedesktop.org/series/29817/
State : success
== Summary ==
IGT patchset tested on top of latest successful build 918863f8e3e8f49235fd2e4a36e11f386c06c11c intel_display_poller: Fix truncation of a test name.
with latest DRM-Tip kernel build CI_DRM_3039229aae71d40f drm-tip: 2017y-09m-05d-11h-05m-56s UTC integration manifest
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-atomic:
pass -> FAIL (fi-snb-2600) fdo#100215fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:461s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:448s fi-blb-e6850 total:289 pass:224 dwarn:1 dfail:0 fail:0 skip:64 time:365s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:555s fi-bwr-2160 total:289 pass:184 dwarn:0 dfail:0 fail:0 skip:105 time:256s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:522s fi-byt-j1900 total:289 pass:254 dwarn:1 dfail:0 fail:0 skip:34 time:528s fi-byt-n2820 total:289 pass:250 dwarn:1 dfail:0 fail:0 skip:38 time:524s fi-elk-e7500 total:289 pass:230 dwarn:0 dfail:0 fail:0 skip:59 time:442s fi-glk-2a total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:614s fi-hsw-4770 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:451s fi-hsw-4770r total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:426s fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:430s fi-ivb-3520m total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:501s fi-ivb-3770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:476s fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:513s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:604s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:604s fi-pnv-d510 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:527s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:476s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:544s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:517s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:450s fi-skl-x1585l total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:516s fi-snb-2520m total:289 pass:251 dwarn:0 dfail:0 fail:0 skip:38 time:569s fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:1 skip:39 time:411s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_144/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx