binder: fix an ret value override

PATCH New Todd Kjos 1 participant 1 message Sep 5, 2017 Android drivers

lore

Share & tools

lore

Todd Kjos

author maintainer

2017-09-05 17:25 UTC #0 lore raw

PATCH 1/1 binder: fix an ret value override

From: Xu YiPing <[email protected]>

commit 372e3147df70 ("binder: guarantee txn complete / errors delivered in-order") incorrectly defined a local ret value. This ret value will be invalid when out of the if block

Signed-off-by Xu YiPing <[email protected]>

Signed-off-by Todd Kjos <[email protected]>

---
 drivers/android/binder.c | 1 -
 1 file changed, 1 deletion(-)

drivers/android/binder.c +0 -1

index 96cc28afa383..7ef9e7f05e17 100644
@@ -2326,7 +2326,6 @@ static int binder_translate_handle(struct flat_binder_object *fp,
 			     (u64)node->ptr);
 		binder_node_unlock(node);
 	} else {
-		int ret;
 		struct binder_ref_data dest_rdata;
 
 		binder_node_unlock(node);

Signature · 1 line

2.14.1.581.gf28d330327-goog