grub2 wchar defconfig fixes

Since a version bump of grub2 (5ffafd2353f5d67) it requires a toolchain with wide character support. Some defconfigs have lines to build grub2 (BR_TARGET_GRUB2=y) but this doesn't always take place, depending on whether BR2_USE_WCHAR is set. Because of this, some defconfigs will fail to successfully build images.

This v2 cuts out some unnecessary changes from v1 (ie: comments in configs to explicitly note this dependency without any other change) and splits up the remaining changes into individual patches. I did not test the minnowboard change, but the galileo change is tested.

Nicholas Sielicki (2):
configs/galileo: grub2 needs wchar toolchain configs/minnowboard_max-graphical: wchar/grub2 fix

 configs/galileo_defconfig                   | 2 ++
 configs/minnowboard_max-graphical_defconfig | 2 ++
 2 files changed, 4 insertions(+)

2.14.1

The galileo_defconfig has the line "BR_TARGET_GRUB2=y", but this currently has no effect because BR_TARGET_GRUB2 cannot be selected without BR2_TOOLCHAIN_BUILDROOT_WCHAR=y, which is not set by default.

---
 configs/galileo_defconfig | 2 ++
 1 file changed, 2 insertions(+)

index 43639a41a..39622e331 100644
@@ -1,4 +1,6 @@
 BR2_x86_x1000=y
+# Needed for TARGET_GRUB2
+BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
 # Linux headers same as kernel, a 3.14 series
 BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_14=y
 BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y

2.14.1

Hello,

Both applied. Thanks!

Thomas

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Committed to 2017.08.x, thanks.

Bye, Peter Korsgaard

minnowboard_max-graphical_defconfig has the line "BR_TARGET_GRUB2=y", but this currently has no effect because BR_TARGET_GRUB2 cannot be selected without BR2_TOOLCHAIN_BUILDROOT_WCHAR=y, which is not set by default.

The minnowboard max defconfig was updated to fix this problem, but the graphical variant was not updated alongside it.

---
 configs/minnowboard_max-graphical_defconfig | 2 ++
 1 file changed, 2 insertions(+)

index ef0947cb7..2c11fb378 100644
@@ -6,6 +6,8 @@ BR2_x86_atom=y
 BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_12=y
 BR2_TOOLCHAIN_BUILDROOT_LOCALE=y
 BR2_TOOLCHAIN_BUILDROOT_CXX=y
+# needed for TARGET_GRUB2
+BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
 
 # System configuration
 BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y

2.14.1

Committed to 2017.08.x, thanks.

Bye, Peter Korsgaard