net: sched: fix memleak for chain zero
Subsystems (3)
Jiri Pirko
maintainerPATCH 1/1 net: sched: fix memleak for chain zero
From: Jiri Pirko <[email protected]>
There's a memleak happening for chain 0. The thing is, chain 0 needs to be always present, not created on demand. Therefore tcf_block_get upon creation of block calls the tcf_chain_create function directly. The chain is created with refcnt == 1, which is not correct in this case and causes the memleak. So move the refcnt increment into tcf_chain_get function even for the case when chain needs to be created.
--- net/sched/cls_api.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
net/sched/cls_api.c +9 -9
@@ -197,7 +197,7 @@ static struct tcf_chain *tcf_chain_create(struct tcf_block *block,list_add_tail (&chain->list, &block->chain_list); chain->block = block; chain->index = chain_index; - chain->refcnt =1 ; + chain->refcnt =0 ;return chain; }
@@ -232,15 +232,15 @@ struct tcf_chain *tcf_chain_get(struct tcf_block *block, u32 chain_index,struct tcf_chain *chain;list_for_each_entry (chain, &block->chain_list, list) { -if (chain->index == chain_index) { - chain->refcnt++; -return chain; - } +if (chain->index == chain_index) + goto incref; } -if (create) -return tcf_chain_create (block, chain_index); -else -return NULL ; + chain = create ?tcf_chain_create (block, chain_index) :NULL ; + +incref: +if (chain) + chain->refcnt++; +return chain; }EXPORT_SYMBOL (tcf_chain_get);
Signature · 1 line
2.9.3
Quoted 9 lines · Jiri Pirko
From: Jiri Pirko <[email protected]>
There's a memleak happening for chain 0. The thing is, chain 0 needs to be always present, not created on demand. Therefore
tcf_block_getupon creation of block calls thetcf_chain_createfunction directly. The chain is created with refcnt == 1, which is not correct in this case and causes the memleak. So move the refcnt increment intotcf_chain_getfunction even for the case when chain needs to be created.
Quoted 3 lines
Reported-by Jakub Kicinski <[email protected]>Fixes 5bc1701881e3 ("net: sched: introduce multichain support for filters")Signed-off-by Jiri Pirko <[email protected]>
Quoted 9 lines · Jiri Pirko
From: Jiri Pirko <[email protected]>
There's a memleak happening for chain 0. The thing is, chain 0 needs to be always present, not created on demand. Therefore
tcf_block_getupon creation of block calls thetcf_chain_createfunction directly. The chain is created with refcnt == 1, which is not correct in this case and causes the memleak. So move the refcnt increment intotcf_chain_getfunction even for the case when chain needs to be created.
Your approach could work but you just make the code even uglier than it is now:
1. The current code is already ugly for special-casing chain 0:
if (--chain->refcnt == 0 && !chain->filter_chain && chain->index != 0)
tcf_chain_destroy(chain);2. With your patch, chain 0 has a different _initial_ refcnt with others.
3. Allowing an object (chain 0) exists with refcnt==0
Compare it with my patch:
1. No special-case for chain 0, the above ugly part is removed
2. Every chain is equal and created with refcnt==1
3. Any chain with refcnt==0 is destroyed
Jiri Pirko
maintainerQuoted 14 lines · Wed, Sep 06, 2017 at 07:40:02PM CEST, [email protected] wrote:
Quoted 9 lines · Jiri Pirko
From: Jiri Pirko <[email protected]>
There's a memleak happening for chain 0. The thing is, chain 0 needs to be always present, not created on demand. Therefore
tcf_block_getupon creation of block calls thetcf_chain_createfunction directly. The chain is created with refcnt == 1, which is not correct in this case and causes the memleak. So move the refcnt increment intotcf_chain_getfunction even for the case when chain needs to be created.Your approach could work but you just make the code even uglier than it is now:
Quoted 6 lines
1. The current code is already ugly for special-casing chain 0:
if (--chain->refcnt == 0 && !chain->filter_chain && chain->index != 0) tcf_chain_destroy(chain);2. With your patch, chain 0 has a different _initial_ refcnt with others.
No. Initial refcnt is the same. ! for every action that holds the chain. So actually, it returns it back where it should be.
Quoted 2 lines
3. Allowing an object (chain 0) exists with refcnt==0
So? That is for every chain that does not have goto_chain action pointing at. Please read the code.
Quoted 8 lines
Compare it with my patch:
1. No special-case for chain 0, the above ugly part is removed
2. Every chain is equal and created with refcnt==1
3. Any chain with refcnt==0 is destroyed
Quoted 17 lines · Jiri Pirko
Quoted 16 lines · Wed, Sep 06, 2017 at 07:40:02PM CEST, [email protected] wrote:
Quoted 9 lines · Jiri Pirko
From: Jiri Pirko <[email protected]>
There's a memleak happening for chain 0. The thing is, chain 0 needs to be always present, not created on demand. Therefore
tcf_block_getupon creation of block calls thetcf_chain_createfunction directly. The chain is created with refcnt == 1, which is not correct in this case and causes the memleak. So move the refcnt increment intotcf_chain_getfunction even for the case when chain needs to be created.Your approach could work but you just make the code even uglier than it is now:
1. The current code is already ugly for special-casing chain 0:
Quoted 7 lines
Quoted 4 lines
if (--chain->refcnt == 0 && !chain->filter_chain && chain->index != 0) tcf_chain_destroy(chain);2. With your patch, chain 0 has a different _initial_ refcnt with others.
No. Initial refcnt is the same. ! for every action that holds the chain. So actually, it returns it back where it should be.
Not all all.
tcf_block_get() calls tcf_chain_create(, 0), after your patch chain 0 has refcnt==0 initially.
Non-0 chain? They are created via tcf_chain_get(), aka, refcnt==0 initially.
Quoted 7 lines
Quoted 4 lines
3. Allowing an object (chain 0) exists with refcnt==0
So? That is for every chain that does not have
goto_chainaction pointing at. Please read the code.
So you are pretending to be GC but you are apparently not.
You create all the troubles by setting yourself to believe chain 0 is special and refcnt==0 is okay. Both are wrong.
Actually the !list_empty() check is totally unnecessary too, it is yet another place you get it wrong, you hide the race condition in commit 744a4cf63e52 which makes it harder to expose.
I understand you don't trust me. Look at DaveM's reaction to your refcnt==0 madness.
Remember, refcnt can be very simple, you just want to make it harder by abusing it or attempting to invent a GC.
I am going to update my patch (to remove all your madness) since this is horribly wrong to me. Sorry.
Jiri Pirko
maintainerQuoted 26 lines · Thu, Sep 07, 2017 at 01:37:59AM CEST, [email protected] wrote:
Quoted 17 lines · Jiri Pirko
Quoted 16 lines · Wed, Sep 06, 2017 at 07:40:02PM CEST, [email protected] wrote:
Quoted 9 lines · Jiri Pirko
From: Jiri Pirko <[email protected]>
There's a memleak happening for chain 0. The thing is, chain 0 needs to be always present, not created on demand. Therefore
tcf_block_getupon creation of block calls thetcf_chain_createfunction directly. The chain is created with refcnt == 1, which is not correct in this case and causes the memleak. So move the refcnt increment intotcf_chain_getfunction even for the case when chain needs to be created.Your approach could work but you just make the code even uglier than it is now:
1. The current code is already ugly for special-casing chain 0:
Quoted 7 lines
Quoted 4 lines
if (--chain->refcnt == 0 && !chain->filter_chain && chain->index != 0) tcf_chain_destroy(chain);2. With your patch, chain 0 has a different _initial_ refcnt with others.
No. Initial refcnt is the same. ! for every action that holds the chain. So actually, it returns it back where it should be.
Quoted 7 lines
Not all all.
tcf_block_get()callstcf_chain_create(, 0), after your patch chain 0 has refcnt==0 initially.Non-0 chain? They are created via
tcf_chain_get(), aka, refcnt==0 initially.
And if they are created on insertion of the filter, put is caller right away which returns the ref back to 0. As I said, Non-0 refcnt means either rule is being inserted/removed of there is an action that holds reference to this chain. So my patch actually fixes the behaviour making chain 0 and other chains to behave the same.
Quoted 20 lines
Quoted 9 lines
Quoted 6 lines
3. Allowing an object (chain 0) exists with refcnt==0
So? That is for every chain that does not have
goto_chainaction pointing at. Please read the code.So you are pretending to be GC but you are apparently not.
You create all the troubles by setting yourself to believe chain 0 is special and refcnt==0 is okay. Both are wrong.
Actually the !list_empty() check is totally unnecessary too, it is yet another place you get it wrong, you hide the race condition in commit
744a4cf63e52which makes it harder to expose.
Quoted 8 lines
I understand you don't trust me. Look at DaveM's reaction to your refcnt==0 madness.
Remember, refcnt can be very simple, you just want to make it harder by abusing it or attempting to invent a GC.
I am going to update my patch (to remove all your madness) since this is horribly wrong to me. Sorry.
It is not so easy to use the refcnt also for filters, I had good reason to relend on filter_chain list to find out if there is a rule. If you figure out how to do it better, be my guest. I suggest you do that for net-next and let's fix the net in the easiest way possible.
David Miller
maintainerFrom: Jiri Pirko <[email protected]>
Date: Wed, 6 Sep 2017 13:14:19 +0200
Quoted 9 lines
From: Jiri Pirko <[email protected]>
There's a memleak happening for chain 0. The thing is, chain 0 needs to be always present, not created on demand. Therefore
tcf_block_getupon creation of block calls thetcf_chain_createfunction directly. The chain is created with refcnt == 1, which is not correct in this case and causes the memleak. So move the refcnt increment intotcf_chain_getfunction even for the case when chain needs to be created.
Quoted 3 lines
Reported-by Jakub Kicinski <[email protected]>Fixes 5bc1701881e3 ("net: sched: introduce multichain support for filters")Signed-off-by Jiri Pirko <[email protected]>
This doesn't apply cleanly any more, please respin.
Thanks Jiri.
Quoted 3 lines · David Miller
This doesn't apply cleanly any more, please respin.
Sigh, you applied this patch despite of strong objections from me.
I seriously doubt your tastes now, David. Fine, this code does not deserve a good taste at all, let bugs stay there.
Good luck!
Jiri Pirko
maintainerQuoted 9 lines · Sat, Sep 09, 2017 at 08:46:42PM CEST, [email protected] wrote:
Quoted 3 lines · David Miller
This doesn't apply cleanly any more, please respin.
Sigh, you applied this patch despite of strong objections from me.
I seriously doubt your tastes now, David. Fine, this code does not deserve a good taste at all, let bugs stay there.
Actually, the reported bug is resolved by this patch. I like your approach Cong, we can make it work and follow-up on this patch. Please stay calm and be patient...
Quoted 6 lines · Jiri Pirko
Quoted 5 lines · Sat, Sep 09, 2017 at 08:46:42PM CEST, [email protected] wrote:
Quoted 3 lines · David Miller
This doesn't apply cleanly any more, please respin.
Quoted 8 lines
Quoted 4 lines
Sigh, you applied this patch despite of strong objections from me.
I seriously doubt your tastes now, David. Fine, this code does not deserve a good taste at all, let bugs stay there.
Actually, the reported bug is resolved by this patch. I like your approach Cong, we can make it work and follow-up on this patch. Please stay calm and be patient...
OK. I already rebased my patches and sent v3.