Skip to contentSkip to conversation

lib6/in6_01.c: Remove IPv6 addresses which do not comply RFC 2373

PATCH Superseded Petr Vorel 3 participants 3 messages Aug 31, 2017 – Sep 7, 2017

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

PATCH 1/1 lib6/in6_01.c: Remove IPv6 addresses which do not comply RFC 2373

glibc 2.26 starts rejecting IPv6 addresses which do not comply RFC 2373.

commit 9a0cc8c1bd7645bf3c988890ffb59639c07a5812

Author: Florian Weimer <[email protected]>
Date:   Fri Jun 23 22:51:00 2017 +0200

inet_pton: Reject IPv6 addresses with many leading zeros [BZ #16637]

2001:db8:00001::f is not a valid IPv6 address according to RFC 2373.

See also:
https://sourceware.org/bugzilla/show_bug.cgi?id=16637

---
 testcases/network/lib6/in6_01.c | 2 --
 1 file changed, 2 deletions(-)
testcases/network/lib6/in6_01.c +0 -2
index f7186b480..3a96ed17d 100644
@@ -40,8 +40,6 @@ static struct {
 	{ "::ffff:10.0.0.1", 1 },
 	{ "::fffe:10.0.0.1", 0 },
 	{ "::7fff:10.0.0.1", 0 },
-	{ "0:0:0:0:0:0:ffff:0a001", 0 },
-	{ "0:0:1:0:0:0:ffff:0a001", 0 },
 };
 
 #define MAPSIZE (sizeof(maptab)/sizeof(maptab[0]))
Signature · 1 line
2.14.0
#1 lore raw

PATCH 1/1 lib6/in6_01.c: Remove IPv6 addresses which do not comply RFC 2373

Hi!

Quoted 23 lines

glibc 2.26 starts rejecting IPv6 addresses which do not comply RFC 2373.

commit 9a0cc8c1bd7645bf3c988890ffb59639c07a5812

Author: Florian Weimer <[email protected]>
Date:   Fri Jun 23 22:51:00 2017 +0200

inet_pton: Reject IPv6 addresses with many leading zeros [BZ #16637]

2001:db8:00001::f is not a valid IPv6 address according to RFC 2373.

See also:
https://sourceware.org/bugzilla/show_bug.cgi?id=16637

---
 testcases/network/lib6/in6_01.c | 2 --
 1 file changed, 2 deletions(-)
testcases/network/lib6/in6_01.c +0 -0
index f7186b480..3a96ed17d 100644

testcases/network/lib6/in6_01.c static struct { · line 44

Quoted 5 lines
testcases/network/lib6/in6_01.c +0 -2
@@ -40,8 +40,6 @@ static struct {
 	{ "::ffff:10.0.0.1", 1 },
 	{ "::fffe:10.0.0.1", 0 },
 	{ "::7fff:10.0.0.1", 0 },
-	{ "0:0:0:0:0:0:ffff:0a001", 0 },
-	{ "0:0:1:0:0:0:ffff:0a001", 0 },

^
Shouldn't we just delete this leading zeroes from the last two lines and be donw with it?

Or do you think that cases covered by this addresses without the leading zeroes are already covered by the rest of the addresses in the structure?

Signature · 2 lines
Cyril Hrubis
[email protected]
#2 lore raw

PATCH 1/1 lib6/in6_01.c: Remove IPv6 addresses which do not comply RFC 2373

Hi,

Quoted 19 lines · Cyril Hrubis

Hi!

Quoted 18 lines

glibc 2.26 starts rejecting IPv6 addresses which do not comply RFC 2373.

commit 9a0cc8c1bd7645bf3c988890ffb59639c07a5812

Author: Florian Weimer <[email protected]>
Date:   Fri Jun 23 22:51:00 2017 +0200

inet_pton: Reject IPv6 addresses with many leading zeros [BZ #16637]

2001:db8:00001::f is not a valid IPv6 address according to RFC 2373.

See also:
https://sourceware.org/bugzilla/show_bug.cgi?id=16637

---
 testcases/network/lib6/in6_01.c | 2 --
 1 file changed, 2 deletions(-)
Quoted 13 lines

testcases/network/lib6/in6_01.c static struct { · line 44

Quoted 10 lines
testcases/network/lib6/in6_01.c +0 -2
index f7186b480..3a96ed17d 100644
@@ -40,8 +40,6 @@ static struct {
 	{ "::ffff:10.0.0.1", 1 },
 	{ "::fffe:10.0.0.1", 0 },
 	{ "::7fff:10.0.0.1", 0 },
-	{ "0:0:0:0:0:0:ffff:0a001", 0 },
-	{ "0:0:1:0:0:0:ffff:0a001", 0 },

^
Shouldn't we just delete this leading zeroes from the last two lines and be donw with it?

Agree, we should change the last segments to 'a001' and keep these test-cases.

Best regards,
Alexey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20170907/420f1fa5/attachment.html>