Staging: ccree: ssi_cipher.c: Correct spelling mistake.

PATCH In review Srishti Sharma 3 participants 8 messages Sep 6, 2017

Subsystems (2)

Staging Crypto API

lore

Share & tools

lore

Julia Lawall

2017-09-06 19:42 UTC #1 lore raw

Quoted 1 line · Srishti Sharma

Correct spelling of counter in comment .

Welcome, and congratulations on submitting the first patch for this round :)

Quoted 10 lines

Signed-off-by Srishti Sharma <[email protected]>
---
 drivers/staging/ccree/ssi_cipher.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ccree/ssi_cipher.c +0 -0
index 8d31a93..99232b2 100644

drivers/staging/ccree/ssi_cipher.c static int ssi_blkcipher_complete(struct device *dev, · line 705

Quoted 5 lines

drivers/staging/ccree/ssi_cipher.c +1 -1

@@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev,
 
 	ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
 
-	/*Set the inflight couter value to local variable*/
+	/*Set the inflight counter value to local variable*/

The change in itself looks fine, but actually the comment is kind of incomprehensible. It could be better as "Store ... in a local variable". Also, the comment doesn't follow the kernel style. Look at other comments in this file or comments in other files to see what is wrong.

julia

Quoted 13 lines

drivers/staging/ccree/ssi_cipher.c +0 -1
 	inflight_counter =  ctx_p->drvdata->inflight_counter;
 	/*Decrease the inflight counter*/
 	if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
--
2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504725863-8495-1-git-send-email-srishtishar%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Srishti Sharma

author

2017-09-06 19:48 UTC #2 lore raw

In reply to Srishti Sharma

Quoted 23 lines · Srishti Sharma

Correct spelling of counter in comment .

Signed-off-by Srishti Sharma <[email protected]>

---

 drivers/staging/ccree/ssi_cipher.c | 2 +- 
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/ccree/ssi_cipher.c +1 -1

index 8d31a93..99232b2 100644 
@@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev, 
 
         ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, 
 dst); 
 
-        /*Set the inflight couter value to local variable*/ 
+        /*Set the inflight counter value to local variable*/ 
         inflight_counter =  ctx_p->drvdata->inflight_counter; 
         /*Decrease the inflight counter*/

         if (ctx_p->flow_mode == BYPASS &&

Quoted 4 lines

ctx_p->drvdata->inflight_counter > 0)
Signature · 1 line
2.7.4 

Thanks for the feedback :) , I'll work on it !

Regards,
Srishti

Srishti Sharma

author

2017-09-06 20:34 UTC #3 lore raw

In reply to Srishti Sharma

Quoted 23 lines · Srishti Sharma

Correct spelling of counter in comment .

Signed-off-by Srishti Sharma <[email protected]>

---

 drivers/staging/ccree/ssi_cipher.c | 2 +- 
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/ccree/ssi_cipher.c +1 -1

index 8d31a93..99232b2 100644 
@@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev, 
 
         ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, 
 dst); 
 
-        /*Set the inflight couter value to local variable*/ 
+        /*Set the inflight counter value to local variable*/ 
         inflight_counter =  ctx_p->drvdata->inflight_counter; 
         /*Decrease the inflight counter*/

         if (ctx_p->flow_mode == BYPASS &&

Quoted 4 lines

ctx_p->drvdata->inflight_counter > 0)
Signature · 1 line
2.7.4 

Hey,

Can I say , /* store the value of inflight_counter variable from driver
private data context to a local variable */ , to make it more comprehensible ?

Regards,
Srishti

Julia Lawall

2017-09-06 20:39 UTC #4 lore raw

Quoted 32 lines · Srishti Sharma

On Thursday, September 7, 2017 at 12:54:49 AM UTC+5:30, Srishti Sharma wrote:

      Correct spelling of counter in comment .

      Signed-off-by: Srishti Sharma <[email protected]>
      ---
       drivers/staging/ccree/ssi_cipher.c | 2 +-
       1 file changed, 1 insertion(+), 1 deletion(-)

      diff --git a/drivers/staging/ccree/ssi_cipher.c
      b/drivers/staging/ccree/ssi_cipher.c
      index 8d31a93..99232b2 100644
      --- a/drivers/staging/ccree/ssi_cipher.c
      +++ b/drivers/staging/ccree/ssi_cipher.c
      @@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct
      device *dev,

               ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx,
      ivsize, src, dst);

      -        /*Set the inflight couter value to local variable*/
      +        /*Set the inflight counter value to local variable*/
               inflight_counter =  ctx_p->drvdata->inflight_counter;
               /*Decrease the inflight counter*/
               if (ctx_p->flow_mode == BYPASS &&
      ctx_p->drvdata->inflight_counter > 0)
      --
      2.7.4

Quoted 5 lines

Hey,
Can I say , /* store the value of inflight_counter variable from driver private data context to a local variable */ , to make it more comprehensible ?

I think it could be a bit of overkill. The "driver private data context" part can be seen from a quick glance at the code. Also, it could be good to bring out the purpose rather than just what the code does. So "save inflight_counter in a a local variable" could be better, because it focuses on the idea of saving some information for later use. Good job on figuring out the formatting problem.

julia

Quoted 15 lines

Regards,
Srishti
--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/2b8bde9c-6e84-48c5-ab93- 76127f314429%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Srishti Sharma

author

2017-09-06 20:57 UTC #5 lore raw

In reply to Srishti Sharma

Quoted 23 lines · Srishti Sharma

Correct spelling of counter in comment .

Signed-off-by Srishti Sharma <[email protected]>

---

 drivers/staging/ccree/ssi_cipher.c | 2 +- 
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/ccree/ssi_cipher.c +1 -1

index 8d31a93..99232b2 100644 
@@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev, 
 
         ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, 
 dst); 
 
-        /*Set the inflight couter value to local variable*/ 
+        /*Set the inflight counter value to local variable*/ 
         inflight_counter =  ctx_p->drvdata->inflight_counter; 
         /*Decrease the inflight counter*/

         if (ctx_p->flow_mode == BYPASS &&

Quoted 4 lines

ctx_p->drvdata->inflight_counter > 0)
Signature · 1 line
2.7.4 

Thanks a lot for this , I have re-sent a v2 !

Regards,
Srishti

Dan Carpenter

2017-09-06 20:59 UTC #6 lore raw

In reply to Srishti Sharma

Quoted 12 lines · Srishti Sharma

Correct spelling of counter in comment .
Signed-off-by Srishti Sharma <[email protected]>
---
 drivers/staging/ccree/ssi_cipher.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ccree/ssi_cipher.c +0 -0
index 8d31a93..99232b2 100644

drivers/staging/ccree/ssi_cipher.c static int ssi_blkcipher_complete(struct device *dev, · line 706

Quoted 6 lines

drivers/staging/ccree/ssi_cipher.c +1 -1

@@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev,
 
 	ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
 
-	/*Set the inflight couter value to local variable*/
+	/*Set the inflight counter value to local variable*/
 	inflight_counter =  ctx_p->drvdata->inflight_counter;

Sure, but it would be better to just delete the comment. It's obvious. But really just delete the local inflight_counter variable as well because that's never used.

regards,
dan carpenter

Srishti Sharma

author

2017-09-06 21:02 UTC #7 lore raw

Quoted 16 lines · Dan Carpenter

Quoted 15 lines · Srishti Sharma
Correct spelling of counter in comment .
Signed-off-by Srishti Sharma <[email protected]>
---
 drivers/staging/ccree/ssi_cipher.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ccree/ssi_cipher.c +0 -0
index 8d31a93..99232b2 100644
@@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev,
 
      ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
 

Quoted 7 lines

drivers/staging/ccree/ssi_cipher.c static int ssi_blkcipher_complete(struct device *dev, · line 706
Quoted 3 lines
drivers/staging/ccree/ssi_cipher.c +1 -1
-     /*Set the inflight couter value to local variable*/
+     /*Set the inflight counter value to local variable*/
      inflight_counter =  ctx_p->drvdata->inflight_counter;
Sure, but it would be better to just delete the comment. It's obvious. But really just delete the local inflight_counter variable as well because that's never used.

Okay, I'll delete it .

Quoted 4 lines

regards,
dan carpenter

Regards,
Srishti