Skip to contentSkip to conversation

package/pngquant: fix target build

PATCH New Bernd Kuhls 2 participants 2 messages Sep 6, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/pngquant: fix target build

Pngquant 2.10 introduced a bundled library libimagequant, Makefile passes $LIQCONFIGUREFLAGS to the configure script of libimagequant before building this library:
https://github.com/pornel/pngquant/blob/master/Makefile#L27

This variable is filled by configure with the content of $LIQCONFIGURE
https://github.com/pornel/pngquant/blob/master/configure#L553

We need to pass CC/CFLAGS/LDFLAGS as parameter to configure to fill $LIQCONFIGURE with correct values in order to use the target toolchain for building libimagequant:
https://github.com/pornel/pngquant/blob/master/configure#L56

Fixes
http://autobuild.buildroot.net/results/ab1/ab1193db9d76adc02be44d6f273e0986952df3e2/

---
 package/pngquant/pngquant.mk | 1 +
 1 file changed, 1 insertion(+)
package/pngquant/pngquant.mk +1 -0
index a602cbef5..1ce8359d4 100644
@@ -22,6 +22,7 @@ define PNGQUANT_CONFIGURE_CMDS
 		./configure --prefix=/usr \
 		$(if $(BR2_PACKAGE_LCMS2),--with-lcms2,--without-lcms2) \
 		$(if $(BR2_X86_CPU_HAS_SSE),--enable-sse,--disable-sse) \
+		$(TARGET_CONFIGURE_OPTS) \
 	)
 endef
 
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 package/pngquant: fix target build

Hello,

Quoted 13 lines · Bernd Kuhls

Pngquant 2.10 introduced a bundled library libimagequant, Makefile passes $LIQCONFIGUREFLAGS to the configure script of libimagequant before building this library:
https://github.com/pornel/pngquant/blob/master/Makefile#L27

This variable is filled by configure with the content of $LIQCONFIGURE
https://github.com/pornel/pngquant/blob/master/configure#L553

We need to pass CC/CFLAGS/LDFLAGS as parameter to configure to fill $LIQCONFIGURE with correct values in order to use the target toolchain for building libimagequant:
https://github.com/pornel/pngquant/blob/master/configure#L56

Quoted 7 lines

Fixes
http://autobuild.buildroot.net/results/ab1/ab1193db9d76adc02be44d6f273e0986952df3e2/

---
 package/pngquant/pngquant.mk | 1 +
 1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com