Skip to contentSkip to conversation

nvme: update timeout module parameter type

PATCH New Marc Olson 3 participants 3 messages Sep 7, 2017 – Oct 4, 2017 NVMe

lore
Share & tools
lore

Marc Olson

author
#0 lore raw

PATCH 1/1 nvme: update timeout module parameter type

The underlying blk_mq_tag_set, and request timeout parameters support an unsigned int. Extend the size of the nvme module parameters for io and admin commands to match.

Signed-off-by Marc Olson <marcolso at amazon.com>
---
 drivers/nvme/host/core.c | 8 ++++----
 drivers/nvme/host/nvme.h | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)
drivers/nvme/host/core.c +4 -4
index fbeca06..097f678 100644
@@ -34,13 +34,13 @@
 
 #define NVME_MINORS		(1U << MINORBITS)
 
-unsigned char admin_timeout = 60;
-module_param(admin_timeout, byte, 0644);
+unsigned int admin_timeout = 60;
+module_param(admin_timeout, uint, 0644);
 MODULE_PARM_DESC(admin_timeout, "timeout in seconds for admin commands");
 EXPORT_SYMBOL_GPL(admin_timeout);
 
-unsigned char nvme_io_timeout = 30;
-module_param_named(io_timeout, nvme_io_timeout, byte, 0644);
+unsigned int nvme_io_timeout = 30;
+module_param_named(io_timeout, nvme_io_timeout, uint, 0644);
 MODULE_PARM_DESC(io_timeout, "timeout in seconds for I/O");
 EXPORT_SYMBOL_GPL(nvme_io_timeout);
drivers/nvme/host/nvme.h +2 -2
index 8edafd8..6afabc4 100644
@@ -30,10 +30,10 @@ enum {
 	NVME_SC_CANCELLED		= -EINTR,
 };
 
-extern unsigned char nvme_io_timeout;
+extern unsigned int nvme_io_timeout;
 #define NVME_IO_TIMEOUT	(nvme_io_timeout * HZ)
 
-extern unsigned char admin_timeout;
+extern unsigned int admin_timeout;
 #define ADMIN_TIMEOUT	(admin_timeout * HZ)
 
 extern unsigned char shutdown_timeout;
Signature · 1 line
2.7.4
maintainer
#1 lore raw

PATCH 1/1 nvme: update timeout module parameter type

Looks fine,

Reviewed-by Christoph Hellwig <hch at lst.de>