libmbim: add udev as optional feature
PATCH 1/1 libmbim: add udev as optional feature
udev support will be enabled in the build if libgudev is selected.
--- package/libmbim/Config.in | 7 ++----- package/libmbim/libmbim.mk | 10 +++++++++- 2 files changed, 11 insertions(+), 6 deletions(-)
package/libmbim/Config.in +2 -5
@@ -3,8 +3,6 @@ config BR2_PACKAGE_LIBMBIM depends on BR2_USE_WCHAR # libglib2 depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 depends on BR2_USE_MMU # libglib2 - depends on BR2_PACKAGE_HAS_UDEV - select BR2_PACKAGE_LIBGUDEV select BR2_PACKAGE_LIBGLIB2 help libmbim is a glib-based library for talking to WWAN modems and
@@ -13,7 +11,6 @@ config BR2_PACKAGE_LIBMBIM http://www.freedesktop.org/wiki/Software/libmbim/ -comment "libmbim needs udev /dev management and a toolchain w/ wchar, threads" +comment "libmbim needs a toolchain w/ wchar, threads" depends on BR2_USE_MMU - depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \ - !BR2_PACKAGE_HAS_UDEV + depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
package/libmbim/libmbim.mk +9 -1
@@ -11,9 +11,17 @@ LIBMBIM_LICENSE = LGPL-2.0+ (library), GPL-2.0+ (programs) LIBMBIM_LICENSE_FILES = COPYING LIBMBIM_INSTALL_STAGING = YES -LIBMBIM_DEPENDENCIES = libglib2 udev libgudev +LIBMBIM_DEPENDENCIES = libglib2 # we don't want -Werror LIBMBIM_CONF_OPTS = --enable-more-warnings=no +# if libgudev available, request udev support +ifeq ($(BR2_PACKAGE_LIBGUDEV),y) +LIBMBIM_DEPENDENCIES += libgudev +LIBMBIM_CONF_OPTS += --with-udev +else +LIBMBIM_CONF_OPTS += --without-udev +endif + $(eval $(autotools-package))
Signature · 1 line
2.13.1
Thomas Petazzoni
AppliedPATCH 1/1 libmbim: add udev as optional feature
Hello,
Quoted 3 lines · Aleksander Morgado
udev support will be enabled in the build if libgudev is selected.
Signed-off-by Aleksander Morgado <[email protected]>
Applied to master, thanks! I just realized you're the maintainer for libmbim and libqmi, so it's nice to see you sending patches to Buildroot to improve their packaging!
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 libmbim: add udev as optional feature
Quoted 9 lines · Aleksander Morgado
Quoted 3 lines
udev support will be enabled in the build if libgudev is selected.
Signed-off-by Aleksander Morgado <[email protected]>Applied to master, thanks! I just realized you're the maintainer for libmbim and libqmi, so it's nice to see you sending patches to Buildroot to improve their packaging!
Speaking of which, is there any way I can get CC-ed to changes done in either libqmi, libmbim or modem-manager? I wouldn't mind to review those.
Signature · 2 lines
Aleksander https://aleksander.es
PATCH 1/1 libmbim: add udev as optional feature
Hi Aleksander,
Quoted 5 lines · Aleksander Morgado
Quoted 5 lines · Aleksander Morgado
Quoted 3 lines
udev support will be enabled in the build if libgudev is selected.
Signed-off-by Aleksander Morgado <[email protected]>
Quoted 7 lines
Quoted 3 lines
Applied to master, thanks! I just realized you're the maintainer for libmbim and libqmi, so it's nice to see you sending patches to Buildroot to improve their packaging!
Speaking of which, is there any way I can get CC-ed to changes done in either libqmi, libmbim or modem-manager? I wouldn't mind to review those.
Add an entry to DEVELOPERS listing the packages you are interested in.
baruch
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -PATCH 1/1 libmbim: add udev as optional feature
In reply to Aleksander MorgadoHello,
Quoted 3 lines · Aleksander Morgado
Speaking of which, is there any way I can get CC-ed to changes done in either libqmi, libmbim or modem-manager? I wouldn't mind to review those.
Add yourself to the DEVELOPERS file for those packages. This way:
* You will be Cc'ed when patches are sent,
because ./utils/get-developers on patches touching those packages will return your e-mail address
* You will be notified when http://autobuild.buildroot.org detects build failures for those packages.
If you're interested, just send a patch adding you to the DEVELOPERS file.
Thanks a lot!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com