media: default for RC_CORE should be n
Subsystems (2)
PATCH 1/1 media: default for RC_CORE should be n
The Linus policy on Kconfig is that the default should be no for all new devices. I.e the user rebuild a new kernel from an old config should not by default get a larger kernel.
--- drivers/media/rc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/rc/Kconfig +1 -1
@@ -2,7 +2,7 @@ menuconfig RC_CORE tristate "Remote Controller support" depends on INPUT - default y + default n ---help--- Enable support for Remote Controllers on Linux. This is needed in order to support several video capture adapters,
Signature · 1 line
2.11.0
Sean Young
maintainerQuoted 3 lines · Stephen Hemminger
The Linus policy on
Kconfigis that the default should be no for all new devices. I.e the user rebuild a new kernel from an old config should not by default get a larger kernel.
That might make sense for new config, but RC_CORE has been present for 7 years; I don't see how changing defaults for existing config makes sense.
Sean
Quoted 22 lines
Fixes b4c184e506a4 ("[media] media: reorganize the main Kconfig items")Signed-off-by Stephen Hemminger <[email protected]>--- drivers/media/rc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/rc/Kconfig +1
-1@@ -2,7 +2,7 @@ menuconfig RC_CORE tristate "Remote Controller support" depends on INPUT - default y + default n ---help--- Enable support for Remote Controllers on Linux. This is needed in order to support several video capture adapters,Signature · 1 line
2.11.0
Quoted 9 lines · On Fri, 8 Sep 2017 19:52:47 +0100 Sean Young <[email protected]> wrote:
Quoted 3 lines · Stephen Hemminger
The Linus policy on
Kconfigis that the default should be no for all new devices. I.e the user rebuild a new kernel from an old config should not by default get a larger kernel.That might make sense for new config, but
RC_COREhas been present for 7 years; I don't see how changing defaults for existing config makes sense.
I took existing config for 4.13 and did 'make oldconfig' and just hitting return caused it to turned on.
The problem is that in my config media is disabled, and now your new reconfiguration makes RC_CORE not dependent on media.
It is a common problem, developers never test with their subsystem disabled.
Em Fri, 8 Sep 2017 12:06:48 -0700
Stephen Hemminger <[email protected]> escreveu:
Quoted 13 lines
Quoted 9 lines · On Fri, 8 Sep 2017 19:52:47 +0100 Sean Young <[email protected]> wrote:
Quoted 3 lines · Stephen Hemminger
The Linus policy on
Kconfigis that the default should be no for all new devices. I.e the user rebuild a new kernel from an old config should not by default get a larger kernel.That might make sense for new config, but
RC_COREhas been present for 7 years; I don't see how changing defaults for existing config makes sense.
Quoted 7 lines
I took existing config for 4.13 and did 'make oldconfig' and just hitting return caused it to turned on.
The problem is that in my config media is disabled, and now your new reconfiguration makes
RC_COREnot dependent on media.It is a common problem, developers never test with their subsystem disabled.
Hi Sean,
Yes, it makes sense to default 'n' for RC_CORE now that this is an independent menu option and it builds the RC core when enabled.
Regards,
Mauro
Quoted 15 lines · Stephen Hemminger
The Linus policy on
Kconfigis that the default should be no for all new devices. I.e the user rebuild a new kernel from an old config should not by default get a larger kernel.Fixes b4c184e506a4 ("[media] media: reorganize the main Kconfig items")Signed-off-by Stephen Hemminger <[email protected]>--- drivers/media/rc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/rc/Kconfig +0
-0
drivers/media/rc/Kconfig line 5
Quoted 5 lines
drivers/media/rc/Kconfig +1
-1@@ -2,7 +2,7 @@ menuconfig RC_CORE tristate "Remote Controller support" depends on INPUT - default y + default n
"default n" is the default, so you can just drop this line.
For the principle:
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds