mmc: tegra: Mark 64 bit dma broken on Tegra186
Subsystems (3)
PATCH 1/1 mmc: tegra: Mark 64 bit dma broken on Tegra186
SDHCI controllers on Tegra186 support 40 bit addressing. IOVA addresses are 48-bit wide on Tegra186.
SDHCI host common code sets dma mask as either 32-bit or 64-bit. To avoid access issues when SMMU is enabled, disable 64-bit dma.
--- drivers/mmc/host/sdhci-tegra.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/mmc/host/sdhci-tegra.c +9 -1
@@ -422,7 +422,15 @@ static const struct sdhci_pltfm_data sdhci_tegra186_pdata = {SDHCI_QUIRK_NO_HISPD_BIT |SDHCI_QUIRK_BROKEN_ADMA_ZEROLEN_DESC | SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN, - .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN, + .quirks2 =SDHCI_QUIRK2_PRESET_VALUE_BROKEN | +/* SDHCI controllers on Tegra186 support 40-bit addressing. +* IOVA addresses are 48-bit wide on Tegra186. +* With 64-bit dma mask used for SDHCI, accesses can +* be broken. Disable 64-bit dma, which would fall back +* to 32-bit dma mask. Ideally 40-bit dma mask would work, +* But it is not supported as of now. +*/ + SDHCI_QUIRK2_BROKEN_64_BIT_DMA, .ops = &tegra114_sdhci_ops, };
Signature · 1 line
2.1.4
Quoted 9 lines · Krishna Reddy
SDHCI controllers on Tegra186 support 40 bit addressing. IOVA addresses are 48-bit wide on Tegra186.
SDHCI host common code sets dma mask as either 32-bit or 64-bit. To avoid access issues when SMMU is enabled, disable 64-bit dma.Signed-off-by Krishna Reddy <[email protected]>--- drivers/mmc/host/sdhci-tegra.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
This matches a local commit:
Quoted 6 lines · Krishna Reddy
SDHCI controllers on Tegra186 support 40 bit addressing. IOVA addresses are 48-bit wide on Tegra186.
SDHCI host common code sets dma mask as either 32-bit or 64-bit. To avoid access issues when SMMU is enabled, disable 64-bit dma.Signed-off-by Krishna Reddy <[email protected]>
Quoted 26 lines
--- drivers/mmc/host/sdhci-tegra.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)drivers/mmc/host/sdhci-tegra.c +9
-1@@ -422,7 +422,15 @@ static const struct sdhci_pltfm_data sdhci_tegra186_pdata = {SDHCI_QUIRK_NO_HISPD_BIT |SDHCI_QUIRK_BROKEN_ADMA_ZEROLEN_DESC | SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN, - .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN, + .quirks2 =SDHCI_QUIRK2_PRESET_VALUE_BROKEN | +/* SDHCI controllers on Tegra186 support 40-bit addressing. +* IOVA addresses are 48-bit wide on Tegra186. +* With 64-bit dma mask used for SDHCI, accesses can +* be broken. Disable 64-bit dma, which would fall back +* to 32-bit dma mask. Ideally 40-bit dma mask would work, +* But it is not supported as of now. +*/ + SDHCI_QUIRK2_BROKEN_64_BIT_DMA, .ops = &tegra114_sdhci_ops, };
Ulf Hansson
AppliedQuoted 6 lines · Krishna Reddy
SDHCI controllers on Tegra186 support 40 bit addressing. IOVA addresses are 48-bit wide on Tegra186.
SDHCI host common code sets dma mask as either 32-bit or 64-bit. To avoid access issues when SMMU is enabled, disable 64-bit dma.Signed-off-by Krishna Reddy <[email protected]>
Thanks, applied for next!
Kind regards
Uffe
Quoted 28 lines
--- drivers/mmc/host/sdhci-tegra.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)drivers/mmc/host/sdhci-tegra.c +9
-2@@ -422,7 +422,15 @@ static const struct sdhci_pltfm_data sdhci_tegra186_pdata = {SDHCI_QUIRK_NO_HISPD_BIT |SDHCI_QUIRK_BROKEN_ADMA_ZEROLEN_DESC | SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN, - .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN, + .quirks2 =SDHCI_QUIRK2_PRESET_VALUE_BROKEN | +/* SDHCI controllers on Tegra186 support 40-bit addressing. +* IOVA addresses are 48-bit wide on Tegra186. +* With 64-bit dma mask used for SDHCI, accesses can +* be broken. Disable 64-bit dma, which would fall back +* to 32-bit dma mask. Ideally 40-bit dma mask would work, +* But it is not supported as of now. +*/ + SDHCI_QUIRK2_BROKEN_64_BIT_DMA, .ops = &tegra114_sdhci_ops, }; --2.1.4