drm/i915/spt+: Don't reset invalid AUX channel interrupt bits in SDEIMR
Subsystems (2)
PATCH 1/1 drm/i915/spt+: Don't reset invalid AUX channel interrupt bits in SDEIMR
The SDE interrupt bits 25, 26 and 27 are either reserved or meant for DDI E hotplug in SPT+. These bits are meant for AUX channels only in LPT and CPT, so add the appropriate checks.
--- drivers/gpu/drm/i915/i915_irq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_irq.c +3 -1
@@ -3241,8 +3241,10 @@ static void ibx_irq_postinstall(struct drm_device *dev)if (HAS_PCH_IBX (dev_priv)) mask =SDE_GMBUS |SDE_AUX_MASK |SDE_POISON ; -else +else if (HAS_PCH_CPT (dev_priv) ||HAS_PCH_LPT (dev_priv)) mask =SDE_GMBUS_CPT |SDE_AUX_MASK_CPT ; +else + mask =SDE_GMBUS_CPT ;gen5_assert_iir_is_zero (dev_priv,SDEIIR );I915_WRITE (SDEIMR , ~mask);
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/spt+: Don't reset invalid AUX channel interrupt bits in SDEIMR
== Series Details ==
== Series Details ==
Series: drm/i915/spt+: Don't reset invalid AUX channel interrupt bits in SDEIMR
URL : https://patchwork.freedesktop.org/series/30068/
State : success
== Summary ==
Series 30068v1 drm/i915/spt+: Don't reset invalid AUX channel interrupt bits in SDEIMR
https://patchwork.freedesktop.org/api/1.0/series/30068/revisions/1/mbox/
Test chamelium:
Subgroup dp-crc-fast:
pass -> FAIL (fi-kbl-7500u) fdo#102514
Test gem_exec_store:
Subgroup basic-default:
incomplete -> PASS (fi-byt-j1900)
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-legacy:
fail -> PASS (fi-ivb-3770) fdo#100215
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-n2820) fdo#101705fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:444s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:454s fi-blb-e6850 total:289 pass:224 dwarn:1 dfail:0 fail:0 skip:64 time:377s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:528s fi-bwr-2160 total:289 pass:184 dwarn:0 dfail:0 fail:0 skip:105 time:268s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:505s fi-byt-j1900 total:289 pass:254 dwarn:1 dfail:0 fail:0 skip:34 time:504s fi-byt-n2820 total:289 pass:250 dwarn:1 dfail:0 fail:0 skip:38 time:493s fi-cfl-s total:289 pass:250 dwarn:4 dfail:0 fail:0 skip:35 time:445s fi-elk-e7500 total:289 pass:230 dwarn:0 dfail:0 fail:0 skip:59 time:451s fi-glk-2a total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:599s fi-hsw-4770 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:426s fi-hsw-4770r total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:410s fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:436s fi-ivb-3520m total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:488s fi-ivb-3770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:460s fi-kbl-7500u total:289 pass:263 dwarn:1 dfail:0 fail:1 skip:24 time:468s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:575s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:581s fi-pnv-d510 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:551s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:452s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:520s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:503s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:459s fi-skl-x1585l total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:481s fi-snb-2520m total:289 pass:251 dwarn:0 dfail:0 fail:0 skip:38 time:570s fi-snb-2600 total:289 pass:248 dwarn:0 dfail:0 fail:2 skip:39 time:422s
b7ca0db5dc374e1f58839cfdc3803d4f4fb47eaf drm-tip: 2017y-09m-08d-20h-12m-37s UTC integration manifest f4bdf8963913 drm/i915/spt+: Don't reset invalid AUX channel interrupt bits in SDEIMR
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5625/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915/spt+: Don't reset invalid AUX channel interrupt bits in SDEIMR
In reply to Dhinakaran Pandiyan== Series Details ==
== Series Details ==
Series: drm/i915/spt+: Don't reset invalid AUX channel interrupt bits in SDEIMR
URL : https://patchwork.freedesktop.org/series/30068/
State : success
== Summary ==
Test gem_eio:
Subgroup in-flight:
fail -> PASS (shard-hsw) fdo#102616
Test gem_pwrite_pread:
Subgroup display-copy-correctness:
fail -> PASS (shard-hsw)
Test gem_exec_reloc:
Subgroup basic-write-gtt-active:
skip -> PASS (shard-hsw)
Test kms_flip:
Subgroup blt-wf_vblank-vs-modeset:
skip -> PASS (shard-hsw)
Test perf:
Subgroup polling:
fail -> PASS (shard-hsw) fdo#102252
Test gem_flink_race:
Subgroup flink_close:
fail -> PASS (shard-hsw)fdo#102616 https://bugs.freedesktop.org/show_bug.cgi?id=102616
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
shard-hsw total:2302 pass:1237 dwarn:0 dfail:0 fail:13 skip:1052 time:9440s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5625/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 5 lines · Dhinakaran Pandiyan
The SDE interrupt bits 25, 26 and 27 are either reserved or meant for DDI E hotplug in SPT+. These bits are meant for AUX channels only in LPT and CPT, so add the appropriate checks.
Signed-off-by Dhinakaran Pandiyan <[email protected]>
Quoted 9 lines
--- drivers/gpu/drm/i915/i915_irq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_irq.c +0
-0
drivers/gpu/drm/i915/i915_irq.c static void ibx_irq_postinstall(struct drm_device *dev) · line 3244
Quoted 5 lines
drivers/gpu/drm/i915/i915_irq.c +1
-1@@ -3241,8 +3241,10 @@ static void ibx_irq_postinstall(struct drm_device *dev)if (HAS_PCH_IBX (dev_priv)) mask =SDE_GMBUS |SDE_AUX_MASK |SDE_POISON ; -else +else if (HAS_PCH_CPT (dev_priv) ||HAS_PCH_LPT (dev_priv))
I was going to ask about PPT but I then noticed:
/* PantherPoint is CPT compatible */
Quoted 9 lines
drivers/gpu/drm/i915/i915_irq.c +2
-0mask =SDE_GMBUS_CPT |SDE_AUX_MASK_CPT ; + else + mask =SDE_GMBUS_CPT ;gen5_assert_iir_is_zero (dev_priv,SDEIIR );I915_WRITE (SDEIMR , ~mask);Signature · 1 line
2.11.0
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
AppliedQuoted 8 lines · Rodrigo Vivi
Quoted 5 lines · Dhinakaran Pandiyan
The SDE interrupt bits 25, 26 and 27 are either reserved or meant for DDI E hotplug in SPT+. These bits are meant for AUX channels only in LPT and CPT, so add the appropriate checks.
Signed-off-by Dhinakaran Pandiyan <[email protected]>Reviewed-by Rodrigo Vivi <[email protected]>
merged to dinq. thanks for the patch.
Quoted 33 lines
Quoted 10 lines
--- drivers/gpu/drm/i915/i915_irq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_irq.c +0
-0drivers/gpu/drm/i915/i915_irq.c static void ibx_irq_postinstall(struct drm_device *dev) · line 3244
Quoted 5 lines
drivers/gpu/drm/i915/i915_irq.c +1
-1@@ -3241,8 +3241,10 @@ static void ibx_irq_postinstall(struct drm_device *dev)if (HAS_PCH_IBX (dev_priv)) mask =SDE_GMBUS |SDE_AUX_MASK |SDE_POISON ; -else +else if (HAS_PCH_CPT (dev_priv) ||HAS_PCH_LPT (dev_priv))I was going to ask about PPT but I then noticed:
/* PantherPoint is CPT compatible */Quoted 9 lines
drivers/gpu/drm/i915/i915_irq.c +2
-1mask =SDE_GMBUS_CPT |SDE_AUX_MASK_CPT ; + else + mask =SDE_GMBUS_CPT ;gen5_assert_iir_is_zero (dev_priv,SDEIIR );I915_WRITE (SDEIMR , ~mask); --2.11.0
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx