Skip to contentSkip to conversation

ipv6: sr: remove duplicate routing header type check

PATCH In review David Lebrun 2 participants 2 messages Sep 10, 2017 – Sep 11, 2017

Subsystems (3)
Networking Network drivers Networking SRv6
lore
Share & tools
lore

David Lebrun

author
#0 lore raw

PATCH 1/1 ipv6: sr: remove duplicate routing header type check

From: David Lebrun <[email protected]>

As seg6_validate_srh() already checks that the Routing Header type is correct, it is not necessary to do it again in get_srh().

Fixes 5829d70b ("ipv6: sr: fix get_srh() to comply with IPv6 standard "RFC 8200")
Signed-off-by David Lebrun <[email protected]>
---
 net/ipv6/seg6_local.c | 4 ----
 1 file changed, 4 deletions(-)
net/ipv6/seg6_local.c +0 -4
index 7ff54db..825b8e0 100644
@@ -72,10 +72,6 @@ static struct ipv6_sr_hdr *get_srh(struct sk_buff *skb)
 
 	srh = (struct ipv6_sr_hdr *)(skb->data + srhoff);
 
-	/* make sure it's a Segment Routing header (Routing Type 4) */
-	if (srh->type != IPV6_SRCRT_TYPE_4)
-		return NULL;
-
 	len = (srh->hdrlen + 1) << 3;
 
 	if (!pskb_may_pull(skb, srhoff + len))
Signature · 1 line
2.10.2
maintainer
#1 lore raw

From: David Lebrun <[email protected]>
Date: Sun, 10 Sep 2017 14:22:01 +0100

Quoted 7 lines

From: David Lebrun <[email protected]>

As seg6_validate_srh() already checks that the Routing Header type is correct, it is not necessary to do it again in get_srh().

Fixes 5829d70b ("ipv6: sr: fix get_srh() to comply with IPv6 standard "RFC 8200")
Signed-off-by David Lebrun <[email protected]>

Applied thanks.