ARM: dts: r8a7743: Add IIC cores to dtsi
PATCH 2/2 ARM: dts: r8a7743: Add IIC cores to dtsi
---
This patch has been tested against Linux-next tag 20170727 and renesas-dev branch. This patch depends on https://www.spinics.net/lists/arm-kernel/msg599220.html
arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+)
arch/arm/boot/dts/r8a7743.dtsi +55 -0
@@ -25,6 +25,9 @@ i2c3 = &i2c3; i2c4 = &i2c4; i2c5 = &i2c5; + i2c6 = &i2c6; + i2c7 = &i2c7; + i2c8 = &i2c8; }; cpus {
@@ -436,6 +439,58 @@ status = "disabled"; }; + i2c6: i2c at e60b0000 { + /* doesn't need pinmux */ + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe60b0000 0 0x425>; + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 926>; + dmas = <&dmac0 0x77>, <&dmac0 0x78>, + <&dmac1 0x77>, <&dmac1 0x78>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg CPG_MOD 926>; + status = "disabled"; + }; + + i2c7: i2c at e6500000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6500000 0 0x425>; + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 318>; + dmas = <&dmac0 0x61>, <&dmac0 0x62>, + <&dmac1 0x61>, <&dmac1 0x62>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 318>; + status = "disabled"; + }; + + i2c8: i2c at e6510000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6510000 0 0x425>; + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 323>; + dmas = <&dmac0 0x65>, <&dmac0 0x66>, + <&dmac1 0x65>, <&dmac1 0x66>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 323>; + status = "disabled"; + }; + scifa0: serial at e6c40000 { compatible = "renesas,scifa-r8a7743", "renesas,rcar-gen2-scifa", "renesas,scifa";
Signature · 1 line
1.9.1
PATCH 2/2 ARM: dts: r8a7743: Add IIC cores to dtsi
Quoted 4 lines · Biju Das
Signed-off-by Biju Das <[email protected]>---
This patch has been tested against Linux-next tag 20170727 and renesas-dev branch. This patch depends on https://www.spinics.net/lists/arm-kernel/msg599220.html
Process comments as per those for
"[PATCH 2/2] ARM: dts: r8a7743: Add I2C DT support".
Patch itself looks good to me.
Quoted 80 lines
arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+)arch/arm/boot/dts/r8a7743.dtsi +55
-0@@ -25,6 +25,9 @@ i2c3 = &i2c3; i2c4 = &i2c4; i2c5 = &i2c5; + i2c6 = &i2c6; + i2c7 = &i2c7; + i2c8 = &i2c8; }; cpus {@@ -436,6 +439,58 @@ status = "disabled"; }; + i2c6: i2c at e60b0000 { + /* doesn't need pinmux */ + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe60b0000 0 0x425>; + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 926>; + dmas = <&dmac0 0x77>, <&dmac0 0x78>, + <&dmac1 0x77>, <&dmac1 0x78>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg CPG_MOD 926>; + status = "disabled"; + }; + + i2c7: i2c at e6500000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6500000 0 0x425>; + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 318>; + dmas = <&dmac0 0x61>, <&dmac0 0x62>, + <&dmac1 0x61>, <&dmac1 0x62>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 318>; + status = "disabled"; + }; + + i2c8: i2c at e6510000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6510000 0 0x425>; + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 323>; + dmas = <&dmac0 0x65>, <&dmac0 0x66>, + <&dmac1 0x65>, <&dmac1 0x66>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 323>; + status = "disabled"; + }; + scifa0: serial at e6c40000 { compatible = "renesas,scifa-r8a7743", "renesas,rcar-gen2-scifa", "renesas,scifa";Signature · 1 line
1.9.1
PATCH 2/2 ARM: dts: r8a7743: Add IIC cores to dtsi
In reply to Biju DasQuoted 12 lines · Biju Das
Signed-off-by Biju Das <[email protected]>---
This patch has been tested against Linux-next tag 20170727 and renesas-dev branch. This patch depends on https://www.spinics.net/lists/arm-kernel/msg599220.htmlarch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+)arch/arm/boot/dts/r8a7743.dtsi +0
-0
[...]
arch/arm/boot/dts/r8a7743.dtsi line 442
Quoted 5 lines
arch/arm/boot/dts/r8a7743.dtsi +1
-0@@ -436,6 +439,58 @@ status = "disabled"; }; + i2c6: i2c at e60b0000 {
I'd use iic0 as the label.
Quoted 4 lines
arch/arm/boot/dts/r8a7743.dtsi +4
-0+ /* doesn't need pinmux */ + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743",
arch/arm/boot/dts/r8a7743.dtsi line 456
Quoted 10 lines
arch/arm/boot/dts/r8a7743.dtsi +10
-0+ "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe60b0000 0 0x425>; + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 926>; + dmas = <&dmac0 0x77>, <&dmac0 0x78>, + <&dmac1 0x77>, <&dmac1 0x78>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg CPG_MOD 926>;
CPG_MOD not needed here, it's not a "clocks" prop.
[...]
MBR, Sergei
PATCH 2/2 ARM: dts: r8a7743: Add IIC cores to dtsi
Quoted 40 lines
-----Original Message-----
From: Sergei Shtylyov [mailto:sergei.shtylyov at cogentembedded.com]
Sent: 09 August 2017 10:17
To: Biju Das <[email protected]>; Rob Herring <[email protected]>; Mark Rutland <[email protected]>
Cc: Simon Horman <[email protected]>; Wolfram Sang <wsa@the- dreams.de>; Magnus Damm <[email protected]>; Russell King <[email protected]>; Chris Paterson <[email protected]>; devicetree at vger.kernel.org; linux-renesas-soc at vger.kernel.org; linux-arm- kernel at lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsiQuoted 3 lines · Biju Das
Signed-off-by Biju Das <[email protected]>---
This patch has been tested against Linux-next tag 20170727 and renesas-devbranch.
Quoted 4 lines
This patch depends on
https://www.spinics.net/lists/arm-kernel/msg599220.htmlarch/arm/boot/dts/r8a7743.dtsi | 55++++++++++++++++++++++++++++++++++++++++++
Quoted 6 lines
1 file changed, 55 insertions(+)(quoted diff) +0
-0
b/arch/arm/boot/dts/r8a7743.dtsiindex 14222c72..5c2b140 100644arch/arm/boot/dts/r8a7743.dtsi +0
-0[...]
arch/arm/boot/dts/r8a7743.dtsi line 442
Quoted 5 lines
arch/arm/boot/dts/r8a7743.dtsi +1
-0@@ -436,6 +439,58 @@ status = "disabled"; }; +i2c6: i2c at e60b0000 {I'd use iic0 as the label.
Quoted 16 lines
Quoted 4 lines
arch/arm/boot/dts/r8a7743.dtsi +4
-0+/* doesn't need pinmux */ +#address-cells = <1>; +#size-cells = <0>; +compatible = "renesas,iic-r8a7743",arch/arm/boot/dts/r8a7743.dtsi line 456
Quoted 10 lines
arch/arm/boot/dts/r8a7743.dtsi +10
-0+ "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; +reg = <0 0xe60b0000 0 0x425>; +interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; +clocks = <&cpg CPG_MOD 926>; +dmas = <&dmac0 0x77>, <&dmac0 0x78>, + <&dmac1 0x77>, <&dmac1 0x78>; +dma-names = "tx", "rx", "tx", "rx"; +power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; +resets = <&cpg CPG_MOD 926>;
CPG_MODnot needed here, it's not a "clocks" prop.
Thanks Sergie, I will correct this.
[>]
Quoted 3 lines
[...]
MBR, Sergei
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
PATCH 2/2 ARM: dts: r8a7743: Add IIC cores to dtsi
In reply to Sergei ShtylyovQuoted 15 lines · Sergei Shtylyov
Quoted 12 lines · Biju Das
Signed-off-by Biju Das <[email protected]>---
This patch has been tested against Linux-next tag 20170727 and renesas-dev branch. This patch depends on https://www.spinics.net/lists/arm-kernel/msg599220.htmlarch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+)arch/arm/boot/dts/r8a7743.dtsi +0
-0[...]
Quoted 6 lines
arch/arm/boot/dts/r8a7743.dtsi line 441
Quoted 4 lines
arch/arm/boot/dts/r8a7743.dtsi +1
-0@@ -436,6 +439,58 @@ status = "disabled"; }; + i2c6: i2c at e60b0000 {I'd use iic0 as the label.
I have no preference here other than that we try to be consistent in DT for different R-Car SoCs. Wolfram, do you have an opinion on this?
Quoted 22 lines
Quoted 5 lines
arch/arm/boot/dts/r8a7743.dtsi +4
-0+ /* doesn't need pinmux */ + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743",arch/arm/boot/dts/r8a7743.dtsi line 456
Quoted 10 lines
arch/arm/boot/dts/r8a7743.dtsi +10
-0+ "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe60b0000 0 0x425>; + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 926>; + dmas = <&dmac0 0x77>, <&dmac0 0x78>, + <&dmac1 0x77>, <&dmac1 0x78>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg CPG_MOD 926>;
CPG_MODnot needed here, it's not a "clocks" prop.[...]
MBR, Sergei
PATCH 2/2 ARM: dts: r8a7743: Add IIC cores to dtsi
Quoted 7 lines
Quoted 4 lines
arch/arm/boot/dts/r8a7743.dtsi line 442
Quoted 2 lines
arch/arm/boot/dts/r8a7743.dtsi +1
-0+ i2c6: i2c at e60b0000 {I'd use iic0 as the label.
I have no preference here other than that we try to be consistent in DT for different R-Car SoCs. Wolfram, do you have an opinion on this?
Back then, for M2-W, I decided to go with the schematics/datasheets. And those mentioned i2c6 rather than iic0. For that reason, the comment
"/* The memory map in the User's Manual maps the cores to bus numbers */"
exists in r8a7791.dtsi. Dunno the manual of this SoC here.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170810/bb3d03e1/attachment.sig>
PATCH 2/2 ARM: dts: r8a7743: Add IIC cores to dtsi
Hello,
Quoted 8 lines
From: Wolfram Sang [mailto:wsa at the-dreams.de]
Sent: 10 August 2017 12:24Quoted 4 lines
Quoted 3 lines
arch/arm/boot/dts/r8a7743.dtsi line 442
Quoted 1 line
arch/arm/boot/dts/r8a7743.dtsi +1
-0+ i2c6: i2c at e60b0000 {I'd use iic0 as the label.
Quoted 5 lines
Quoted 2 lines
I have no preference here other than that we try to be consistent in DT for different R-Car SoCs. Wolfram, do you have an opinion on this?
Back then, for M2-W, I decided to go with the schematics/datasheets. And those mentioned i2c6 rather than iic0. For that reason, the comment
The M2 schematics still use i2c6, and for consistency I'd vote to use the same with RZ/G1M.
Quoted 4 lines
"/* The memory map in the User's Manual maps the cores to bus numbers */"
exists in
r8a7791.dtsi. Dunno the manual of this SoC here.
The manual for r8a7743 uses the same terminology as the r8a7791 manuals.
Kind regards, Chris
PATCH 2/2 ARM: dts: r8a7743: Add IIC cores to dtsi
Quoted 10 lines · Chris Paterson
Hello,
Quoted 8 lines
From: Wolfram Sang [mailto:wsa at the-dreams.de]
Sent: 10 August 2017 12:24Quoted 4 lines
Quoted 3 lines
arch/arm/boot/dts/r8a7743.dtsi line 442
Quoted 1 line
arch/arm/boot/dts/r8a7743.dtsi +1
-0+ i2c6: i2c at e60b0000 {I'd use iic0 as the label.
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
I have no preference here other than that we try to be consistent in DT for different R-Car SoCs. Wolfram, do you have an opinion on this?
Back then, for M2-W, I decided to go with the schematics/datasheets. And those mentioned i2c6 rather than iic0. For that reason, the comment
The M2 schematics still use i2c6, and for consistency I'd vote to use the same with RZ/G1M.
+1
Quoted 5 lines
Quoted 3 lines
"/* The memory map in the User's Manual maps the cores to bus numbers */"
exists in
r8a7791.dtsi. Dunno the manual of this SoC here.The manual for r8a7743 uses the same terminology as the r8a7791 manuals.
PATCH 2/2 ARM: dts: r8a7743: Add IIC cores to dtsi
In reply to Chris PatersonQuoted 7 lines · Chris Paterson
Quoted 7 lines
From: Wolfram Sang [mailto:wsa at the-dreams.de]
Sent: 10 August 2017 12:24Quoted 3 lines
Quoted 3 lines
Quoted 1 line
+ i2c6: i2c at
e60b0000{I'd use iic0 as the label.
Sergei: I assume you meant "iic3"? ;-)
Quoted 7 lines
Quoted 6 lines
Quoted 3 lines
I have no preference here other than that we try to be consistent in DT for different R-Car SoCs. Wolfram, do you have an opinion on this?
Back then, for M2-W, I decided to go with the schematics/datasheets. And those mentioned i2c6 rather than iic0. For that reason, the comment
Quoted 8 lines
The M2 schematics still use i2c6, and for consistency I'd vote to use the same with RZ/G1M.
Quoted 4 lines
"/* The memory map in the User's Manual maps the cores to bus numbers */"
exists in
r8a7791.dtsi. Dunno the manual of this SoC here.The manual for r8a7743 uses the same terminology as the r8a7791 manuals.
The pinctrl section does, indeed.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
PATCH 2/2 ARM: dts: r8a7743: Add IIC cores to dtsi
Hello!
Quoted 9 lines · Geert Uytterhoeven
Quoted 7 lines
Quoted 7 lines
From: Wolfram Sang [mailto:wsa at the-dreams.de]
Sent: 10 August 2017 12:24Quoted 3 lines
Quoted 3 lines
Quoted 1 line
+ i2c6: i2c at
e60b0000{I'd use iic0 as the label.
Sergei: I assume you meant "iic3"? ;-)
After having a look at the manual, yes. :-)
[...]
Quoted 3 lines
Gr{oetje,eeting}s,
Geert
MBR, Sergei
PATCH v2 1/1 ARM: dts: r8a7743: add IIC cores to dtsi
In reply to Sergei Shtylyov---
v1-->v2
Corrected the resets property for i2c6 device node.
This patch is compiled against renesas-devel tag renesas-devel-20170814-v4.13-rc5.
arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+)
arch/arm/boot/dts/r8a7743.dtsi +55 -0
@@ -25,6 +25,9 @@ i2c3 = &i2c3; i2c4 = &i2c4; i2c5 = &i2c5; + i2c6 = &i2c6; + i2c7 = &i2c7; + i2c8 = &i2c8; }; cpus {
@@ -411,6 +414,58 @@ status = "disabled"; }; + i2c6: i2c at e60b0000 { + /* doesn't need pinmux */ + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe60b0000 0 0x425>; + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 926>; + dmas = <&dmac0 0x77>, <&dmac0 0x78>, + <&dmac1 0x77>, <&dmac1 0x78>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 926>; + status = "disabled"; + }; + + i2c7: i2c at e6500000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6500000 0 0x425>; + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 318>; + dmas = <&dmac0 0x61>, <&dmac0 0x62>, + <&dmac1 0x61>, <&dmac1 0x62>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 318>; + status = "disabled"; + }; + + i2c8: i2c at e6510000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6510000 0 0x425>; + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 323>; + dmas = <&dmac0 0x65>, <&dmac0 0x66>, + <&dmac1 0x65>, <&dmac1 0x66>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 323>; + status = "disabled"; + }; + scifa0: serial at e6c40000 { compatible = "renesas,scifa-r8a7743", "renesas,rcar-gen2-scifa", "renesas,scifa";
Signature · 1 line
1.9.1
PATCH v2 1/1 ARM: dts: r8a7743: add IIC cores to dtsi
Hello reviewers,
Quoted 7 lines
From: Biju Das [mailto:biju.das at bp.renesas.com]
Sent: 14 August 2017 10:53Signed-off-by Biju Das <[email protected]>---
v1-->v2
Corrected the resets property for i2c6 device node.
Are you happy with this version of the patch?
Or is the discussion for moving to 'iic' still alive?
Thanks, Chris
Quoted 83 lines
This patch is compiled against renesas-devel tag renesas-devel-20170814- v4.13-rc5.
arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+)arch/arm/boot/dts/r8a7743.dtsi +55
-1@@ -25,6 +25,9 @@ i2c3 = &i2c3; i2c4 = &i2c4; i2c5 = &i2c5; + i2c6 = &i2c6; + i2c7 = &i2c7; + i2c8 = &i2c8; }; cpus {@@ -411,6 +414,58 @@ status = "disabled"; }; + i2c6: i2c at e60b0000 { + /* doesn't need pinmux */ + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe60b0000 0 0x425>; + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 926>; + dmas = <&dmac0 0x77>, <&dmac0 0x78>, + <&dmac1 0x77>, <&dmac1 0x78>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 926>; + status = "disabled"; + }; + + i2c7: i2c at e6500000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6500000 0 0x425>; + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 318>; + dmas = <&dmac0 0x61>, <&dmac0 0x62>, + <&dmac1 0x61>, <&dmac1 0x62>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 318>; + status = "disabled"; + }; + + i2c8: i2c at e6510000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6510000 0 0x425>; + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 323>; + dmas = <&dmac0 0x65>, <&dmac0 0x66>, + <&dmac1 0x65>, <&dmac1 0x66>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 323>; + status = "disabled"; + }; + scifa0: serial at e6c40000 { compatible = "renesas,scifa-r8a7743", "renesas,rcar-gen2-scifa", "renesas,scifa"; --1.9.1
PATCH v2 1/1 ARM: dts: r8a7743: add IIC cores to dtsi
Quoted 11 lines · Chris Paterson
Quoted 7 lines
From: Biju Das [mailto:biju.das at bp.renesas.com]
Sent: 14 August 2017 10:53Signed-off-by Biju Das <[email protected]>---
v1-->v2
Corrected the resets property for i2c6 device node.Are you happy with this version of the patch?
Or is the discussion for moving to 'iic' still alive?
Yes, appears so. I'd like the labels to be named iic<n>.
Quoted 1 line
Thanks, Chris
MBR, Sergei
PATCH v2 1/1 ARM: dts: r8a7743: add IIC cores to dtsi
Quoted 10 lines · Sergei Shtylyov
Quoted 8 lines · Chris Paterson
Quoted 7 lines
From: Biju Das [mailto:biju.das at bp.renesas.com]
Sent: 14 August 2017 10:53Signed-off-by Biju Das <[email protected]>---
v1-->v2
Corrected the resets property for i2c6 device node.
Quoted 5 lines
Quoted 3 lines
Are you happy with this version of the patch?
Or is the discussion for moving to 'iic' still alive?
Yes, appears so. I'd like the labels to be named iic<n>.
Chirs, I'm marking this as "Changes Requested" and expecting to see iic in v3 when you are ready.
PATCH v2 1/1 ARM: dts: r8a7743: add IIC cores to dtsi
Quoted 16 lines
From: Simon Horman [mailto:horms at verge.net.au]
Sent: 30 August 2017 08:32Quoted 10 lines · Sergei Shtylyov
Quoted 8 lines · Chris Paterson
Quoted 7 lines
From: Biju Das [mailto:biju.das at bp.renesas.com]
Sent: 14 August 2017 10:53Signed-off-by Biju Das <[email protected]>---
v1-->v2
Corrected the resets property for i2c6 device node.
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Are you happy with this version of the patch?
Or is the discussion for moving to 'iic' still alive?
Yes, appears so. I'd like the labels to be named iic<n>.
Chirs, I'm marking this as "Changes Requested" and expecting to see iic in v3 when you are ready.
Sure, thanks.
PATCH v3 1/1 ARM: dts: r8a7743: Add IIC cores to dtsi
In reply to Biju DasFrom: Biju Das <[email protected]>
---v2->v3
- Renamed lables to use iic instead of i2c.
v1->v2
- Corrected the resets property for i2c6 device node.
This patch is based on renesas-devel tag renesas-devel-20170905-v4.13.
DT bindings has been accepted by Wolfram:
https://patchwork.kernel.org/patch/9888119
arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+)
arch/arm/boot/dts/r8a7743.dtsi +55 -0
@@ -25,6 +25,9 @@ i2c3 = &i2c3; i2c4 = &i2c4; i2c5 = &i2c5; + i2c6 = &iic0; + i2c7 = &iic1; + i2c8 = &iic3; }; cpus {
@@ -436,6 +439,58 @@ status = "disabled"; }; + iic0: i2c at e6500000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6500000 0 0x425>; + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 318>; + dmas = <&dmac0 0x61>, <&dmac0 0x62>, + <&dmac1 0x61>, <&dmac1 0x62>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 318>; + status = "disabled"; + }; + + iic1: i2c at e6510000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6510000 0 0x425>; + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 323>; + dmas = <&dmac0 0x65>, <&dmac0 0x66>, + <&dmac1 0x65>, <&dmac1 0x66>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 323>; + status = "disabled"; + }; + + iic3: i2c at e60b0000 { + /* doesn't need pinmux */ + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe60b0000 0 0x425>; + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 926>; + dmas = <&dmac0 0x77>, <&dmac0 0x78>, + <&dmac1 0x77>, <&dmac1 0x78>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 926>; + status = "disabled"; + }; + scifa0: serial at e6c40000 { compatible = "renesas,scifa-r8a7743", "renesas,rcar-gen2-scifa", "renesas,scifa";
Signature · 1 line
1.9.1
Simon Horman
AppliedPATCH v3 1/1 ARM: dts: r8a7743: Add IIC cores to dtsi
Quoted 8 lines · Chris Paterson
From: Biju Das <[email protected]>
Signed-off-by Biju Das <[email protected]>Signed-off-by Chris Paterson <[email protected]>---
v2->v3
- Renamed lables to use iic instead of i2c.
Quoted 7 lines
v1->v2
- Corrected the resets property for i2c6 device node.This patch is based on renesas-devel tag renesas-devel-20170905-v4.13.
DT bindings has been accepted by Wolfram:
https://patchwork.kernel.org/patch/9888119
Thanks, applied.