Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS
Subsystems (20)
v10 cover Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS
Hi folks,
We have a large influx of new, unmerged, drivers that are now parsing fwnode endpoints and each one of them is doing this a little bit differently. The needs are still exactly the same for the graph data structure is device independent. This is still a non-trivial task and the majority of the driver implementations are buggy, just buggy in different ways.
Facilitate parsing endpoints by adding a convenience function for parsing the endpoints, and make the omap3isp and rcar-vin drivers use them as an example.
To show where we're getting with this, I've added support for async sub-device notifier support that is notifiers that can be registered by sub-device drivers as well as V4L2 fwnode improvements to make use of them and the DTS changes for the Nokia N9. Some of these patches I've posted previously in this set here:
<URL:http://www.spinics.net/lists/linux-media/msg118764.html>
Since that, the complete callback of the master notifier registering the V4L2 device is only called once all sub-notifiers have been completed as well. This way the device node creation can be postponed until all devices have been successfully initialised.
With this, the as3645a driver successfully registers a sub-device to the media device created by the omap3isp driver. The kernel also has the information it's related to the sensor driven by the smiapp driver but we don't have a way to expose that information yet.
since v9:
- Drop "as3645a: Switch to fwnode property API" and "ACPI: Document how to refer to LEDs from remote nodes" patches. They're better off separately from this set.
- Address property documentation redundancy in smiapp DT binding documentation.
- Add patches "ov5670: Add support for flash and lens devices" and "ov13858: Add support for flash and lens devices".
since v8:
- Improve terminology for notifiers. Instead of master / subdev, we have root, parent and subdev notifiers.
- Renamed "flash" property as "flash-leds". There are many, and currently we make assumptions in a lot of places (e.g. LED bindings) that these are LEDs. While we don't have any other types of flashes supported right now (e.g. Xenon), it's safer to assume we might have them in the future.
- Use ENOTCONN instead of EPERM to tell from driver's callback function that an endpoint is to be skipped but not handled as an error.
- Avoid accessing notifier's subdevs array as well as num_subdevs field from rcar-vin driver.
- Add a patch "v4l: async: Allow async notifier register call succeed with no subdevs", which allows, well, what the subject says.
- Move checks for subdev / v4l2_dev from __v4l2_async_notifier_register() to v4l2_async_notifier_register() and v4l2_async_subdev_notifier_register().
- Don't initialise notifier->list. There was no need to do so, as this is the entry added to the list and not used otherwise. I.e. regarding this, the state before this patchset is restored.
- Clean up error handling in v4l2_async_notifier_fwnode_parse_endpoint().
- WARN_ON() in v4l2_async_notifier_parse_fwnode_endpoints() if the asd_struct_size is smaller than size of struct v4l2_async_subdev.
- Make v4l2_fwnode_reference_parse() static as there should be no need to use it outside the V4L2 fwnode framework. Also, remove the callback function as well as other arguments that always have the same value in current usage. (This can be changed later on if needed without affecting drivers.)
- Add the patch "v4l: fwnode: Add a helper function to obtain device / interger references", which allows similar use than v4l2_fwnode_reference_parse() but is more useful on ACPI based systems --- on ACPI, you can only refer to device nodes (corresponding struct deice in Linux), not to data extension nodes under the devices.
- Improve v4l2_fwnode_reference_parse_sensor_common() to work on ACPI based systems.
- Add patch "ACPI: Document how to refer to LEDs from remote nodes" to document using and referring to LEDs on ACPI.
- Rebase the set on AS3645A fixes I just sent ("AS3645A fixes")
- In v4l2_fwnode_reference_parse_sensor_common(), tell if parsing a property failed.
- Improved documentation for v4l2_async_notifier_parse_fwnode_endpoints().
- Fix v4l2_async_notifier_try_all_subdevs(); it is allowed that the list entry being iterated over is deleted but no other changes to the list are allowed. This could be the case if a sub-device driver's notifier binds a sub-device. Restart the loop whenever a match is found.
- Add patch "as3645a: Switch to fwnode property API" which also adds ACPI support.
since v7:
- Added three more patches:
v4l: async: Remove re-probing support
v4l: async: Use more intuitive names for internal functions
dt: bindings: smiapp: Document lens-focus and flash properties
The last one was already sent previously after the rest of the patchset.
- Removed re-probing support. This is hard to support and only useful in special cases. It can be reintroduced later on if there's really a need --- note that in e.g. omap3isp this was always broken and no-one ever complained.
- Remove smiapp driver's async complete callback (and ops). It is
redundant: the sub-device nodes are created through the master notifier.
- Improve flash property documentation in video-interfaces.txt.
- Introduce helper functions to call notifier operations, one for each operation.
- Rename v4l2_async_test_notify as v4l2_async_match_notify and v4l2_async_belongs to v4l2_async_find_match.
- v4l2_async_notifier_test_all_subdevs() renamed as v4l2_async_notifier_try_all_subdevs().
- Made notifier_v4l2_dev a function (it was a macro).
- Registering subdev notifiers from sub-device drivers that control sub-devices created through sub-notifiers is now supported. In other words, subdev notifiers may be registered through other subdev notifiers. This is the source of the bulk of the changes between v7 and v8.
- Add explanatory comments to helper functions used by V4L2 async framework. This should help understanding the internal workings of the framework.
- Removed the "notifiers" list in struct v4l2_async_notifier. The information can be found from existing data structures.
- Explicitly check that registering a non-subdev notifier has v4l2_dev and a subdev notifier has a sub-device pointer.
- Unified several code paths between subdev notifiers and non-subdev notifiers.
- Fixed v4l2_async_notifier_release() --- calling it on a notifier for which the driver had allocated the subdevs array would lead calling kvfree() on that array. Now notifier->max_subdevs is checked before proceeding.
- Fixed a use-after-free issue in
v4l2_async_notifier_fwnode_parse_endpoints().
- Small fixes to KernelDoc documentation for
v4l2_async_notifier_parse_fwnode_endpoints().
since v6:
- Drop the last patch that added variant for parsing endpoints given specific port and endpoints numbers.
- Separate driver changes from the fwnode endpoint parser patch into two patches. rcar-vin driver is now using the name function.
- Use -ENOTCONN to tell the parser that and endpoint (or a reference) is to be ignored.
- parse_endpoint and parse_single callback functions are now optional and documented as such.
- Added Laurent's patch adding notifier operations struct which I rebase on the fwnode parser patchset. I wrote another patch to call the notifier operations through macros.
- Add DT bindings for flash and lens devices.
- V4L2 fwnode parser for references (such as flash and lens).
- Added smiapp driver support for async sub-devices (lens and flash).
- Added a few fixes for omap3isp.
since v5:
- Use v4l2_async_ prefix for static functions as well (4th patch)
- Use memcpy() to copy array rather than a loop
- Document that the v4l2_async_subdev pointer in driver specific struct must be the first member
- Improve documentation of the added functions (4th and 5th patches)
- Arguments
- More thorough explation of the purpose, usage and object lifetime
- Added acks
since v4:
- Prepend the set with three documentation fixes.
- The driver's async struct must begin with struct v4l2_async_subdev. Fix this for omap3isp and document it.
- Improve documentation for new functions.
- Don't use devm_ family of functions for allocating memory. Introduce v4l2_async_notifier_release() to release memory resources.
- Rework both v4l2_async_notifier_fwnode_parse_endpoints() and v4l2_async_notifier_fwnode_parse_endpoint() and the local functions they call. This should make the code cleaner. Despite the name, for linking and typical usage reasons the functions remain in v4l2-fwnode.c.
- Convert rcar-vin to use v4l2_async_notifier_fwnode_parse_endpoint().
- Use kvmalloc() for allocating the notifier's subdevs array.
- max_subdevs argument for notifier_realloc is now the total maximum number of subdevs, not the number of available subdevs.
- Use fwnode_device_is_available() to make sure the device actually exists.
- Move the note telling v4l2_async_notifier_fwnode_parse_endpoints() should not be used by new drivers to the last patch adding v4l2_async_notifier_fwnode_parse_endpoint().
since v3:
- Rebase on current mediatree master.
since v2:
- Rebase on CCP2 support patches.
- Prepend a patch cleaning up omap3isp driver a little.
since v1:
- The first patch has been merged (it was a bugfix).
- In anticipation that the parsing can take place over several iterations, take the existing number of async sub-devices into account when re-allocating an array of async sub-devices.
- Rework the first patch to better anticipate parsing single endpoint at a time by a driver.
- Add a second patch that adds a function for parsing endpoints one at a time based on port and endpoint numbers.
Laurent Pinchart (1):
v4l: async: Move async subdev notifier operations to a separate
structure
Sakari Ailus (23):
v4l: fwnode: Move KernelDoc documentation to the header
v4l: async: Remove re-probing support
v4l: async: Use more intuitive names for internal functions
v4l: async: Add V4L2 async documentation to the documentation build
v4l: fwnode: Support generic parsing of graph endpoints in a device
omap3isp: Use generic parser for parsing fwnode endpoints
rcar-vin: Use generic parser for parsing fwnode endpoints
omap3isp: Fix check for our own sub-devices
omap3isp: Print the name of the entity where no source pads could be
found
v4l: async: Introduce helpers for calling async ops callbacks
v4l: async: Register sub-devices before calling bound callback
v4l: async: Allow async notifier register call succeed with no subdevs
v4l: async: Allow binding notifiers to sub-devices
dt: bindings: Add a binding for flash LED devices associated to a
sensor
dt: bindings: Add lens-focus binding for image sensors
ACPI: Document how to refer to LEDs from remote nodes
as3645a: Switch to fwnode property API
v4l: fwnode: Add a helper function for parsing generic references
v4l: fwnode: Add a helper function to obtain device / interger
references
v4l: fwnode: Add convenience function for parsing common external refs
smiapp: Add support for flash and lens devices
dt: bindings: smiapp: Document lens-focus and flash properties
arm: dts: omap3: N9/N950: Add flash references to the camera
Documentation/acpi/dsd/leds.txt | 92 +++++ .../devicetree/bindings/media/i2c/nokia,smia.txt | 2 + .../devicetree/bindings/media/video-interfaces.txt | 10 + Documentation/media/kapi/v4l2-async.rst | 3 + Documentation/media/kapi/v4l2-core.rst | 1 + arch/arm/boot/dts/omap3-n9.dts | 1 + arch/arm/boot/dts/omap3-n950-n9.dtsi | 4 +- arch/arm/boot/dts/omap3-n950.dts | 1 + drivers/leds/leds-as3645a.c | 81 +++-- drivers/media/i2c/smiapp/smiapp-core.c | 18 +- drivers/media/i2c/smiapp/smiapp.h | 4 +- drivers/media/platform/am437x/am437x-vpfe.c | 8 +- drivers/media/platform/atmel/atmel-isc.c | 10 +- drivers/media/platform/atmel/atmel-isi.c | 10 +- drivers/media/platform/davinci/vpif_capture.c | 8 +- drivers/media/platform/davinci/vpif_display.c | 8 +- drivers/media/platform/exynos4-is/media-dev.c | 8 +- drivers/media/platform/omap3isp/isp.c | 127 +++---- drivers/media/platform/omap3isp/isp.h | 5 +- drivers/media/platform/pxa_camera.c | 8 +- drivers/media/platform/qcom/camss-8x16/camss.c | 8 +- drivers/media/platform/rcar-vin/rcar-core.c | 122 +++---- drivers/media/platform/rcar-vin/rcar-dma.c | 10 +- drivers/media/platform/rcar-vin/rcar-v4l2.c | 14 +- drivers/media/platform/rcar-vin/rcar-vin.h | 4 +- drivers/media/platform/rcar_drif.c | 10 +- drivers/media/platform/soc_camera/soc_camera.c | 14 +- drivers/media/platform/stm32/stm32-dcmi.c | 10 +- drivers/media/platform/ti-vpe/cal.c | 8 +- drivers/media/platform/xilinx/xilinx-vipp.c | 8 +- drivers/media/v4l2-core/v4l2-async.c | 345 +++++++++++++----- drivers/media/v4l2-core/v4l2-fwnode.c | 386 +++++++++++++++++---- drivers/staging/media/imx/imx-media-dev.c | 8 +- include/media/v4l2-async.h | 68 +++- include/media/v4l2-fwnode.h | 150 +++++++- 35 files changed, 1135 insertions(+), 439 deletions(-) create mode 100644 Documentation/acpi/dsd/leds.txt create mode 100644 Documentation/media/kapi/v4l2-async.rst
Signature · 80 lines
2.11.0
Laurent Pinchart (1):
v4l: async: Move async subdev notifier operations to a separate
structure
Sakari Ailus (23):
v4l: fwnode: Move KernelDoc documentation to the header
v4l: async: Remove re-probing support
v4l: async: Use more intuitive names for internal functions
v4l: async: Add V4L2 async documentation to the documentation build
v4l: fwnode: Support generic parsing of graph endpoints in a device
omap3isp: Use generic parser for parsing fwnode endpoints
rcar-vin: Use generic parser for parsing fwnode endpoints
omap3isp: Fix check for our own sub-devices
omap3isp: Print the name of the entity where no source pads could be
found
v4l: async: Introduce helpers for calling async ops callbacks
v4l: async: Register sub-devices before calling bound callback
v4l: async: Allow async notifier register call succeed with no subdevs
v4l: async: Allow binding notifiers to sub-devices
dt: bindings: Add a binding for flash LED devices associated to a
sensor
dt: bindings: Add lens-focus binding for image sensors
v4l: fwnode: Add a helper function for parsing generic references
v4l: fwnode: Add a helper function to obtain device / interger
references
v4l: fwnode: Add convenience function for parsing common external refs
dt: bindings: smiapp: Document lens-focus and flash properties
smiapp: Add support for flash and lens devices
ov5670: Add support for flash and lens devices
ov13858: Add support for flash and lens devices
arm: dts: omap3: N9/N950: Add flash references to the camera
.../devicetree/bindings/media/i2c/nokia,smia.txt | 2 +
.../devicetree/bindings/media/video-interfaces.txt | 10 +
Documentation/media/kapi/v4l2-async.rst | 3 +
Documentation/media/kapi/v4l2-core.rst | 1 +
arch/arm/boot/dts/omap3-n9.dts | 1 +
arch/arm/boot/dts/omap3-n950-n9.dtsi | 4 +-
arch/arm/boot/dts/omap3-n950.dts | 1 +
drivers/media/i2c/ov13858.c | 26 +-
drivers/media/i2c/ov5670.c | 33 +-
drivers/media/i2c/smiapp/smiapp-core.c | 38 +-
drivers/media/i2c/smiapp/smiapp.h | 4 +-
drivers/media/platform/am437x/am437x-vpfe.c | 8 +-
drivers/media/platform/atmel/atmel-isc.c | 10 +-
drivers/media/platform/atmel/atmel-isi.c | 10 +-
drivers/media/platform/davinci/vpif_capture.c | 8 +-
drivers/media/platform/davinci/vpif_display.c | 8 +-
drivers/media/platform/exynos4-is/media-dev.c | 8 +-
drivers/media/platform/omap3isp/isp.c | 127 +++----
drivers/media/platform/omap3isp/isp.h | 5 +-
drivers/media/platform/pxa_camera.c | 8 +-
drivers/media/platform/qcom/camss-8x16/camss.c | 8 +-
drivers/media/platform/rcar-vin/rcar-core.c | 122 +++----
drivers/media/platform/rcar-vin/rcar-dma.c | 10 +-
drivers/media/platform/rcar-vin/rcar-v4l2.c | 14 +-
drivers/media/platform/rcar-vin/rcar-vin.h | 4 +-
drivers/media/platform/rcar_drif.c | 10 +-
drivers/media/platform/soc_camera/soc_camera.c | 14 +-
drivers/media/platform/stm32/stm32-dcmi.c | 10 +-
drivers/media/platform/ti-vpe/cal.c | 8 +-
drivers/media/platform/xilinx/xilinx-vipp.c | 8 +-
drivers/media/v4l2-core/v4l2-async.c | 345 +++++++++++++-----
drivers/media/v4l2-core/v4l2-fwnode.c | 386 +++++++++++++++++----
drivers/staging/media/imx/imx-media-dev.c | 8 +-
include/media/v4l2-async.h | 68 +++-
include/media/v4l2-fwnode.h | 150 +++++++-
35 files changed, 1059 insertions(+), 421 deletions(-)
create mode 100644 Documentation/media/kapi/v4l2-async.rst
--
2.11.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.htmlSakari Ailus
maintainerPATCH v10 1/24 v4l: fwnode: Move KernelDoc documentation to the header
In V4L2 the practice is to have the KernelDoc documentation in the header and not in .c source code files. This consequently makes the V4L2 fwnode function documentation part of the Media documentation build.
Also correct the link related function and argument naming in documentation.
--- drivers/media/v4l2-core/v4l2-fwnode.c | 75 -------------------------------- include/media/v4l2-fwnode.h | 81 ++++++++++++++++++++++++++++++++++- 2 files changed, 80 insertions(+), 76 deletions(-)
drivers/media/v4l2-core/v4l2-fwnode.c +0 -75
@@ -181,25 +181,6 @@ v4l2_fwnode_endpoint_parse_csi1_bus(struct fwnode_handle *fwnode, vep->bus_type =V4L2_MBUS_CSI1 ; } -/** -* v4l2_fwnode_endpoint_parse() - parse all fwnode node properties -* @fwnode: pointer to the endpoint's fwnode handle -* @vep: pointer to the V4L2 fwnode data structure -* -* All properties are optional. If none are found, we don't set any flags. This -* means the port has a static configuration and no properties have to be -* specified explicitly. If any properties that identify the bus as parallel -* are found and slave-mode isn't set, we set V4L2_MBUS_MASTER. Similarly, if -* we recognise the bus as serial CSI-2 and clock-noncontinuous isn't set, we -* set the V4L2_MBUS_CSI2_CONTINUOUS_CLOCK flag. The caller should hold a -* reference to @fwnode. -* -* NOTE: This function does not parse properties the size of which is variable -* without a low fixed limit. Please use v4l2_fwnode_endpoint_alloc_parse() in -* new drivers instead. -* -* Return: 0 on success or a negative error code on failure. -*/ int v4l2_fwnode_endpoint_parse (struct fwnode_handle *fwnode,struct v4l2_fwnode_endpoint *vep) {
@@ -239,14 +220,6 @@ int v4l2_fwnode_endpoint_parse(struct fwnode_handle *fwnode, }EXPORT_SYMBOL_GPL (v4l2_fwnode_endpoint_parse); -/* -* v4l2_fwnode_endpoint_free() - free the V4L2 fwnode acquired by -* v4l2_fwnode_endpoint_alloc_parse() -* @vep - the V4L2 fwnode the resources of which are to be released -* -* It is safe to call this function with NULL argument or on a V4L2 fwnode the -* parsing of which failed. -*/ void v4l2_fwnode_endpoint_free (struct v4l2_fwnode_endpoint *vep) {if (IS_ERR_OR_NULL (vep))
@@ -257,29 +230,6 @@ void v4l2_fwnode_endpoint_free(struct v4l2_fwnode_endpoint *vep) }EXPORT_SYMBOL_GPL (v4l2_fwnode_endpoint_free); -/** -* v4l2_fwnode_endpoint_alloc_parse() - parse all fwnode node properties -* @fwnode: pointer to the endpoint's fwnode handle -* -* All properties are optional. If none are found, we don't set any flags. This -* means the port has a static configuration and no properties have to be -* specified explicitly. If any properties that identify the bus as parallel -* are found and slave-mode isn't set, we set V4L2_MBUS_MASTER. Similarly, if -* we recognise the bus as serial CSI-2 and clock-noncontinuous isn't set, we -* set the V4L2_MBUS_CSI2_CONTINUOUS_CLOCK flag. The caller should hold a -* reference to @fwnode. -* -* v4l2_fwnode_endpoint_alloc_parse() has two important differences to -* v4l2_fwnode_endpoint_parse(): -* -* 1. It also parses variable size data. -* -* 2. The memory it has allocated to store the variable size data must be freed -* using v4l2_fwnode_endpoint_free() when no longer needed. -* -* Return: Pointer to v4l2_fwnode_endpoint if successful, on an error pointer -* on error. -*/ struct v4l2_fwnode_endpoint *v4l2_fwnode_endpoint_alloc_parse (struct fwnode_handle *fwnode) {
@@ -322,24 +272,6 @@ struct v4l2_fwnode_endpoint *v4l2_fwnode_endpoint_alloc_parse( }EXPORT_SYMBOL_GPL (v4l2_fwnode_endpoint_alloc_parse); -/** -* v4l2_fwnode_endpoint_parse_link() - parse a link between two endpoints -* @__fwnode: pointer to the endpoint's fwnode at the local end of the link -* @link: pointer to the V4L2 fwnode link data structure -* -* Fill the link structure with the local and remote nodes and port numbers. -* The local_node and remote_node fields are set to point to the local and -* remote port's parent nodes respectively (the port parent node being the -* parent node of the port node if that node isn't a 'ports' node, or the -* grand-parent node of the port node otherwise). -* -* A reference is taken to both the local and remote nodes, the caller must use -* v4l2_fwnode_endpoint_put_link() to drop the references when done with the -* link. -* -* Return: 0 on success, or -ENOLINK if the remote endpoint fwnode can't be -* found. -*/ int v4l2_fwnode_parse_link (struct fwnode_handle *__fwnode,struct v4l2_fwnode_link *link) {
@@ -374,13 +306,6 @@ int v4l2_fwnode_parse_link(struct fwnode_handle *__fwnode, }EXPORT_SYMBOL_GPL (v4l2_fwnode_parse_link); -/** -* v4l2_fwnode_put_link() - drop references to nodes in a link -* @link: pointer to the V4L2 fwnode link data structure -* -* Drop references to the local and remote nodes in the link. This function -* must be called on every link parsed with v4l2_fwnode_parse_link(). -*/ void v4l2_fwnode_put_link (struct v4l2_fwnode_link *link) {fwnode_handle_put (link->local_node);
include/media/v4l2-fwnode.h +80 -1
93 lines not on this page · raw message
Signature · 1 line
2.11.0
Sakari Ailus
maintainerPATCH v10 2/24 v4l: async: Remove re-probing support
In reply to Sakari AilusRemove V4L2 async re-probing support. The re-probing support has been there to support cases where the sub-devices require resources provided by the main driver's hardware to function, such as clocks.
Reprobing has allowed unbinding and again binding the main driver without explicilty unbinding the sub-device drivers. This is certainly not a common need, and the responsibility will be the user's going forward.
An alternative could have been to introduce notifier specific locks. Considering the complexity of the re-probing and that it isn't really a solution to a problem but a workaround, remove re-probing instead.
--- drivers/media/v4l2-core/v4l2-async.c | 54 ------------------------------------ 1 file changed, 54 deletions(-)
drivers/media/v4l2-core/v4l2-async.c +0 -54
@@ -198,78 +198,24 @@ EXPORT_SYMBOL(v4l2_async_notifier_register);void v4l2_async_notifier_unregister (struct v4l2_async_notifier *notifier) {struct v4l2_subdev *sd, *tmp; -unsigned int notif_n_subdev = notifier->num_subdevs; -unsigned int n_subdev =min (notif_n_subdev,V4L2_MAX_SUBDEVS ); -struct device **dev; -int i =0 ;if (!notifier->v4l2_dev)return ; - dev =kvmalloc_array (n_subdev,sizeof (*dev),GFP_KERNEL ); -if (!dev) { -dev_err (notifier->v4l2_dev->dev, -"Failed to allocate device cache!\n" ); - } -mutex_lock (&list_lock);list_del (¬ifier->list);list_for_each_entry_safe (sd, tmp, ¬ifier->done, async_list) { -struct device *d; - - d =get_device (sd->dev); -v4l2_async_cleanup (sd); -/* If we handled USB devices, we'd have to lock the parent too */ -device_release_driver (d); -if (notifier->unbind) notifier->unbind (notifier, sd, sd->asd); - -/* -* Store device at the device cache, in order to call -* put_device() on the final step -*/ -if (dev) - dev[i++] = d; -else -put_device (d); }mutex_unlock (&list_lock); -/* -* Call device_attach() to reprobe devices -* -* NOTE: If dev allocation fails, i is 0, and the whole loop won't be -* executed. -*/ -while (i--) { -struct device *d = dev[i]; - -if (d &&device_attach (d) <0 ) { -const char *name ="(none)" ; -int lock =device_trylock (d); - -if (lock && d->driver) - name = d->driver->name; -dev_err (d,"Failed to re-probe to %s\n" , name); -if (lock) -device_unlock (d); - } -put_device (d); - } -kvfree (dev); - notifier->v4l2_dev =NULL ; - -/* -* Don't care about the waiting list, it is initialised and populated -* upon notifier registration. -*/ }EXPORT_SYMBOL (v4l2_async_notifier_unregister);
Signature · 1 line
2.11.0
Sakari Ailus
maintainerPATCH v10 3/24 v4l: async: Use more intuitive names for internal functions
In reply to Sakari AilusRename internal functions to make the names of the functions better describe what they do.
Old name New name
v4l2_async_test_notify v4l2_async_match_notify
v4l2_async_belongs v4l2_async_find_match
--- drivers/media/v4l2-core/v4l2-async.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-)
drivers/media/v4l2-core/v4l2-async.c +10 -9
@@ -60,8 +60,8 @@ static LIST_HEAD(subdev_list);static LIST_HEAD (notifier_list);static DEFINE_MUTEX (list_lock); -static struct v4l2_async_subdev *v4l2_async_belongs (struct v4l2_async_notifier *notifier, -struct v4l2_subdev *sd) +static struct v4l2_async_subdev *v4l2_async_find_match ( +struct v4l2_async_notifier *notifier,struct v4l2_subdev *sd) {bool (*match)(struct v4l2_subdev *,struct v4l2_async_subdev *);struct v4l2_async_subdev *asd;
@@ -95,9 +95,9 @@ static struct v4l2_async_subdev *v4l2_async_belongs(struct v4l2_async_notifier *return NULL ; } -static int v4l2_async_test_notify (struct v4l2_async_notifier *notifier, -struct v4l2_subdev *sd, -struct v4l2_async_subdev *asd) +static int v4l2_async_match_notify (struct v4l2_async_notifier *notifier, +struct v4l2_subdev *sd, +struct v4l2_async_subdev *asd) {int ret;
@@ -175,11 +175,11 @@ int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev,list_for_each_entry_safe (sd, tmp, &subdev_list, async_list) {int ret; - asd =v4l2_async_belongs (notifier, sd); + asd =v4l2_async_find_match (notifier, sd);if (!asd)continue ; - ret =v4l2_async_test_notify (notifier, sd, asd); + ret =v4l2_async_match_notify (notifier, sd, asd);if (ret <0 ) {mutex_unlock (&list_lock);return ret;
@@ -236,9 +236,10 @@ int v4l2_async_register_subdev(struct v4l2_subdev *sd)INIT_LIST_HEAD (&sd->async_list);list_for_each_entry (notifier, ¬ifier_list, list) { -struct v4l2_async_subdev *asd =v4l2_async_belongs (notifier, sd); +struct v4l2_async_subdev *asd =v4l2_async_find_match (notifier, + sd);if (asd) { -int ret =v4l2_async_test_notify (notifier, sd, asd); +int ret =v4l2_async_match_notify (notifier, sd, asd);mutex_unlock (&list_lock);return ret; }
Signature · 1 line
2.11.0
A message that is not in the archive (sent off-list or not yet received): 20170911080008.21208-1-sakari.ailus-VuQAYsv1563Yd54FQh9/[email protected]
PATCH v10 4/24 v4l: async: Add V4L2 async documentation to the documentation build
The V4L2 async wasn't part of the documentation build. Fix this.
--- Documentation/media/kapi/v4l2-async.rst | 3 +++ Documentation/media/kapi/v4l2-core.rst | 1 + 2 files changed, 4 insertions(+) create mode 100644 Documentation/media/kapi/v4l2-async.rst
Documentation/media/kapi/v4l2-async.rst new file +3 -0
@@ -0,0 +1,3 @@ +V4L2 async kAPI +^^^^^^^^^^^^^^^ +.. kernel-doc:: include/media/v4l2-async.h
Documentation/media/kapi/v4l2-core.rst +1 -0
@@ -19,6 +19,7 @@ Video4Linux devices v4l2-mc v4l2-mediabus v4l2-mem2mem + v4l2-async v4l2-fwnode v4l2-rect v4l2-tuner
Signature · 6 lines
2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v10 6/24 omap3isp: Use generic parser for parsing fwnode endpoints
In reply to a message not in the archiveInstead of using driver implementation, use v4l2_async_notifier_parse_fwnode_endpoints() to parse the fwnode endpoints of the device.
--- drivers/media/platform/omap3isp/isp.c | 115 +++++++++++----------------------- drivers/media/platform/omap3isp/isp.h | 5 +- 2 files changed, 37 insertions(+), 83 deletions(-)
drivers/media/platform/omap3isp/isp.c +36 -79
@@ -2001,6 +2001,7 @@ static int isp_remove(struct platform_device *pdev)__omap3isp_put (isp, false);media_entity_enum_cleanup (&isp->crashed); +v4l2_async_notifier_release (&isp->notifier);return 0 ; }
@@ -2011,44 +2012,41 @@ enum isp_of_phy { ISP_OF_PHY_CSIPHY2, }; -static int isp_fwnode_parse (struct device *dev,struct fwnode_handle *fwnode, -struct isp_async_subdev *isd) +static int isp_fwnode_parse (struct device *dev, +struct v4l2_fwnode_endpoint *vep, +struct v4l2_async_subdev *asd) { +struct isp_async_subdev *isd = + container_of(asd, struct isp_async_subdev, asd);struct isp_bus_cfg *buscfg = &isd->bus; -struct v4l2_fwnode_endpoint vep; -unsigned int i; -int ret;bool csi1 = false; - - ret =v4l2_fwnode_endpoint_parse (fwnode, &vep); -if (ret) -return ret; +unsigned int i;dev_dbg (dev,"parsing endpoint %pOF, interface %u\n" , -to_of_node (fwnode), vep.base.port); +to_of_node (vep->base.local_fwnode), vep->base.port); -switch (vep.base.port) { +switch (vep->base.port) {case ISP_OF_PHY_PARALLEL : buscfg->interface =ISP_INTERFACE_PARALLEL ; buscfg->bus.parallel.data_lane_shift = - vep.bus.parallel.data_shift; + vep->bus.parallel.data_shift; buscfg->bus.parallel.clk_pol = - !!(vep.bus.parallel.flags + !!(vep->bus.parallel.flags &V4L2_MBUS_PCLK_SAMPLE_FALLING ); buscfg->bus.parallel.hs_pol = - !!(vep.bus.parallel.flags &V4L2_MBUS_VSYNC_ACTIVE_LOW ); + !!(vep->bus.parallel.flags &V4L2_MBUS_VSYNC_ACTIVE_LOW ); buscfg->bus.parallel.vs_pol = - !!(vep.bus.parallel.flags &V4L2_MBUS_HSYNC_ACTIVE_LOW ); + !!(vep->bus.parallel.flags &V4L2_MBUS_HSYNC_ACTIVE_LOW ); buscfg->bus.parallel.fld_pol = - !!(vep.bus.parallel.flags &V4L2_MBUS_FIELD_EVEN_LOW ); + !!(vep->bus.parallel.flags &V4L2_MBUS_FIELD_EVEN_LOW ); buscfg->bus.parallel.data_pol = - !!(vep.bus.parallel.flags &V4L2_MBUS_DATA_ACTIVE_LOW ); - buscfg->bus.parallel.bt656 = vep.bus_type ==V4L2_MBUS_BT656 ; + !!(vep->bus.parallel.flags &V4L2_MBUS_DATA_ACTIVE_LOW ); + buscfg->bus.parallel.bt656 = vep->bus_type ==V4L2_MBUS_BT656 ;break ;case ISP_OF_PHY_CSIPHY1 :case ISP_OF_PHY_CSIPHY2 : -switch (vep.bus_type) { +switch (vep->bus_type) {case V4L2_MBUS_CCP2 :case V4L2_MBUS_CSI1 :dev_dbg (dev,"CSI-1/CCP-2 configuration\n" );
@@ -2060,11 +2058,11 @@ static int isp_fwnode_parse(struct device *dev, struct fwnode_handle *fwnode,break ;default :dev_err (dev,"unsupported bus type %u\n" , - vep.bus_type); + vep->bus_type);return -EINVAL ; } -switch (vep.base.port) { +switch (vep->base.port) {case ISP_OF_PHY_CSIPHY1 :if (csi1) buscfg->interface =ISP_INTERFACE_CCP2B_PHY1 ;
@@ -2080,47 +2078,47 @@ static int isp_fwnode_parse(struct device *dev, struct fwnode_handle *fwnode, }if (csi1) { buscfg->bus.ccp2.lanecfg.clk.pos = - vep.bus.mipi_csi1.clock_lane; + vep->bus.mipi_csi1.clock_lane; buscfg->bus.ccp2.lanecfg.clk.pol = - vep.bus.mipi_csi1.lane_polarity[0 ]; + vep->bus.mipi_csi1.lane_polarity[0 ];dev_dbg (dev,"clock lane polarity %u, pos %u\n" , buscfg->bus.ccp2.lanecfg.clk.pol, buscfg->bus.ccp2.lanecfg.clk.pos); buscfg->bus.ccp2.lanecfg.data[0 ].pos = - vep.bus.mipi_csi1.data_lane; + vep->bus.mipi_csi1.data_lane; buscfg->bus.ccp2.lanecfg.data[0 ].pol = - vep.bus.mipi_csi1.lane_polarity[1 ]; + vep->bus.mipi_csi1.lane_polarity[1 ];dev_dbg (dev,"data lane polarity %u, pos %u\n" , buscfg->bus.ccp2.lanecfg.data[0 ].pol, buscfg->bus.ccp2.lanecfg.data[0 ].pos); buscfg->bus.ccp2.strobe_clk_pol = - vep.bus.mipi_csi1.clock_inv; - buscfg->bus.ccp2.phy_layer = vep.bus.mipi_csi1.strobe; + vep->bus.mipi_csi1.clock_inv; + buscfg->bus.ccp2.phy_layer = vep->bus.mipi_csi1.strobe; buscfg->bus.ccp2.ccp2_mode = - vep.bus_type ==V4L2_MBUS_CCP2 ; + vep->bus_type ==V4L2_MBUS_CCP2 ; buscfg->bus.ccp2.vp_clk_pol =1 ; buscfg->bus.ccp2.crc =1 ; }else { buscfg->bus.csi2.lanecfg.clk.pos = - vep.bus.mipi_csi2.clock_lane; + vep->bus.mipi_csi2.clock_lane; buscfg->bus.csi2.lanecfg.clk.pol = - vep.bus.mipi_csi2.lane_polarities[0 ]; + vep->bus.mipi_csi2.lane_polarities[0 ];dev_dbg (dev,"clock lane polarity %u, pos %u\n" , buscfg->bus.csi2.lanecfg.clk.pol, buscfg->bus.csi2.lanecfg.clk.pos); buscfg->bus.csi2.num_data_lanes = - vep.bus.mipi_csi2.num_data_lanes; + vep->bus.mipi_csi2.num_data_lanes;for (i =0 ; i < buscfg->bus.csi2.num_data_lanes; i++) { buscfg->bus.csi2.lanecfg.data[i].pos = - vep.bus.mipi_csi2.data_lanes[i]; + vep->bus.mipi_csi2.data_lanes[i]; buscfg->bus.csi2.lanecfg.data[i].pol = - vep.bus.mipi_csi2.lane_polarities[i +1 ]; + vep->bus.mipi_csi2.lane_polarities[i +1 ]; dev_dbg(dev, "data lane %u polarity %u, pos %u\n", i, buscfg->bus.csi2.lanecfg.data[i].pol,
@@ -2137,57 +2135,13 @@ static int isp_fwnode_parse(struct device *dev, struct fwnode_handle *fwnode,default :dev_warn (dev,"%pOF: invalid interface %u\n" , -to_of_node (fwnode), vep.base.port); +to_of_node (vep->base.local_fwnode), vep->base.port);return -EINVAL ; }return 0 ; } -static int isp_fwnodes_parse (struct device *dev, -struct v4l2_async_notifier *notifier) -{ -struct fwnode_handle *fwnode =NULL ; - - notifier->subdevs =devm_kcalloc ( - dev,ISP_MAX_SUBDEVS ,sizeof (*notifier->subdevs),GFP_KERNEL ); -if (!notifier->subdevs) -return -ENOMEM ; - -while (notifier->num_subdevs <ISP_MAX_SUBDEVS && - (fwnode =fwnode_graph_get_next_endpoint ( -of_fwnode_handle (dev->of_node), fwnode))) { -struct isp_async_subdev *isd; - - isd =devm_kzalloc (dev,sizeof (*isd),GFP_KERNEL ); -if (!isd) - goto error; - -if (isp_fwnode_parse (dev, fwnode, isd)) { -devm_kfree (dev, isd); -continue ; - } - - notifier->subdevs[notifier->num_subdevs] = &isd->asd; - - isd->asd.match.fwnode.fwnode = -fwnode_graph_get_remote_port_parent (fwnode); -if (!isd->asd.match.fwnode.fwnode) { -dev_warn (dev,"bad remote port parent\n" ); - goto error; - } - - isd->asd.match_type =V4L2_ASYNC_MATCH_FWNODE ; - notifier->num_subdevs++; - } - -return notifier->num_subdevs; - -error: -fwnode_handle_put (fwnode); -return -EINVAL ; -} -static int isp_subdev_notifier_complete (struct v4l2_async_notifier *async) { struct isp_device *isp = container_of(async, struct isp_device,
@@ -2256,7 +2210,9 @@ static int isp_probe(struct platform_device *pdev)if (ret)return ret; - ret =isp_fwnodes_parse (&pdev->dev, &isp->notifier); + ret =v4l2_async_notifier_parse_fwnode_endpoints ( + &pdev->dev, &isp->notifier,sizeof (struct isp_async_subdev ), + isp_fwnode_parse);if (ret <0 )return ret;
@@ -2407,6 +2363,7 @@ static int isp_probe(struct platform_device *pdev)__omap3isp_put (isp, false); error:mutex_destroy (&isp->isp_mutex); +v4l2_async_notifier_release (&isp->notifier);return ret; }
drivers/media/platform/omap3isp/isp.h +1 -4
@@ -220,14 +220,11 @@ struct isp_device {unsigned int sbl_resources;unsigned int subclk_resources; - -#define ISP_MAX_SUBDEVS 8 -struct v4l2_subdev *subdevs[ISP_MAX_SUBDEVS ]; };struct isp_async_subdev { -struct isp_bus_cfg bus;struct v4l2_async_subdev asd; +struct isp_bus_cfg bus; };#define v4l2_subdev_to_bus_cfg (sd) \
Signature · 6 lines
2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v10 7/24 rcar-vin: Use generic parser for parsing fwnode endpoints
In reply to a message not in the archiveInstead of using driver implementation, use v4l2_async_notifier_parse_fwnode_endpoints() to parse the fwnode endpoints of the device.
--- drivers/media/platform/rcar-vin/rcar-core.c | 112 +++++++++------------------- drivers/media/platform/rcar-vin/rcar-dma.c | 10 +-- drivers/media/platform/rcar-vin/rcar-v4l2.c | 14 ++-- drivers/media/platform/rcar-vin/rcar-vin.h | 4 +- 4 files changed, 48 insertions(+), 92 deletions(-)
drivers/media/platform/rcar-vin/rcar-core.c +34 -78
@@ -21,6 +21,7 @@#include <linux/platform_device.h> #include <linux/pm_runtime.h> +#include <media/v4l2-async.h> #include <media/v4l2-fwnode.h> #include "rcar-vin.h"
@@ -77,14 +78,14 @@ static int rvin_digital_notify_complete(struct v4l2_async_notifier *notifier)int ret;/* Verify subdevices mbus format */ -if (!rvin_mbus_supported (&vin->digital)) { +if (!rvin_mbus_supported (vin->digital)) {vin_err (vin,"Unsupported media bus format for %s\n" , - vin->digital.subdev->name); + vin->digital->subdev->name);return -EINVAL ; }vin_dbg (vin,"Found media bus format for %s: %d\n" , - vin->digital.subdev->name, vin->digital.code); + vin->digital->subdev->name, vin->digital->code); ret =v4l2_device_register_subdev_nodes (&vin->v4l2_dev);if (ret <0 ) {
@@ -103,7 +104,7 @@ static void rvin_digital_notify_unbind(struct v4l2_async_notifier *notifier,vin_dbg (vin,"unbind digital subdev %s\n" , subdev->name);rvin_v4l2_remove (vin); - vin->digital.subdev =NULL ; + vin->digital->subdev =NULL ; } static int rvin_digital_notify_bound(struct v4l2_async_notifier *notifier,
@@ -120,117 +121,70 @@ static int rvin_digital_notify_bound(struct v4l2_async_notifier *notifier, ret =rvin_find_pad (subdev,MEDIA_PAD_FL_SOURCE );if (ret <0 )return ret; - vin->digital.source_pad = ret; + vin->digital->source_pad = ret; ret =rvin_find_pad (subdev,MEDIA_PAD_FL_SINK ); - vin->digital.sink_pad = ret <0 ?0 : ret; + vin->digital->sink_pad = ret <0 ?0 : ret; - vin->digital.subdev = subdev; + vin->digital->subdev = subdev;vin_dbg (vin,"bound subdev %s source pad: %u sink pad: %u\n" , - subdev->name, vin->digital.source_pad, - vin->digital.sink_pad); + subdev->name, vin->digital->source_pad, + vin->digital->sink_pad);return 0 ; } -static int rvin_digitial_parse_v4l2 (struct rvin_dev *vin, -struct device_node *ep, -struct v4l2_mbus_config *mbus_cfg) +static int rvin_digital_parse_v4l2 (struct device *dev, +struct v4l2_fwnode_endpoint *vep, +struct v4l2_async_subdev *asd) { -struct v4l2_fwnode_endpoint v4l2_ep; -int ret; +struct rvin_dev *vin =dev_get_drvdata (dev); +struct rvin_graph_entity *rvge = + container_of(asd, struct rvin_graph_entity, asd); - ret =v4l2_fwnode_endpoint_parse (of_fwnode_handle (ep), &v4l2_ep); -if (ret) { -vin_err (vin,"Could not parse v4l2 endpoint\n" ); -return -EINVAL ; - } +if (vep->base.port || vep->base.id) +return -ENOTCONN ; - mbus_cfg->type = v4l2_ep.bus_type; + rvge->mbus_cfg.type = vep->bus_type; -switch (mbus_cfg->type) { +switch (rvge->mbus_cfg.type) {case V4L2_MBUS_PARALLEL :vin_dbg (vin,"Found PARALLEL media bus\n" ); - mbus_cfg->flags = v4l2_ep.bus.parallel.flags; + rvge->mbus_cfg.flags = vep->bus.parallel.flags;break ;case V4L2_MBUS_BT656 :vin_dbg (vin,"Found BT656 media bus\n" ); - mbus_cfg->flags =0 ; + rvge->mbus_cfg.flags =0 ;break ;default :vin_err (vin,"Unknown media bus type\n" );return -EINVAL ; } -return 0 ; -} - -static int rvin_digital_graph_parse (struct rvin_dev *vin) -{ -struct device_node *ep, *np; -int ret; - - vin->digital.asd.match.fwnode.fwnode =NULL ; - vin->digital.subdev =NULL ; - -/* -* Port 0 id 0 is local digital input, try to get it. -* Not all instances can or will have this, that is OK -*/ - ep =of_graph_get_endpoint_by_regs (vin->dev->of_node,0 ,0 ); -if (!ep) -return 0 ; - - np =of_graph_get_remote_port_parent (ep); -if (!np) { -vin_err (vin,"No remote parent for digital input\n" ); -of_node_put (ep); -return -EINVAL ; - } -of_node_put (np); - - ret =rvin_digitial_parse_v4l2 (vin, ep, &vin->digital.mbus_cfg); -of_node_put (ep); -if (ret) -return ret; - - vin->digital.asd.match.fwnode.fwnode =of_fwnode_handle (np); - vin->digital.asd.match_type =V4L2_ASYNC_MATCH_FWNODE ; + vin->digital = rvge;return 0 ; }static int rvin_digital_graph_init (struct rvin_dev *vin) { -struct v4l2_async_subdev **subdevs =NULL ;int ret; - ret =rvin_digital_graph_parse (vin); + ret =v4l2_async_notifier_parse_fwnode_endpoints ( + vin->dev, &vin->notifier, +sizeof (struct rvin_graph_entity ), rvin_digital_parse_v4l2);if (ret)return ret; -if (!vin->digital.asd.match.fwnode.fwnode) { -vin_dbg (vin,"No digital subdevice found\n" ); -return -ENODEV ; - } - -/* Register the subdevices notifier. */ - subdevs =devm_kzalloc (vin->dev,sizeof (*subdevs),GFP_KERNEL ); -if (subdevs ==NULL ) -return -ENOMEM ; - - subdevs[0 ] = &vin->digital.asd; - -vin_dbg (vin,"Found digital subdevice %pOF\n" , -to_of_node (subdevs[0 ]->match.fwnode.fwnode)); +if (vin->digital) +vin_dbg (vin,"Found digital subdevice %pOF\n" , +to_of_node ( + vin->digital->asd.match.fwnode.fwnode)); - vin->notifier.num_subdevs =1 ; - vin->notifier.subdevs = subdevs; vin->notifier.bound = rvin_digital_notify_bound; vin->notifier.unbind = rvin_digital_notify_unbind; vin->notifier.complete = rvin_digital_notify_complete; - ret =v4l2_async_notifier_register (&vin->v4l2_dev, &vin->notifier);if (ret <0 ) {vin_err (vin,"Notifier registration failed\n" );
@@ -290,6 +244,8 @@ static int rcar_vin_probe(struct platform_device *pdev)if (ret)return ret; +platform_set_drvdata (pdev, vin); + ret =rvin_digital_graph_init (vin);if (ret <0 ) goto error;
@@ -297,11 +253,10 @@ static int rcar_vin_probe(struct platform_device *pdev)pm_suspend_ignore_children (&pdev->dev, true);pm_runtime_enable (&pdev->dev); -platform_set_drvdata (pdev, vin); -return 0 ; error:rvin_dma_remove (vin); +v4l2_async_notifier_release (&vin->notifier);return ret; }
@@ -313,6 +268,7 @@ static int rcar_vin_remove(struct platform_device *pdev)pm_runtime_disable (&pdev->dev);v4l2_async_notifier_unregister (&vin->notifier); +v4l2_async_notifier_release (&vin->notifier);rvin_dma_remove (vin);
drivers/media/platform/rcar-vin/rcar-dma.c +5 -5
@@ -183,7 +183,7 @@ static int rvin_setup(struct rvin_dev *vin)/* * Input interface */ -switch (vin->digital.code) { +switch (vin->digital->code) {case MEDIA_BUS_FMT_YUYV8_1X16 :/* BT.601/BT.1358 16bit YCbCr422 */ vnmc |=VNMC_INF_YUV16 ;
@@ -191,7 +191,7 @@ static int rvin_setup(struct rvin_dev *vin)break ;case MEDIA_BUS_FMT_UYVY8_2X8 :/* BT.656 8bit YCbCr422 or BT.601 8bit YCbCr422 */ - vnmc |= vin->digital.mbus_cfg.type ==V4L2_MBUS_BT656 ? + vnmc |= vin->digital->mbus_cfg.type ==V4L2_MBUS_BT656 ?VNMC_INF_YUV8_BT656 :VNMC_INF_YUV8_BT601 ; input_is_yuv = true;break ;
@@ -200,7 +200,7 @@ static int rvin_setup(struct rvin_dev *vin)break ;case MEDIA_BUS_FMT_UYVY10_2X10 :/* BT.656 10bit YCbCr422 or BT.601 10bit YCbCr422 */ - vnmc |= vin->digital.mbus_cfg.type ==V4L2_MBUS_BT656 ? + vnmc |= vin->digital->mbus_cfg.type ==V4L2_MBUS_BT656 ?VNMC_INF_YUV10_BT656 :VNMC_INF_YUV10_BT601 ; input_is_yuv = true;break ;
@@ -212,11 +212,11 @@ static int rvin_setup(struct rvin_dev *vin) dmr2 =VNDMR2_FTEV |VNDMR2_VLV (1 );/* Hsync Signal Polarity Select */ -if (!(vin->digital.mbus_cfg.flags &V4L2_MBUS_HSYNC_ACTIVE_LOW )) +if (!(vin->digital->mbus_cfg.flags &V4L2_MBUS_HSYNC_ACTIVE_LOW )) dmr2 |=VNDMR2_HPS ;/* Vsync Signal Polarity Select */ -if (!(vin->digital.mbus_cfg.flags &V4L2_MBUS_VSYNC_ACTIVE_LOW )) +if (!(vin->digital->mbus_cfg.flags &V4L2_MBUS_VSYNC_ACTIVE_LOW )) dmr2 |=VNDMR2_VPS ;/*
drivers/media/platform/rcar-vin/rcar-v4l2.c +7 -7
@@ -111,7 +111,7 @@ static int rvin_reset_format(struct rvin_dev *vin)struct v4l2_mbus_framefmt *mf = &fmt.format;int ret; - fmt.pad = vin->digital.source_pad; + fmt.pad = vin->digital->source_pad; ret =v4l2_subdev_call (vin_to_source (vin), pad, get_fmt,NULL , &fmt);if (ret)
@@ -172,13 +172,13 @@ static int __rvin_try_format_source(struct rvin_dev *vin, sd =vin_to_source (vin); -v4l2_fill_mbus_format (&format.format, pix, vin->digital.code); +v4l2_fill_mbus_format (&format.format, pix, vin->digital->code); pad_cfg =v4l2_subdev_alloc_pad_config (sd);if (pad_cfg ==NULL )return -ENOMEM ; - format.pad = vin->digital.source_pad; + format.pad = vin->digital->source_pad; field = pix->field;
@@ -555,7 +555,7 @@ static int rvin_enum_dv_timings(struct file *file, void *priv_fh,if (timings->pad)return -EINVAL ; - timings->pad = vin->digital.sink_pad; + timings->pad = vin->digital->sink_pad; ret =v4l2_subdev_call (sd, pad, enum_dv_timings, timings);
@@ -607,7 +607,7 @@ static int rvin_dv_timings_cap(struct file *file, void *priv_fh,if (cap->pad)return -EINVAL ; - cap->pad = vin->digital.sink_pad; + cap->pad = vin->digital->sink_pad; ret =v4l2_subdev_call (sd, pad, dv_timings_cap, cap);
@@ -625,7 +625,7 @@ static int rvin_g_edid(struct file *file, void *fh, struct v4l2_edid *edid)if (edid->pad)return -EINVAL ; - edid->pad = vin->digital.sink_pad; + edid->pad = vin->digital->sink_pad; ret =v4l2_subdev_call (sd, pad, get_edid, edid);
@@ -643,7 +643,7 @@ static int rvin_s_edid(struct file *file, void *fh, struct v4l2_edid *edid)if (edid->pad)return -EINVAL ; - edid->pad = vin->digital.sink_pad; + edid->pad = vin->digital->sink_pad; ret =v4l2_subdev_call (sd, pad, set_edid, edid);
drivers/media/platform/rcar-vin/rcar-vin.h +2 -2
@@ -126,7 +126,7 @@ struct rvin_dev {struct v4l2_device v4l2_dev;struct v4l2_ctrl_handler ctrl_handler;struct v4l2_async_notifier notifier; -struct rvin_graph_entity digital; +struct rvin_graph_entity *digital;struct mutex lock;struct vb2_queue queue;
@@ -145,7 +145,7 @@ struct rvin_dev {struct v4l2_rect compose; }; -#define vin_to_source (vin) vin->digital.subdev +#define vin_to_source (vin) ((vin)->digital->subdev)/* Debug */ #define vin_dbg(d, fmt, arg...) dev_dbg(d->dev, fmt, ##arg)
Signature · 6 lines
2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v10 10/24 v4l: async: Move async subdev notifier operations to a separate structure
In reply to a message not in the archiveFrom: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/[email protected]>
The async subdev notifier .bound(), .unbind() and .complete() operations are function pointers stored directly in the v4l2_async_subdev structure. As the structure isn't immutable, this creates a potential security risk as the function pointers are mutable.
To fix this, move the function pointers to a new v4l2_async_subdev_operations structure that can be made const in drivers.
--- drivers/media/platform/am437x/am437x-vpfe.c | 8 +++++-- drivers/media/platform/atmel/atmel-isc.c | 10 ++++++--- drivers/media/platform/atmel/atmel-isi.c | 10 ++++++--- drivers/media/platform/davinci/vpif_capture.c | 8 +++++-- drivers/media/platform/davinci/vpif_display.c | 8 +++++-- drivers/media/platform/exynos4-is/media-dev.c | 8 +++++-- drivers/media/platform/omap3isp/isp.c | 6 +++++- drivers/media/platform/pxa_camera.c | 8 +++++-- drivers/media/platform/qcom/camss-8x16/camss.c | 8 +++++-- drivers/media/platform/rcar-vin/rcar-core.c | 10 ++++++--- drivers/media/platform/rcar_drif.c | 10 ++++++--- drivers/media/platform/soc_camera/soc_camera.c | 14 +++++++------ drivers/media/platform/stm32/stm32-dcmi.c | 10 ++++++--- drivers/media/platform/ti-vpe/cal.c | 8 +++++-- drivers/media/platform/xilinx/xilinx-vipp.c | 8 +++++-- drivers/media/v4l2-core/v4l2-async.c | 20 +++++++++--------- drivers/staging/media/imx/imx-media-dev.c | 8 +++++-- include/media/v4l2-async.h | 29 +++++++++++++++++--------- 18 files changed, 131 insertions(+), 60 deletions(-)
drivers/media/platform/am437x/am437x-vpfe.c +6 -2
@@ -2417,6 +2417,11 @@ static int vpfe_async_complete(struct v4l2_async_notifier *notifier)return vpfe_probe_complete (vpfe); } +static const struct v4l2_async_notifier_operations vpfe_async_ops = { + .bound = vpfe_async_bound, + .complete = vpfe_async_complete, +}; +static struct vpfe_config *vpfe_get_pdata (struct platform_device *pdev) {
@@ -2590,8 +2595,7 @@ static int vpfe_probe(struct platform_device *pdev) vpfe->notifier.subdevs = vpfe->cfg->asd; vpfe->notifier.num_subdevs =ARRAY_SIZE (vpfe->cfg->asd); - vpfe->notifier.bound = vpfe_async_bound; - vpfe->notifier.complete = vpfe_async_complete; + vpfe->notifier.ops = &vpfe_async_ops; ret =v4l2_async_notifier_register (&vpfe->v4l2_dev, &vpfe->notifier);if (ret) {
drivers/media/platform/atmel/atmel-isc.c +7 -3
@@ -1639,6 +1639,12 @@ static int isc_async_complete(struct v4l2_async_notifier *notifier)return 0 ; } +static const struct v4l2_async_notifier_operations isc_async_ops = { + .bound = isc_async_bound, + .unbind = isc_async_unbind, + .complete = isc_async_complete, +}; +static void isc_subdev_cleanup (struct isc_device *isc) {struct isc_subdev_entity *subdev_entity;
@@ -1851,9 +1857,7 @@ static int atmel_isc_probe(struct platform_device *pdev)list_for_each_entry (subdev_entity, &isc->subdev_entities, list) { subdev_entity->notifier.subdevs = &subdev_entity->asd; subdev_entity->notifier.num_subdevs =1 ; - subdev_entity->notifier.bound = isc_async_bound; - subdev_entity->notifier.unbind = isc_async_unbind; - subdev_entity->notifier.complete = isc_async_complete; + subdev_entity->notifier.ops = &isc_async_ops; ret =v4l2_async_notifier_register (&isc->v4l2_dev, &subdev_entity->notifier);
drivers/media/platform/atmel/atmel-isi.c +7 -3
@@ -1105,6 +1105,12 @@ static int isi_graph_notify_bound(struct v4l2_async_notifier *notifier,return 0 ; } +static const struct v4l2_async_notifier_operations isi_graph_notify_ops = { + .bound = isi_graph_notify_bound, + .unbind = isi_graph_notify_unbind, + .complete = isi_graph_notify_complete, +}; +static int isi_graph_parse (struct atmel_isi *isi,struct device_node *node) {struct device_node *ep =NULL ;
@@ -1152,9 +1158,7 @@ static int isi_graph_init(struct atmel_isi *isi) isi->notifier.subdevs = subdevs; isi->notifier.num_subdevs =1 ; - isi->notifier.bound = isi_graph_notify_bound; - isi->notifier.unbind = isi_graph_notify_unbind; - isi->notifier.complete = isi_graph_notify_complete; + isi->notifier.ops = &isi_graph_notify_ops; ret =v4l2_async_notifier_register (&isi->v4l2_dev, &isi->notifier);if (ret <0 ) {
drivers/media/platform/davinci/vpif_capture.c +6 -2
@@ -1500,6 +1500,11 @@ static int vpif_async_complete(struct v4l2_async_notifier *notifier)return vpif_probe_complete (); } +static const struct v4l2_async_notifier_operations vpif_async_ops = { + .bound = vpif_async_bound, + .complete = vpif_async_complete, +}; +static struct vpif_capture_config *vpif_capture_get_pdata (struct platform_device *pdev) {
@@ -1691,8 +1696,7 @@ static __init int vpif_probe(struct platform_device *pdev) }else { vpif_obj.notifier.subdevs = vpif_obj.config->asd; vpif_obj.notifier.num_subdevs = vpif_obj.config->asd_sizes[0 ]; - vpif_obj.notifier.bound = vpif_async_bound; - vpif_obj.notifier.complete = vpif_async_complete; + vpif_obj.notifier.ops = &vpif_async_ops; err =v4l2_async_notifier_register (&vpif_obj.v4l2_dev, &vpif_obj.notifier);if (err) {
drivers/media/platform/davinci/vpif_display.c +6 -2
@@ -1232,6 +1232,11 @@ static int vpif_async_complete(struct v4l2_async_notifier *notifier)return vpif_probe_complete (); } +static const struct v4l2_async_notifier_operations vpif_async_ops = { + .bound = vpif_async_bound, + .complete = vpif_async_complete, +}; +/* * vpif_probe: This function creates device entries by register itself to the * V4L2 driver and initializes fields of each channel objects
@@ -1313,8 +1318,7 @@ static __init int vpif_probe(struct platform_device *pdev) }else { vpif_obj.notifier.subdevs = vpif_obj.config->asd; vpif_obj.notifier.num_subdevs = vpif_obj.config->asd_sizes[0 ]; - vpif_obj.notifier.bound = vpif_async_bound; - vpif_obj.notifier.complete = vpif_async_complete; + vpif_obj.notifier.ops = &vpif_async_ops; err =v4l2_async_notifier_register (&vpif_obj.v4l2_dev, &vpif_obj.notifier);if (err) {
drivers/media/platform/exynos4-is/media-dev.c +6 -2
@@ -1405,6 +1405,11 @@ static int subdev_notifier_complete(struct v4l2_async_notifier *notifier)return media_device_register (&fmd->media_dev); } +static const struct v4l2_async_notifier_operations subdev_notifier_ops = { + .bound = subdev_notifier_bound, + .complete = subdev_notifier_complete, +}; +static int fimc_md_probe (struct platform_device *pdev) {struct device *dev = &pdev->dev;
@@ -1479,8 +1484,7 @@ static int fimc_md_probe(struct platform_device *pdev)if (fmd->num_sensors >0 ) { fmd->subdev_notifier.subdevs = fmd->async_subdevs; fmd->subdev_notifier.num_subdevs = fmd->num_sensors; - fmd->subdev_notifier.bound = subdev_notifier_bound; - fmd->subdev_notifier.complete = subdev_notifier_complete; + fmd->subdev_notifier.ops = &subdev_notifier_ops; fmd->num_sensors =0 ; ret = v4l2_async_notifier_register(&fmd->v4l2_dev,
drivers/media/platform/omap3isp/isp.c +5 -1
@@ -2171,6 +2171,10 @@ static int isp_subdev_notifier_complete(struct v4l2_async_notifier *async)return media_device_register (&isp->media_dev); } +static const struct v4l2_async_notifier_operations isp_subdev_notifier_ops = { + .complete = isp_subdev_notifier_complete, +}; +/* * isp_probe - Probe ISP platform device * @pdev: Pointer to ISP platform device
@@ -2341,7 +2345,7 @@ static int isp_probe(struct platform_device *pdev)if (ret <0 ) goto error_register_entities; - isp->notifier.complete = isp_subdev_notifier_complete; + isp->notifier.ops = &isp_subdev_notifier_ops; ret =v4l2_async_notifier_register (&isp->v4l2_dev, &isp->notifier);if (ret)
drivers/media/platform/pxa_camera.c +6 -2
@@ -2221,6 +2221,11 @@ static void pxa_camera_sensor_unbind(struct v4l2_async_notifier *notifier,mutex_unlock (&pcdev->mlock); } +static const struct v4l2_async_notifier_operations pxa_camera_sensor_ops = { + .bound = pxa_camera_sensor_bound, + .unbind = pxa_camera_sensor_unbind, +}; +/* * Driver probe, remove, suspend and resume operations */
@@ -2489,8 +2494,7 @@ static int pxa_camera_probe(struct platform_device *pdev) pcdev->asds[0 ] = &pcdev->asd; pcdev->notifier.subdevs = pcdev->asds; pcdev->notifier.num_subdevs =1 ; - pcdev->notifier.bound = pxa_camera_sensor_bound; - pcdev->notifier.unbind = pxa_camera_sensor_unbind; + pcdev->notifier.ops = &pxa_camera_sensor_ops;if (!of_have_populated_dt ()) pcdev->asd.match_type =V4L2_ASYNC_MATCH_I2C ;
drivers/media/platform/qcom/camss-8x16/camss.c +6 -2
@@ -601,6 +601,11 @@ static int camss_subdev_notifier_complete(struct v4l2_async_notifier *async)return media_device_register (&camss->media_dev); } +static const struct v4l2_async_notifier_operations camss_subdev_notifier_ops = { + .bound = camss_subdev_notifier_bound, + .complete = camss_subdev_notifier_complete, +}; +static const struct media_device_ops camss_media_ops = { .link_notify = v4l2_pipeline_link_notify, };
@@ -655,8 +660,7 @@ static int camss_probe(struct platform_device *pdev) goto err_register_entities;if (camss->notifier.num_subdevs) { - camss->notifier.bound = camss_subdev_notifier_bound; - camss->notifier.complete = camss_subdev_notifier_complete; + camss->notifier.ops = &camss_subdev_notifier_ops; ret =v4l2_async_notifier_register (&camss->v4l2_dev, &camss->notifier);
drivers/media/platform/rcar-vin/rcar-core.c +7 -3
@@ -134,6 +134,12 @@ static int rvin_digital_notify_bound(struct v4l2_async_notifier *notifier,return 0 ; } +static const struct v4l2_async_notifier_operations rvin_digital_notify_ops = { + .bound = rvin_digital_notify_bound, + .unbind = rvin_digital_notify_unbind, + .complete = rvin_digital_notify_complete, +}; + static int rvin_digital_parse_v4l2(struct device *dev, struct v4l2_fwnode_endpoint *vep,
@@ -182,9 +188,7 @@ static int rvin_digital_graph_init(struct rvin_dev *vin)to_of_node ( vin->digital->asd.match.fwnode.fwnode)); - vin->notifier.bound = rvin_digital_notify_bound; - vin->notifier.unbind = rvin_digital_notify_unbind; - vin->notifier.complete = rvin_digital_notify_complete; + vin->notifier.ops = &rvin_digital_notify_ops; ret =v4l2_async_notifier_register (&vin->v4l2_dev, &vin->notifier);if (ret <0 ) {vin_err (vin,"Notifier registration failed\n" );
drivers/media/platform/rcar_drif.c +7 -3
@@ -1185,6 +1185,12 @@ static int rcar_drif_notify_complete(struct v4l2_async_notifier *notifier)return ret; } +static const struct v4l2_async_notifier_operations rcar_drif_notify_ops = { + .bound = rcar_drif_notify_bound, + .unbind = rcar_drif_notify_unbind, + .complete = rcar_drif_notify_complete, +}; +/* Read endpoint properties */ static void rcar_drif_get_ep_properties (struct rcar_drif_sdr *sdr,struct fwnode_handle *fwnode)
@@ -1347,9 +1353,7 @@ static int rcar_drif_sdr_probe(struct rcar_drif_sdr *sdr)if (ret) goto error; - sdr->notifier.bound = rcar_drif_notify_bound; - sdr->notifier.unbind = rcar_drif_notify_unbind; - sdr->notifier.complete = rcar_drif_notify_complete; + sdr->notifier.ops = &rcar_drif_notify_ops;/* Register notifier */ ret =v4l2_async_notifier_register (&sdr->v4l2_dev, &sdr->notifier);
drivers/media/platform/soc_camera/soc_camera.c +8 -6
@@ -1391,6 +1391,12 @@ static int soc_camera_async_complete(struct v4l2_async_notifier *notifier)return 0 ; } +static const struct v4l2_async_notifier_operations soc_camera_async_ops = { + .bound = soc_camera_async_bound, + .unbind = soc_camera_async_unbind, + .complete = soc_camera_async_complete, +}; +static int scan_async_group (struct soc_camera_host *ici,struct v4l2_async_subdev **asd,unsigned int size) {
@@ -1437,9 +1443,7 @@ static int scan_async_group(struct soc_camera_host *ici, sasc->notifier.subdevs = asd; sasc->notifier.num_subdevs = size; - sasc->notifier.bound = soc_camera_async_bound; - sasc->notifier.unbind = soc_camera_async_unbind; - sasc->notifier.complete = soc_camera_async_complete; + sasc->notifier.ops = &soc_camera_async_ops; icd->sasc = sasc; icd->parent = ici->v4l2_dev.dev;
@@ -1537,9 +1541,7 @@ static int soc_of_bind(struct soc_camera_host *ici, sasc->notifier.subdevs = &info->subdev; sasc->notifier.num_subdevs =1 ; - sasc->notifier.bound = soc_camera_async_bound; - sasc->notifier.unbind = soc_camera_async_unbind; - sasc->notifier.complete = soc_camera_async_complete; + sasc->notifier.ops = &soc_camera_async_ops; icd->sasc = sasc; icd->parent = ici->v4l2_dev.dev;
drivers/media/platform/stm32/stm32-dcmi.c +7 -3
@@ -1495,6 +1495,12 @@ static int dcmi_graph_notify_bound(struct v4l2_async_notifier *notifier,return 0 ; } +static const struct v4l2_async_notifier_operations dcmi_graph_notify_ops = { + .bound = dcmi_graph_notify_bound, + .unbind = dcmi_graph_notify_unbind, + .complete = dcmi_graph_notify_complete, +}; +static int dcmi_graph_parse (struct stm32_dcmi *dcmi,struct device_node *node) {struct device_node *ep =NULL ;
@@ -1542,9 +1548,7 @@ static int dcmi_graph_init(struct stm32_dcmi *dcmi) dcmi->notifier.subdevs = subdevs; dcmi->notifier.num_subdevs =1 ; - dcmi->notifier.bound = dcmi_graph_notify_bound; - dcmi->notifier.unbind = dcmi_graph_notify_unbind; - dcmi->notifier.complete = dcmi_graph_notify_complete; + dcmi->notifier.ops = &dcmi_graph_notify_ops; ret =v4l2_async_notifier_register (&dcmi->v4l2_dev, &dcmi->notifier);if (ret <0 ) {
drivers/media/platform/ti-vpe/cal.c +6 -2
@@ -1522,6 +1522,11 @@ static int cal_async_complete(struct v4l2_async_notifier *notifier)return 0 ; } +static const struct v4l2_async_notifier_operations cal_async_ops = { + .bound = cal_async_bound, + .complete = cal_async_complete, +}; +static int cal_complete_ctx (struct cal_ctx *ctx) {struct video_device *vfd;
@@ -1736,8 +1741,7 @@ static int of_cal_create_instance(struct cal_ctx *ctx, int inst) ctx->asd_list[0 ] = asd; ctx->notifier.subdevs = ctx->asd_list; ctx->notifier.num_subdevs =1 ; - ctx->notifier.bound = cal_async_bound; - ctx->notifier.complete = cal_async_complete; + ctx->notifier.ops = &cal_async_ops; ret =v4l2_async_notifier_register (&ctx->v4l2_dev, &ctx->notifier);if (ret) {
drivers/media/platform/xilinx/xilinx-vipp.c +6 -2
@@ -351,6 +351,11 @@ static int xvip_graph_notify_bound(struct v4l2_async_notifier *notifier,return -EINVAL ; } +static const struct v4l2_async_notifier_operations xvip_graph_notify_ops = { + .bound = xvip_graph_notify_bound, + .complete = xvip_graph_notify_complete, +}; +static int xvip_graph_parse_one (struct xvip_composite_device *xdev,struct device_node *node) {
@@ -548,8 +553,7 @@ static int xvip_graph_init(struct xvip_composite_device *xdev) xdev->notifier.subdevs = subdevs; xdev->notifier.num_subdevs = num_subdevs; - xdev->notifier.bound = xvip_graph_notify_bound; - xdev->notifier.complete = xvip_graph_notify_complete; + xdev->notifier.ops = &xvip_graph_notify_ops; ret =v4l2_async_notifier_register (&xdev->v4l2_dev, &xdev->notifier);if (ret <0 ) {
drivers/media/v4l2-core/v4l2-async.c +10 -10
@@ -102,16 +102,16 @@ static int v4l2_async_match_notify(struct v4l2_async_notifier *notifier, {int ret; -if (notifier->bound) { - ret = notifier->bound (notifier, sd, asd); +if (notifier->ops->bound) { + ret = notifier->ops->bound (notifier, sd, asd);if (ret <0 )return ret; } ret =v4l2_device_register_subdev (notifier->v4l2_dev, sd);if (ret <0 ) { -if (notifier->unbind) - notifier->unbind (notifier, sd, asd); +if (notifier->ops->unbind) + notifier->ops->unbind (notifier, sd, asd);return ret; }
@@ -123,8 +123,8 @@ static int v4l2_async_match_notify(struct v4l2_async_notifier *notifier,/* Move from the global subdevice list to notifier's done */ list_move (&sd->async_list, ¬ifier->done); -if (list_empty (¬ifier->waiting) && notifier->complete) -return notifier->complete (notifier); +if (list_empty (¬ifier->waiting) && notifier->ops->complete) +return notifier->ops->complete (notifier);return 0 ; }
@@ -210,8 +210,8 @@ void v4l2_async_notifier_unregister(struct v4l2_async_notifier *notifier)list_for_each_entry_safe (sd, tmp, ¬ifier->done, async_list) {v4l2_async_cleanup (sd); -if (notifier->unbind) - notifier->unbind (notifier, sd, sd->asd); +if (notifier->ops->unbind) + notifier->ops->unbind (notifier, sd, sd->asd); }mutex_unlock (&list_lock);
@@ -300,8 +300,8 @@ void v4l2_async_unregister_subdev(struct v4l2_subdev *sd)v4l2_async_cleanup (sd); -if (notifier->unbind) - notifier->unbind (notifier, sd, sd->asd); +if (notifier->ops->unbind) + notifier->ops->unbind (notifier, sd, sd->asd);mutex_unlock (&list_lock); }
drivers/staging/media/imx/imx-media-dev.c +6 -2
@@ -440,6 +440,11 @@ static int imx_media_probe_complete(struct v4l2_async_notifier *notifier)return media_device_register (&imxmd->md); } +static const struct v4l2_async_notifier_operations imx_media_subdev_ops = { + .bound = imx_media_subdev_bound, + .complete = imx_media_probe_complete, +}; +/* * adds controls to a video device from an entity subdevice. * Continues upstream from the entity's sink pads.
@@ -608,8 +613,7 @@ static int imx_media_probe(struct platform_device *pdev)/* prepare the async subdev notifier and register it */ imxmd->subdev_notifier.subdevs = imxmd->async_ptrs; - imxmd->subdev_notifier.bound = imx_media_subdev_bound; - imxmd->subdev_notifier.complete = imx_media_probe_complete; + imxmd->subdev_notifier.ops = &imx_media_subdev_ops; ret =v4l2_async_notifier_register (&imxmd->v4l2_dev, &imxmd->subdev_notifier);if (ret) {
include/media/v4l2-async.h +19 -10
@@ -18,6 +18,7 @@ struct device;struct device_node ;struct v4l2_device ;struct v4l2_subdev ; +struct v4l2_async_notifier ;/* A random max subdevice number, used to allocate an array on stack */ #define V4L2_MAX_SUBDEVS 128U
@@ -79,8 +80,25 @@ struct v4l2_async_subdev { };/** +* struct v4l2_async_notifier_operations - Asynchronous V4L2 notifier operations +* @bound: a subdevice driver has successfully probed one of the subdevices +* @complete: all subdevices have been probed successfully +* @unbind: a subdevice is leaving +*/ +struct v4l2_async_notifier_operations { +int (*bound)(struct v4l2_async_notifier *notifier, +struct v4l2_subdev *subdev, +struct v4l2_async_subdev *asd); +int (*complete)(struct v4l2_async_notifier *notifier); +void (*unbind)(struct v4l2_async_notifier *notifier, +struct v4l2_subdev *subdev, +struct v4l2_async_subdev *asd); +}; + +/** * struct v4l2_async_notifier - v4l2_device notifier data * +* @ops: notifier operations * @num_subdevs: number of subdevices used in the subdevs array * @max_subdevs: number of subdevices allocated in the subdevs array * @subdevs: array of pointers to subdevice descriptors
@@ -88,11 +106,9 @@ struct v4l2_async_subdev {* @waiting: list of struct v4l2_async_subdev, waiting for their drivers * @done: list of struct v4l2_subdev, already probed * @list: member in a global list of notifiers -* @bound: a subdevice driver has successfully probed one of subdevices -* @complete: all subdevices have been probed successfully -* @unbind: a subdevice is leaving */ struct v4l2_async_notifier { +const struct v4l2_async_notifier_operations *ops;unsigned int num_subdevs;unsigned int max_subdevs;struct v4l2_async_subdev **subdevs;
@@ -100,13 +116,6 @@ struct v4l2_async_notifier {struct list_head waiting;struct list_head done;struct list_head list; -int (*bound)(struct v4l2_async_notifier *notifier, -struct v4l2_subdev *subdev, -struct v4l2_async_subdev *asd); -int (*complete)(struct v4l2_async_notifier *notifier); -void (*unbind)(struct v4l2_async_notifier *notifier, -struct v4l2_subdev *subdev, -struct v4l2_async_subdev *asd); };/**
Signature · 6 lines
2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v10 13/24 v4l: async: Allow async notifier register call succeed with no subdevs
In reply to a message not in the archiveThe information on how many async sub-devices would be bindable to a notifier is typically dependent on information from platform firmware and it's not driver's business to be aware of that.
Many V4L2 main drivers are perfectly usable (and useful) without async sub-devices and so if there aren't any around, just proceed call the notifier's complete callback immediately without registering the notifier itself.
If a driver needs to check whether there are async sub-devices available, it can be done by inspecting the notifier's num_subdevs field which tells the number of async sub-devices.
--- drivers/media/v4l2-core/v4l2-async.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/media/v4l2-core/v4l2-async.c +4 -2
@@ -170,10 +170,12 @@ int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev,struct v4l2_async_subdev *asd;int i; -if (!v4l2_dev || !notifier->num_subdevs || - notifier->num_subdevs >V4L2_MAX_SUBDEVS ) +if (!v4l2_dev || notifier->num_subdevs >V4L2_MAX_SUBDEVS )return -EINVAL ; +if (!notifier->num_subdevs) +return v4l2_async_notifier_call_complete (notifier); + notifier->v4l2_dev = v4l2_dev;INIT_LIST_HEAD (¬ifier->waiting);INIT_LIST_HEAD (¬ifier->done);
Signature · 6 lines
2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v10 14/24 v4l: async: Allow binding notifiers to sub-devices
In reply to a message not in the archiveRegistering a notifier has required the knowledge of struct v4l2_device for the reason that sub-devices generally are registered to the v4l2_device (as well as the media device, also available through v4l2_device).
This information is not available for sub-device drivers at probe time.
What this patch does is that it allows registering notifiers without having v4l2_device around. Instead the sub-device pointer is stored in the notifier. Once the sub-device of the driver that registered the notifier is registered, the notifier will gain the knowledge of the v4l2_device, and the binding of async sub-devices from the sub-device driver's notifier may proceed.
The root notifier's complete callback is only called when all sub-device notifiers are completed.
--- drivers/media/v4l2-core/v4l2-async.c | 217 ++++++++++++++++++++++++++++++----- include/media/v4l2-async.h | 16 ++- 2 files changed, 202 insertions(+), 31 deletions(-)
drivers/media/v4l2-core/v4l2-async.c +187 -30
@@ -53,6 +53,10 @@ static int v4l2_async_notifier_call_complete(struct v4l2_async_notifier *n)return n->ops->complete (n); } +static int v4l2_async_match_notify (struct v4l2_async_notifier *notifier, +struct v4l2_subdev *sd, +struct v4l2_async_subdev *asd); +static bool match_i2c (struct v4l2_subdev *sd,struct v4l2_async_subdev *asd) {#if IS_ENABLED (CONFIG_I2C )
@@ -124,14 +128,128 @@ static struct v4l2_async_subdev *v4l2_async_find_match(return NULL ; } +/* Get the sub-device notifier registered by a sub-device driver. */ +static struct v4l2_async_notifier *v4l2_async_get_subdev_notifier ( +struct v4l2_subdev *sd) +{ +struct v4l2_async_notifier *n; + +list_for_each_entry (n, ¬ifier_list, list) +if (n->sd == sd) +return n; + +return NULL ; +} + +/* Return true if all sub-device notifiers are complete, false otherwise. */ +static bool v4l2_async_subdev_notifiers_complete ( +struct v4l2_async_notifier *notifier) +{ +struct v4l2_subdev *sd; + +if (!list_empty (¬ifier->waiting)) +return false; + +list_for_each_entry (sd, ¬ifier->done, async_list) { +struct v4l2_async_notifier *subdev_notifier = +v4l2_async_get_subdev_notifier (sd); + +if (!subdev_notifier) +continue ; + +if (!v4l2_async_subdev_notifiers_complete (subdev_notifier)) +return false; + } + +return true; +} + +/* Get v4l2_device related to the notifier if one can be found. */ +static struct v4l2_device *v4l2_async_notifier_get_v4l2_dev ( +struct v4l2_async_notifier *notifier) +{ +while (notifier->parent) + notifier = notifier->parent; + +return notifier->v4l2_dev; +} + +/* Test all async sub-devices in a notifier for a match. */ +static int v4l2_async_notifier_try_all_subdevs ( +struct v4l2_async_notifier *notifier) +{ +struct v4l2_subdev *sd; + +if (!v4l2_async_notifier_get_v4l2_dev (notifier)) +return 0 ; + +again: +list_for_each_entry (sd, &subdev_list, async_list) { +struct v4l2_async_subdev *asd; +int ret; + + asd =v4l2_async_find_match (notifier, sd); +if (!asd) +continue ; + + ret =v4l2_async_match_notify (notifier, sd, asd); +if (ret <0 ) +return ret; + +/* +* v4l2_async_match_notify() may lead to registering a +* new notifier and thus changing the async subdevs +* list. In order to proceed safely from here, restart +* parsing the list from the beginning. +*/ + goto again; + } + +return 0 ; +} + +/* Try completing a notifier. */ +static int v4l2_async_notifier_try_complete ( +struct v4l2_async_notifier *notifier) +{ +do { +int ret; + +/* Any local async sub-devices left? */ +if (!list_empty (¬ifier->waiting)) +return 0 ; + +/* +* Any sub-device notifiers waiting for async subdevs +* to be bound? +*/ +if (!v4l2_async_subdev_notifiers_complete (notifier)) +return 0 ; + +/* Proceed completing the notifier */ + ret =v4l2_async_notifier_call_complete (notifier); +if (ret <0 ) +return ret; + +/* +* Obtain notifier's parent. If there is one, repeat +* the process, otherwise we're done here. +*/ + }while ((notifier = notifier->parent)); + +return 0 ; +} +static int v4l2_async_match_notify (struct v4l2_async_notifier *notifier,struct v4l2_subdev *sd,struct v4l2_async_subdev *asd) { +struct v4l2_async_notifier *subdev_notifier;int ret; - ret =v4l2_device_register_subdev (notifier->v4l2_dev, sd); -if (ret <0 ) + ret =v4l2_device_register_subdev ( +v4l2_async_notifier_get_v4l2_dev (notifier), sd); +if (ret)return ret; ret =v4l2_async_notifier_call_bound (notifier, sd, asd);
@@ -148,10 +266,20 @@ static int v4l2_async_match_notify(struct v4l2_async_notifier *notifier,/* Move from the global subdevice list to notifier's done */ list_move (&sd->async_list, ¬ifier->done); -if (list_empty (¬ifier->waiting)) -return v4l2_async_notifier_call_complete (notifier); +/* +* See if the sub-device has a notifier. If it does, proceed +* with checking for its async sub-devices. +*/ + subdev_notifier =v4l2_async_get_subdev_notifier (sd); +if (subdev_notifier && !subdev_notifier->parent) { + subdev_notifier->parent = notifier; + ret =v4l2_async_notifier_try_all_subdevs (subdev_notifier); +if (ret) +return ret; + } -return 0 ; +/* Try completing the notifier and its parent(s). */ +return v4l2_async_notifier_try_complete (notifier); }static void v4l2_async_cleanup (struct v4l2_subdev *sd)
@@ -163,20 +291,18 @@ static void v4l2_async_cleanup(struct v4l2_subdev *sd) sd->dev =NULL ; } -int v4l2_async_notifier_register (struct v4l2_device *v4l2_dev, -struct v4l2_async_notifier *notifier) +static int __v4l2_async_notifier_register (struct v4l2_async_notifier *notifier) { -struct v4l2_subdev *sd, *tmp;struct v4l2_async_subdev *asd; +int ret;int i; -if (!v4l2_dev || notifier->num_subdevs >V4L2_MAX_SUBDEVS ) +if (notifier->num_subdevs >V4L2_MAX_SUBDEVS )return -EINVAL ;if (!notifier->num_subdevs)return v4l2_async_notifier_call_complete (notifier); - notifier->v4l2_dev = v4l2_dev;INIT_LIST_HEAD (¬ifier->waiting);INIT_LIST_HEAD (¬ifier->done);
@@ -200,18 +326,10 @@ int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev,mutex_lock (&list_lock); -list_for_each_entry_safe (sd, tmp, &subdev_list, async_list) { -int ret; - - asd =v4l2_async_find_match (notifier, sd); -if (!asd) -continue ; - - ret =v4l2_async_match_notify (notifier, sd, asd); -if (ret <0 ) { -mutex_unlock (&list_lock); -return ret; - } + ret =v4l2_async_notifier_try_all_subdevs (notifier); +if (ret) { +mutex_unlock (&list_lock); +return ret; }/* Keep also completed notifiers on the list */
@@ -221,28 +339,67 @@ int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev,return 0 ; } + +int v4l2_async_notifier_register (struct v4l2_device *v4l2_dev, +struct v4l2_async_notifier *notifier) +{ +if (!v4l2_dev || notifier->sd) +return -EINVAL ; + + notifier->v4l2_dev = v4l2_dev; + +return __v4l2_async_notifier_register (notifier); +}EXPORT_SYMBOL (v4l2_async_notifier_register); -void v4l2_async_notifier_unregister (struct v4l2_async_notifier *notifier) +int v4l2_async_subdev_notifier_register (struct v4l2_subdev *sd, +struct v4l2_async_notifier *notifier) { -struct v4l2_subdev *sd, *tmp; +if (!sd || notifier->v4l2_dev) +return -EINVAL ; -if (!notifier->v4l2_dev) -return ; + notifier->sd = sd; -mutex_lock (&list_lock); +return __v4l2_async_notifier_register (notifier); +} +EXPORT_SYMBOL (v4l2_async_subdev_notifier_register); -list_del (¬ifier->list); +/* Unbind all sub-devices in the notifier tree. */ +static void v4l2_async_notifier_unbind_all_subdevs ( +struct v4l2_async_notifier *notifier) +{ +struct v4l2_subdev *sd, *tmp;list_for_each_entry_safe (sd, tmp, ¬ifier->done, async_list) { +struct v4l2_async_notifier *subdev_notifier = +v4l2_async_get_subdev_notifier (sd); + +if (subdev_notifier) +v4l2_async_notifier_unbind_all_subdevs (subdev_notifier); +v4l2_async_cleanup (sd);v4l2_async_notifier_call_unbind (notifier, sd, sd->asd); + +list_del (&sd->async_list); +list_add (&sd->async_list, &subdev_list); } -mutex_unlock (&list_lock); + notifier->parent =NULL ; +} + +void v4l2_async_notifier_unregister (struct v4l2_async_notifier *notifier) +{ +if (!notifier->v4l2_dev && !notifier->sd) +return ; - notifier->v4l2_dev =NULL ; +mutex_lock (&list_lock); + +v4l2_async_notifier_unbind_all_subdevs (notifier); + +list_del (¬ifier->list); + +mutex_unlock (&list_lock); }EXPORT_SYMBOL (v4l2_async_notifier_unregister);
include/media/v4l2-async.h +15 -1
@@ -102,7 +102,9 @@ struct v4l2_async_notifier_operations {* @num_subdevs: number of subdevices used in the subdevs array * @max_subdevs: number of subdevices allocated in the subdevs array * @subdevs: array of pointers to subdevice descriptors -* @v4l2_dev: pointer to struct v4l2_device +* @v4l2_dev: v4l2_device of the root notifier, NULL otherwise +* @sd: sub-device that registered the notifier, NULL otherwise +* @parent: parent notifier carrying @v4l2_dev * @waiting: list of struct v4l2_async_subdev, waiting for their drivers * @done: list of struct v4l2_subdev, already probed * @list: member in a global list of notifiers
@@ -113,6 +115,8 @@ struct v4l2_async_notifier {unsigned int max_subdevs;struct v4l2_async_subdev **subdevs;struct v4l2_device *v4l2_dev; +struct v4l2_subdev *sd; +struct v4l2_async_notifier *parent;struct list_head waiting;struct list_head done;struct list_head list;
@@ -128,6 +132,16 @@ int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev, struct v4l2_async_notifier *notifier);/** +* v4l2_async_subdev_notifier_register - registers a subdevice asynchronous +* notifier for a sub-device +* +* @sd: pointer to &struct v4l2_subdev +* @notifier: pointer to &struct v4l2_async_notifier +*/ +int v4l2_async_subdev_notifier_register (struct v4l2_subdev *sd, +struct v4l2_async_notifier *notifier); + +/** * v4l2_async_notifier_unregister - unregisters a subdevice asynchronous notifier * * @notifier: pointer to &struct v4l2_async_notifier
Signature · 6 lines
2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v10 14/24] v4l: async: Allow binding notifiers to sub-devices
Quoted 39 lines · Sakari Ailus
Registering a notifier has required the knowledge of struct
v4l2_devicefor the reason that sub-devices generally are registered to thev4l2_device(as well as the media device, also available throughv4l2_device).This information is not available for sub-device drivers at probe time.
What this patch does is that it allows registering notifiers without having
v4l2_devicearound. Instead the sub-device pointer is stored in the notifier. Once the sub-device of the driver that registered the notifier is registered, the notifier will gain the knowledge of thev4l2_device, and the binding of async sub-devices from the sub-device driver's notifier may proceed.The root notifier's complete callback is only called when all sub-device notifiers are completed.
Signed-off-by Sakari Ailus <[email protected]>--- drivers/media/v4l2-core/v4l2-async.c | 217 ++++++++++++++++++++++++++++++----- include/media/v4l2-async.h | 16 ++- 2 files changed, 202 insertions(+), 31 deletions(-)drivers/media/v4l2-core/v4l2-async.c +4
-0@@ -53,6 +53,10 @@ static int v4l2_async_notifier_call_complete(struct v4l2_async_notifier *n)return n->ops->complete (n); } +static int v4l2_async_match_notify (struct v4l2_async_notifier *notifier, +struct v4l2_subdev *sd, +struct v4l2_async_subdev *asd); +static bool match_i2c (struct v4l2_subdev *sd,struct v4l2_async_subdev *asd) {#if IS_ENABLED (CONFIG_I2C )
drivers/media/v4l2-core/v4l2-async.c static struct v4l2_async_subdev *v4l2_async_find_match( · line 132
Quoted 5 lines
drivers/media/v4l2-core/v4l2-async.c +2
-0@@ -124,14 +128,128 @@ static struct v4l2_async_subdev *v4l2_async_find_match(return NULL ; } +/* Get the sub-device notifier registered by a sub-device driver. */ +static struct v4l2_async_notifier *v4l2_async_get_subdev_notifier(
I prefer to call this v4l2_async_find_subdev_notifier(). 'get' suggests a getter function, but this actually has to find it. I think this may have confused me during an earlier review of this code. The comment also needs
updating: "Find the sub-device...".
Quoted 13 lines
drivers/media/v4l2-core/v4l2-async.c +13
-0+ struct v4l2_subdev *sd) +{ +struct v4l2_async_notifier *n; + +list_for_each_entry (n, ¬ifier_list, list) +if (n->sd == sd) +return n; + +return NULL ; +} + +/* Return true if all sub-device notifiers are complete, false otherwise. */ +static bool v4l2_async_subdev_notifiers_complete(
drivers/media/v4l2-core/v4l2-async.c static struct v4l2_async_subdev *v4l2_async_find_match( · line 155
Quoted 10 lines
drivers/media/v4l2-core/v4l2-async.c +10
-0+ struct v4l2_async_notifier *notifier) +{ +struct v4l2_subdev *sd; + +if (!list_empty (¬ifier->waiting)) +return false; + +list_for_each_entry (sd, ¬ifier->done, async_list) { +struct v4l2_async_notifier *subdev_notifier = +v4l2_async_get_subdev_notifier (sd);
Would it make sense to add a 'struct v4l2_async_notifier *subdev_notifier' field to struct v4l2_subdev? It's set when a subdev registers a notifier.
That way you can just use sd->subdev_notifier here.
I wonder if v4l2_async_get_subdev_notifier() is needed at all if you do this.
Quoted 174 lines
drivers/media/v4l2-core/v4l2-async.c +111
-22+ +if (!subdev_notifier) +continue ; + +if (!v4l2_async_subdev_notifiers_complete (subdev_notifier)) +return false; + } + +return true; +} + +/* Get v4l2_device related to the notifier if one can be found. */ +static struct v4l2_device *v4l2_async_notifier_get_v4l2_dev ( +struct v4l2_async_notifier *notifier) +{ +while (notifier->parent) + notifier = notifier->parent; + +return notifier->v4l2_dev; +} + +/* Test all async sub-devices in a notifier for a match. */ +static int v4l2_async_notifier_try_all_subdevs ( +struct v4l2_async_notifier *notifier) +{ +struct v4l2_subdev *sd; + +if (!v4l2_async_notifier_get_v4l2_dev (notifier)) +return 0 ; + +again: +list_for_each_entry (sd, &subdev_list, async_list) { +struct v4l2_async_subdev *asd; +int ret; + + asd =v4l2_async_find_match (notifier, sd); +if (!asd) +continue ; + + ret =v4l2_async_match_notify (notifier, sd, asd); +if (ret <0 ) +return ret; + +/* +* v4l2_async_match_notify() may lead to registering a +* new notifier and thus changing the async subdevs +* list. In order to proceed safely from here, restart +* parsing the list from the beginning. +*/ + goto again; + } + +return 0 ; +} + +/* Try completing a notifier. */ +static int v4l2_async_notifier_try_complete ( +struct v4l2_async_notifier *notifier) +{ +do { +int ret; + +/* Any local async sub-devices left? */ +if (!list_empty (¬ifier->waiting)) +return 0 ; + +/* +* Any sub-device notifiers waiting for async subdevs +* to be bound? +*/ +if (!v4l2_async_subdev_notifiers_complete (notifier)) +return 0 ; + +/* Proceed completing the notifier */ + ret =v4l2_async_notifier_call_complete (notifier); +if (ret <0 ) +return ret; + +/* +* Obtain notifier's parent. If there is one, repeat +* the process, otherwise we're done here. +*/ + }while ((notifier = notifier->parent)); + +return 0 ; +} +static int v4l2_async_match_notify (struct v4l2_async_notifier *notifier,struct v4l2_subdev *sd,struct v4l2_async_subdev *asd) { +struct v4l2_async_notifier *subdev_notifier;int ret; - ret =v4l2_device_register_subdev (notifier->v4l2_dev, sd); -if (ret <0 ) + ret =v4l2_device_register_subdev ( +v4l2_async_notifier_get_v4l2_dev (notifier), sd); +if (ret)return ret; ret =v4l2_async_notifier_call_bound (notifier, sd, asd);@@ -148,10 +266,20 @@ static int v4l2_async_match_notify(struct v4l2_async_notifier *notifier,/* Move from the global subdevice list to notifier's done */ list_move (&sd->async_list, ¬ifier->done); -if (list_empty (¬ifier->waiting)) -return v4l2_async_notifier_call_complete (notifier); +/* +* See if the sub-device has a notifier. If it does, proceed +* with checking for its async sub-devices. +*/ + subdev_notifier =v4l2_async_get_subdev_notifier (sd); +if (subdev_notifier && !subdev_notifier->parent) { + subdev_notifier->parent = notifier; + ret =v4l2_async_notifier_try_all_subdevs (subdev_notifier); +if (ret) +return ret; + } -return 0 ; +/* Try completing the notifier and its parent(s). */ +return v4l2_async_notifier_try_complete (notifier); }static void v4l2_async_cleanup (struct v4l2_subdev *sd)@@ -163,20 +291,18 @@ static void v4l2_async_cleanup(struct v4l2_subdev *sd) sd->dev =NULL ; } -int v4l2_async_notifier_register (struct v4l2_device *v4l2_dev, -struct v4l2_async_notifier *notifier) +static int __v4l2_async_notifier_register (struct v4l2_async_notifier *notifier) { -struct v4l2_subdev *sd, *tmp;struct v4l2_async_subdev *asd; +int ret;int i; -if (!v4l2_dev || notifier->num_subdevs >V4L2_MAX_SUBDEVS ) +if (notifier->num_subdevs >V4L2_MAX_SUBDEVS )return -EINVAL ;if (!notifier->num_subdevs)return v4l2_async_notifier_call_complete (notifier); - notifier->v4l2_dev = v4l2_dev;INIT_LIST_HEAD (¬ifier->waiting);INIT_LIST_HEAD (¬ifier->done);@@ -200,18 +326,10 @@ int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev,mutex_lock (&list_lock); -list_for_each_entry_safe (sd, tmp, &subdev_list, async_list) { -int ret; - - asd =v4l2_async_find_match (notifier, sd); -if (!asd) -continue ; - - ret =v4l2_async_match_notify (notifier, sd, asd); -if (ret <0 ) { -mutex_unlock (&list_lock); -return ret; - } + ret =v4l2_async_notifier_try_all_subdevs (notifier); +if (ret) { +mutex_unlock (&list_lock); +return ret; }/* Keep also completed notifiers on the list */
drivers/media/v4l2-core/v4l2-async.c int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev, · line 346
Quoted 8 lines
drivers/media/v4l2-core/v4l2-async.c +5
-0@@ -221,28 +339,67 @@ int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev,return 0 ; } + +int v4l2_async_notifier_register (struct v4l2_device *v4l2_dev, +struct v4l2_async_notifier *notifier) +{ +if (!v4l2_dev || notifier->sd)
Should this be a WARN_ON?
Quoted 4 lines
drivers/media/v4l2-core/v4l2-async.c +4
-0+return -EINVAL ; + + notifier->v4l2_dev = v4l2_dev; +
drivers/media/v4l2-core/v4l2-async.c int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev, · line 358
Quoted 10 lines
drivers/media/v4l2-core/v4l2-async.c +5
-2+return __v4l2_async_notifier_register (notifier); +}EXPORT_SYMBOL (v4l2_async_notifier_register); -void v4l2_async_notifier_unregister (struct v4l2_async_notifier *notifier) +int v4l2_async_subdev_notifier_register (struct v4l2_subdev *sd, +struct v4l2_async_notifier *notifier) { -struct v4l2_subdev *sd, *tmp; +if (!sd || notifier->v4l2_dev)
Ditto.
Quoted 25 lines
drivers/media/v4l2-core/v4l2-async.c +16
-4+return -EINVAL ; -if (!notifier->v4l2_dev) -return ; + notifier->sd = sd; -mutex_lock (&list_lock); +return __v4l2_async_notifier_register (notifier); +} +EXPORT_SYMBOL (v4l2_async_subdev_notifier_register); -list_del (¬ifier->list); +/* Unbind all sub-devices in the notifier tree. */ +static void v4l2_async_notifier_unbind_all_subdevs ( +struct v4l2_async_notifier *notifier) +{ +struct v4l2_subdev *sd, *tmp;list_for_each_entry_safe (sd, tmp, ¬ifier->done, async_list) { +struct v4l2_async_notifier *subdev_notifier = +v4l2_async_get_subdev_notifier (sd); + +if (subdev_notifier) +v4l2_async_notifier_unbind_all_subdevs (subdev_notifier); +
drivers/media/v4l2-core/v4l2-async.c int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev, · line 388
Quoted 10 lines
drivers/media/v4l2-core/v4l2-async.c +4
-1v4l2_async_cleanup (sd);v4l2_async_notifier_call_unbind (notifier, sd, sd->asd); + +list_del (&sd->async_list); +list_add (&sd->async_list, &subdev_list); } -mutex_unlock (&list_lock); + notifier->parent =NULL ;
Shouldn't notifier->v4l2_dev and notifier->sd be set to NULL as well? I can't really tell.
Quoted 23 lines
drivers/media/v4l2-core/v4l2-async.c +13
-1+} + +void v4l2_async_notifier_unregister (struct v4l2_async_notifier *notifier) +{ +if (!notifier->v4l2_dev && !notifier->sd) +return ; - notifier->v4l2_dev =NULL ; +mutex_lock (&list_lock); + +v4l2_async_notifier_unbind_all_subdevs (notifier); + +list_del (¬ifier->list); + +mutex_unlock (&list_lock); }EXPORT_SYMBOL (v4l2_async_notifier_unregister);include/media/v4l2-async.h +0
-0
include/media/v4l2-async.h struct v4l2_async_notifier_operations { · line 107
Quoted 7 lines
include/media/v4l2-async.h +3
-1@@ -102,7 +102,9 @@ struct v4l2_async_notifier_operations {* @num_subdevs: number of subdevices used in the subdevs array * @max_subdevs: number of subdevices allocated in the subdevs array * @subdevs: array of pointers to subdevice descriptors -* @v4l2_dev: pointer to struct v4l2_device +* @v4l2_dev: v4l2_device of the root notifier, NULL otherwise +* @sd: sub-device that registered the notifier, NULL otherwise +* @parent: parent notifier carrying @v4l2_dev
That's not correct, it only carries v4l2_dev if it is the root notifier. I think just 'parent notifier' is sufficient here.
Quoted 20 lines
include/media/v4l2-async.h +5
-0* @waiting: list of struct v4l2_async_subdev, waiting for their drivers * @done: list of struct v4l2_subdev, already probed * @list: member in a global list of notifiers @@ -113,6 +115,8 @@ struct v4l2_async_notifier {unsigned int max_subdevs;struct v4l2_async_subdev **subdevs;struct v4l2_device *v4l2_dev; +struct v4l2_subdev *sd; +struct v4l2_async_notifier *parent;struct list_head waiting;struct list_head done;struct list_head list;@@ -128,6 +132,16 @@ int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev, struct v4l2_async_notifier *notifier);/** +* v4l2_async_subdev_notifier_register - registers a subdevice asynchronous +* notifier for a sub-device +*
include/media/v4l2-async.h int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev, · line 147
Quoted 10 lines
include/media/v4l2-async.h +7
-0+* @sd: pointer to &struct v4l2_subdev +* @notifier: pointer to &struct v4l2_async_notifier +*/ +int v4l2_async_subdev_notifier_register (struct v4l2_subdev *sd, +struct v4l2_async_notifier *notifier); + +/** * v4l2_async_notifier_unregister - unregisters a subdevice asynchronous notifier * * @notifier: pointer to &struct v4l2_async_notifier
Regards,
Hans
Re: [PATCH v10 14/24] v4l: async: Allow binding notifiers to sub-devices
Hi Hans,
Thanks for the review!
Quoted 43 lines · Hans Verkuil
Quoted 42 lines · Sakari Ailus
Registering a notifier has required the knowledge of struct
v4l2_devicefor the reason that sub-devices generally are registered to thev4l2_device(as well as the media device, also available throughv4l2_device).This information is not available for sub-device drivers at probe time.
What this patch does is that it allows registering notifiers without having
v4l2_devicearound. Instead the sub-device pointer is stored in the notifier. Once the sub-device of the driver that registered the notifier is registered, the notifier will gain the knowledge of thev4l2_device, and the binding of async sub-devices from the sub-device driver's notifier may proceed.The root notifier's complete callback is only called when all sub-device notifiers are completed.
Signed-off-by Sakari Ailus <[email protected]>--- drivers/media/v4l2-core/v4l2-async.c | 217 ++++++++++++++++++++++++++++++----- include/media/v4l2-async.h | 16 ++- 2 files changed, 202 insertions(+), 31 deletions(-)drivers/media/v4l2-core/v4l2-async.c +4
-0@@ -53,6 +53,10 @@ static int v4l2_async_notifier_call_complete(struct v4l2_async_notifier *n)return n->ops->complete (n); } +static int v4l2_async_match_notify (struct v4l2_async_notifier *notifier, +struct v4l2_subdev *sd, +struct v4l2_async_subdev *asd); +static bool match_i2c (struct v4l2_subdev *sd,struct v4l2_async_subdev *asd) {#if IS_ENABLED (CONFIG_I2C )@@ -124,14 +128,128 @@ static struct v4l2_async_subdev *v4l2_async_find_match(return NULL ; }
Quoted 7 lines
drivers/media/v4l2-core/v4l2-async.c static struct v4l2_async_subdev *v4l2_async_find_match( · line 132
Quoted 2 lines
drivers/media/v4l2-core/v4l2-async.c +2
-0+/* Get the sub-device notifier registered by a sub-device driver. */ +static struct v4l2_async_notifier *v4l2_async_get_subdev_notifier(I prefer to call this
v4l2_async_find_subdev_notifier(). 'get' suggests a getter function, but this actually has to find it. I think this may have confused me during an earlier review of this code. The comment also needs
updating: "Find the sub-device...".
Yes, makes sense. Get also suggests that there would be reference counting which is not the case here.
I made the corresponding change to v4l2_async_notifier_find_v4l2_dev() as well.
Quoted 28 lines
Quoted 14 lines
drivers/media/v4l2-core/v4l2-async.c +13
-0+ struct v4l2_subdev *sd) +{ +struct v4l2_async_notifier *n; + +list_for_each_entry (n, ¬ifier_list, list) +if (n->sd == sd) +return n; + +return NULL ; +} + +/* Return true if all sub-device notifiers are complete, false otherwise. */ +static bool v4l2_async_subdev_notifiers_complete(drivers/media/v4l2-core/v4l2-async.c static struct v4l2_async_subdev *v4l2_async_find_match( · line 155
Quoted 10 lines
drivers/media/v4l2-core/v4l2-async.c +10
-0+ struct v4l2_async_notifier *notifier) +{ +struct v4l2_subdev *sd; + +if (!list_empty (¬ifier->waiting)) +return false; + +list_for_each_entry (sd, ¬ifier->done, async_list) { +struct v4l2_async_notifier *subdev_notifier = +v4l2_async_get_subdev_notifier (sd);Would it make sense to add a 'struct
v4l2_async_notifier*subdev_notifier' field to structv4l2_subdev? It's set when a subdev registers a notifier.
Quoted 4 lines
That way you can just use
sd->subdev_notifierhere.I wonder if
v4l2_async_get_subdev_notifier()is needed at all if you do this.
I thought of that, but ended up keeping the information in the notifier. As the information is already available elsewhere, I didn't end up adding a new field for the purpose. This is certainly not performance critical either.
Quoted 176 lines
Quoted 176 lines
drivers/media/v4l2-core/v4l2-async.c +111
-22+ +if (!subdev_notifier) +continue ; + +if (!v4l2_async_subdev_notifiers_complete (subdev_notifier)) +return false; + } + +return true; +} + +/* Get v4l2_device related to the notifier if one can be found. */ +static struct v4l2_device *v4l2_async_notifier_get_v4l2_dev ( +struct v4l2_async_notifier *notifier) +{ +while (notifier->parent) + notifier = notifier->parent; + +return notifier->v4l2_dev; +} + +/* Test all async sub-devices in a notifier for a match. */ +static int v4l2_async_notifier_try_all_subdevs ( +struct v4l2_async_notifier *notifier) +{ +struct v4l2_subdev *sd; + +if (!v4l2_async_notifier_get_v4l2_dev (notifier)) +return 0 ; + +again: +list_for_each_entry (sd, &subdev_list, async_list) { +struct v4l2_async_subdev *asd; +int ret; + + asd =v4l2_async_find_match (notifier, sd); +if (!asd) +continue ; + + ret =v4l2_async_match_notify (notifier, sd, asd); +if (ret <0 ) +return ret; + +/* +* v4l2_async_match_notify() may lead to registering a +* new notifier and thus changing the async subdevs +* list. In order to proceed safely from here, restart +* parsing the list from the beginning. +*/ + goto again; + } + +return 0 ; +} + +/* Try completing a notifier. */ +static int v4l2_async_notifier_try_complete ( +struct v4l2_async_notifier *notifier) +{ +do { +int ret; + +/* Any local async sub-devices left? */ +if (!list_empty (¬ifier->waiting)) +return 0 ; + +/* +* Any sub-device notifiers waiting for async subdevs +* to be bound? +*/ +if (!v4l2_async_subdev_notifiers_complete (notifier)) +return 0 ; + +/* Proceed completing the notifier */ + ret =v4l2_async_notifier_call_complete (notifier); +if (ret <0 ) +return ret; + +/* +* Obtain notifier's parent. If there is one, repeat +* the process, otherwise we're done here. +*/ + }while ((notifier = notifier->parent)); + +return 0 ; +} +static int v4l2_async_match_notify (struct v4l2_async_notifier *notifier,struct v4l2_subdev *sd,struct v4l2_async_subdev *asd) { +struct v4l2_async_notifier *subdev_notifier;int ret; - ret =v4l2_device_register_subdev (notifier->v4l2_dev, sd); -if (ret <0 ) + ret =v4l2_device_register_subdev ( +v4l2_async_notifier_get_v4l2_dev (notifier), sd); +if (ret)return ret; ret =v4l2_async_notifier_call_bound (notifier, sd, asd);@@ -148,10 +266,20 @@ static int v4l2_async_match_notify(struct v4l2_async_notifier *notifier,/* Move from the global subdevice list to notifier's done */ list_move (&sd->async_list, ¬ifier->done); -if (list_empty (¬ifier->waiting)) -return v4l2_async_notifier_call_complete (notifier); +/* +* See if the sub-device has a notifier. If it does, proceed +* with checking for its async sub-devices. +*/ + subdev_notifier =v4l2_async_get_subdev_notifier (sd); +if (subdev_notifier && !subdev_notifier->parent) { + subdev_notifier->parent = notifier; + ret =v4l2_async_notifier_try_all_subdevs (subdev_notifier); +if (ret) +return ret; + } -return 0 ; +/* Try completing the notifier and its parent(s). */ +return v4l2_async_notifier_try_complete (notifier); }static void v4l2_async_cleanup (struct v4l2_subdev *sd)@@ -163,20 +291,18 @@ static void v4l2_async_cleanup(struct v4l2_subdev *sd) sd->dev =NULL ; } -int v4l2_async_notifier_register (struct v4l2_device *v4l2_dev, -struct v4l2_async_notifier *notifier) +static int __v4l2_async_notifier_register (struct v4l2_async_notifier *notifier) { -struct v4l2_subdev *sd, *tmp;struct v4l2_async_subdev *asd; +int ret;int i; -if (!v4l2_dev || notifier->num_subdevs >V4L2_MAX_SUBDEVS ) +if (notifier->num_subdevs >V4L2_MAX_SUBDEVS )return -EINVAL ;if (!notifier->num_subdevs)return v4l2_async_notifier_call_complete (notifier); - notifier->v4l2_dev = v4l2_dev;INIT_LIST_HEAD (¬ifier->waiting);INIT_LIST_HEAD (¬ifier->done);@@ -200,18 +326,10 @@ int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev,mutex_lock (&list_lock); -list_for_each_entry_safe (sd, tmp, &subdev_list, async_list) { -int ret; - - asd =v4l2_async_find_match (notifier, sd); -if (!asd) -continue ; - - ret =v4l2_async_match_notify (notifier, sd, asd); -if (ret <0 ) { -mutex_unlock (&list_lock); -return ret; - } + ret =v4l2_async_notifier_try_all_subdevs (notifier); +if (ret) { +mutex_unlock (&list_lock); +return ret; }/* Keep also completed notifiers on the list */ @@ -221,28 +339,67 @@ int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev,
Quoted 9 lines
drivers/media/v4l2-core/v4l2-async.c int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev, · line 346
Quoted 7 lines
drivers/media/v4l2-core/v4l2-async.c +5
-0return 0 ; } + +int v4l2_async_notifier_register (struct v4l2_device *v4l2_dev, +struct v4l2_async_notifier *notifier) +{ +if (!v4l2_dev || notifier->sd)Should this be a
WARN_ON?
Added WARN_ON().
Quoted 9 lines
Quoted 9 lines
drivers/media/v4l2-core/v4l2-async.c +6
-0+return -EINVAL ; + + notifier->v4l2_dev = v4l2_dev; + +return __v4l2_async_notifier_register (notifier); +}EXPORT_SYMBOL (v4l2_async_notifier_register);
Quoted 8 lines
drivers/media/v4l2-core/v4l2-async.c int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev, · line 358
Quoted 6 lines
drivers/media/v4l2-core/v4l2-async.c +3
-2-void v4l2_async_notifier_unregister (struct v4l2_async_notifier *notifier) +int v4l2_async_subdev_notifier_register (struct v4l2_subdev *sd, +struct v4l2_async_notifier *notifier) { -struct v4l2_subdev *sd, *tmp; +if (!sd || notifier->v4l2_dev)Ditto.
Indeed.
Quoted 34 lines
Quoted 34 lines
drivers/media/v4l2-core/v4l2-async.c +19
-4+return -EINVAL ; -if (!notifier->v4l2_dev) -return ; + notifier->sd = sd; -mutex_lock (&list_lock); +return __v4l2_async_notifier_register (notifier); +} +EXPORT_SYMBOL (v4l2_async_subdev_notifier_register); -list_del (¬ifier->list); +/* Unbind all sub-devices in the notifier tree. */ +static void v4l2_async_notifier_unbind_all_subdevs ( +struct v4l2_async_notifier *notifier) +{ +struct v4l2_subdev *sd, *tmp;list_for_each_entry_safe (sd, tmp, ¬ifier->done, async_list) { +struct v4l2_async_notifier *subdev_notifier = +v4l2_async_get_subdev_notifier (sd); + +if (subdev_notifier) +v4l2_async_notifier_unbind_all_subdevs (subdev_notifier); +v4l2_async_cleanup (sd);v4l2_async_notifier_call_unbind (notifier, sd, sd->asd); + +list_del (&sd->async_list); +list_add (&sd->async_list, &subdev_list); }
Quoted 5 lines
drivers/media/v4l2-core/v4l2-async.c int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev, · line 388
Quoted 2 lines
drivers/media/v4l2-core/v4l2-async.c +1
-1-mutex_unlock (&list_lock); + notifier->parent =NULL ;Shouldn't
notifier->v4l2_devandnotifier->sdbe set to NULL as well? I can't really tell.
Well spotted. Yes. This was actually broken by the patch; v4l2_dev used to be set NULL. Will fix.
Quoted 19 lines
Quoted 19 lines
drivers/media/v4l2-core/v4l2-async.c +13
-1+} + +void v4l2_async_notifier_unregister (struct v4l2_async_notifier *notifier) +{ +if (!notifier->v4l2_dev && !notifier->sd) +return ; - notifier->v4l2_dev =NULL ; +mutex_lock (&list_lock); + +v4l2_async_notifier_unbind_all_subdevs (notifier); + +list_del (¬ifier->list); + +mutex_unlock (&list_lock); }EXPORT_SYMBOL (v4l2_async_notifier_unregister);
Quoted 15 lines
include/media/v4l2-async.h struct v4l2_async_notifier_operations { · line 107
Quoted 12 lines
include/media/v4l2-async.h +3
-1@@ -102,7 +102,9 @@ struct v4l2_async_notifier_operations {* @num_subdevs: number of subdevices used in the subdevs array * @max_subdevs: number of subdevices allocated in the subdevs array * @subdevs: array of pointers to subdevice descriptors -* @v4l2_dev: pointer to struct v4l2_device +* @v4l2_dev: v4l2_device of the root notifier, NULL otherwise +* @sd: sub-device that registered the notifier, NULL otherwise +* @parent: parent notifier carrying @v4l2_dev That's not correct, it only carries
v4l2_devif it is the root notifier. I think just 'parent notifier' is sufficient here.
Will change.
Quoted 31 lines
Quoted 31 lines
include/media/v4l2-async.h +12
-0* @waiting: list of struct v4l2_async_subdev, waiting for their drivers * @done: list of struct v4l2_subdev, already probed * @list: member in a global list of notifiers @@ -113,6 +115,8 @@ struct v4l2_async_notifier {unsigned int max_subdevs;struct v4l2_async_subdev **subdevs;struct v4l2_device *v4l2_dev; +struct v4l2_subdev *sd; +struct v4l2_async_notifier *parent;struct list_head waiting;struct list_head done;struct list_head list;@@ -128,6 +132,16 @@ int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev, struct v4l2_async_notifier *notifier);/** +* v4l2_async_subdev_notifier_register - registers a subdevice asynchronous +* notifier for a sub-device +* +* @sd: pointer to &struct v4l2_subdev +* @notifier: pointer to &struct v4l2_async_notifier +*/ +int v4l2_async_subdev_notifier_register (struct v4l2_subdev *sd, +struct v4l2_async_notifier *notifier); + +/** * v4l2_async_notifier_unregister - unregisters a subdevice asynchronous notifier * * @notifier: pointer to &struct v4l2_async_notifier
Signature · 4 lines
Regards, Sakari Ailus e-mail: [email protected]
PATCH v10 17/24 v4l: fwnode: Add a helper function for parsing generic references
In reply to a message not in the archiveAdd function v4l2_fwnode_reference_count() for counting external references and v4l2_fwnode_reference_parse() for parsing them as async sub-devices.
This can be done on e.g. flash or lens async sub-devices that are not part of but are associated with a sensor.
struct v4l2_async_notifier.max_subdevs field is added to contain the maximum number of sub-devices in a notifier to reflect the memory allocated for the subdevs array.
--- drivers/media/v4l2-core/v4l2-fwnode.c | 47 +++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+)
drivers/media/v4l2-core/v4l2-fwnode.c +47 -0
@@ -449,6 +449,53 @@ int v4l2_async_notifier_parse_fwnode_endpoints( }EXPORT_SYMBOL_GPL (v4l2_async_notifier_parse_fwnode_endpoints); +static int v4l2_fwnode_reference_parse ( +struct device *dev,struct v4l2_async_notifier *notifier, +const char *prop) +{ +struct fwnode_reference_args args; +unsigned int index =0 ; +int ret; + +for (; !fwnode_property_get_reference_args ( +dev_fwnode (dev), prop,NULL ,0 , index, &args); index++) +fwnode_handle_put (args.fwnode); + + ret =v4l2_async_notifier_realloc (notifier, + notifier->num_subdevs + index); +if (ret) +return -ENOMEM ; + +for (ret = -ENOENT , index =0 ; + !fwnode_property_get_reference_args ( +dev_fwnode (dev), prop,NULL ,0 , index, &args); + index++) { +struct v4l2_async_subdev *asd; + +if (WARN_ON (notifier->num_subdevs >= notifier->max_subdevs)) { + ret = -EINVAL ; + goto error; + } + + asd =kzalloc (sizeof (*asd),GFP_KERNEL ); +if (!asd) { + ret = -ENOMEM ; + goto error; + } + + notifier->subdevs[notifier->num_subdevs] = asd; + asd->match.fwnode.fwnode = args.fwnode; + asd->match_type =V4L2_ASYNC_MATCH_FWNODE ; + notifier->num_subdevs++; + } + +return 0 ; + +error: +fwnode_handle_put (args.fwnode); +return ret; +} +MODULE_LICENSE ("GPL" );MODULE_AUTHOR ("Sakari Ailus <sakari.ailus-VuQAYsv1563Yd54FQh9/[email protected]>" );MODULE_AUTHOR ("Sylwester Nawrocki <[email protected]>" );
Signature · 6 lines
2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v10 17/24] v4l: fwnode: Add a helper function for parsing generic references
Quoted 10 lines · Sakari Ailus
Add function
v4l2_fwnode_reference_count()for counting external references andv4l2_fwnode_reference_parse()for parsing them as async sub-devices.This can be done on e.g. flash or lens async sub-devices that are not part of but are associated with a sensor.
struct v4l2_async_notifier.max_subdevs field is added to contain the maximum number of sub-devices in a notifier to reflect the memory allocated for the subdevs array.
This paragraph appears to be out-of-date.
Quoted 16 lines
Signed-off-by Sakari Ailus <[email protected]>--- drivers/media/v4l2-core/v4l2-fwnode.c | 47 +++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+)drivers/media/v4l2-core/v4l2-fwnode.c +2
-0@@ -449,6 +449,53 @@ int v4l2_async_notifier_parse_fwnode_endpoints( }EXPORT_SYMBOL_GPL (v4l2_async_notifier_parse_fwnode_endpoints); +static int v4l2_fwnode_reference_parse( + struct device *dev, struct v4l2_async_notifier *notifier,
drivers/media/v4l2-core/v4l2-fwnode.c int v4l2_async_notifier_parse_fwnode_endpoints( · line 463
Quoted 10 lines
drivers/media/v4l2-core/v4l2-fwnode.c +10
-0+ const char *prop) +{ +struct fwnode_reference_args args; +unsigned int index =0 ; +int ret; + +for (; !fwnode_property_get_reference_args ( +dev_fwnode (dev), prop,NULL ,0 , index, &args); index++) +fwnode_handle_put (args.fwnode); +
If nothing is found (i.e. index == 0), shouldn't you just return here?
drivers/media/v4l2-core/v4l2-fwnode.c int v4l2_async_notifier_parse_fwnode_endpoints( · line 469
Quoted 6 lines
drivers/media/v4l2-core/v4l2-fwnode.c +6
-0+ ret =v4l2_async_notifier_realloc (notifier, + notifier->num_subdevs + index); +if (ret) +return -ENOMEM ; + + for (ret = -ENOENT, index = 0;
There is no reason for the 'ret = -ENOENT' to be in the for(), just set it before the 'for' statement.
Quoted 11 lines
drivers/media/v4l2-core/v4l2-fwnode.c +11
-0+ !fwnode_property_get_reference_args ( +dev_fwnode (dev), prop,NULL ,0 , index, &args); + index++) { +struct v4l2_async_subdev *asd; + +if (WARN_ON (notifier->num_subdevs >= notifier->max_subdevs)) { + ret = -EINVAL ; + goto error; + } + + asd =kzalloc (sizeof (*asd),GFP_KERNEL );
drivers/media/v4l2-core/v4l2-fwnode.c int v4l2_async_notifier_parse_fwnode_endpoints( · line 490
Quoted 10 lines
drivers/media/v4l2-core/v4l2-fwnode.c +10
-0+if (!asd) { + ret = -ENOMEM ; + goto error; + } + + notifier->subdevs[notifier->num_subdevs] = asd; + asd->match.fwnode.fwnode = args.fwnode; + asd->match_type =V4L2_ASYNC_MATCH_FWNODE ; + notifier->num_subdevs++; + }
If the loop doesn't find anything, then it still returns 0, not -ENOENT. So why set ret to ENOENT? Something weird going on here.
I think you should also add a comment explaining this function.
drivers/media/v4l2-core/v4l2-fwnode.c int v4l2_async_notifier_parse_fwnode_endpoints(
Quoted 12 lines
drivers/media/v4l2-core/v4l2-fwnode.c +8
-0+ +return 0 ; + +error: +fwnode_handle_put (args.fwnode); +return ret; +} +MODULE_LICENSE ("GPL" );MODULE_AUTHOR ("Sakari Ailus <[email protected]>" );MODULE_AUTHOR ("Sylwester Nawrocki <[email protected]>" );
Regards,
Hans
Re: [PATCH v10 17/24] v4l: fwnode: Add a helper function for parsing generic references
Hi Hans,
Thanks for the review!
Quoted 5 lines · Hans Verkuil
Quoted 4 lines · Sakari Ailus
Add function
v4l2_fwnode_reference_count()for counting external references andv4l2_fwnode_reference_parse()for parsing them as async sub-devices.
Quoted 8 lines
Quoted 6 lines
This can be done on e.g. flash or lens async sub-devices that are not part of but are associated with a sensor.
struct v4l2_async_notifier.max_subdevs field is added to contain the maximum number of sub-devices in a notifier to reflect the memory allocated for the subdevs array.
This paragraph appears to be out-of-date.
Will remove.
Quoted 15 lines
Quoted 15 lines
Signed-off-by Sakari Ailus <[email protected]>--- drivers/media/v4l2-core/v4l2-fwnode.c | 47 +++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+)drivers/media/v4l2-core/v4l2-fwnode.c +0
-0@@ -449,6 +449,53 @@ int v4l2_async_notifier_parse_fwnode_endpoints( }EXPORT_SYMBOL_GPL (v4l2_async_notifier_parse_fwnode_endpoints);
Quoted 14 lines
drivers/media/v4l2-core/v4l2-fwnode.c int v4l2_async_notifier_parse_fwnode_endpoints( · line 463
Quoted 12 lines
drivers/media/v4l2-core/v4l2-fwnode.c +12
-0+static int v4l2_fwnode_reference_parse ( +struct device *dev,struct v4l2_async_notifier *notifier, +const char *prop) +{ +struct fwnode_reference_args args; +unsigned int index =0 ; +int ret; + +for (; !fwnode_property_get_reference_args ( +dev_fwnode (dev), prop,NULL ,0 , index, &args); index++) +fwnode_handle_put (args.fwnode); +If nothing is found (i.e. index == 0), shouldn't you just return here?
You could. yes. It would actually simplify the code, I could just return -ENOENT here.
Quoted 27 lines
drivers/media/v4l2-core/v4l2-fwnode.c int v4l2_async_notifier_parse_fwnode_endpoints( · line 469
Quoted 7 lines
drivers/media/v4l2-core/v4l2-fwnode.c +6
-0+ ret =v4l2_async_notifier_realloc (notifier, + notifier->num_subdevs + index); +if (ret) +return -ENOMEM ; + + for (ret = -ENOENT, index = 0;There is no reason for the 'ret =
-ENOENT' to be in thefor(), just set it before the 'for' statement.Quoted 16 lines
drivers/media/v4l2-core/v4l2-fwnode.c +16
-0+ !fwnode_property_get_reference_args ( +dev_fwnode (dev), prop,NULL ,0 , index, &args); + index++) { +struct v4l2_async_subdev *asd; + +if (WARN_ON (notifier->num_subdevs >= notifier->max_subdevs)) { + ret = -EINVAL ; + goto error; + } + + asd =kzalloc (sizeof (*asd),GFP_KERNEL ); +if (!asd) { + ret = -ENOMEM ; + goto error; + } +
Quoted 8 lines
drivers/media/v4l2-core/v4l2-fwnode.c int v4l2_async_notifier_parse_fwnode_endpoints( · line 490
Quoted 5 lines
drivers/media/v4l2-core/v4l2-fwnode.c +5
-0+ notifier->subdevs[notifier->num_subdevs] = asd; + asd->match.fwnode.fwnode = args.fwnode; + asd->match_type =V4L2_ASYNC_MATCH_FWNODE ; + notifier->num_subdevs++; + }If the loop doesn't find anything, then it still returns 0, not
-ENOENT. So why set ret to ENOENT? Something weird going on here.
:-)
I think -ENOENT would make sense indeed if there are no entries found.
Quoted 2 lines
I think you should also add a comment explaining this function.
Yes. I had that in the header when it was exported, I'll add the same comments here.
Quoted 14 lines
Quoted 13 lines
drivers/media/v4l2-core/v4l2-fwnode.c +8
-0+ +return 0 ; + +error: +fwnode_handle_put (args.fwnode); +return ret; +} +MODULE_LICENSE ("GPL" );MODULE_AUTHOR ("Sakari Ailus <[email protected]>" );MODULE_AUTHOR ("Sylwester Nawrocki <[email protected]>" );
Signature · 4 lines
Regards, Sakari Ailus e-mail: [email protected]
PATCH v10 18/24 v4l: fwnode: Add a helper function to obtain device / interger references
In reply to a message not in the archivev4l2_fwnode_reference_parse_int_prop() will find an fwnode such that under the device's own fwnode, it will follow child fwnodes with the given property -- value pair and return the resulting fwnode.
--- drivers/media/v4l2-core/v4l2-fwnode.c | 93 +++++++++++++++++++++++++++++++++++ 1 file changed, 93 insertions(+)
drivers/media/v4l2-core/v4l2-fwnode.c +93 -0
@@ -496,6 +496,99 @@ static int v4l2_fwnode_reference_parse(return ret; } +static struct fwnode_handle *v4l2_fwnode_reference_get_int_prop ( +struct fwnode_handle *fwnode,const char *prop,unsigned int index, +const char **props,unsigned int nprops) +{ +struct fwnode_reference_args fwnode_args; +unsigned int *args = fwnode_args.args; +struct fwnode_handle *child; +int ret; + + ret =fwnode_property_get_reference_args (fwnode, prop,NULL , nprops, + index, &fwnode_args); +if (ret) +return ERR_PTR (ret == -EINVAL ? -ENOENT : ret); + +for (fwnode = fwnode_args.fwnode; + nprops; nprops--, fwnode = child, props++, args++) { +u32 val; + +fwnode_for_each_child_node (fwnode, child) { +if (fwnode_property_read_u32 (child, *props, &val)) +continue ; + +if (val == *args) +break ; + } + +fwnode_handle_put (fwnode); + +if (!child) { + fwnode =ERR_PTR (-ENOENT ); +break ; + } + } + +return fwnode; +} + +static int v4l2_fwnode_reference_parse_int_props ( +struct device *dev,struct v4l2_async_notifier *notifier, +const char *prop,const char **props,unsigned int nprops) +{ +struct fwnode_handle *fwnode; +unsigned int index =0 ; +int ret; + +while (!IS_ERR ((fwnode =v4l2_fwnode_reference_get_int_prop ( +dev_fwnode (dev), prop, index, props, + nprops)))) { +fwnode_handle_put (fwnode); + index++; + } + +if (PTR_ERR (fwnode) != -ENOENT ) +return PTR_ERR (fwnode); + + ret =v4l2_async_notifier_realloc (notifier, + notifier->num_subdevs + index); +if (ret) +return -ENOMEM ; + +for (index =0 ; !IS_ERR ((fwnode =v4l2_fwnode_reference_get_int_prop ( +dev_fwnode (dev), prop, index, props, + nprops))); ) { +struct v4l2_async_subdev *asd; + +if (WARN_ON (notifier->num_subdevs >= notifier->max_subdevs)) { + ret = -EINVAL ; + goto error; + } + + asd =kzalloc (sizeof (struct v4l2_async_subdev ),GFP_KERNEL ); +if (!asd) { + ret = -ENOMEM ; + goto error; + } + + notifier->subdevs[notifier->num_subdevs] = asd; + asd->match.fwnode.fwnode = fwnode; + asd->match_type =V4L2_ASYNC_MATCH_FWNODE ; + notifier->num_subdevs++; + +fwnode_handle_put (fwnode); + + index++; + } + +return PTR_ERR (fwnode) == -ENOENT ?0 :PTR_ERR (fwnode); + +error: +fwnode_handle_put (fwnode); +return ret; +} +MODULE_LICENSE ("GPL" );MODULE_AUTHOR ("Sakari Ailus <sakari.ailus-VuQAYsv1563Yd54FQh9/[email protected]>" );MODULE_AUTHOR ("Sylwester Nawrocki <[email protected]>" );
Signature · 6 lines
2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v10 18/24] v4l: fwnode: Add a helper function to obtain device / interger references
Typo in subject: interger -> integer
Quoted 2 lines · Sakari Ailus
v4l2_fwnode_reference_parse_int_prop()will find an fwnode such that under the device's own fwnode,
Sorry, you lost me here. Which device are we talking about?
Quoted 2 lines
it will follow child fwnodes with the given property -- value pair and return the resulting fwnode.
property-value pair (easier readable that way).
You only describe v4l2_fwnode_reference_parse_int_prop(), not v4l2_fwnode_reference_parse_int_props().
Quoted 11 lines
Signed-off-by Sakari Ailus <[email protected]>--- drivers/media/v4l2-core/v4l2-fwnode.c | 93 +++++++++++++++++++++++++++++++++++ 1 file changed, 93 insertions(+)drivers/media/v4l2-core/v4l2-fwnode.c +0
-0
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 501
Quoted 6 lines
drivers/media/v4l2-core/v4l2-fwnode.c +3
-0@@ -496,6 +496,99 @@ static int v4l2_fwnode_reference_parse(return ret; } +static struct fwnode_handle *v4l2_fwnode_reference_get_int_prop ( +struct fwnode_handle *fwnode,const char *prop,unsigned int index, +const char **props,unsigned int nprops)
Need comments describing what this does.
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 511
Quoted 10 lines
drivers/media/v4l2-core/v4l2-fwnode.c +10
-0+{ +struct fwnode_reference_args fwnode_args; +unsigned int *args = fwnode_args.args; +struct fwnode_handle *child; +int ret; + + ret =fwnode_property_get_reference_args (fwnode, prop,NULL , nprops, + index, &fwnode_args); +if (ret) +return ERR_PTR (ret == -EINVAL ? -ENOENT : ret);
Why map EINVAL to ENOENT? Needs a comment, either here or in the function description.
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 514
Quoted 3 lines
drivers/media/v4l2-core/v4l2-fwnode.c +3
-0+ +for (fwnode = fwnode_args.fwnode; + nprops; nprops--, fwnode = child, props++, args++) {
I think you cram too much in this for-loop: fwnode, nprops, fwnode, props, args... It's hard to parse.
I would make this a 'while (nprops)' and write out all the other assignments, increments and decrements.
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 522
Quoted 8 lines
drivers/media/v4l2-core/v4l2-fwnode.c +8
-0+u32 val; + +fwnode_for_each_child_node (fwnode, child) { +if (fwnode_property_read_u32 (child, *props, &val)) +continue ; + +if (val == *args) +break ;
I'm lost. This really needs comments and perhaps even an DT or ACPI example so you can see what exactly it is we're doing here.
Quoted 6 lines
drivers/media/v4l2-core/v4l2-fwnode.c +6
-0+ } + +fwnode_handle_put (fwnode); + +if (!child) { + fwnode =ERR_PTR (-ENOENT );
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 538
Quoted 10 lines
drivers/media/v4l2-core/v4l2-fwnode.c +10
-0+break ; + } + } + +return fwnode; +} + +static int v4l2_fwnode_reference_parse_int_props ( +struct device *dev,struct v4l2_async_notifier *notifier, +const char *prop,const char **props,unsigned int nprops)
Needs comments describing what this does.
Quoted 4 lines
drivers/media/v4l2-core/v4l2-fwnode.c +4
-0+{ +struct fwnode_handle *fwnode; +unsigned int index =0 ; +int ret;
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 552
Quoted 10 lines
drivers/media/v4l2-core/v4l2-fwnode.c +10
-0+ +while (!IS_ERR ((fwnode =v4l2_fwnode_reference_get_int_prop ( +dev_fwnode (dev), prop, index, props, + nprops)))) { +fwnode_handle_put (fwnode); + index++; + } + +if (PTR_ERR (fwnode) != -ENOENT ) +return PTR_ERR (fwnode);
Missing 'if (index == 0)'?
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 561
Quoted 9 lines
drivers/media/v4l2-core/v4l2-fwnode.c +9
-0+ + ret =v4l2_async_notifier_realloc (notifier, + notifier->num_subdevs + index); +if (ret) +return -ENOMEM ; + +for (index =0 ; !IS_ERR ((fwnode =v4l2_fwnode_reference_get_int_prop ( +dev_fwnode (dev), prop, index, props, + nprops))); ) {
I'd add 'index++' in this for-loop. It's weird that it is missing.
Quoted 24 lines
drivers/media/v4l2-core/v4l2-fwnode.c +23
-0+struct v4l2_async_subdev *asd; + +if (WARN_ON (notifier->num_subdevs >= notifier->max_subdevs)) { + ret = -EINVAL ; + goto error; + } + + asd =kzalloc (sizeof (struct v4l2_async_subdev ),GFP_KERNEL ); +if (!asd) { + ret = -ENOMEM ; + goto error; + } + + notifier->subdevs[notifier->num_subdevs] = asd; + asd->match.fwnode.fwnode = fwnode; + asd->match_type =V4L2_ASYNC_MATCH_FWNODE ; + notifier->num_subdevs++; + +fwnode_handle_put (fwnode); + + index++; + } +
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse(
Quoted 10 lines
drivers/media/v4l2-core/v4l2-fwnode.c +7
-0+return PTR_ERR (fwnode) == -ENOENT ?0 :PTR_ERR (fwnode); + +error: +fwnode_handle_put (fwnode); +return ret; +} +MODULE_LICENSE ("GPL" );MODULE_AUTHOR ("Sakari Ailus <[email protected]>" );MODULE_AUTHOR ("Sylwester Nawrocki <[email protected]>" );
Regards,
Hans
Re: [PATCH v10 18/24] v4l: fwnode: Add a helper function to obtain device / interger references
Hi Hans,
Thanks for the review.
Quoted 7 lines · Hans Verkuil
Typo in subject: interger -> integer
Quoted 2 lines · Sakari Ailus
v4l2_fwnode_reference_parse_int_prop()will find an fwnode such that under the device's own fwnode,Sorry, you lost me here. Which device are we talking about?
The fwnode related a struct device, in other words what dev_fwnode(dev) gives you. This is either struct device.fwnode or struct device.of_node.fwnode, depending on which firmware interface was used to create the device.
I'll add a note of this.
Quoted 8 lines
Quoted 3 lines
it will follow child fwnodes with the given property -- value pair and return the resulting fwnode.
property-value pair (easier readable that way).
You only describe
v4l2_fwnode_reference_parse_int_prop(), notv4l2_fwnode_reference_parse_int_props().
Yes, I think I changed the naming but forgot to update the commit. I'll do that now.
Quoted 15 lines
Quoted 15 lines
Signed-off-by Sakari Ailus <[email protected]>--- drivers/media/v4l2-core/v4l2-fwnode.c | 93 +++++++++++++++++++++++++++++++++++ 1 file changed, 93 insertions(+)drivers/media/v4l2-core/v4l2-fwnode.c +0
-0@@ -496,6 +496,99 @@ static int v4l2_fwnode_reference_parse(return ret; }
Quoted 5 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 501
Quoted 3 lines
drivers/media/v4l2-core/v4l2-fwnode.c +3
-0+static struct fwnode_handle *v4l2_fwnode_reference_get_int_prop ( +struct fwnode_handle *fwnode,const char *prop,unsigned int index, +const char **props,unsigned int nprops)Need comments describing what this does.
Yes. I'll also rename it (get -> read) for consistency with the async changes.
Quoted 13 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 511
Quoted 11 lines
drivers/media/v4l2-core/v4l2-fwnode.c +10
-0+{ +struct fwnode_reference_args fwnode_args; +unsigned int *args = fwnode_args.args; +struct fwnode_handle *child; +int ret; + + ret =fwnode_property_get_reference_args (fwnode, prop,NULL , nprops, + index, &fwnode_args); +if (ret) +return ERR_PTR (ret == -EINVAL ? -ENOENT : ret);Why map EINVAL to ENOENT? Needs a comment, either here or in the function description.
fwnode_property_get_reference_args() returns currently a little bit different error codes in ACPI / DT. This is worth documenting there and fixing as well.
Quoted 7 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 514
Quoted 4 lines
drivers/media/v4l2-core/v4l2-fwnode.c +3
-0+ +for (fwnode = fwnode_args.fwnode; + nprops; nprops--, fwnode = child, props++, args++) {I think you cram too much in this for-loop: fwnode, nprops, fwnode, props, args... It's hard to parse.
Hmm. I'm not sure if that really helps; the function is just handling each entry in the array and related array pointers are changed accordingly. The fwnode = child assignment is there to move to the child node. I.e. what you need for handling the loop itself.
I can change this though if you think it really makes a difference for better.
Quoted 4 lines
I would make this a 'while (nprops)' and write out all the other assignments, increments and decrements.
Quoted 11 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 522
Quoted 8 lines
drivers/media/v4l2-core/v4l2-fwnode.c +8
-0+u32 val; + +fwnode_for_each_child_node (fwnode, child) { +if (fwnode_property_read_u32 (child, *props, &val)) +continue ; + +if (val == *args) +break ;I'm lost. This really needs comments and perhaps even an DT or ACPI example so you can see what exactly it is we're doing here.
I'll add comments to the code. A good example will be ACPI documentation for LEDs, see 17th patch in v9. That will go through the linux-pm tree so it won't be available in the same tree for a while.
Quoted 11 lines
Quoted 11 lines
drivers/media/v4l2-core/v4l2-fwnode.c +10
-0+ } + +fwnode_handle_put (fwnode); + +if (!child) { + fwnode =ERR_PTR (-ENOENT ); +break ; + } + } +
Quoted 8 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 538
Quoted 6 lines
drivers/media/v4l2-core/v4l2-fwnode.c +6
-0+return fwnode; +} + +static int v4l2_fwnode_reference_parse_int_props ( +struct device *dev,struct v4l2_async_notifier *notifier, +const char *prop,const char **props,unsigned int nprops)Needs comments describing what this does.
Will add.
Quoted 17 lines
Quoted 5 lines
drivers/media/v4l2-core/v4l2-fwnode.c +4
-0+{ +struct fwnode_handle *fwnode; +unsigned int index =0 ; +int ret;drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 552
Quoted 10 lines
drivers/media/v4l2-core/v4l2-fwnode.c +10
-0+ +while (!IS_ERR ((fwnode =v4l2_fwnode_reference_get_int_prop ( +dev_fwnode (dev), prop, index, props, + nprops)))) { +fwnode_handle_put (fwnode); + index++; + } + +if (PTR_ERR (fwnode) != -ENOENT ) +return PTR_ERR (fwnode);Missing 'if (index == 0)'?
Yes, will add.
Quoted 12 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 561
Quoted 10 lines
drivers/media/v4l2-core/v4l2-fwnode.c +9
-0+ + ret =v4l2_async_notifier_realloc (notifier, + notifier->num_subdevs + index); +if (ret) +return -ENOMEM ; + +for (index =0 ; !IS_ERR ((fwnode =v4l2_fwnode_reference_get_int_prop ( +dev_fwnode (dev), prop, index, props, + nprops))); ) {I'd add 'index++' in this for-loop. It's weird that it is missing.
Agreed, I'll move it there.
Quoted 35 lines
Quoted 35 lines
drivers/media/v4l2-core/v4l2-fwnode.c +30
-0+struct v4l2_async_subdev *asd; + +if (WARN_ON (notifier->num_subdevs >= notifier->max_subdevs)) { + ret = -EINVAL ; + goto error; + } + + asd =kzalloc (sizeof (struct v4l2_async_subdev ),GFP_KERNEL ); +if (!asd) { + ret = -ENOMEM ; + goto error; + } + + notifier->subdevs[notifier->num_subdevs] = asd; + asd->match.fwnode.fwnode = fwnode; + asd->match_type =V4L2_ASYNC_MATCH_FWNODE ; + notifier->num_subdevs++; + +fwnode_handle_put (fwnode); + + index++; + } + +return PTR_ERR (fwnode) == -ENOENT ?0 :PTR_ERR (fwnode); + +error: +fwnode_handle_put (fwnode); +return ret; +} +MODULE_LICENSE ("GPL" );MODULE_AUTHOR ("Sakari Ailus <[email protected]>" );MODULE_AUTHOR ("Sylwester Nawrocki <[email protected]>" );
Signature · 4 lines
Regards, Sakari Ailus e-mail: [email protected]
Re: [PATCH v10 18/24] v4l: fwnode: Add a helper function to obtain device / interger references
Quoted 47 lines · Sakari Ailus
Hi Hans,
Thanks for the review.
Quoted 7 lines · Hans Verkuil
Typo in subject: interger -> integer
Quoted 2 lines · Sakari Ailus
v4l2_fwnode_reference_parse_int_prop()will find an fwnode such that under the device's own fwnode,Sorry, you lost me here. Which device are we talking about?
The fwnode related a struct device, in other words what
dev_fwnode(dev)gives you. This is either struct device.fwnode or struct device.of_node.fwnode, depending on which firmware interface was used to create the device.I'll add a note of this.
Quoted 8 lines
Quoted 3 lines
it will follow child fwnodes with the given property -- value pair and return the resulting fwnode.
property-value pair (easier readable that way).
You only describe
v4l2_fwnode_reference_parse_int_prop(), notv4l2_fwnode_reference_parse_int_props().Yes, I think I changed the naming but forgot to update the commit. I'll do that now.
Quoted 15 lines
Quoted 15 lines
Signed-off-by Sakari Ailus <[email protected]>--- drivers/media/v4l2-core/v4l2-fwnode.c | 93 +++++++++++++++++++++++++++++++++++ 1 file changed, 93 insertions(+)drivers/media/v4l2-core/v4l2-fwnode.c +0
-0@@ -496,6 +496,99 @@ static int v4l2_fwnode_reference_parse(return ret; }
Quoted 8 lines
Quoted 5 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 501
Quoted 3 lines
drivers/media/v4l2-core/v4l2-fwnode.c +3
-0+static struct fwnode_handle *v4l2_fwnode_reference_get_int_prop ( +struct fwnode_handle *fwnode,const char *prop,unsigned int index, +const char **props,unsigned int nprops)Need comments describing what this does.
Yes. I'll also rename it (get -> read) for consistency with the async changes.
Which async changes? Since the fwnode_handle that's returned is refcounted I wonder if 'get' isn't the right name in this case.
Quoted 27 lines
Quoted 14 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 511
Quoted 12 lines
drivers/media/v4l2-core/v4l2-fwnode.c +10
-0+{ +struct fwnode_reference_args fwnode_args; +unsigned int *args = fwnode_args.args; +struct fwnode_handle *child; +int ret; + + ret =fwnode_property_get_reference_args (fwnode, prop,NULL , nprops, + index, &fwnode_args); +if (ret) +return ERR_PTR (ret == -EINVAL ? -ENOENT : ret);Why map EINVAL to ENOENT? Needs a comment, either here or in the function description.
fwnode_property_get_reference_args()returns currently a little bit different error codes in ACPI / DT. This is worth documenting there and fixing as well.Quoted 7 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 514
Quoted 4 lines
drivers/media/v4l2-core/v4l2-fwnode.c +3
-0+ +for (fwnode = fwnode_args.fwnode; + nprops; nprops--, fwnode = child, props++, args++) {I think you cram too much in this for-loop: fwnode, nprops, fwnode, props, args... It's hard to parse.
Quoted 7 lines
Hmm. I'm not sure if that really helps; the function is just handling each entry in the array and related array pointers are changed accordingly. The fwnode = child assignment is there to move to the child node. I.e. what you need for handling the loop itself.
I can change this though if you think it really makes a difference for better.
I think so, yes. I noticed you like complex for-loops :-)
Quoted 17 lines
Quoted 5 lines
I would make this a 'while (nprops)' and write out all the other assignments, increments and decrements.
Quoted 11 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 522
Quoted 8 lines
drivers/media/v4l2-core/v4l2-fwnode.c +8
-0+u32 val; + +fwnode_for_each_child_node (fwnode, child) { +if (fwnode_property_read_u32 (child, *props, &val)) +continue ; + +if (val == *args) +break ;I'm lost. This really needs comments and perhaps even an DT or ACPI example so you can see what exactly it is we're doing here.
Quoted 3 lines
I'll add comments to the code. A good example will be ACPI documentation for LEDs, see 17th patch in v9. That will go through the linux-pm tree so it won't be available in the same tree for a while.
Ideally an ACPI and an equivalent DT example would be nice to have, but I might be asking too much. I'm not that familiar with ACPI, so for me a DT example is easier.
Quoted 85 lines
Quoted 12 lines
Quoted 12 lines
drivers/media/v4l2-core/v4l2-fwnode.c +10
-0+ } + +fwnode_handle_put (fwnode); + +if (!child) { + fwnode =ERR_PTR (-ENOENT ); +break ; + } + } +Quoted 8 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 538
Quoted 6 lines
drivers/media/v4l2-core/v4l2-fwnode.c +6
-0+return fwnode; +} + +static int v4l2_fwnode_reference_parse_int_props ( +struct device *dev,struct v4l2_async_notifier *notifier, +const char *prop,const char **props,unsigned int nprops)Needs comments describing what this does.
Will add.
Quoted 17 lines
Quoted 5 lines
drivers/media/v4l2-core/v4l2-fwnode.c +4
-0+{ +struct fwnode_handle *fwnode; +unsigned int index =0 ; +int ret;drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 552
Quoted 10 lines
drivers/media/v4l2-core/v4l2-fwnode.c +10
-0+ +while (!IS_ERR ((fwnode =v4l2_fwnode_reference_get_int_prop ( +dev_fwnode (dev), prop, index, props, + nprops)))) { +fwnode_handle_put (fwnode); + index++; + } + +if (PTR_ERR (fwnode) != -ENOENT ) +return PTR_ERR (fwnode);Missing 'if (index == 0)'?
Yes, will add.
Quoted 12 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 561
Quoted 10 lines
drivers/media/v4l2-core/v4l2-fwnode.c +9
-0+ + ret =v4l2_async_notifier_realloc (notifier, + notifier->num_subdevs + index); +if (ret) +return -ENOMEM ; + +for (index =0 ; !IS_ERR ((fwnode =v4l2_fwnode_reference_get_int_prop ( +dev_fwnode (dev), prop, index, props, + nprops))); ) {I'd add 'index++' in this for-loop. It's weird that it is missing.
Agreed, I'll move it there.
Quoted 27 lines
Quoted 27 lines
drivers/media/v4l2-core/v4l2-fwnode.c +26
-0+struct v4l2_async_subdev *asd; + +if (WARN_ON (notifier->num_subdevs >= notifier->max_subdevs)) { + ret = -EINVAL ; + goto error; + } + + asd =kzalloc (sizeof (struct v4l2_async_subdev ),GFP_KERNEL ); +if (!asd) { + ret = -ENOMEM ; + goto error; + } + + notifier->subdevs[notifier->num_subdevs] = asd; + asd->match.fwnode.fwnode = fwnode; + asd->match_type =V4L2_ASYNC_MATCH_FWNODE ; + notifier->num_subdevs++; + +fwnode_handle_put (fwnode); + + index++; + } + +return PTR_ERR (fwnode) == -ENOENT ?0 :PTR_ERR (fwnode); + +error:
Quoted 9 lines
Quoted 8 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse(
Quoted 8 lines
drivers/media/v4l2-core/v4l2-fwnode.c +4
-0+fwnode_handle_put (fwnode); +return ret; +} +MODULE_LICENSE ("GPL" );MODULE_AUTHOR ("Sakari Ailus <[email protected]>" );MODULE_AUTHOR ("Sylwester Nawrocki <[email protected]>" );
Regards,
Hans
Re: [PATCH v10 18/24] v4l: fwnode: Add a helper function to obtain device / interger references
Hi Hans,
Quoted 54 lines · Hans Verkuil
Quoted 53 lines · Sakari Ailus
Hi Hans,
Thanks for the review.
Quoted 7 lines · Hans Verkuil
Typo in subject: interger -> integer
Quoted 2 lines · Sakari Ailus
v4l2_fwnode_reference_parse_int_prop()will find an fwnode such that under the device's own fwnode,Sorry, you lost me here. Which device are we talking about?
The fwnode related a struct device, in other words what
dev_fwnode(dev)gives you. This is either struct device.fwnode or struct device.of_node.fwnode, depending on which firmware interface was used to create the device.I'll add a note of this.
Quoted 8 lines
Quoted 3 lines
it will follow child fwnodes with the given property -- value pair and return the resulting fwnode.
property-value pair (easier readable that way).
You only describe
v4l2_fwnode_reference_parse_int_prop(), notv4l2_fwnode_reference_parse_int_props().Yes, I think I changed the naming but forgot to update the commit. I'll do that now.
Quoted 20 lines
Quoted 12 lines
Signed-off-by Sakari Ailus <[email protected]>--- drivers/media/v4l2-core/v4l2-fwnode.c | 93 +++++++++++++++++++++++++++++++++++ 1 file changed, 93 insertions(+)drivers/media/v4l2-core/v4l2-fwnode.c +0
-0drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 501
Quoted 6 lines
drivers/media/v4l2-core/v4l2-fwnode.c +3
-0@@ -496,6 +496,99 @@ static int v4l2_fwnode_reference_parse(return ret; } +static struct fwnode_handle *v4l2_fwnode_reference_get_int_prop ( +struct fwnode_handle *fwnode,const char *prop,unsigned int index, +const char **props,unsigned int nprops)Need comments describing what this does.
Quoted 5 lines
Quoted 2 lines
Yes. I'll also rename it (get -> read) for consistency with the async changes.
Which async changes? Since the
fwnode_handlethat's returned is refcounted I wonder if 'get' isn't the right name in this case.
Right. True. I'll leave that as-is then.
Quoted 33 lines
Quoted 33 lines
Quoted 15 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 511
Quoted 13 lines
drivers/media/v4l2-core/v4l2-fwnode.c +10
-0+{ +struct fwnode_reference_args fwnode_args; +unsigned int *args = fwnode_args.args; +struct fwnode_handle *child; +int ret; + + ret =fwnode_property_get_reference_args (fwnode, prop,NULL , nprops, + index, &fwnode_args); +if (ret) +return ERR_PTR (ret == -EINVAL ? -ENOENT : ret);Why map EINVAL to ENOENT? Needs a comment, either here or in the function description.
fwnode_property_get_reference_args()returns currently a little bit different error codes in ACPI / DT. This is worth documenting there and fixing as well.Quoted 7 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 514
Quoted 4 lines
drivers/media/v4l2-core/v4l2-fwnode.c +3
-0+ +for (fwnode = fwnode_args.fwnode; + nprops; nprops--, fwnode = child, props++, args++) {I think you cram too much in this for-loop: fwnode, nprops, fwnode, props, args... It's hard to parse.
Hmm. I'm not sure if that really helps; the function is just handling each entry in the array and related array pointers are changed accordingly. The fwnode = child assignment is there to move to the child node. I.e. what you need for handling the loop itself.
Quoted 4 lines
Quoted 2 lines
I can change this though if you think it really makes a difference for better.
I think so, yes. I noticed you like complex for-loops :-)
I don't really see a difference. The loop increment will just move at the end of the block inside the loop.
Quoted 18 lines
Quoted 18 lines
Quoted 17 lines
I would make this a 'while (nprops)' and write out all the other assignments, increments and decrements.
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 522
Quoted 8 lines
drivers/media/v4l2-core/v4l2-fwnode.c +8
-0+u32 val; + +fwnode_for_each_child_node (fwnode, child) { +if (fwnode_property_read_u32 (child, *props, &val)) +continue ; + +if (val == *args) +break ;I'm lost. This really needs comments and perhaps even an DT or ACPI example so you can see what exactly it is we're doing here.
Quoted 7 lines
Quoted 3 lines
I'll add comments to the code. A good example will be ACPI documentation for LEDs, see 17th patch in v9. That will go through the linux-pm tree so it won't be available in the same tree for a while.
Ideally an ACPI and an equivalent DT example would be nice to have, but I might be asking too much. I'm not that familiar with ACPI, so for me a DT example is easier.
This won't be useful on DT although you could technically use it. In DT you can directly refer to any node but on ACPI you can just refer to devices, hence this.
Would you be happy with the leds.txt example? I think it's a good example as it's directly related to this.
Quoted 99 lines
Quoted 86 lines
Quoted 13 lines
Quoted 13 lines
drivers/media/v4l2-core/v4l2-fwnode.c +10
-0+ } + +fwnode_handle_put (fwnode); + +if (!child) { + fwnode =ERR_PTR (-ENOENT ); +break ; + } + } +Quoted 8 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 538
Quoted 6 lines
drivers/media/v4l2-core/v4l2-fwnode.c +6
-0+return fwnode; +} + +static int v4l2_fwnode_reference_parse_int_props ( +struct device *dev,struct v4l2_async_notifier *notifier, +const char *prop,const char **props,unsigned int nprops)Needs comments describing what this does.
Will add.
Quoted 17 lines
Quoted 5 lines
drivers/media/v4l2-core/v4l2-fwnode.c +4
-0+{ +struct fwnode_handle *fwnode; +unsigned int index =0 ; +int ret;drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 552
Quoted 10 lines
drivers/media/v4l2-core/v4l2-fwnode.c +10
-0+ +while (!IS_ERR ((fwnode =v4l2_fwnode_reference_get_int_prop ( +dev_fwnode (dev), prop, index, props, + nprops)))) { +fwnode_handle_put (fwnode); + index++; + } + +if (PTR_ERR (fwnode) != -ENOENT ) +return PTR_ERR (fwnode);Missing 'if (index == 0)'?
Yes, will add.
Quoted 12 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 561
Quoted 10 lines
drivers/media/v4l2-core/v4l2-fwnode.c +9
-0+ + ret =v4l2_async_notifier_realloc (notifier, + notifier->num_subdevs + index); +if (ret) +return -ENOMEM ; + +for (index =0 ; !IS_ERR ((fwnode =v4l2_fwnode_reference_get_int_prop ( +dev_fwnode (dev), prop, index, props, + nprops))); ) {I'd add 'index++' in this for-loop. It's weird that it is missing.
Agreed, I'll move it there.
Quoted 27 lines
Quoted 27 lines
drivers/media/v4l2-core/v4l2-fwnode.c +26
-0+struct v4l2_async_subdev *asd; + +if (WARN_ON (notifier->num_subdevs >= notifier->max_subdevs)) { + ret = -EINVAL ; + goto error; + } + + asd =kzalloc (sizeof (struct v4l2_async_subdev ),GFP_KERNEL ); +if (!asd) { + ret = -ENOMEM ; + goto error; + } + + notifier->subdevs[notifier->num_subdevs] = asd; + asd->match.fwnode.fwnode = fwnode; + asd->match_type =V4L2_ASYNC_MATCH_FWNODE ; + notifier->num_subdevs++; + +fwnode_handle_put (fwnode); + + index++; + } + +return PTR_ERR (fwnode) == -ENOENT ?0 :PTR_ERR (fwnode); + +error:Quoted 9 lines
Quoted 8 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse(
Quoted 8 lines
drivers/media/v4l2-core/v4l2-fwnode.c +4
-0+fwnode_handle_put (fwnode); +return ret; +} +MODULE_LICENSE ("GPL" );MODULE_AUTHOR ("Sakari Ailus <[email protected]>" );MODULE_AUTHOR ("Sylwester Nawrocki <[email protected]>" );Regards,
Hans
Signature · 2 lines
Sakari Ailus e-mail: [email protected]
Re: [PATCH v10 18/24] v4l: fwnode: Add a helper function to obtain device / interger references
Quoted 128 lines · Sakari Ailus
Hi Hans,
Quoted 54 lines · Hans Verkuil
Quoted 53 lines · Sakari Ailus
Hi Hans,
Thanks for the review.
Quoted 7 lines · Hans Verkuil
Typo in subject: interger -> integer
Quoted 2 lines · Sakari Ailus
v4l2_fwnode_reference_parse_int_prop()will find an fwnode such that under the device's own fwnode,Sorry, you lost me here. Which device are we talking about?
The fwnode related a struct device, in other words what
dev_fwnode(dev)gives you. This is either struct device.fwnode or struct device.of_node.fwnode, depending on which firmware interface was used to create the device.I'll add a note of this.
Quoted 8 lines
Quoted 3 lines
it will follow child fwnodes with the given property -- value pair and return the resulting fwnode.
property-value pair (easier readable that way).
You only describe
v4l2_fwnode_reference_parse_int_prop(), notv4l2_fwnode_reference_parse_int_props().Yes, I think I changed the naming but forgot to update the commit. I'll do that now.
Quoted 20 lines
Quoted 12 lines
Signed-off-by Sakari Ailus <[email protected]>--- drivers/media/v4l2-core/v4l2-fwnode.c | 93 +++++++++++++++++++++++++++++++++++ 1 file changed, 93 insertions(+)drivers/media/v4l2-core/v4l2-fwnode.c +0
-0drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 501
Quoted 6 lines
drivers/media/v4l2-core/v4l2-fwnode.c +3
-0@@ -496,6 +496,99 @@ static int v4l2_fwnode_reference_parse(return ret; } +static struct fwnode_handle *v4l2_fwnode_reference_get_int_prop ( +struct fwnode_handle *fwnode,const char *prop,unsigned int index, +const char **props,unsigned int nprops)Need comments describing what this does.
Quoted 5 lines
Quoted 2 lines
Yes. I'll also rename it (get -> read) for consistency with the async changes.
Which async changes? Since the
fwnode_handlethat's returned is refcounted I wonder if 'get' isn't the right name in this case.Right. True. I'll leave that as-is then.
Quoted 33 lines
Quoted 33 lines
Quoted 15 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 511
Quoted 13 lines
drivers/media/v4l2-core/v4l2-fwnode.c +10
-0+{ +struct fwnode_reference_args fwnode_args; +unsigned int *args = fwnode_args.args; +struct fwnode_handle *child; +int ret; + + ret =fwnode_property_get_reference_args (fwnode, prop,NULL , nprops, + index, &fwnode_args); +if (ret) +return ERR_PTR (ret == -EINVAL ? -ENOENT : ret);Why map EINVAL to ENOENT? Needs a comment, either here or in the function description.
fwnode_property_get_reference_args()returns currently a little bit different error codes in ACPI / DT. This is worth documenting there and fixing as well.Quoted 7 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 514
Quoted 4 lines
drivers/media/v4l2-core/v4l2-fwnode.c +3
-0+ +for (fwnode = fwnode_args.fwnode; + nprops; nprops--, fwnode = child, props++, args++) {I think you cram too much in this for-loop: fwnode, nprops, fwnode, props, args... It's hard to parse.
Hmm. I'm not sure if that really helps; the function is just handling each entry in the array and related array pointers are changed accordingly. The fwnode = child assignment is there to move to the child node. I.e. what you need for handling the loop itself.
Quoted 4 lines
Quoted 2 lines
I can change this though if you think it really makes a difference for better.
I think so, yes. I noticed you like complex for-loops :-)
I don't really see a difference. The loop increment will just move at the end of the block inside the loop.
Quoted 22 lines
Quoted 21 lines
Quoted 6 lines
I would make this a 'while (nprops)' and write out all the other assignments, increments and decrements.
Quoted 11 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 522
Quoted 8 lines
drivers/media/v4l2-core/v4l2-fwnode.c +8
-0+u32 val; + +fwnode_for_each_child_node (fwnode, child) { +if (fwnode_property_read_u32 (child, *props, &val)) +continue ; + +if (val == *args) +break ;I'm lost. This really needs comments and perhaps even an DT or ACPI example so you can see what exactly it is we're doing here.
I'll add comments to the code. A good example will be ACPI documentation for LEDs, see 17th patch in v9. That will go through the linux-pm tree so it won't be available in the same tree for a while.
Quoted 7 lines
Quoted 3 lines
Ideally an ACPI and an equivalent DT example would be nice to have, but I might be asking too much. I'm not that familiar with ACPI, so for me a DT example is easier.
This won't be useful on DT although you could technically use it. In DT you can directly refer to any node but on ACPI you can just refer to devices, hence this.
So this function will effectively only be used with acpi? That should be documented. I think that explains some of my confusion since I was trying to map this code to a device tree, without much success.
Quoted 2 lines
Would you be happy with the leds.txt example? I think it's a good example as it's directly related to this.
Yes, that will work.
Regards,
Hans
Re: [PATCH v10 18/24] v4l: fwnode: Add a helper function to obtain device / interger references
Quoted 20 lines · Hans Verkuil
Quoted 20 lines
Quoted 19 lines
Quoted 12 lines
Quoted 11 lines
drivers/media/v4l2-core/v4l2-fwnode.c static int v4l2_fwnode_reference_parse( · line 522
Quoted 8 lines
drivers/media/v4l2-core/v4l2-fwnode.c +8
-0+u32 val; + +fwnode_for_each_child_node (fwnode, child) { +if (fwnode_property_read_u32 (child, *props, &val)) +continue ; + +if (val == *args) +break ;I'm lost. This really needs comments and perhaps even an DT or ACPI example so you can see what exactly it is we're doing here.
Quoted 3 lines
I'll add comments to the code. A good example will be ACPI documentation for LEDs, see 17th patch in v9. That will go through the linux-pm tree so it won't be available in the same tree for a while.
Ideally an ACPI and an equivalent DT example would be nice to have, but I might be asking too much. I'm not that familiar with ACPI, so for me a DT example is easier.
Quoted 7 lines
Quoted 3 lines
This won't be useful on DT although you could technically use it. In DT you can directly refer to any node but on ACPI you can just refer to devices, hence this.
So this function will effectively only be used with acpi? That should be documented. I think that explains some of my confusion since I was trying to map this code to a device tree, without much success.
I'll add to the documentation of the function:
* While it is technically possible to use this function on DT, it is only
* meaningful on ACPI. On Device tree you can refer to any node in the tree but
* on ACPI the references are limited to devices.
Quoted 5 lines
Quoted 3 lines
Would you be happy with the leds.txt example? I think it's a good example as it's directly related to this.
Yes, that will work.
I'll add a separate patch that I'll post later on. The ACPI documentation should get merged first.
Signature · 2 lines
Sakari Ailus e-mail: [email protected]
PATCH v10 21/24 smiapp: Add support for flash and lens devices
In reply to a message not in the archiveParse async sub-devices by using v4l2_subdev_fwnode_reference_parse_sensor_common().
These types devices aren't directly related to the sensor, but are nevertheless handled by the smiapp driver due to the relationship of these component to the main part of the camera module --- the sensor.
This does not yet address providing the user space with information on how to associate the sensor or lens devices but the kernel now has the necessary information to do that.
--- drivers/media/i2c/smiapp/smiapp-core.c | 38 +++++++++++++++++++++++++++------- drivers/media/i2c/smiapp/smiapp.h | 4 +++- 2 files changed, 33 insertions(+), 9 deletions(-)
drivers/media/i2c/smiapp/smiapp-core.c +30 -8
@@ -31,7 +31,7 @@#include <linux/regulator/consumer.h> #include <linux/slab.h> #include <linux/smiapp.h> -#include <linux/v4l2-mediabus.h> +#include <media/v4l2-async.h> #include <media/v4l2-fwnode.h> #include <media/v4l2-device.h>
@@ -2887,17 +2887,24 @@ static int smiapp_probe(struct i2c_client *client,v4l2_i2c_subdev_init (&sensor->src->sd, client, &smiapp_ops); sensor->src->sd.internal_ops = &smiapp_internal_src_ops; + rval =v4l2_fwnode_reference_parse_sensor_common ( + &client->dev, &sensor->notifier); +if (rval <0 ) +return rval; + sensor->vana =devm_regulator_get (&client->dev,"vana" );if (IS_ERR (sensor->vana)) {dev_err (&client->dev,"could not get regulator for vana\n" ); -return PTR_ERR (sensor->vana); + rval =PTR_ERR (sensor->vana); + goto out_release_async_notifier; } sensor->ext_clk =devm_clk_get (&client->dev,NULL );if (IS_ERR (sensor->ext_clk)) {dev_err (&client->dev,"could not get clock (%ld)\n" ,PTR_ERR (sensor->ext_clk)); -return -EPROBE_DEFER ; + rval = -EPROBE_DEFER ; + goto out_release_async_notifier; } rval =clk_set_rate (sensor->ext_clk, sensor->hwcfg->ext_clk);
@@ -2905,17 +2912,19 @@ static int smiapp_probe(struct i2c_client *client,dev_err (&client->dev,"unable to set clock freq to %u\n" , sensor->hwcfg->ext_clk); -return rval; + goto out_release_async_notifier; } sensor->xshutdown =devm_gpiod_get_optional (&client->dev,"xshutdown" ,GPIOD_OUT_LOW ); -if (IS_ERR (sensor->xshutdown)) -return PTR_ERR (sensor->xshutdown); +if (IS_ERR (sensor->xshutdown)) { + rval =PTR_ERR (sensor->xshutdown); + goto out_release_async_notifier; + } rval =smiapp_power_on (&client->dev);if (rval <0 ) -return rval; + goto out_release_async_notifier; rval =smiapp_identify_module (sensor);if (rval) {
@@ -3092,9 +3101,14 @@ static int smiapp_probe(struct i2c_client *client,if (rval <0 ) goto out_media_entity_cleanup; + rval =v4l2_async_subdev_notifier_register (&sensor->src->sd, + &sensor->notifier); +if (rval) + goto out_media_entity_cleanup; + rval =v4l2_async_register_subdev (&sensor->src->sd);if (rval <0 ) - goto out_media_entity_cleanup; + goto out_unregister_async_notifier;pm_runtime_set_active (&client->dev);pm_runtime_get_noresume (&client->dev);
@@ -3105,6 +3119,9 @@ static int smiapp_probe(struct i2c_client *client,return 0 ; +out_unregister_async_notifier: +v4l2_async_notifier_unregister (&sensor->notifier); + out_media_entity_cleanup:media_entity_cleanup (&sensor->src->sd.entity);
@@ -3114,6 +3131,9 @@ static int smiapp_probe(struct i2c_client *client, out_power_off:smiapp_power_off (&client->dev); +out_release_async_notifier: +v4l2_async_notifier_release (&sensor->notifier); +return rval; }
@@ -3124,6 +3144,8 @@ static int smiapp_remove(struct i2c_client *client)unsigned int i;v4l2_async_unregister_subdev (subdev); +v4l2_async_notifier_unregister (&sensor->notifier); +v4l2_async_notifier_release (&sensor->notifier);pm_runtime_disable (&client->dev);if (!pm_runtime_status_suspended (&client->dev))
drivers/media/i2c/smiapp/smiapp.h +3 -1
@@ -20,9 +20,10 @@#define __SMIAPP_PRIV_H_#include <linux/mutex.h> +#include <media/i2c/smiapp.h> +#include <media/v4l2-async.h> #include <media/v4l2-ctrls.h> #include <media/v4l2-subdev.h> -#include <media/i2c/smiapp.h> #include "smiapp-pll.h" #include "smiapp-reg.h"
@@ -172,6 +173,7 @@ struct smiapp_subdev {* struct smiapp_sensor - Main device structure */ struct smiapp_sensor { +struct v4l2_async_notifier notifier;/* * "mutex" is used to serialise access to all fields here * except v4l2_ctrls at the end of the struct. "mutex" is also
Signature · 6 lines
2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v10 21/24] smiapp: Add support for flash and lens devices
Quoted 7 lines · Sakari Ailus
Parse async sub-devices by using
v4l2_subdev_fwnode_reference_parse_sensor_common().These types devices aren't directly related to the sensor, but are nevertheless handled by the smiapp driver due to the relationship of these component to the main part of the camera module --- the sensor.
Quoted 5 lines
This does not yet address providing the user space with information on how to associate the sensor or lens devices but the kernel now has the necessary information to do that.
Signed-off-by Sakari Ailus <[email protected]>
Regards,
Hans
Quoted 139 lines
--- drivers/media/i2c/smiapp/smiapp-core.c | 38 +++++++++++++++++++++++++++------- drivers/media/i2c/smiapp/smiapp.h | 4 +++- 2 files changed, 33 insertions(+), 9 deletions(-)drivers/media/i2c/smiapp/smiapp-core.c +30
-8@@ -31,7 +31,7 @@#include <linux/regulator/consumer.h> #include <linux/slab.h> #include <linux/smiapp.h> -#include <linux/v4l2-mediabus.h> +#include <media/v4l2-async.h> #include <media/v4l2-fwnode.h> #include <media/v4l2-device.h> @@ -2887,17 +2887,24 @@ static int smiapp_probe(struct i2c_client *client,v4l2_i2c_subdev_init (&sensor->src->sd, client, &smiapp_ops); sensor->src->sd.internal_ops = &smiapp_internal_src_ops; + rval =v4l2_fwnode_reference_parse_sensor_common ( + &client->dev, &sensor->notifier); +if (rval <0 ) +return rval; + sensor->vana =devm_regulator_get (&client->dev,"vana" );if (IS_ERR (sensor->vana)) {dev_err (&client->dev,"could not get regulator for vana\n" ); -return PTR_ERR (sensor->vana); + rval =PTR_ERR (sensor->vana); + goto out_release_async_notifier; } sensor->ext_clk =devm_clk_get (&client->dev,NULL );if (IS_ERR (sensor->ext_clk)) {dev_err (&client->dev,"could not get clock (%ld)\n" ,PTR_ERR (sensor->ext_clk)); -return -EPROBE_DEFER ; + rval = -EPROBE_DEFER ; + goto out_release_async_notifier; } rval =clk_set_rate (sensor->ext_clk, sensor->hwcfg->ext_clk);@@ -2905,17 +2912,19 @@ static int smiapp_probe(struct i2c_client *client,dev_err (&client->dev,"unable to set clock freq to %u\n" , sensor->hwcfg->ext_clk); -return rval; + goto out_release_async_notifier; } sensor->xshutdown =devm_gpiod_get_optional (&client->dev,"xshutdown" ,GPIOD_OUT_LOW ); -if (IS_ERR (sensor->xshutdown)) -return PTR_ERR (sensor->xshutdown); +if (IS_ERR (sensor->xshutdown)) { + rval =PTR_ERR (sensor->xshutdown); + goto out_release_async_notifier; + } rval =smiapp_power_on (&client->dev);if (rval <0 ) -return rval; + goto out_release_async_notifier; rval =smiapp_identify_module (sensor);if (rval) {@@ -3092,9 +3101,14 @@ static int smiapp_probe(struct i2c_client *client,if (rval <0 ) goto out_media_entity_cleanup; + rval =v4l2_async_subdev_notifier_register (&sensor->src->sd, + &sensor->notifier); +if (rval) + goto out_media_entity_cleanup; + rval =v4l2_async_register_subdev (&sensor->src->sd);if (rval <0 ) - goto out_media_entity_cleanup; + goto out_unregister_async_notifier;pm_runtime_set_active (&client->dev);pm_runtime_get_noresume (&client->dev);@@ -3105,6 +3119,9 @@ static int smiapp_probe(struct i2c_client *client,return 0 ; +out_unregister_async_notifier: +v4l2_async_notifier_unregister (&sensor->notifier); + out_media_entity_cleanup:media_entity_cleanup (&sensor->src->sd.entity);@@ -3114,6 +3131,9 @@ static int smiapp_probe(struct i2c_client *client, out_power_off:smiapp_power_off (&client->dev); +out_release_async_notifier: +v4l2_async_notifier_release (&sensor->notifier); +return rval; }@@ -3124,6 +3144,8 @@ static int smiapp_remove(struct i2c_client *client)unsigned int i;v4l2_async_unregister_subdev (subdev); +v4l2_async_notifier_unregister (&sensor->notifier); +v4l2_async_notifier_release (&sensor->notifier);pm_runtime_disable (&client->dev);if (!pm_runtime_status_suspended (&client->dev))drivers/media/i2c/smiapp/smiapp.h +3
-1@@ -20,9 +20,10 @@#define __SMIAPP_PRIV_H_#include <linux/mutex.h> +#include <media/i2c/smiapp.h> +#include <media/v4l2-async.h> #include <media/v4l2-ctrls.h> #include <media/v4l2-subdev.h> -#include <media/i2c/smiapp.h> #include "smiapp-pll.h" #include "smiapp-reg.h" @@ -172,6 +173,7 @@ struct smiapp_subdev {* struct smiapp_sensor - Main device structure */ struct smiapp_sensor { +struct v4l2_async_notifier notifier;/* * "mutex" is used to serialise access to all fields here * except v4l2_ctrls at the end of the struct. "mutex" is also
Sakari Ailus
maintainerPATCH v10 5/24 v4l: fwnode: Support generic parsing of graph endpoints in a device
In reply to Sakari AilusThe current practice is that drivers iterate over their endpoints and parse each endpoint separately. This is very similar in a number of drivers, implement a generic function for the job. Driver specific matters can be taken into account in the driver specific callback.
--- drivers/media/v4l2-core/v4l2-async.c | 30 ++++++++ drivers/media/v4l2-core/v4l2-fwnode.c | 136 ++++++++++++++++++++++++++++++++++ include/media/v4l2-async.h | 24 +++++- include/media/v4l2-fwnode.h | 56 ++++++++++++++ 4 files changed, 244 insertions(+), 2 deletions(-)
drivers/media/v4l2-core/v4l2-async.c +30 -0
@@ -22,6 +22,7 @@#include <media/v4l2-async.h> #include <media/v4l2-device.h> +#include <media/v4l2-fwnode.h> #include <media/v4l2-subdev.h> static bool match_i2c (struct v4l2_subdev *sd,struct v4l2_async_subdev *asd)
@@ -219,6 +220,35 @@ void v4l2_async_notifier_unregister(struct v4l2_async_notifier *notifier) }EXPORT_SYMBOL (v4l2_async_notifier_unregister); +void v4l2_async_notifier_release (struct v4l2_async_notifier *notifier) +{ +unsigned int i; + +if (!notifier->max_subdevs) +return ; + +for (i =0 ; i < notifier->num_subdevs; i++) { +struct v4l2_async_subdev *asd = notifier->subdevs[i]; + +switch (asd->match_type) { +case V4L2_ASYNC_MATCH_FWNODE : +fwnode_handle_put (asd->match.fwnode.fwnode); +break ; +default : +WARN_ON_ONCE (1 ); + } + +kfree (asd); + } + + notifier->max_subdevs =0 ; + notifier->num_subdevs =0 ; + +kvfree (notifier->subdevs); + notifier->subdevs =NULL ; +} +EXPORT_SYMBOL_GPL (v4l2_async_notifier_release); +int v4l2_async_register_subdev (struct v4l2_subdev *sd) {struct v4l2_async_notifier *notifier;
drivers/media/v4l2-core/v4l2-fwnode.c +136 -0
154 lines not on this page · raw message
include/media/v4l2-async.h +22 -2
@@ -18,7 +18,6 @@ struct device;struct device_node ;struct v4l2_device ;struct v4l2_subdev ; -struct v4l2_async_notifier ;/* A random max subdevice number, used to allocate an array on stack */ #define V4L2_MAX_SUBDEVS 128U
@@ -50,6 +49,10 @@ enum v4l2_async_match_type {* @match: union of per-bus type matching data sets * @list: used to link struct v4l2_async_subdev objects, waiting to be * probed, to a notifier->waiting list +* +* When this struct is used as a member in a driver specific struct, +* the driver specific struct shall contain the @struct +* v4l2_async_subdev as its first member. */ struct v4l2_async_subdev {enum v4l2_async_match_type match_type;
@@ -78,7 +81,8 @@ struct v4l2_async_subdev {/** * struct v4l2_async_notifier - v4l2_device notifier data * -* @num_subdevs: number of subdevices +* @num_subdevs: number of subdevices used in the subdevs array +* @max_subdevs: number of subdevices allocated in the subdevs array * @subdevs: array of pointers to subdevice descriptors * @v4l2_dev: pointer to struct v4l2_device * @waiting: list of struct v4l2_async_subdev, waiting for their drivers
@@ -90,6 +94,7 @@ struct v4l2_async_subdev {*/ struct v4l2_async_notifier {unsigned int num_subdevs; +unsigned int max_subdevs;struct v4l2_async_subdev **subdevs;struct v4l2_device *v4l2_dev;struct list_head waiting;
@@ -121,6 +126,21 @@ int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev,void v4l2_async_notifier_unregister (struct v4l2_async_notifier *notifier);/** +* v4l2_async_notifier_release - release notifier resources +* @notifier: the notifier the resources of which are to be released +* +* Release memory resources related to a notifier, including the async +* sub-devices allocated for the purposes of the notifier. The user is +* responsible for releasing the notifier's resources after calling +* @v4l2_async_notifier_parse_fwnode_endpoints. +* +* There is no harm from calling v4l2_async_notifier_release in other +* cases as long as its memory has been zeroed after it has been +* allocated. +*/ +void v4l2_async_notifier_release (struct v4l2_async_notifier *notifier); + +/** * v4l2_async_register_subdev - registers a sub-device to the asynchronous * subdevice framework *
include/media/v4l2-fwnode.h +56 -0
66 lines not on this page · raw message
Signature · 1 line
2.11.0
Sakari Ailus
maintainerPATCH v10 8/24 omap3isp: Fix check for our own sub-devices
In reply to Sakari AilusWe only want to link sub-devices that were bound to the async notifier the isp driver registered but there may be other sub-devices in the v4l2_device as well. Check for the correct async notifier.
--- drivers/media/platform/omap3isp/isp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/omap3isp/isp.c +1 -1
@@ -2155,7 +2155,7 @@ static int isp_subdev_notifier_complete(struct v4l2_async_notifier *async)return ret;list_for_each_entry (sd, &v4l2_dev->subdevs, list) { -if (!sd->asd) +if (sd->notifier != &isp->notifier)continue ; ret = isp_link_entity(isp, &sd->entity,
Signature · 1 line
2.11.0
Sakari Ailus
maintainerPATCH v10 9/24 omap3isp: Print the name of the entity where no source pads could be found
In reply to Sakari AilusIf no source pads are found in an entity, print the name of the entity.
--- drivers/media/platform/omap3isp/isp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/platform/omap3isp/isp.c +2 -2
@@ -1669,8 +1669,8 @@ static int isp_link_entity(break ; }if (i == entity->num_pads) { -dev_err (isp->dev,"%s: no source pad in external entity\n" , - __func__); +dev_err (isp->dev,"%s: no source pad in external entity %s\n" , + __func__, entity->name);return -EINVAL ; }
Signature · 1 line
2.11.0
Sakari Ailus
maintainerPATCH v10 11/24 v4l: async: Introduce helpers for calling async ops callbacks
In reply to Sakari AilusAdd three helper functions to call async operations callbacks. Besides simplifying callbacks, this allows async notifiers to have no ops set, i.e. it can be left NULL.
--- drivers/media/v4l2-core/v4l2-async.c | 49 ++++++++++++++++++++++++++---------- include/media/v4l2-async.h | 1 + 2 files changed, 37 insertions(+), 13 deletions(-)
drivers/media/v4l2-core/v4l2-async.c +36 -13
@@ -25,6 +25,34 @@#include <media/v4l2-fwnode.h> #include <media/v4l2-subdev.h> +static int v4l2_async_notifier_call_bound (struct v4l2_async_notifier *n, +struct v4l2_subdev *subdev, +struct v4l2_async_subdev *asd) +{ +if (!n->ops || !n->ops->bound) +return 0 ; + +return n->ops->bound (n, subdev, asd); +} + +static void v4l2_async_notifier_call_unbind (struct v4l2_async_notifier *n, +struct v4l2_subdev *subdev, +struct v4l2_async_subdev *asd) +{ +if (!n->ops || !n->ops->unbind) +return ; + + n->ops->unbind (n, subdev, asd); +} + +static int v4l2_async_notifier_call_complete (struct v4l2_async_notifier *n) +{ +if (!n->ops || !n->ops->complete) +return 0 ; + +return n->ops->complete (n); +} +static bool match_i2c (struct v4l2_subdev *sd,struct v4l2_async_subdev *asd) {#if IS_ENABLED (CONFIG_I2C )
@@ -102,16 +130,13 @@ static int v4l2_async_match_notify(struct v4l2_async_notifier *notifier, {int ret; -if (notifier->ops->bound) { - ret = notifier->ops->bound (notifier, sd, asd); -if (ret <0 ) -return ret; - } + ret =v4l2_async_notifier_call_bound (notifier, sd, asd); +if (ret <0 ) +return ret; ret =v4l2_device_register_subdev (notifier->v4l2_dev, sd);if (ret <0 ) { -if (notifier->ops->unbind) - notifier->ops->unbind (notifier, sd, asd); +v4l2_async_notifier_call_unbind (notifier, sd, asd);return ret; }
@@ -123,8 +148,8 @@ static int v4l2_async_match_notify(struct v4l2_async_notifier *notifier,/* Move from the global subdevice list to notifier's done */ list_move (&sd->async_list, ¬ifier->done); -if (list_empty (¬ifier->waiting) && notifier->ops->complete) -return notifier->ops->complete (notifier); +if (list_empty (¬ifier->waiting)) +return v4l2_async_notifier_call_complete (notifier);return 0 ; }
@@ -210,8 +235,7 @@ void v4l2_async_notifier_unregister(struct v4l2_async_notifier *notifier)list_for_each_entry_safe (sd, tmp, ¬ifier->done, async_list) {v4l2_async_cleanup (sd); -if (notifier->ops->unbind) - notifier->ops->unbind (notifier, sd, sd->asd); +v4l2_async_notifier_call_unbind (notifier, sd, sd->asd); }mutex_unlock (&list_lock);
@@ -300,8 +324,7 @@ void v4l2_async_unregister_subdev(struct v4l2_subdev *sd)v4l2_async_cleanup (sd); -if (notifier->ops->unbind) - notifier->ops->unbind (notifier, sd, sd->asd); +v4l2_async_notifier_call_unbind (notifier, sd, sd->asd);mutex_unlock (&list_lock); }
include/media/v4l2-async.h +1 -0
@@ -164,4 +164,5 @@ int v4l2_async_register_subdev(struct v4l2_subdev *sd);* @sd: pointer to &struct v4l2_subdev */ void v4l2_async_unregister_subdev (struct v4l2_subdev *sd); +#endif
Signature · 1 line
2.11.0
Sakari Ailus
maintainerPATCH v10 12/24 v4l: async: Register sub-devices before calling bound callback
In reply to Sakari AilusRegister the sub-device before calling the notifier's bound callback. Doing this the other way around is problematic as the struct v4l2_device has not assigned for the sub-device yet and may be required by the bound callback.
--- drivers/media/v4l2-core/v4l2-async.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/media/v4l2-core/v4l2-async.c +3 -3
@@ -130,13 +130,13 @@ static int v4l2_async_match_notify(struct v4l2_async_notifier *notifier, {int ret; - ret =v4l2_async_notifier_call_bound (notifier, sd, asd); + ret =v4l2_device_register_subdev (notifier->v4l2_dev, sd);if (ret <0 )return ret; - ret =v4l2_device_register_subdev (notifier->v4l2_dev, sd); + ret =v4l2_async_notifier_call_bound (notifier, sd, asd);if (ret <0 ) { -v4l2_async_notifier_call_unbind (notifier, sd, asd); +v4l2_device_unregister_subdev (sd);return ret; }
Signature · 1 line
2.11.0
Sakari Ailus
maintainerPATCH v10 15/24 dt: bindings: Add a binding for flash LED devices associated to a sensor
In reply to Sakari AilusCamera flash drivers (and LEDs) are separate from the sensor devices in DT. In order to make an association between the two, provide the association information to the software.
--- Documentation/devicetree/bindings/media/video-interfaces.txt | 8 ++++++++ 1 file changed, 8 insertions(+)
Documentation/devicetree/bindings/media/video-interfaces.txt +8 -0
@@ -67,6 +67,14 @@ are required in a relevant parent node: identifier, should be 1. - #size-cells : should be zero. + +Optional properties +------------------- + +- flash-leds: An array of phandles, each referring to a flash LED, a sub-node + of the LED driver device node. + + Optional endpoint properties ----------------------------
Signature · 1 line
2.11.0
Sakari Ailus
maintainerPATCH v10 16/24 dt: bindings: Add lens-focus binding for image sensors
In reply to Sakari AilusThe lens-focus property contains a phandle to the lens voice coil driver that is associated to the sensor; typically both are contained in the same camera module.
--- Documentation/devicetree/bindings/media/video-interfaces.txt | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/media/video-interfaces.txt +2 -0
@@ -74,6 +74,8 @@ Optional properties - flash-leds: An array of phandles, each referring to a flash LED, a sub-node of the LED driver device node. +- lens-focus: A phandle to the node of the focus lens controller. + Optional endpoint properties ----------------------------
Signature · 1 line
2.11.0
Sakari Ailus
maintainerPATCH v10 19/24 v4l: fwnode: Add convenience function for parsing common external refs
In reply to Sakari AilusAdd v4l2_fwnode_parse_reference_sensor_common for parsing common sensor properties that refer to adjacent devices such as flash or lens driver chips.
As this is an association only, there's little a regular driver needs to know about these devices as such.
--- drivers/media/v4l2-core/v4l2-fwnode.c | 35 +++++++++++++++++++++++++++++++++++ include/media/v4l2-fwnode.h | 13 +++++++++++++ 2 files changed, 48 insertions(+)
drivers/media/v4l2-core/v4l2-fwnode.c +35 -0
@@ -589,6 +589,41 @@ static int v4l2_fwnode_reference_parse_int_props(return ret; } +int v4l2_fwnode_reference_parse_sensor_common ( +struct device *dev,struct v4l2_async_notifier *notifier) +{ +static const char *led_props[] = {"led" }; +static const struct { +const char *name; +const char **props; +unsigned int nprops; + } props[] = { + {"flash-leds" , led_props,ARRAY_SIZE (led_props) }, + {"lens-focus" ,NULL ,0 }, + }; +unsigned int i; + +for (i =0 ; i <ARRAY_SIZE (props); i++) { +int ret; + +if (props[i].props &&is_acpi_node (dev_fwnode (dev))) + ret =v4l2_fwnode_reference_parse_int_props ( + dev, notifier, props[i].name, + props[i].props, props[i].nprops); +else + ret =v4l2_fwnode_reference_parse ( + dev, notifier, props[i].name); +if (ret) { +dev_warn (dev,"parsing property \"%s\" failed (%d)\n" , + props[i].name, ret); +return ret; + } + } + +return 0 ; +} +EXPORT_SYMBOL_GPL (v4l2_fwnode_reference_parse_sensor_common); +MODULE_LICENSE ("GPL" );MODULE_AUTHOR ("Sakari Ailus <[email protected]>" );MODULE_AUTHOR ("Sylwester Nawrocki <[email protected]>" );
include/media/v4l2-fwnode.h +13 -0
@@ -257,4 +257,17 @@ int v4l2_async_notifier_parse_fwnode_endpoints(struct v4l2_fwnode_endpoint *vep, struct v4l2_async_subdev *asd)); +/** +* v4l2_fwnode_reference_parse_sensor_common - parse common references on +* sensors for async sub-devices +* @dev: the device node the properties of which are parsed for references +* @notifier: the async notifier where the async subdevs will be added +* +* Return: 0 on success +* -ENOMEM if memory allocation failed +* -EINVAL if property parsing failed +*/ +int v4l2_fwnode_reference_parse_sensor_common ( +struct device *dev,struct v4l2_async_notifier *notifier); +#endif /* _V4L2_FWNODE_H */
Signature · 1 line
2.11.0
Re: [PATCH v10 19/24] v4l: fwnode: Add convenience function for parsing common external refs
Quoted 65 lines · Sakari Ailus
Add
v4l2_fwnode_parse_reference_sensor_commonfor parsing common sensor properties that refer to adjacent devices such as flash or lens driver chips.As this is an association only, there's little a regular driver needs to know about these devices as such.
Signed-off-by Sakari Ailus <[email protected]>Acked-by Hans Verkuil <[email protected]>--- drivers/media/v4l2-core/v4l2-fwnode.c | 35 +++++++++++++++++++++++++++++++++++ include/media/v4l2-fwnode.h | 13 +++++++++++++ 2 files changed, 48 insertions(+)drivers/media/v4l2-core/v4l2-fwnode.c +35
-0@@ -589,6 +589,41 @@ static int v4l2_fwnode_reference_parse_int_props(return ret; } +int v4l2_fwnode_reference_parse_sensor_common ( +struct device *dev,struct v4l2_async_notifier *notifier) +{ +static const char *led_props[] = {"led" }; +static const struct { +const char *name; +const char **props; +unsigned int nprops; + } props[] = { + {"flash-leds" , led_props,ARRAY_SIZE (led_props) }, + {"lens-focus" ,NULL ,0 }, + }; +unsigned int i; + +for (i =0 ; i <ARRAY_SIZE (props); i++) { +int ret; + +if (props[i].props &&is_acpi_node (dev_fwnode (dev))) + ret =v4l2_fwnode_reference_parse_int_props ( + dev, notifier, props[i].name, + props[i].props, props[i].nprops); +else + ret =v4l2_fwnode_reference_parse ( + dev, notifier, props[i].name); +if (ret) { +dev_warn (dev,"parsing property \"%s\" failed (%d)\n" , + props[i].name, ret); +return ret; + } + } + +return 0 ; +} +EXPORT_SYMBOL_GPL (v4l2_fwnode_reference_parse_sensor_common); +MODULE_LICENSE ("GPL" );MODULE_AUTHOR ("Sakari Ailus <[email protected]>" );MODULE_AUTHOR ("Sylwester Nawrocki <[email protected]>" );include/media/v4l2-fwnode.h +0
-0
include/media/v4l2-fwnode.h int v4l2_async_notifier_parse_fwnode_endpoints( · line 265
Quoted 9 lines
include/media/v4l2-fwnode.h +6
-0@@ -257,4 +257,17 @@ int v4l2_async_notifier_parse_fwnode_endpoints(struct v4l2_fwnode_endpoint *vep, struct v4l2_async_subdev *asd)); +/** +* v4l2_fwnode_reference_parse_sensor_common - parse common references on +* sensors for async sub-devices +* @dev: the device node the properties of which are parsed for references +* @notifier: the async notifier where the async subdevs will be added +*
I think you should add a note that if this function returns 0 the caller should remember to call v4l2_async_notifier_release. That is not immediately obvious.
Regards,
Hans
Quoted 9 lines
include/media/v4l2-fwnode.h +7
-0+* Return: 0 on success +* -ENOMEM if memory allocation failed +* -EINVAL if property parsing failed +*/ +int v4l2_fwnode_reference_parse_sensor_common ( +struct device *dev,struct v4l2_async_notifier *notifier); +#endif /* _V4L2_FWNODE_H */
Re: [PATCH v10 19/24] v4l: fwnode: Add convenience function for parsing common external refs
Quoted 69 lines · Hans Verkuil
Quoted 68 lines · Sakari Ailus
Add
v4l2_fwnode_parse_reference_sensor_commonfor parsing common sensor properties that refer to adjacent devices such as flash or lens driver chips.As this is an association only, there's little a regular driver needs to know about these devices as such.
Signed-off-by Sakari Ailus <[email protected]>Acked-by Hans Verkuil <[email protected]>--- drivers/media/v4l2-core/v4l2-fwnode.c | 35 +++++++++++++++++++++++++++++++++++ include/media/v4l2-fwnode.h | 13 +++++++++++++ 2 files changed, 48 insertions(+)drivers/media/v4l2-core/v4l2-fwnode.c +35
-0@@ -589,6 +589,41 @@ static int v4l2_fwnode_reference_parse_int_props(return ret; } +int v4l2_fwnode_reference_parse_sensor_common ( +struct device *dev,struct v4l2_async_notifier *notifier) +{ +static const char *led_props[] = {"led" }; +static const struct { +const char *name; +const char **props; +unsigned int nprops; + } props[] = { + {"flash-leds" , led_props,ARRAY_SIZE (led_props) }, + {"lens-focus" ,NULL ,0 }, + }; +unsigned int i; + +for (i =0 ; i <ARRAY_SIZE (props); i++) { +int ret; + +if (props[i].props &&is_acpi_node (dev_fwnode (dev))) + ret =v4l2_fwnode_reference_parse_int_props ( + dev, notifier, props[i].name, + props[i].props, props[i].nprops); +else + ret =v4l2_fwnode_reference_parse ( + dev, notifier, props[i].name); +if (ret) { +dev_warn (dev,"parsing property \"%s\" failed (%d)\n" , + props[i].name, ret); +return ret; + } + } + +return 0 ; +} +EXPORT_SYMBOL_GPL (v4l2_fwnode_reference_parse_sensor_common); +MODULE_LICENSE ("GPL" );MODULE_AUTHOR ("Sakari Ailus <[email protected]>" );MODULE_AUTHOR ("Sylwester Nawrocki <[email protected]>" );include/media/v4l2-fwnode.h +0
-0@@ -257,4 +257,17 @@ int v4l2_async_notifier_parse_fwnode_endpoints(struct v4l2_fwnode_endpoint *vep, struct v4l2_async_subdev *asd));
Quoted 10 lines
include/media/v4l2-fwnode.h int v4l2_async_notifier_parse_fwnode_endpoints( · line 265
Quoted 6 lines
include/media/v4l2-fwnode.h +6
-0+/** +* v4l2_fwnode_reference_parse_sensor_common - parse common references on +* sensors for async sub-devices +* @dev: the device node the properties of which are parsed for references +* @notifier: the async notifier where the async subdevs will be added +* I think you should add a note that if this function returns 0 the caller should remember to call
v4l2_async_notifier_release. That is not immediately obvious.
I'll add that, plus a note to v4l2_async_notifier_release() as well.
Signature · 2 lines
Sakari Ailus e-mail: [email protected]
Re: [PATCH v10 19/24] v4l: fwnode: Add convenience function for parsing common external refs
In reply to Sakari AilusQuoted 15 lines · Sakari Ailus
Add
v4l2_fwnode_parse_reference_sensor_commonfor parsing common sensor properties that refer to adjacent devices such as flash or lens driver chips.As this is an association only, there's little a regular driver needs to know about these devices as such.
Signed-off-by Sakari Ailus <[email protected]>Acked-by Hans Verkuil <[email protected]>--- drivers/media/v4l2-core/v4l2-fwnode.c | 35 +++++++++++++++++++++++++++++++++++ include/media/v4l2-fwnode.h | 13 +++++++++++++ 2 files changed, 48 insertions(+)
Quoted 10 lines
+/**
+ *v4l2_fwnode_reference_parse_sensor_common- parse common references on
+ * sensors for async sub-devices
+ * @dev: the device node the properties of which are parsed for references
+ * @notifier: the async notifier where the async subdevs will be added
+ *
+ * Return: 0 on success
+ *-ENOMEMif memory allocation failed
+ *-EINVALif property parsing failed
+ */
Returns: would sound more correct to me, but it seems kernel is split on that.
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Re: [PATCH v10 19/24] v4l: fwnode: Add convenience function for parsing common external refs
Quoted 27 lines · Pavel Machek
Quoted 15 lines · Sakari Ailus
Add
v4l2_fwnode_parse_reference_sensor_commonfor parsing common sensor properties that refer to adjacent devices such as flash or lens driver chips.As this is an association only, there's little a regular driver needs to know about these devices as such.
Signed-off-by Sakari Ailus <[email protected]>Acked-by Hans Verkuil <[email protected]>--- drivers/media/v4l2-core/v4l2-fwnode.c | 35 +++++++++++++++++++++++++++++++++++ include/media/v4l2-fwnode.h | 13 +++++++++++++ 2 files changed, 48 insertions(+)Quoted 10 lines
+/**
+ *v4l2_fwnode_reference_parse_sensor_common- parse common references on
+ * sensors for async sub-devices
+ * @dev: the device node the properties of which are parsed for references
+ * @notifier: the async notifier where the async subdevs will be added
+ *
+ * Return: 0 on success
+ *-ENOMEMif memory allocation failed
+ *-EINVALif property parsing failed
+ */
Quoted 2 lines
Returns: would sound more correct to me, but it seems kernel is split on that.
I think in V4L2 there are roughly as many of each instances. I'll keep it as it is.
Quoted 2 lines
Acked-by Pavel Machek <[email protected]>
Thanks!
Signature · 2 lines
Sakari Ailus e-mail: [email protected]
Sakari Ailus
maintainerPATCH v10 20/24 dt: bindings: smiapp: Document lens-focus and flash properties
In reply to Sakari AilusDocument optional lens-focus and flash properties for the smiapp driver.
--- Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/media/i2c/nokia,smia.txt +2 -0
@@ -27,6 +27,8 @@ Optional properties - nokia,nvm-size: The size of the NVM, in bytes. If the size is not given, the NVM contents will not be read. - reset-gpios: XSHUTDOWN GPIO +- flash-leds: See ../video-interfaces.txt +- lens-focus: See ../video-interfaces.txt Endpoint node mandatory properties
Signature · 1 line
2.11.0
A message that is not in the archive (sent off-list or not yet received): 20170911080008.21208-21-sakari.ailus-VuQAYsv1563Yd54FQh9/[email protected]
Hans Verkuil
Acked-byRe: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and flash properties
Quoted 3 lines · Sakari Ailus
Document optional lens-focus and flash properties for the smiapp driver.
Regards,
Hans
Quoted 10 lines
--- Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++ 1 file changed, 2 insertions(+)Documentation/devicetree/bindings/media/i2c/nokia,smia.txt +0
-0
Documentation/devicetree/bindings/media/i2c/nokia,smia.txt Optional properties · line 34
Quoted 8 lines
Documentation/devicetree/bindings/media/i2c/nokia,smia.txt +2
-0@@ -27,6 +27,8 @@ Optional properties - nokia,nvm-size: The size of the NVM, in bytes. If the size is not given, the NVM contents will not be read. - reset-gpios: XSHUTDOWN GPIO +- flash-leds: See ../video-interfaces.txt +- lens-focus: See ../video-interfaces.txt Endpoint node mandatory properties
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Pavel Machek
Acked-byRe: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and flash properties
In reply to a message not in the archiveQuoted 1 line · Sakari Ailus
Document optional lens-focus and flash properties for the smiapp
driver.
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and flash properties
In reply to Sakari AilusQuoted 6 lines · Sakari Ailus
Document optional lens-focus and flash properties for the smiapp driver.
Signed-off-by Sakari Ailus <[email protected]>--- Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++ 1 file changed, 2 insertions(+)
Sakari Ailus
maintainerRe: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and flash properties
Hi Rob,
Quoted 9 lines · Rob Herring
Quoted 6 lines · Sakari Ailus
Document optional lens-focus and flash properties for the smiapp driver.
Signed-off-by Sakari Ailus <[email protected]>--- Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++ 1 file changed, 2 insertions(+)Acked-by Rob Herring <[email protected]>
Thanks for the ack. There have been since a few iterations of the set, and the corresponding patch in v13 has minor changes to this:
<URL:http://www.spinics.net/lists/linux-media/msg121929.html>
Essentially "flash" was renamed to "flash-leds" as the current flash devices we have are all LEDs and the referencing assumes LED framework's ways to describe LEDs. The same change is present in the patch adding the property to video-interfaces.txt:
<URL:http://www.spinics.net/lists/linux-media/msg121924.html>
Signature · 4 lines
Regards, Sakari Ailus [email protected]
A message that is not in the archive (sent off-list or not yet received): ef8edab3-5b55-c298-2a40-72b5e22586ea-VuQAYsv1563Yd54FQh9/[email protected]
Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and flash properties
Quoted 15 lines · Sakari Ailus
Hi Rob,
Quoted 11 lines · Rob Herring
Quoted 7 lines · Sakari Ailus
Document optional lens-focus and flash properties for the smiapp driver.
--- Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++ 1 file changed, 2 insertions(+)
Quoted 5 lines
Quoted 1 line
Acked-by Rob Herring <[email protected]>Thanks for the ack. There have been since a few iterations of the set, and the corresponding patch in v13 has minor changes to this:
My review script can't deal with subject changes...
Quoted 5 lines
<URL:http://www.spinics.net/lists/linux-media/msg121929.html>
Essentially "flash" was renamed to "flash-leds" as the current flash devices we have are all LEDs and the referencing assumes LED framework's ways to describe LEDs. The same change is present in the patch adding the property
So we're kind of creating a binding that mirrors the gpio bindings (*-gpios) which is a bit of an oddball as all other bindings have gone with a fixed property name and then a *-names property to name them. The main downside to this form is a prefixed property name is harder to parse and validate. So perhaps we should follow the more common pattern, but we're not really describing a h/w connection just an association. And now we also have the trigger source binding to associate LEDs with device nodes, so perhaps that should be used here. We shouldn't really have 2 ways to associate things in DT even if how that gets handled in the kernel is different.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): CAL_Jsq+YKSDn7Hoq-2wRsGyGRbQvNPEVXrj13bSNCqQpKE2CvQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and flash properties
Hi Rob,
Quoted 27 lines · Rob Herring
Quoted 15 lines · Sakari Ailus
Hi Rob,
Quoted 11 lines · Rob Herring
Quoted 7 lines · Sakari Ailus
Document optional lens-focus and flash properties for the smiapp driver.
--- Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++ 1 file changed, 2 insertions(+)Quoted 5 lines
Quoted 1 line
Acked-by Rob Herring <[email protected]>Thanks for the ack. There have been since a few iterations of the set, and the corresponding patch in v13 has minor changes to this:
My review script can't deal with subject changes...
Quoted 2 lines
<URL:http://www.spinics.net/lists/linux-media/msg121929.html>
Quoted 7 lines
Quoted 3 lines
Essentially "flash" was renamed to "flash-leds" as the current flash devices we have are all LEDs and the referencing assumes LED framework's ways to describe LEDs. The same change is present in the patch adding the property
So we're kind of creating a binding that mirrors the gpio bindings (*-gpios) which is a bit of an oddball as all other bindings have gone with a fixed property name and then a *-names property to name them.
It could be that "flash-leds" will remain the only one. Depending on whether anyone would ever want to support a Xenon flash in which case we could add a property for "flash-xenon" or such. Quite possibly not; LEDs have improved in luminosity a lot over the recent years and aren't that far from tiny Xenon flash devices. I don't remember seeing a mobile phone less than five years or so with a Xenon flash.
Quoted 7 lines
The main downside to this form is a prefixed property name is harder to parse and validate. So perhaps we should follow the more common pattern, but we're not really describing a h/w connection just an association. And now we also have the trigger source binding to associate LEDs with device nodes, so perhaps that should be used here. We shouldn't really have 2 ways to associate things in DT even if how that gets handled in the kernel is different.
trigger-sources is not really the same thing: it's present in the LED node, not in the sensor to start with. The LED driver has no knowledge of the Media device --- the sensor driver gains this information through the endpoints. The sensor driver would need to find the node which contains a phandle back to the sensor node.
Having this property in the sensor gives the association information between the sensor and the LED. It could be present elsewhere, e.g. the master device with DMA engines if there's no association with a sensor.
Some sensors do support strobing the flash, too. The flash type (Xenon or LED) needs to be known to the strobe source (sensor).
The strobe wiring may not be there: the module vendors often omit that. Or it could be omitted on the board. That's the case with LED flashes; they can mostly be triggered using I²C as well albeit less precisely.
Signature · 8 lines
Kind regards, Sakari Ailus sakari.ailus-VuQAYsv1563Yd54FQh9/[email protected] -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Sakari Ailus
maintainerPATCH v10 22/24 ov5670: Add support for flash and lens devices
In reply to Sakari AilusParse async sub-devices by using v4l2_subdev_fwnode_reference_parse_sensor_common().
--- drivers/media/i2c/ov5670.c | 33 +++++++++++++++++++++++++-------- 1 file changed, 25 insertions(+), 8 deletions(-)
drivers/media/i2c/ov5670.c +25 -8
@@ -18,6 +18,7 @@#include <linux/pm_runtime.h> #include <media/v4l2-ctrls.h> #include <media/v4l2-device.h> +#include <media/v4l2-fwnode.h> #define OV5670_REG_CHIP_ID 0x300a#define OV5670_CHIP_ID 0x005670
@@ -1807,6 +1808,7 @@ static const struct ov5670_mode supported_modes[] = {struct ov5670 {struct v4l2_subdev sd;struct media_pad pad; +struct v4l2_async_notifier notifier;struct v4l2_ctrl_handler ctrl_handler;/* V4L2 Controls */
@@ -2473,11 +2475,13 @@ static int ov5670_probe(struct i2c_client *client)return -EINVAL ; ov5670 =devm_kzalloc (&client->dev,sizeof (*ov5670),GFP_KERNEL ); -if (!ov5670) { - ret = -ENOMEM ; - err_msg ="devm_kzalloc() error" ; - goto error_print; - } +if (!ov5670) +return -ENOMEM ; + + ret =v4l2_fwnode_reference_parse_sensor_common ( + &client->dev, &ov5670->notifier); +if (ret <0 ) +return ret;/* Initialize subdev */ v4l2_i2c_subdev_init (&ov5670->sd, client, &ov5670_subdev_ops);
@@ -2486,7 +2490,7 @@ static int ov5670_probe(struct i2c_client *client) ret =ov5670_identify_module (ov5670);if (ret) { err_msg ="ov5670_identify_module() error" ; - goto error_print; + goto error_release_notifier; }mutex_init (&ov5670->mutex);
@@ -2513,11 +2517,18 @@ static int ov5670_probe(struct i2c_client *client) goto error_handler_free; } + ret =v4l2_async_subdev_notifier_register (&ov5670->sd, + &ov5670->notifier); +if (ret) { + err_msg ="can't register async notifier" ; + goto error_entity_cleanup; + } +/* Async register for subdev */ ret =v4l2_async_register_subdev (&ov5670->sd);if (ret <0 ) { err_msg ="v4l2_async_register_subdev() error" ; - goto error_entity_cleanup; + goto error_unregister_notifier; } ov5670->streaming = false;
@@ -2533,6 +2544,9 @@ static int ov5670_probe(struct i2c_client *client)return 0 ; +error_unregister_notifier: +v4l2_async_notifier_unregister (&ov5670->notifier); + error_entity_cleanup:media_entity_cleanup (&ov5670->sd.entity);
@@ -2542,7 +2556,8 @@ static int ov5670_probe(struct i2c_client *client) error_mutex_destroy:mutex_destroy (&ov5670->mutex); -error_print: +error_release_notifier: +v4l2_async_notifier_release (&ov5670->notifier);dev_err (&client->dev,"%s: %s %d\n" , __func__, err_msg, ret);return ret;
@@ -2554,6 +2569,8 @@ static int ov5670_remove(struct i2c_client *client)struct ov5670 *ov5670 =to_ov5670 (sd);v4l2_async_unregister_subdev (sd); +v4l2_async_notifier_unregister (&ov5670->notifier); +v4l2_async_notifier_release (&ov5670->notifier);media_entity_cleanup (&sd->entity);v4l2_ctrl_handler_free (sd->ctrl_handler);mutex_destroy (&ov5670->mutex);
Signature · 1 line
2.11.0
A message that is not in the archive (sent off-list or not yet received): 20170911080008.21208-23-sakari.ailus-VuQAYsv1563Yd54FQh9/[email protected]
Hans Verkuil
Acked-byRe: [PATCH v10 22/24] ov5670: Add support for flash and lens devices
Quoted 4 lines · Sakari Ailus
Parse async sub-devices by using
v4l2_subdev_fwnode_reference_parse_sensor_common().
Regards,
Hans
Quoted 94 lines
--- drivers/media/i2c/ov5670.c | 33 +++++++++++++++++++++++++-------- 1 file changed, 25 insertions(+), 8 deletions(-)drivers/media/i2c/ov5670.c +23
-8@@ -18,6 +18,7 @@#include <linux/pm_runtime.h> #include <media/v4l2-ctrls.h> #include <media/v4l2-device.h> +#include <media/v4l2-fwnode.h> #define OV5670_REG_CHIP_ID 0x300a#define OV5670_CHIP_ID 0x005670@@ -1807,6 +1808,7 @@ static const struct ov5670_mode supported_modes[] = {struct ov5670 {struct v4l2_subdev sd;struct media_pad pad; +struct v4l2_async_notifier notifier;struct v4l2_ctrl_handler ctrl_handler;/* V4L2 Controls */ @@ -2473,11 +2475,13 @@ static int ov5670_probe(struct i2c_client *client)return -EINVAL ; ov5670 =devm_kzalloc (&client->dev,sizeof (*ov5670),GFP_KERNEL ); -if (!ov5670) { - ret = -ENOMEM ; - err_msg ="devm_kzalloc() error" ; - goto error_print; - } +if (!ov5670) +return -ENOMEM ; + + ret =v4l2_fwnode_reference_parse_sensor_common ( + &client->dev, &ov5670->notifier); +if (ret <0 ) +return ret;/* Initialize subdev */ v4l2_i2c_subdev_init (&ov5670->sd, client, &ov5670_subdev_ops);@@ -2486,7 +2490,7 @@ static int ov5670_probe(struct i2c_client *client) ret =ov5670_identify_module (ov5670);if (ret) { err_msg ="ov5670_identify_module() error" ; - goto error_print; + goto error_release_notifier; }mutex_init (&ov5670->mutex);@@ -2513,11 +2517,18 @@ static int ov5670_probe(struct i2c_client *client) goto error_handler_free; } + ret =v4l2_async_subdev_notifier_register (&ov5670->sd, + &ov5670->notifier); +if (ret) { + err_msg ="can't register async notifier" ; + goto error_entity_cleanup; + } +/* Async register for subdev */ ret =v4l2_async_register_subdev (&ov5670->sd);if (ret <0 ) { err_msg ="v4l2_async_register_subdev() error" ; - goto error_entity_cleanup; + goto error_unregister_notifier; } ov5670->streaming = false;@@ -2533,6 +2544,9 @@ static int ov5670_probe(struct i2c_client *client)return 0 ; +error_unregister_notifier: +v4l2_async_notifier_unregister (&ov5670->notifier); + error_entity_cleanup:media_entity_cleanup (&ov5670->sd.entity);@@ -2542,7 +2556,8 @@ static int ov5670_probe(struct i2c_client *client) error_mutex_destroy:mutex_destroy (&ov5670->mutex); -error_print: +error_release_notifier: +v4l2_async_notifier_release (&ov5670->notifier);dev_err (&client->dev,"%s: %s %d\n" , __func__, err_msg, ret);return ret;
drivers/media/i2c/ov5670.c static int ov5670_remove(struct i2c_client *client) · line 2576
Quoted 8 lines
drivers/media/i2c/ov5670.c +2
-0@@ -2554,6 +2569,8 @@ static int ov5670_remove(struct i2c_client *client)struct ov5670 *ov5670 =to_ov5670 (sd);v4l2_async_unregister_subdev (sd); +v4l2_async_notifier_unregister (&ov5670->notifier); +v4l2_async_notifier_release (&ov5670->notifier);media_entity_cleanup (&sd->entity);v4l2_ctrl_handler_free (sd->ctrl_handler);mutex_destroy (&ov5670->mutex);
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Sakari Ailus
maintainerPATCH v10 23/24 ov13858: Add support for flash and lens devices
In reply to Sakari AilusParse async sub-devices by using v4l2_subdev_fwnode_reference_parse_sensor_common().
--- drivers/media/i2c/ov13858.c | 26 +++++++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-)
drivers/media/i2c/ov13858.c +23 -3
@@ -18,6 +18,7 @@#include <linux/pm_runtime.h> #include <media/v4l2-ctrls.h> #include <media/v4l2-device.h> +#include <media/v4l2-fwnode.h> #define OV13858_REG_VALUE_08BIT 1#define OV13858_REG_VALUE_16BIT 2
@@ -1028,6 +1029,7 @@ static const struct ov13858_mode supported_modes[] = {struct ov13858 {struct v4l2_subdev sd;struct media_pad pad; +struct v4l2_async_notifier notifier;struct v4l2_ctrl_handler ctrl_handler;/* V4L2 Controls */
@@ -1715,6 +1717,11 @@ static int ov13858_probe(struct i2c_client *client,if (!ov13858)return -ENOMEM ; + ret =v4l2_fwnode_reference_parse_sensor_common ( + &client->dev, &ov13858->notifier); +if (ret <0 ) +return ret; +/* Initialize subdev */ v4l2_i2c_subdev_init (&ov13858->sd, client, &ov13858_subdev_ops);
@@ -1722,7 +1729,7 @@ static int ov13858_probe(struct i2c_client *client, ret =ov13858_identify_module (ov13858);if (ret) {dev_err (&client->dev,"failed to find sensor: %d\n" , ret); -return ret; + goto error_notifier_release; }/* Set default mode to max resolution */
@@ -1730,7 +1737,7 @@ static int ov13858_probe(struct i2c_client *client, ret =ov13858_init_controls (ov13858);if (ret) -return ret; + goto error_notifier_release;/* Initialize subdev */ ov13858->sd.internal_ops = &ov13858_internal_ops;
@@ -1746,9 +1753,14 @@ static int ov13858_probe(struct i2c_client *client, goto error_handler_free; } + ret =v4l2_async_subdev_notifier_register (&ov13858->sd, + &ov13858->notifier); +if (ret) + goto error_media_entity; + ret =v4l2_async_register_subdev (&ov13858->sd);if (ret <0 ) - goto error_media_entity; + goto error_notifier_unregister;/* * Device is already turned on by i2c-core with ACPI domain PM.
@@ -1761,11 +1773,17 @@ static int ov13858_probe(struct i2c_client *client,return 0 ; +error_notifier_unregister: +v4l2_async_notifier_unregister (&ov13858->notifier); + error_media_entity:media_entity_cleanup (&ov13858->sd.entity); error_handler_free:ov13858_free_controls (ov13858); + +error_notifier_release: +v4l2_async_notifier_release (&ov13858->notifier);dev_err (&client->dev,"%s failed:%d\n" , __func__, ret);return ret;
@@ -1777,6 +1795,8 @@ static int ov13858_remove(struct i2c_client *client)struct ov13858 *ov13858 =to_ov13858 (sd);v4l2_async_unregister_subdev (sd); +v4l2_async_notifier_unregister (&ov13858->notifier); +v4l2_async_notifier_release (&ov13858->notifier);media_entity_cleanup (&sd->entity);ov13858_free_controls (ov13858);
Signature · 1 line
2.11.0
Re: [PATCH v10 23/24] ov13858: Add support for flash and lens devices
Quoted 4 lines · Sakari Ailus
Parse async sub-devices by using
v4l2_subdev_fwnode_reference_parse_sensor_common().Signed-off-by Sakari Ailus <[email protected]>
Regards,
Hans
Quoted 98 lines
--- drivers/media/i2c/ov13858.c | 26 +++++++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-)drivers/media/i2c/ov13858.c +23
-3@@ -18,6 +18,7 @@#include <linux/pm_runtime.h> #include <media/v4l2-ctrls.h> #include <media/v4l2-device.h> +#include <media/v4l2-fwnode.h> #define OV13858_REG_VALUE_08BIT 1#define OV13858_REG_VALUE_16BIT 2@@ -1028,6 +1029,7 @@ static const struct ov13858_mode supported_modes[] = {struct ov13858 {struct v4l2_subdev sd;struct media_pad pad; +struct v4l2_async_notifier notifier;struct v4l2_ctrl_handler ctrl_handler;/* V4L2 Controls */ @@ -1715,6 +1717,11 @@ static int ov13858_probe(struct i2c_client *client,if (!ov13858)return -ENOMEM ; + ret =v4l2_fwnode_reference_parse_sensor_common ( + &client->dev, &ov13858->notifier); +if (ret <0 ) +return ret; +/* Initialize subdev */ v4l2_i2c_subdev_init (&ov13858->sd, client, &ov13858_subdev_ops);@@ -1722,7 +1729,7 @@ static int ov13858_probe(struct i2c_client *client, ret =ov13858_identify_module (ov13858);if (ret) {dev_err (&client->dev,"failed to find sensor: %d\n" , ret); -return ret; + goto error_notifier_release; }/* Set default mode to max resolution */ @@ -1730,7 +1737,7 @@ static int ov13858_probe(struct i2c_client *client, ret =ov13858_init_controls (ov13858);if (ret) -return ret; + goto error_notifier_release;/* Initialize subdev */ ov13858->sd.internal_ops = &ov13858_internal_ops;@@ -1746,9 +1753,14 @@ static int ov13858_probe(struct i2c_client *client, goto error_handler_free; } + ret =v4l2_async_subdev_notifier_register (&ov13858->sd, + &ov13858->notifier); +if (ret) + goto error_media_entity; + ret =v4l2_async_register_subdev (&ov13858->sd);if (ret <0 ) - goto error_media_entity; + goto error_notifier_unregister;/* * Device is already turned on by i2c-core with ACPI domain PM. @@ -1761,11 +1773,17 @@ static int ov13858_probe(struct i2c_client *client,return 0 ; +error_notifier_unregister: +v4l2_async_notifier_unregister (&ov13858->notifier); + error_media_entity:media_entity_cleanup (&ov13858->sd.entity); error_handler_free:ov13858_free_controls (ov13858); + +error_notifier_release: +v4l2_async_notifier_release (&ov13858->notifier);dev_err (&client->dev,"%s failed:%d\n" , __func__, ret);return ret;@@ -1777,6 +1795,8 @@ static int ov13858_remove(struct i2c_client *client)struct ov13858 *ov13858 =to_ov13858 (sd);v4l2_async_unregister_subdev (sd); +v4l2_async_notifier_unregister (&ov13858->notifier); +v4l2_async_notifier_release (&ov13858->notifier);media_entity_cleanup (&sd->entity);ov13858_free_controls (ov13858);
Sakari Ailus
maintainerPATCH v10 24/24 arm: dts: omap3: N9/N950: Add flash references to the camera
In reply to Sakari AilusAdd flash and indicator LED phandles to the sensor node.
--- arch/arm/boot/dts/omap3-n9.dts | 1 + arch/arm/boot/dts/omap3-n950-n9.dtsi | 4 ++-- arch/arm/boot/dts/omap3-n950.dts | 1 + 3 files changed, 4 insertions(+), 2 deletions(-)
arch/arm/boot/dts/omap3-n9.dts +1 -0
@@ -26,6 +26,7 @@ clocks = <&isp 0>; clock-frequency = <9600000>; nokia,nvm-size = <(16 * 64)>; + flash-leds = <&as3645a_flash &as3645a_indicator>; port { smia_1_1: endpoint { link-frequencies = /bits/ 64 <199200000 210000000 499200000>;
arch/arm/boot/dts/omap3-n950-n9.dtsi +2 -2
@@ -271,14 +271,14 @@ #size-cells = <0>; reg = <0x30>; compatible = "ams,as3645a"; - flash@0 { + as3645a_flash: flash@0 { reg = <0x0>; flash-timeout-us = <150000>; flash-max-microamp = <320000>; led-max-microamp = <60000>; ams,input-max-microamp = <1750000>; }; - indicator@1 { + as3645a_indicator: indicator@1 { reg = <0x1>; led-max-microamp = <10000>; };
arch/arm/boot/dts/omap3-n950.dts +1 -0
@@ -60,6 +60,7 @@ clocks = <&isp 0>; clock-frequency = <9600000>; nokia,nvm-size = <(16 * 64)>; + flash-leds = <&as3645a_flash &as3645a_indicator>; port { smia_1_1: endpoint { link-frequencies = /bits/ 64 <210000000 333600000 398400000>;
Signature · 1 line
2.11.0
A message that is not in the archive (sent off-list or not yet received): 20170911080008.21208-25-sakari.ailus-VuQAYsv1563Yd54FQh9/[email protected]
Hans Verkuil
Acked-byRe: [PATCH v10 24/24] arm: dts: omap3: N9/N950: Add flash references to the camera
Quoted 3 lines · Sakari Ailus
Add flash and indicator LED phandles to the sensor node.
Regards,
Hans
Quoted 45 lines
--- arch/arm/boot/dts/omap3-n9.dts | 1 + arch/arm/boot/dts/omap3-n950-n9.dtsi | 4 ++-- arch/arm/boot/dts/omap3-n950.dts | 1 + 3 files changed, 4 insertions(+), 2 deletions(-)arch/arm/boot/dts/omap3-n9.dts +1
-0@@ -26,6 +26,7 @@ clocks = <&isp 0>; clock-frequency = <9600000>; nokia,nvm-size = <(16 * 64)>; + flash-leds = <&as3645a_flash &as3645a_indicator>; port { smia_1_1: endpoint { link-frequencies = /bits/ 64 <199200000 210000000 499200000>;arch/arm/boot/dts/omap3-n950-n9.dtsi +2
-2@@ -271,14 +271,14 @@ #size-cells = <0>; reg = <0x30>; compatible = "ams,as3645a"; - flash@0 { + as3645a_flash: flash@0 { reg = <0x0>; flash-timeout-us = <150000>; flash-max-microamp = <320000>; led-max-microamp = <60000>; ams,input-max-microamp = <1750000>; }; - indicator@1 { + as3645a_indicator: indicator@1 { reg = <0x1>; led-max-microamp = <10000>; };arch/arm/boot/dts/omap3-n950.dts +0
-0
arch/arm/boot/dts/omap3-n950.dts line 66
Quoted 7 lines
arch/arm/boot/dts/omap3-n950.dts +1
-0@@ -60,6 +60,7 @@ clocks = <&isp 0>; clock-frequency = <9600000>; nokia,nvm-size = <(16 * 64)>; + flash-leds = <&as3645a_flash &as3645a_indicator>; port { smia_1_1: endpoint { link-frequencies = /bits/ 64 <210000000 333600000 398400000>;
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v10 24/24] arm: dts: omap3: N9/N950: Add flash references to the camera
In reply to Sakari AilusQuoted 3 lines · Sakari Ailus
Add flash and indicator LED phandles to the sensor node.
Signed-off-by Sakari Ailus <[email protected]>
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Rafael J. Wysocki
maintainerHi,
Quoted 26 lines · Sakari Ailus
Hi folks,
We have a large influx of new, unmerged, drivers that are now parsing fwnode endpoints and each one of them is doing this a little bit differently. The needs are still exactly the same for the graph data structure is device independent. This is still a non-trivial task and the majority of the driver implementations are buggy, just buggy in different ways.
Facilitate parsing endpoints by adding a convenience function for parsing the endpoints, and make the omap3isp and rcar-vin drivers use them as an example.
To show where we're getting with this, I've added support for async sub-device notifier support that is notifiers that can be registered by sub-device drivers as well as V4L2 fwnode improvements to make use of them and the DTS changes for the Nokia N9. Some of these patches I've posted previously in this set here:
<URL:http://www.spinics.net/lists/linux-media/msg118764.html>
Since that, the complete callback of the master notifier registering the V4L2 device is only called once all sub-notifiers have been completed as well. This way the device node creation can be postponed until all devices have been successfully initialised.
Quoted 4 lines
With this, the as3645a driver successfully registers a sub-device to the media device created by the omap3isp driver. The kernel also has the information it's related to the sensor driven by the smiapp driver but we don't have a way to expose that information yet.
I don't see core changes in this set, so I'm assuming it to be targeted at the users of endpoints etc.
Thanks,
Rafael
Sakari Ailus
maintainerHi Rafael,
Quoted 30 lines · Rafael J. Wysocki
Hi,
Quoted 26 lines · Sakari Ailus
Hi folks,
We have a large influx of new, unmerged, drivers that are now parsing fwnode endpoints and each one of them is doing this a little bit differently. The needs are still exactly the same for the graph data structure is device independent. This is still a non-trivial task and the majority of the driver implementations are buggy, just buggy in different ways.
Facilitate parsing endpoints by adding a convenience function for parsing the endpoints, and make the omap3isp and rcar-vin drivers use them as an example.
To show where we're getting with this, I've added support for async sub-device notifier support that is notifiers that can be registered by sub-device drivers as well as V4L2 fwnode improvements to make use of them and the DTS changes for the Nokia N9. Some of these patches I've posted previously in this set here:
<URL:http://www.spinics.net/lists/linux-media/msg118764.html>
Since that, the complete callback of the master notifier registering the V4L2 device is only called once all sub-notifiers have been completed as well. This way the device node creation can be postponed until all devices have been successfully initialised.
Quoted 7 lines
Quoted 4 lines
With this, the as3645a driver successfully registers a sub-device to the media device created by the omap3isp driver. The kernel also has the information it's related to the sensor driven by the smiapp driver but we don't have a way to expose that information yet.
I don't see core changes in this set, so I'm assuming it to be targeted at the users of endpoints etc.
Yes, this is dealing with V4L2 and how information from firmware is used mainly but there is also DT binding documentation.
Signature · 4 lines
Kind regards, Sakari Ailus [email protected]