Skip to contentSkip to conversation

procfs: remove unused variable

PATCH Applied Arnd Bergmann 2 participants 2 messages Sep 11, 2017 – Sep 12, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 procfs: remove unused variable

in NOMMU configurations, we get a warning about a variable that has become unused:

fs/proc/task_nommu.c: In function 'nommu_vma_show':
fs/proc/task_nommu.c:148:28: error: unused variable 'priv' [-Werror=unused-variable]

Fixes 01a949ccf3b9 ("fs, proc: remove priv argument from is_stack")
---
 fs/proc/task_nommu.c | 1 -
 1 file changed, 1 deletion(-)
fs/proc/task_nommu.c +0 -1
index dea90b566a6e..b00b766098fa 100644
@@ -145,7 +145,6 @@ static int nommu_vma_show(struct seq_file *m, struct vm_area_struct *vma,
 			  int is_pid)
 {
 	struct mm_struct *mm = vma->vm_mm;
-	struct proc_maps_private *priv = m->private;
 	unsigned long ino = 0;
 	struct file *file;
 	dev_t dev = 0;
Signature · 1 line
2.9.0
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Arnd Bergmann

in NOMMU configurations, we get a warning about a variable that has become unused:

fs/proc/task_nommu.c: In function 'nommu_vma_show':
fs/proc/task_nommu.c:148:28: error: unused variable 'priv' [-Werror=unused-variable]

Fixes 01a949ccf3b9 ("fs, proc: remove priv argument from is_stack")

this sha doesn't exist in Linus tree. I guess it comes from linux-next. The merged commit is 1240ea0dc3bb ("fs, proc: remove priv argument from is_stack")

Other than that

Thanks for catching this and the fix!

Quoted 20 lines
---
 fs/proc/task_nommu.c | 1 -
 1 file changed, 1 deletion(-)
fs/proc/task_nommu.c +0 -1
index dea90b566a6e..b00b766098fa 100644
@@ -145,7 +145,6 @@ static int nommu_vma_show(struct seq_file *m, struct vm_area_struct *vma,
 			  int is_pid)
 {
 	struct mm_struct *mm = vma->vm_mm;
-	struct proc_maps_private *priv = m->private;
 	unsigned long ino = 0;
 	struct file *file;
 	dev_t dev = 0;
Signature · 1 line
2.9.0
Signature · 2 lines
Michal Hocko
SUSE Labs