drm/i915/bxt: set min brightness from VBT
Subsystems (2)
PATCH 1/1 drm/i915/bxt: set min brightness from VBT
Min brightness value from vbt was missing for BXT platform. This setting have to refer backlight ic spec to restrict min backlight output. Without this restriction, driver would allow to configure lower brightness value and violate backlight ic requirement.
--- drivers/gpu/drm/i915/intel_panel.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/intel_panel.c +2 -0
@@ -1699,6 +1699,8 @@ bxt_setup_backlight(struct intel_connector *connector, enum pipe unused)if (!panel->backlight.max)return -ENODEV ; + panel->backlight.min =get_backlight_min_vbt (connector); + val =bxt_get_backlight (connector); val =intel_panel_compute_brightness (connector, val); panel->backlight.level = clamp(val, panel->backlight.min,
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/bxt: set min brightness from VBT
== Series Details ==
== Series Details ==
Series: drm/i915/bxt: set min brightness from VBT
URL : https://patchwork.freedesktop.org/series/30163/
State : success
== Summary ==
Series 30163v1 drm/i915/bxt: set min brightness from VBT
https://patchwork.freedesktop.org/api/1.0/series/30163/revisions/1/mbox/
Test chamelium:
Subgroup dp-edid-read:
fail -> PASS (fi-kbl-7500u)
Test gem_ringfill:
Subgroup basic-default-hang:
incomplete -> DMESG-WARN (fi-pnv-d510) fdo#101600
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-atomic:
pass -> FAIL (fi-snb-2600) fdo#100215 +1
Test kms_frontbuffer_tracking:
Subgroup basic:
dmesg-warn -> PASS (fi-bdw-5557u) fdo#102473fdo#101600 https://bugs.freedesktop.org/show_bug.cgi?id=101600
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#102473 https://bugs.freedesktop.org/show_bug.cgi?id=102473
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:449s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:450s fi-blb-e6850 total:289 pass:224 dwarn:1 dfail:0 fail:0 skip:64 time:379s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:527s fi-bwr-2160 total:289 pass:184 dwarn:0 dfail:0 fail:0 skip:105 time:268s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:511s fi-byt-j1900 total:289 pass:254 dwarn:1 dfail:0 fail:0 skip:34 time:501s fi-byt-n2820 total:289 pass:250 dwarn:1 dfail:0 fail:0 skip:38 time:496s fi-cfl-s total:289 pass:250 dwarn:4 dfail:0 fail:0 skip:35 time:450s fi-elk-e7500 total:289 pass:230 dwarn:0 dfail:0 fail:0 skip:59 time:448s fi-glk-2a total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:596s fi-hsw-4770 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:428s fi-hsw-4770r total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:408s fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:430s fi-ivb-3520m total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:485s fi-ivb-3770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:463s fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:494s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:580s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:585s fi-pnv-d510 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:550s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:457s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:520s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:491s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:458s fi-skl-x1585l total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:472s fi-snb-2520m total:289 pass:251 dwarn:0 dfail:0 fail:0 skip:38 time:577s fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:1 skip:39 time:424s
3cbfafbde5bb92b6ecdbfd47e189d2742aa6fbec drm-tip: 2017y-09m-11d-23h-04m-21s UTC integration manifest c7426a2e11bb drm/i915/bxt: set min brightness from VBT
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5649/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915/bxt: set min brightness from VBT
In reply to Lee, Shawn C== Series Details ==
== Series Details ==
Series: drm/i915/bxt: set min brightness from VBT
URL : https://patchwork.freedesktop.org/series/30163/
State : success
== Summary ==
Test kms_setmode:
Subgroup basic:
pass -> FAIL (shard-hsw) fdo#99912
Test kms_cursor_legacy:
Subgroup flip-vs-cursor-atomic:
fail -> PASS (shard-hsw) fdo#102402fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#102402 https://bugs.freedesktop.org/show_bug.cgi?id=102402
shard-hsw total:2301 pass:1236 dwarn:0 dfail:0 fail:13 skip:1052 time:9413s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5649/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
AppliedQuoted 11 lines · Shawn C
Min brightness value from vbt was missing for BXT platform. This setting have to refer backlight ic spec to restrict min backlight output. Without this restriction, driver would allow to configure lower brightness value and violate backlight ic requirement.
Fixes 0fb890c01349 ("drm/i915/bxt: BLC implementation")Cc Jani Nikula <[email protected]>Cc Cooper Chiou <[email protected]>Cc Gary C Wang <[email protected]>Signed-off-by Shawn Lee <[email protected]>
Pushed to drm-intel-next-queued, thanks for the patch.
Care to send a similar patch for cnp_setup_backlight, please?
BR,
Jani.
Quoted 17 lines
--- drivers/gpu/drm/i915/intel_panel.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/i915/intel_panel.c +2
-0@@ -1699,6 +1699,8 @@ bxt_setup_backlight(struct intel_connector *connector, enum pipe unused)if (!panel->backlight.max)return -ENODEV ; + panel->backlight.min =get_backlight_min_vbt (connector); + val =bxt_get_backlight (connector); val =intel_panel_compute_brightness (connector, val); panel->backlight.level = clamp(val, panel->backlight.min,
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Lee, Shawn C
AppliedNo problem! I will commit a patch for CNP later.
Quoted 10 lines · Shawn C
Min brightness value from vbt was missing for BXT platform. This setting have to refer backlight ic spec to restrict min backlight output. Without this restriction, driver would allow to configure lower brightness value and violate backlight ic requirement.
Fixes 0fb890c01349 ("drm/i915/bxt: BLC implementation")Cc Jani Nikula <[email protected]>Cc Cooper Chiou <[email protected]>Cc Gary C Wang <[email protected]>Signed-off-by Shawn Lee <[email protected]>
Pushed to drm-intel-next-queued, thanks for the patch.
Care to send a similar patch for cnp_setup_backlight, please?
BR,
Jani.
Quoted 10 lines
--- drivers/gpu/drm/i915/intel_panel.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/i915/intel_panel.c +0
-0
drivers/gpu/drm/i915/intel_panel.c bxt_setup_backlight(struct intel_connector *connector, enum pipe unused) · line 1706
Quoted 8 lines
drivers/gpu/drm/i915/intel_panel.c +2
-0@@ -1699,6 +1699,8 @@ bxt_setup_backlight(struct intel_connector *connector, enum pipe unused)if (!panel->backlight.max)return -ENODEV ; + panel->backlight.min =get_backlight_min_vbt (connector); + val =bxt_get_backlight (connector); val =intel_panel_compute_brightness (connector, val); panel->backlight.level = clamp(val, panel->backlight.min,
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx