drm/atomic: Interruptible locks for everyone!
Subsystems (2)
Maarten Lankhorst
maintainerv2 cover drm/atomic: Interruptible locks for everyone!
drm_atomic_commit could previous have always failed when waits failed, but locking was always done uninterruptibly. Add infrastructure to make it possible for callers to choose interruptible locking, and convert the 5 most common ioctl's to use it.
All other atomic helpers can be converted when additional tests are added to kms_atomic_interruptible.
Changes since last version:
- Small fixes to the preparation patch
- Convert setcrtc as well.
Maarten Lankhorst (6):
drm/atomic: Prepare drm_modeset_lock infrastructure for interruptible
waiting, v2.
drm/atomic: Convert atomic ioctl locking to interruptible. drm/legacy: Convert cursor ioctl locking to interruptible. drm/legacy: Convert setplane ioctl locking to interruptible. drm/atomic: Convert pageflip ioctl locking to interruptible. drm/crtc: Convert setcrtc ioctl locking to interruptible.
drivers/gpu/drm/drm_atomic.c | 7 +-- drivers/gpu/drm/drm_crtc.c | 7 +-- drivers/gpu/drm/drm_debugfs_crc.c | 2 +- drivers/gpu/drm/drm_modeset_lock.c | 96 +++++++++++++++++++------------------- drivers/gpu/drm/drm_plane.c | 21 +++++---- include/drm/drm_modeset_lock.h | 12 +++-- 6 files changed, 77 insertions(+), 68 deletions(-)
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Maarten Lankhorst
maintainerPATCH v2 1/6 drm/atomic: Prepare drm_modeset_lock infrastructure for interruptible waiting, v2.
When we want to make drm_atomic_commit interruptible, there are a lot of places that call the lock function, which we don't have control over.
Rather than trying to convert every single one, it's easier to toggle interruptible waiting per acquire_ctx. If drm_modeset_acquire_init is called with DRM_MODESET_ACQUIRE_INTERRUPTIBLE, then we will perform interruptible waits in drm_modeset_lock and drm_modeset_backoff.
Changes since v1:
- Fix locking example in drm_modeset_lock.c to be compatible with interruptible waiting (xexaxo) and make it default. Uninterruptible waiting shouldn't happen except in corner cases, but the example will still apply if the flag is removed.
- Add drm_modeset_lock_single_interruptible() to documentation.
- Fix dead link to removed drm_modeset_lock_interruptible() in drm_modeset_lock().
--- drivers/gpu/drm/drm_debugfs_crc.c | 2 +- drivers/gpu/drm/drm_modeset_lock.c | 96 +++++++++++++++++++------------------- include/drm/drm_modeset_lock.h | 12 +++-- 3 files changed, 57 insertions(+), 53 deletions(-)
drivers/gpu/drm/drm_debugfs_crc.c +1 -1
@@ -155,7 +155,7 @@ static int crtc_crc_open(struct inode *inode, struct file *filep)int ret =0 ;if (drm_drv_uses_atomic_modeset (crtc->dev)) { - ret =drm_modeset_lock_interruptible (&crtc->mutex,NULL ); + ret =drm_modeset_lock_single_interruptible (&crtc->mutex);if (ret)return ret;
drivers/gpu/drm/drm_modeset_lock.c +48 -48
162 lines not on this page · raw message
include/drm/drm_modeset_lock.h +8 -4
@@ -34,6 +34,7 @@ struct drm_modeset_lock;* @contended: used internally for -EDEADLK handling * @locked: list of held locks * @trylock_only: trylock mode used in atomic contexts/panic notifiers +* @interruptible: whether interruptible locking should be used. * * Each thread competing for a set of locks must use one acquire * ctx. And if any lock fxn returns -EDEADLK, it must backoff and
@@ -59,6 +60,9 @@ struct drm_modeset_acquire_ctx {* Trylock mode, use only for panic handlers! */ bool trylock_only; + +/* Perform interruptible waits on this context. */ +bool interruptible; };/**
@@ -82,12 +86,13 @@ struct drm_modeset_lock {struct list_head head; }; +#define DRM_MODESET_ACQUIRE_INTERRUPTIBLE BIT(0) +void drm_modeset_acquire_init (struct drm_modeset_acquire_ctx *ctx,uint32_t flags);void drm_modeset_acquire_fini (struct drm_modeset_acquire_ctx *ctx);void drm_modeset_drop_locks (struct drm_modeset_acquire_ctx *ctx); -void drm_modeset_backoff (struct drm_modeset_acquire_ctx *ctx); -int drm_modeset_backoff_interruptible (struct drm_modeset_acquire_ctx *ctx); +int drm_modeset_backoff (struct drm_modeset_acquire_ctx *ctx);void drm_modeset_lock_init (struct drm_modeset_lock *lock);
@@ -111,8 +116,7 @@ static inline bool drm_modeset_is_locked(struct drm_modeset_lock *lock)int drm_modeset_lock (struct drm_modeset_lock *lock,struct drm_modeset_acquire_ctx *ctx); -int drm_modeset_lock_interruptible (struct drm_modeset_lock *lock, -struct drm_modeset_acquire_ctx *ctx); +int __must_check drm_modeset_lock_single_interruptible (struct drm_modeset_lock *lock);void drm_modeset_unlock (struct drm_modeset_lock *lock);struct drm_device ;
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v2 1/6] drm/atomic: Prepare drm_modeset_lock infrastructure for interruptible waiting, v2.
Quoted 17 lines · Maarten Lankhorst
When we want to make
drm_atomic_commitinterruptible, there are a lot of places that call the lock function, which we don't have control over.Rather than trying to convert every single one, it's easier to toggle interruptible waiting per
acquire_ctx. Ifdrm_modeset_acquire_initis called withDRM_MODESET_ACQUIRE_INTERRUPTIBLE, then we will perform interruptible waits indrm_modeset_lockanddrm_modeset_backoff.Changes since v1:
- Fix locking example indrm_modeset_lock.cto be compatible with interruptible waiting (xexaxo) and make it default. Uninterruptible waiting shouldn't happen except in corner cases, but the example will still apply if the flag is removed.
- Adddrm_modeset_lock_single_interruptible()to documentation.
- Fix dead link to removeddrm_modeset_lock_interruptible()indrm_modeset_lock().
Quoted 3 lines
Signed-off-by Maarten Lankhorst <[email protected]>Reviewed-by Daniel Vetter <[email protected]> #v1Cc Emil Velikov <[email protected]>
Thanks for the documentation updates/fixes Maarten. FWIW the series is
-Emil
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 1/6] drm/atomic: Prepare drm_modeset_lock infrastructure for interruptible waiting, v2.
Op 12-09-17 om 15:56 schreef Emil Velikov:
Quoted 19 lines
Quoted 17 lines · Maarten Lankhorst
When we want to make
drm_atomic_commitinterruptible, there are a lot of places that call the lock function, which we don't have control over.Rather than trying to convert every single one, it's easier to toggle interruptible waiting per
acquire_ctx. Ifdrm_modeset_acquire_initis called withDRM_MODESET_ACQUIRE_INTERRUPTIBLE, then we will perform interruptible waits indrm_modeset_lockanddrm_modeset_backoff.Changes since v1:
- Fix locking example indrm_modeset_lock.cto be compatible with interruptible waiting (xexaxo) and make it default. Uninterruptible waiting shouldn't happen except in corner cases, but the example will still apply if the flag is removed.
- Adddrm_modeset_lock_single_interruptible()to documentation.
- Fix dead link to removeddrm_modeset_lock_interruptible()indrm_modeset_lock().
Quoted 7 lines
Quoted 3 lines
Signed-off-by Maarten Lankhorst <[email protected]>Reviewed-by Daniel Vetter <[email protected]> #v1Cc Emil Velikov <[email protected]>Thanks for the documentation updates/fixes Maarten. FWIW the series is
Reviewed-by Emil Velikov <[email protected]>-Emil
Thanks, applied. :)
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Maarten Lankhorst
maintainerPATCH v2 2/6 drm/atomic: Convert atomic ioctl locking to interruptible.
In reply to Maarten LankhorstPass DRM_MODESET_ACQUIRE_INTERRUPTIBLE to acquire_init, and handle drm_modeset_backoff which can now fail by returning the error.
--- drivers/gpu/drm/drm_atomic.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_atomic.c +4 -3
@@ -2234,7 +2234,7 @@ int drm_mode_atomic_ioctl(struct drm_device *dev, (arg->flags & DRM_MODE_PAGE_FLIP_EVENT))return -EINVAL ; -drm_modeset_acquire_init (&ctx,0 ); +drm_modeset_acquire_init (&ctx,DRM_MODESET_ACQUIRE_INTERRUPTIBLE ); state =drm_atomic_state_alloc (dev);if (!state)
@@ -2347,8 +2347,9 @@ int drm_mode_atomic_ioctl(struct drm_device *dev,if (ret == -EDEADLK ) {drm_atomic_state_clear (state); -drm_modeset_backoff (&ctx); - goto retry; + ret =drm_modeset_backoff (&ctx); +if (!ret) + goto retry; }drm_atomic_state_put (state);
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Maarten Lankhorst
maintainerPATCH v2 3/6 drm/legacy: Convert cursor ioctl locking to interruptible.
In reply to Maarten LankhorstPass DRM_MODESET_ACQUIRE_INTERRUPTIBLE to acquire_init, and handle drm_modeset_backoff which can now fail by returning the error.
--- drivers/gpu/drm/drm_plane.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_plane.c +4 -3
@@ -834,7 +834,7 @@ static int drm_mode_cursor_common(struct drm_device *dev,return -ENOENT ; } -drm_modeset_acquire_init (&ctx,0 ); +drm_modeset_acquire_init (&ctx,DRM_MODESET_ACQUIRE_INTERRUPTIBLE ); retry: ret =drm_modeset_lock (&crtc->mutex, &ctx);if (ret)
@@ -876,8 +876,9 @@ static int drm_mode_cursor_common(struct drm_device *dev, } out:if (ret == -EDEADLK ) { -drm_modeset_backoff (&ctx); - goto retry; + ret =drm_modeset_backoff (&ctx); +if (!ret) + goto retry; }drm_modeset_drop_locks (&ctx);
Signature · 6 lines
2.14.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Maarten Lankhorst
maintainerPATCH v2 4/6 drm/legacy: Convert setplane ioctl locking to interruptible.
In reply to Maarten LankhorstPass DRM_MODESET_ACQUIRE_INTERRUPTIBLE to acquire_init, and handle drm_modeset_backoff which can now fail by returning the error.
--- drivers/gpu/drm/drm_plane.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_plane.c +4 -3
@@ -667,7 +667,7 @@ static int setplane_internal(struct drm_plane *plane,struct drm_modeset_acquire_ctx ctx;int ret; -drm_modeset_acquire_init (&ctx,0 ); +drm_modeset_acquire_init (&ctx,DRM_MODESET_ACQUIRE_INTERRUPTIBLE ); retry: ret =drm_modeset_lock_all_ctx (plane->dev, &ctx);if (ret)
@@ -678,8 +678,9 @@ static int setplane_internal(struct drm_plane *plane, fail:if (ret == -EDEADLK ) { -drm_modeset_backoff (&ctx); - goto retry; + ret =drm_modeset_backoff (&ctx); +if (!ret) + goto retry; }drm_modeset_drop_locks (&ctx);drm_modeset_acquire_fini (&ctx);
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Maarten Lankhorst
maintainerPATCH v2 5/6 drm/atomic: Convert pageflip ioctl locking to interruptible.
In reply to Maarten LankhorstPass DRM_MODESET_ACQUIRE_INTERRUPTIBLE to acquire_init, and handle drm_modeset_backoff which can now fail by returning the error.
--- drivers/gpu/drm/drm_plane.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_plane.c +4 -3
@@ -987,7 +987,7 @@ int drm_mode_page_flip_ioctl(struct drm_device *dev,return -EINVAL ; } -drm_modeset_acquire_init (&ctx,0 ); +drm_modeset_acquire_init (&ctx,DRM_MODESET_ACQUIRE_INTERRUPTIBLE ); retry: ret =drm_modeset_lock (&crtc->mutex, &ctx);if (ret)
@@ -1076,8 +1076,9 @@ int drm_mode_page_flip_ioctl(struct drm_device *dev, crtc->primary->old_fb =NULL ;if (ret == -EDEADLK ) { -drm_modeset_backoff (&ctx); - goto retry; + ret =drm_modeset_backoff (&ctx); +if (!ret) + goto retry; }drm_modeset_drop_locks (&ctx);
Signature · 6 lines
2.14.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Maarten Lankhorst
maintainerPATCH v2 6/6 drm/crtc: Convert setcrtc ioctl locking to interruptible.
In reply to Maarten LankhorstPass DRM_MODESET_ACQUIRE_INTERRUPTIBLE to acquire_init, and handle drm_modeset_backoff which can now fail by returning the error.
--- drivers/gpu/drm/drm_crtc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_crtc.c +4 -3
@@ -577,7 +577,7 @@ int drm_mode_setcrtc(struct drm_device *dev, void *data,DRM_DEBUG_KMS ("[CRTC:%d:%s]\n" , crtc->base.id, crtc->name);mutex_lock (&crtc->dev->mode_config.mutex); -drm_modeset_acquire_init (&ctx,0 ); +drm_modeset_acquire_init (&ctx,DRM_MODESET_ACQUIRE_INTERRUPTIBLE ); retry: ret =drm_modeset_lock_all_ctx (crtc->dev, &ctx);if (ret)
@@ -717,8 +717,9 @@ int drm_mode_setcrtc(struct drm_device *dev, void *data,kfree (connector_set);drm_mode_destroy (dev, mode);if (ret == -EDEADLK ) { -drm_modeset_backoff (&ctx); - goto retry; + ret =drm_modeset_backoff (&ctx); +if (!ret) + goto retry; }drm_modeset_drop_locks (&ctx);drm_modeset_acquire_fini (&ctx);
Signature · 6 lines
2.14.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Patchwork
CI✓ Fi.CI.BAT: success for drm/atomic: Interruptible locks for everyone! (rev3)
In reply to Maarten Lankhorst== Series Details ==
== Series Details ==
Series: drm/atomic: Interruptible locks for everyone! (rev3)
URL : https://patchwork.freedesktop.org/series/27987/
State : success
== Summary ==
Series 27987v3 drm/atomic: Interruptible locks for everyone!
https://patchwork.freedesktop.org/api/1.0/series/27987/revisions/3/mbox/
Test chamelium:
Subgroup dp-crc-fast:
fail -> PASS (fi-kbl-7500u) fdo#102514
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-atomic:
pass -> FAIL (fi-snb-2600) fdo#100215fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:453s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:457s fi-blb-e6850 total:289 pass:224 dwarn:1 dfail:0 fail:0 skip:64 time:377s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:538s fi-bwr-2160 total:289 pass:184 dwarn:0 dfail:0 fail:0 skip:105 time:267s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:510s fi-byt-j1900 total:289 pass:254 dwarn:1 dfail:0 fail:0 skip:34 time:506s fi-byt-n2820 total:289 pass:250 dwarn:1 dfail:0 fail:0 skip:38 time:503s fi-cfl-s total:289 pass:250 dwarn:4 dfail:0 fail:0 skip:35 time:452s fi-elk-e7500 total:289 pass:230 dwarn:0 dfail:0 fail:0 skip:59 time:449s fi-glk-2a total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:604s fi-hsw-4770 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:433s fi-hsw-4770r total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:418s fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:438s fi-ivb-3520m total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:481s fi-ivb-3770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:466s fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:490s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:579s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:588s fi-pnv-d510 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:547s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:455s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:526s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:505s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:459s fi-skl-x1585l total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:474s fi-snb-2520m total:289 pass:251 dwarn:0 dfail:0 fail:0 skip:38 time:584s fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:1 skip:39 time:428s
694f07d3df18c02da3f526ae0e1238eb12534e1e drm-tip: 2017y-09m-12d-09h-59m-00s UTC integration manifest 0d3eb880f5d1 drm/crtc: Convert setcrtc ioctl locking to interruptible.e665e1385f27 drm/atomic: Convert pageflip ioctl locking to interruptible. ffd30c21b012 drm/legacy: Convert setplane ioctl locking to interruptible. 25bbdbdb7620 drm/legacy: Convert cursor ioctl locking to interruptible.e02fa2a74d3f drm/atomic: Convert atomic ioctl locking to interruptible.1d4e5aee5d7b drm/atomic: Prepare drm_modeset_lock infrastructure for interruptible waiting, v2.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5659/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/atomic: Interruptible locks for everyone! (rev3)
In reply to Maarten Lankhorst== Series Details ==
== Series Details ==
Series: drm/atomic: Interruptible locks for everyone! (rev3)
URL : https://patchwork.freedesktop.org/series/27987/
State : success
== Summary ==
Test perf:
Subgroup polling:
pass -> FAIL (shard-hsw) fdo#102252
Test gem_eio:
Subgroup in-flight:
pass -> FAIL (shard-hsw) fdo#102616fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102616 https://bugs.freedesktop.org/show_bug.cgi?id=102616
shard-hsw total:2301 pass:1236 dwarn:0 dfail:0 fail:13 skip:1052 time:9411s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5659/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx