Skip to contentSkip to conversation

drm/amd/display: Disable pre-Vega ASICs by default

PATCH Superseded Harry Wentland 3 participants 3 messages Sep 12, 2017 – Sep 13, 2017 2 messages not in the archive

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/amd/display: Disable pre-Vega ASICs by default

v2: Clarify help text for pre-vega config

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++
 drivers/gpu/drm/amd/display/Kconfig        | 9 +++++++++
 2 files changed, 11 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +2 -0
index 34671790ce80..8c496a57788f 100644
@@ -1995,7 +1995,9 @@ bool amdgpu_device_asic_has_dc_support(enum amd_asic_type asic_type)
 	case CHIP_TONGA:
 	case CHIP_FIJI:
 	case CHIP_VEGA10:
+#if defined(CONFIG_DRM_AMD_DC_PRE_VEGA)
 		return amdgpu_dc != 0;
+#endif
 	case CHIP_KABINI:
 	case CHIP_MULLINS:
 		return amdgpu_dc > 0;
drivers/gpu/drm/amd/display/Kconfig +9 -0
index e91b6e57cf03..239a477310af 100644
@@ -3,11 +3,20 @@ menu "Display Engine Configuration"
 
 config DRM_AMD_DC
 	bool "AMD DC - Enable new display engine
+	default y
 	help
 	  Choose this option if you want to use the new display engine
 	  support for AMDGPU. This adds required support for Vega and
 	  Raven ASICs.
 
+config DRM_AMD_DC_PRE_VEGA
+	bool "DC support for Polaris and older ASICs"
+	default n
+	help
+	  Choose this option to enable the new DC support for older asics
+	  by default. This includes Polaris, Carrizo, Tonga, Bonaire,
+	  and Hawaii.
+
 config DRM_AMD_DC_DCN1_0
 	bool "DCN 1.0 Raven family"
 	depends on DRM_AMD_DC && X86
Signature · 6 lines
2.11.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20170912204619.7405-1-harry.wentland-5C7GfCeVMHo@public.gmane.org

#2 lore raw

Add Fiji to the help text?

Regards
//Ernst

2017-09-12 22:46 GMT+02:00 Harry Wentland <[email protected]>:

Quoted 50 lines

v2: Clarify help text for pre-vega config

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++
 drivers/gpu/drm/amd/display/Kconfig        | 9 +++++++++
 2 files changed, 11 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +2 -0
index 34671790ce80..8c496a57788f 100644
@@ -1995,7 +1995,9 @@ bool amdgpu_device_asic_has_dc_support(enum amd_asic_type asic_type)
        case CHIP_TONGA:
        case CHIP_FIJI:
        case CHIP_VEGA10:
+#if defined(CONFIG_DRM_AMD_DC_PRE_VEGA)
                return amdgpu_dc != 0;
+#endif
        case CHIP_KABINI:
        case CHIP_MULLINS:
                return amdgpu_dc > 0;
drivers/gpu/drm/amd/display/Kconfig +9 -1
index e91b6e57cf03..239a477310af 100644
@@ -3,11 +3,20 @@ menu "Display Engine Configuration"
 
 config DRM_AMD_DC
        bool "AMD DC - Enable new display engine
+       default y
        help
          Choose this option if you want to use the new display engine
          support for AMDGPU. This adds required support for Vega and
          Raven ASICs.
 
+config DRM_AMD_DC_PRE_VEGA
+       bool "DC support for Polaris and older ASICs"
+       default n
+       help
+         Choose this option to enable the new DC support for older asics
+         by default. This includes Polaris, Carrizo, Tonga, Bonaire,
+         and Hawaii.
+
 config DRM_AMD_DC_DCN1_0
        bool "DCN 1.0 Raven family"
        depends on DRM_AMD_DC && X86
--

2.11.0

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): CAD=4a=UEw-4vtJ1kqj3_Tkmxp6PyD7XThccR-ckMhS0zVYp9DQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#4 lore raw
Quoted 1 line · Ernst Sjöstrand

Add Fiji to the help text?

Maybe just say DCE8, 10, 11.

Alex

Quoted 55 lines

Regards
//Ernst

2017-09-12 22:46 GMT+02:00 Harry Wentland <[email protected]>:

Quoted 50 lines

v2: Clarify help text for pre-vega config

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++
 drivers/gpu/drm/amd/display/Kconfig        | 9 +++++++++
 2 files changed, 11 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +2 -0
index 34671790ce80..8c496a57788f 100644
@@ -1995,7 +1995,9 @@ bool amdgpu_device_asic_has_dc_support(enum amd_asic_type asic_type)
        case CHIP_TONGA:
        case CHIP_FIJI:
        case CHIP_VEGA10:
+#if defined(CONFIG_DRM_AMD_DC_PRE_VEGA)
                return amdgpu_dc != 0;
+#endif
        case CHIP_KABINI:
        case CHIP_MULLINS:
                return amdgpu_dc > 0;
drivers/gpu/drm/amd/display/Kconfig +9 -1
index e91b6e57cf03..239a477310af 100644
@@ -3,11 +3,20 @@ menu "Display Engine Configuration"
 
 config DRM_AMD_DC
        bool "AMD DC - Enable new display engine
+       default y
        help
          Choose this option if you want to use the new display engine
          support for AMDGPU. This adds required support for Vega and
          Raven ASICs.
 
+config DRM_AMD_DC_PRE_VEGA
+       bool "DC support for Polaris and older ASICs"
+       default n
+       help
+         Choose this option to enable the new DC support for older asics
+         by default. This includes Polaris, Carrizo, Tonga, Bonaire,
+         and Hawaii.
+
 config DRM_AMD_DC_DCN1_0
        bool "DCN 1.0 Raven family"
        depends on DRM_AMD_DC && X86
--

2.11.0

Quoted 8 lines
Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx