Skip to contentSkip to conversation

arm64: Cleanups if modules are disabled

PATCH New Geert Uytterhoeven 2 participants 2 messages Sep 5, 2017 – Sep 12, 2017

lore
Share & tools
lore
#0 lore raw

cover arm64: Cleanups if modules are disabled

Hi Catalin, Will,

This patch series disables printing and reservation of virtual memory for modules if module support is disabled.

The two patches are independent of each other.

Thanks for your comments!

Geert Uytterhoeven (2):
arm64: Do not print virtual memory for modules if modules are disabled
arm64: Do not reserve virtual memory for modules if modules are
disabled

 arch/arm64/include/asm/memory.h | 4 ++++
 arch/arm64/mm/init.c            | 2 ++
 2 files changed, 6 insertions(+)
Signature · 12 lines
2.7.4

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
#1 lore raw

cover arm64: Cleanups if modules are disabled

Quoted 4 lines · Geert Uytterhoeven

Hi Catalin, Will,

This patch series disables printing and reservation of virtual memory for modules if module support is disabled.

If we're going to do this, then we should probably also update the pt dumping code (mm/dump.c) to avoid dumping the modules area too.

There are also some weird consequences of defining MODULES_VSIZE to be 0, since we'll end up registering a zero-length region with KASAN and calculating a bogus module_alloc_base in the kaslr code. This might all be harmless, but it feels like we're laying down some tripwires for ourselves that I'd rather avoid doing.

Will