Skip to contentSkip to conversation

armv8: mmu: remove unused macro definition

PATCH New Andy Yan 4 participants 9 messages Aug 17, 2017 – Sep 13, 2017 Arm (32-bit)

lore
Share & tools
lore

Andy Yan

author
#0 lore raw

PATCH v2 1/2 armv8: mmu: remove unused macro definition

Macro VA_BITS and PTE_BLOCK_BITS are not used
in the code, so remove them.

Signed-off-by Andy Yan <[email protected]>
Reviewed-by Philipp Tomsich <[email protected]>

---

Changes in v2:
- remove CONFIG_SYS_PTL2_BITS from the whitelist

 arch/arm/include/asm/armv8/mmu.h | 9 ---------
 scripts/config_whitelist.txt     | 2 --
 2 files changed, 11 deletions(-)
arch/arm/include/asm/armv8/mmu.h +0 -9
index a349903..7752741 100644
@@ -8,15 +8,6 @@
 #ifndef _ASM_ARMV8_MMU_H_
 #define _ASM_ARMV8_MMU_H_
 
-/***************************************************************/
-/*
- * The following definitions are related each other, shoud be
- * calculated specifically.
- */
-
-#define VA_BITS			CONFIG_SYS_VA_BITS
-#define PTE_BLOCK_BITS		CONFIG_SYS_PTL2_BITS
-
 /*
  * block/section address mask and size definitions.
  */
scripts/config_whitelist.txt +0 -2
index db28457..63b8b25 100644
@@ -4440,7 +4440,6 @@ CONFIG_SYS_PSDPAR
 CONFIG_SYS_PSSR_VAL
 CONFIG_SYS_PTCPAR
 CONFIG_SYS_PTDPAR
-CONFIG_SYS_PTL2_BITS
 CONFIG_SYS_PTV
 CONFIG_SYS_PUAPAR
 CONFIG_SYS_QE_FMAN_FW_IN_MMC

@@ -4815,7 +4814,6 @@ CONFIG_SYS_USE_SERIALFLASH
 CONFIG_SYS_USE_SPIFLASH
 CONFIG_SYS_USR_EXCEP
 CONFIG_SYS_U_BOOT_OFFS
-CONFIG_SYS_VA_BITS
 CONFIG_SYS_VCXK_ACKNOWLEDGE_DDR
 CONFIG_SYS_VCXK_ACKNOWLEDGE_PIN
 CONFIG_SYS_VCXK_ACKNOWLEDGE_PORT
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH v2 1/2 armv8: mmu: remove unused macro definition

ping

Quoted 55 lines · Andy Yan

Macro VA_BITS and PTE_BLOCK_BITS are not used
in the code, so remove them.

Signed-off-by Andy Yan <[email protected]>
Reviewed-by Philipp Tomsich <[email protected]>

---

Changes in v2:
- remove CONFIG_SYS_PTL2_BITS from the whitelist

  arch/arm/include/asm/armv8/mmu.h | 9 ---------
  scripts/config_whitelist.txt     | 2 --
  2 files changed, 11 deletions(-)
arch/arm/include/asm/armv8/mmu.h +0 -9
index a349903..7752741 100644
@@ -8,15 +8,6 @@
  #ifndef _ASM_ARMV8_MMU_H_
  #define _ASM_ARMV8_MMU_H_
 
-/***************************************************************/
-/*
- * The following definitions are related each other, shoud be
- * calculated specifically.
- */
-
-#define VA_BITS			CONFIG_SYS_VA_BITS
-#define PTE_BLOCK_BITS		CONFIG_SYS_PTL2_BITS
-
  /*
   * block/section address mask and size definitions.
   */
scripts/config_whitelist.txt +0 -2
index db28457..63b8b25 100644
@@ -4440,7 +4440,6 @@ CONFIG_SYS_PSDPAR
  CONFIG_SYS_PSSR_VAL
  CONFIG_SYS_PTCPAR
  CONFIG_SYS_PTDPAR
-CONFIG_SYS_PTL2_BITS
  CONFIG_SYS_PTV
  CONFIG_SYS_PUAPAR
  CONFIG_SYS_QE_FMAN_FW_IN_MMC

@@ -4815,7 +4814,6 @@ CONFIG_SYS_USE_SERIALFLASH
  CONFIG_SYS_USE_SPIFLASH
  CONFIG_SYS_USR_EXCEP
  CONFIG_SYS_U_BOOT_OFFS
-CONFIG_SYS_VA_BITS
  CONFIG_SYS_VCXK_ACKNOWLEDGE_DDR
  CONFIG_SYS_VCXK_ACKNOWLEDGE_PIN
  CONFIG_SYS_VCXK_ACKNOWLEDGE_PORT
author
#2 lore raw

PATCH v2 2/2 armv8: mmu: add space around operator

In reply to Andy Yan

Add space around operator "+", make it
match the coding style.

Signed-off-by Andy Yan <[email protected]>

---

Changes in v2: None

 arch/arm/include/asm/armv8/mmu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/armv8/mmu.h +1 -1
index 7752741..6121aab 100644
@@ -16,7 +16,7 @@
 #undef  PAGE_SIZE
 #define PAGE_SHIFT		12
 #define PAGE_SIZE		(1 << PAGE_SHIFT)
-#define PAGE_MASK		(~(PAGE_SIZE-1))
+#define PAGE_MASK		(~(PAGE_SIZE - 1))
 
 /***************************************************************/
Signature · 1 line
2.7.4
author
#4 lore raw

PATCH v2 2/2 armv8: mmu: add space around operator

ping

Quoted 15 lines · Philipp Tomsich
Quoted 11 lines

Add space around operator "+", make it
match the coding style.

Signed-off-by Andy Yan <[email protected]>

---

Changes in v2: None

  arch/arm/include/asm/armv8/mmu.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by Philipp Tomsich <[email protected]>
#6 lore raw

PATCH v2 2/2 armv8: mmu: add space around operator

In reply to Andy Yan
Quoted 6 lines · Andy Yan

Add space around operator "+", make it
match the coding style.

Signed-off-by Andy Yan <[email protected]>
Reviewed-by Philipp Tomsich <[email protected]>
Reviewed-by York Sun <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170912/01f1bb7e/attachment.sig>
#7 lore raw

PATCH v2 1/2 armv8: mmu: remove unused macro definition

In reply to Andy Yan
Quoted 6 lines · Andy Yan

Macro VA_BITS and PTE_BLOCK_BITS are not used
in the code, so remove them.

Signed-off-by Andy Yan <[email protected]>
Reviewed-by Philipp Tomsich <[email protected]>
Quoted 9 lines

---

Changes in v2:
- remove CONFIG_SYS_PTL2_BITS from the whitelist

  arch/arm/include/asm/armv8/mmu.h | 9 ---------
  scripts/config_whitelist.txt     | 2 --
  2 files changed, 11 deletions(-)
Reviewed-by York Sun <[email protected]>
#8 lore raw

PATCH v2 1/2 armv8: mmu: remove unused macro definition

In reply to Andy Yan
Quoted 6 lines · Andy Yan

Macro VA_BITS and PTE_BLOCK_BITS are not used
in the code, so remove them.

Signed-off-by Andy Yan <[email protected]>
Reviewed-by Philipp Tomsich <[email protected]>
Reviewed-by York Sun <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170912/6a6c6957/attachment.sig>