Skip to contentSkip to conversation

armv8: ls1043a: disable IFC in SPL only when QSPI is used

PATCH Superseded Yangbo Lu 2 participants 3 messages Sep 13, 2017 – Sep 15, 2017

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Yangbo Lu

author
#0 lore raw

PATCH 1/1 armv8: ls1043a: disable IFC in SPL only when QSPI is used

SD boot couldn't work with ls1043aqds_sdcard_ifc_defconfig since IFC in SPL is disabled. This patch is to fix this issue.

Signed-off-by Yangbo Lu <[email protected]>
---
 include/configs/ls1043a_common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/ls1043a_common.h +1 -1
index 002830c27e..1f9efffa56 100644
@@ -22,7 +22,7 @@
 #if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_NAND_BOOT))
 #define SPL_NO_MMC
 #endif
-#if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SD_BOOT))
+#if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SD_BOOT_QSPI))
 #define SPL_NO_IFC
 #endif
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 armv8: ls1043a: disable IFC in SPL only when QSPI is used

Quoted 2 lines · Yangbo Lu

SD boot couldn't work with ls1043aqds_sdcard_ifc_defconfig since IFC in SPL is disabled. This patch is to fix this issue.

You subject matches the change. But the commit message is confusing. Please rephrase it.

York

Quoted 20 lines
Signed-off-by Yangbo Lu <[email protected]>
---
  include/configs/ls1043a_common.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/ls1043a_common.h +1 -1
index 002830c27e..1f9efffa56 100644
@@ -22,7 +22,7 @@
  #if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_NAND_BOOT))
  #define SPL_NO_MMC
  #endif
-#if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SD_BOOT))
+#if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SD_BOOT_QSPI))
  #define SPL_NO_IFC
  #endif
author
#2 lore raw

PATCH 1/1 armv8: ls1043a: disable IFC in SPL only when QSPI is used

Hi York,

Thanks for your comments.
The v2 patch had been sent out.

Best regards,
Yangbo Lu

-----Original Message-----
From: York Sun
Sent: 2017年9月15日 5:18
To: Y.b. Lu <[email protected]>; u-boot at lists.denx.de
Subject: Re: [PATCH] armv8: ls1043a: disable IFC in SPL only when QSPI is used

Quoted 2 lines · Yangbo Lu

SD boot couldn't work with ls1043aqds_sdcard_ifc_defconfig since IFC in SPL is disabled. This patch is to fix this issue.

You subject matches the change. But the commit message is confusing. Please rephrase it.

York

Quoted 21 lines
Signed-off-by Yangbo Lu <[email protected]>
---
  include/configs/ls1043a_common.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/ls1043a_common.h +1 -1
index 002830c27e..1f9efffa56 100644
@@ -22,7 +22,7 @@
  #if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_NAND_BOOT))
  #define SPL_NO_MMC
  #endif
-#if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SD_BOOT))
+#if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SD_BOOT_QSPI))
  #define SPL_NO_IFC
  #endif