Skip to contentSkip to conversation

klibc.bbclass: Add -mfloat-abi on arm

PATCH In review Khem Raj 2 participants 3 messages Sep 13, 2017

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH v3 1/1 klibc.bbclass: Add -mfloat-abi on arm

Default toolchain is not configured for hard float therefore we need to pass the right -mfloat-abi option

---
Changes in V3: Append -mfloat-abi only on armv6

 meta-initramfs/classes/klibc.bbclass                         | 2 ++
 meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb | 1 -
 2 files changed, 2 insertions(+), 1 deletion(-)
meta-initramfs/classes/klibc.bbclass +2 -0
index c9de58cec..1ec7b2b05 100644
@@ -5,6 +5,8 @@ DEPENDS =+ "klcc-cross"
 # Set CC = "${TARGET_PREFIX}klcc -shared" to build the dynamic version.
 CC_forcevariable = "${TARGET_PREFIX}klcc ${TOOLCHAIN_OPTIONS}"
 CC_forcevariable_armv4_linux-gnueabi = "${TARGET_PREFIX}klcc ${TOOLCHAIN_OPTIONS} -march=armv4 -mthumb-interwork"
+CC_append_armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}"
+CC_append_armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}"
 
 CPP_forcevariable = "${CC} -E"
 
meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb +0 -1
index 867407723..8ca1ca727 100644
@@ -21,7 +21,6 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git;tag=b7455d847ab4f9eeeb6a729efc3
 S = "${WORKDIR}/git/"
 
 EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
-CFLAGS += "${TUNE_CCARGS}"
 
 do_install () {
 
Signature · 1 line
2.14.1
#1 lore raw
Quoted 6 lines · Khem Raj

Default toolchain is not configured for hard float therefore we need to pass the right -mfloat-abi option

---
Changes in V3: Append -mfloat-abi only on armv6

The change seems to be for armv7a and armv7ve, not armv6 ?

Quoted 37 lines
 meta-initramfs/classes/klibc.bbclass                         | 2 ++
 meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb | 1 -
 2 files changed, 2 insertions(+), 1 deletion(-)
meta-initramfs/classes/klibc.bbclass +2 -0
index c9de58cec..1ec7b2b05 100644
@@ -5,6 +5,8 @@ DEPENDS =+ "klcc-cross"
 # Set CC = "${TARGET_PREFIX}klcc -shared" to build the dynamic version.
 CC_forcevariable = "${TARGET_PREFIX}klcc ${TOOLCHAIN_OPTIONS}"
 CC_forcevariable_armv4_linux-gnueabi = "${TARGET_PREFIX}klcc ${TOOLCHAIN_OPTIONS} -march=armv4 -mthumb-interwork"
+CC_append_armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}"
+CC_append_armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}"
 
 CPP_forcevariable = "${CC} -E"
 
meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb +0 -2
index 867407723..8ca1ca727 100644
@@ -21,7 +21,6 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git;tag=b7455d847ab4f9eeeb6a729efc3
 S = "${WORKDIR}/git/"
 
 EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
-CFLAGS += "${TUNE_CCARGS}"
 
 do_install () {
 
--

2.14.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

author
#2 lore raw
Quoted 9 lines · Andre McCurdy
Quoted 6 lines · Khem Raj

Default toolchain is not configured for hard float therefore we need to pass the right -mfloat-abi option

---
Changes in V3: Append -mfloat-abi only on armv6

The change seems to be for armv7a and armv7ve, not armv6 ?

yes. its a typo in the comment I should have said arm7, I dont build for v6

Quoted 38 lines
Quoted 38 lines
 meta-initramfs/classes/klibc.bbclass                         | 2 ++
 meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb | 1 -
 2 files changed, 2 insertions(+), 1 deletion(-)
meta-initramfs/classes/klibc.bbclass +2 -0
index c9de58cec..1ec7b2b05 100644
@@ -5,6 +5,8 @@ DEPENDS =+ "klcc-cross"
 # Set CC = "${TARGET_PREFIX}klcc -shared" to build the dynamic version.
 CC_forcevariable = "${TARGET_PREFIX}klcc ${TOOLCHAIN_OPTIONS}"
 CC_forcevariable_armv4_linux-gnueabi = "${TARGET_PREFIX}klcc ${TOOLCHAIN_OPTIONS} -march=armv4 -mthumb-interwork"
+CC_append_armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}"
+CC_append_armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}"
 
 CPP_forcevariable = "${CC} -E"
 
meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb +0 -2
index 867407723..8ca1ca727 100644
@@ -21,7 +21,6 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git;tag=b7455d847ab4f9eeeb6a729efc3
 S = "${WORKDIR}/git/"
 
 EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
-CFLAGS += "${TUNE_CCARGS}"
 
 do_install () {
 
--

2.14.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel