Skip to contentSkip to conversation

package/lmv2: add missing host-pkgconf dependency

PATCH New Romain Naour 2 participants 4 messages Sep 13, 2017 – Sep 24, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/lmv2: add missing host-pkgconf dependency

configure.ac use PKG_CHECK_MODULES macro to find some libraries dependencies. So add host-pkgconf in LVM2_DEPENDENCIES.

Fixes:
checking pkg-config is at least version 0.9.0... ./configure: line 9875: [...]/host/bin/pkg-config: No such file or directory

---
 package/lvm2/lvm2.mk | 2 ++
 1 file changed, 2 insertions(+)
package/lvm2/lvm2.mk +2 -0
index 63ac109..f7f7069 100644
@@ -21,6 +21,8 @@ LVM2_CONF_OPTS += \
 	--enable-dmeventd \
 	--disable-nls
 
+LVM2_DEPENDENCIES += host-pkgconf
+
 # LVM2 uses autoconf, but not automake, and the build system does not
 # take into account the toolchain passed at configure time.
 LVM2_MAKE_ENV = $(TARGET_CONFIGURE_OPTS)
Signature · 1 line
2.9.5
#1 lore raw

PATCH 1/1 package/lmv2: add missing host-pkgconf dependency

Quoted 5 lines · Romain Naour

configure.ac use PKG_CHECK_MODULES macro to find some libraries dependencies. So add host-pkgconf in LVM2_DEPENDENCIES.

Fixes:
checking pkg-config is at least version 0.9.0... ./configure: line 9875: [...]/host/bin/pkg-config: No such file or directory

Any idea why the autobuilders didn't hit this failure?

Regards,
Arnout

Quoted 20 lines
---
 package/lvm2/lvm2.mk | 2 ++
 1 file changed, 2 insertions(+)
package/lvm2/lvm2.mk +2 -0
index 63ac109..f7f7069 100644
@@ -21,6 +21,8 @@ LVM2_CONF_OPTS += \
 	--enable-dmeventd \
 	--disable-nls
 
+LVM2_DEPENDENCIES += host-pkgconf
+
 # LVM2 uses autoconf, but not automake, and the build system does not
 # take into account the toolchain passed at configure time.
 LVM2_MAKE_ENV = $(TARGET_CONFIGURE_OPTS)
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#2 lore raw

PATCH 1/1 package/lmv2: add missing host-pkgconf dependency

Quoted 10 lines · Arnout Vandecappelle
Quoted 5 lines · Romain Naour

configure.ac use PKG_CHECK_MODULES macro to find some libraries dependencies. So add host-pkgconf in LVM2_DEPENDENCIES.

Fixes:
checking pkg-config is at least version 0.9.0... ./configure: line 9875: [...]/host/bin/pkg-config: No such file or directory

Any idea why the autobuilders didn't hit this failure?

Even though you didn't answer :-) I applied to master after all, since
configure clearly really wants pkg-config. Thanks!

Regards,
Arnout

Quoted 21 lines
Quoted 20 lines
---
 package/lvm2/lvm2.mk | 2 ++
 1 file changed, 2 insertions(+)
package/lvm2/lvm2.mk +2 -0
index 63ac109..f7f7069 100644
@@ -21,6 +21,8 @@ LVM2_CONF_OPTS += \
 	--enable-dmeventd \
 	--disable-nls
 
+LVM2_DEPENDENCIES += host-pkgconf
+
 # LVM2 uses autoconf, but not automake, and the build system does not
 # take into account the toolchain passed at configure time.
 LVM2_MAKE_ENV = $(TARGET_CONFIGURE_OPTS)
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#3 lore raw

PATCH 1/1 package/lmv2: add missing host-pkgconf dependency

Hi Arnout,

Le 24/09/2017 ? 15:01, Arnout Vandecappelle a ?crit?:

Quoted 9 lines · Arnout Vandecappelle
Quoted 6 lines · Romain Naour
Quoted 3 lines

configure.ac use PKG_CHECK_MODULES macro to find some libraries dependencies. So add host-pkgconf in LVM2_DEPENDENCIES.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Fixes:
checking pkg-config is at least version 0.9.0... ./configure: line 9875: [...]/host/bin/pkg-config: No such file or directory

Any idea why the autobuilders didn't hit this failure?

Even though you didn't answer :-) I applied to master after all, since
configure clearly really wants pkg-config. Thanks!

Sorry, I missed your reply :(

The autobuilders didn't hit this issue because when pkg-config is missing the build doesn't stop.
I noticed it by chance while looking at a build log file.

Best regards,
Romain

Quoted 26 lines

Regards,
Arnout

Quoted 21 lines
Quoted 20 lines
---
 package/lvm2/lvm2.mk | 2 ++
 1 file changed, 2 insertions(+)
package/lvm2/lvm2.mk +2 -0
index 63ac109..f7f7069 100644
@@ -21,6 +21,8 @@ LVM2_CONF_OPTS += \
 	--enable-dmeventd \
 	--disable-nls
 
+LVM2_DEPENDENCIES += host-pkgconf
+
 # LVM2 uses autoconf, but not automake, and the build system does not
 # take into account the toolchain passed at configure time.
 LVM2_MAKE_ENV = $(TARGET_CONFIGURE_OPTS)