Skip to contentSkip to conversation

tools: objtool: fix memory leak in elf_create_rela_section()

PATCH In review Josh Poimboeuf 4 participants 7 messages Sep 13, 2017 – Sep 15, 2017 objtool

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools: objtool: fix memory leak in elf_create_rela_section()

From: Martin Kepplinger <[email protected]>

Let's free the allocated char array relaname before returning in order to avoid leaking memory.

---
 tools/objtool/elf.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
tools/objtool/elf.c +5 -1
index 6e9f980a7d26..6aacbc31316d 100644
@@ -508,8 +508,12 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base)
 	strcat(relaname, base->name);
 
 	sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0);
-	if (!sec)
+	if (!sec) {
+		free(relaname);
 		return NULL;
+	}
+
+	free(relaname);
 
 	base->rela = sec;
 	sec->base = base;
Signature · 1 line
2.13.5
#1 lore raw
Quoted 16 lines · Josh Poimboeuf

From: Martin Kepplinger <[email protected]>

Let's free the allocated char array relaname before returning in order to avoid leaking memory.

---
 tools/objtool/elf.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
tools/objtool/elf.c +0 -0
index 6e9f980a7d26..6aacbc31316d 100644

tools/objtool/elf.c struct section *elf_create_rela_section(struct elf *elf, struct section *base) · line 516

Quoted 10 lines
tools/objtool/elf.c +5 -1
@@ -508,8 +508,12 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base)
 	strcat(relaname, base->name);
 
 	sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0);
-	if (!sec)
+	if (!sec) {
+		free(relaname);
 		return NULL;
+	}
+
+	free(relaname);

Erm, I'm quite sure if you read this code a second time you'll see how this pattern could be improved! ;-)

Thanks,

Ingo

#2 lore raw

PATCH v2 1/1 tools: objtool: fix memory leak in elf_create_rela_section()

Let's free the allocated char array relaname before returning in order to avoid leaking memory.

---

I should've allocated some brain resources before freeing some computer's.

 tools/objtool/elf.c | 1 +
 1 file changed, 1 insertion(+)
tools/objtool/elf.c +1 -0
index 6e9f980a7d26..1e89a5f8bfc9 100644
@@ -508,6 +508,7 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base)
 	strcat(relaname, base->name);
 
 	sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0);
+	free(relaname);
 	if (!sec)
 		return NULL;
 
Signature · 1 line
2.11.0
author Acked-by on v2 1/1
#3 lore raw
Quoted 7 lines · Martin Kepplinger

Let's free the allocated char array relaname before returning in order to avoid leaking memory.

---

I should've allocated some brain resources before freeing some computer's.

Oops. I also failed to engage the brain. Sometimes the simplest patches are the most deceptive. ;-)

Signature · 1 line
Josh
#4 lore raw

[tip:core/urgent] tools/objtool: Fix memory leak in elf_create_rela_section()

In reply to Martin Kepplinger
tools/objtool: Fix memory leak in elf_create_rela_section()
Commit-ID:  5d0be52d44e32ae98b1345e9ecfa6a97783ca2c9
Gitweb:     http://git.kernel.org/tip/5d0be52d44e32ae98b1345e9ecfa6a97783ca2c9
Author:     Martin Kepplinger <[email protected]>
AuthorDate: Thu, 14 Sep 2017 08:01:38 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 14 Sep 2017 16:02:30 +0200

tools/objtool: Fix memory leak in elf_create_rela_section()

Let's free the allocated char array 'relaname' before returning, in order to avoid leaking memory.

---
 tools/objtool/elf.c | 1 +
 1 file changed, 1 insertion(+)
tools/objtool/elf.c +1 -0
index 6e9f980..1e89a5f 100644
@@ -508,6 +508,7 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base)
 	strcat(relaname, base->name);
 
 	sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0);
+	free(relaname);
 	if (!sec)
 		return NULL;
 
#5 lore raw

[tip:core/urgent] tools/objtool: Fix memory leak in elf_create_rela_section()

In reply to Martin Kepplinger
tools/objtool: Fix memory leak in elf_create_rela_section()
Commit-ID:  5b1972d74446bed79df5ddc9674bc3f2a0b6c444
Gitweb:     http://git.kernel.org/tip/5b1972d74446bed79df5ddc9674bc3f2a0b6c444
Author:     Martin Kepplinger <[email protected]>
AuthorDate: Thu, 14 Sep 2017 08:01:38 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Fri, 15 Sep 2017 10:30:30 +0200

tools/objtool: Fix memory leak in elf_create_rela_section()

Let's free the allocated char array 'relaname' before returning, in order to avoid leaking memory.

---
 tools/objtool/elf.c | 1 +
 1 file changed, 1 insertion(+)
tools/objtool/elf.c +1 -0
index 6e9f980..1e89a5f 100644
@@ -508,6 +508,7 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base)
 	strcat(relaname, base->name);
 
 	sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0);
+	free(relaname);
 	if (!sec)
 		return NULL;
 
#6 lore raw

[tip:core/urgent] objtool: Fix memory leak in elf_create_rela_section()

In reply to Martin Kepplinger
objtool: Fix memory leak in elf_create_rela_section()
Commit-ID:  0998b7a0befdf6e734032895ee639a5e6f88cc3f
Gitweb:     http://git.kernel.org/tip/0998b7a0befdf6e734032895ee639a5e6f88cc3f
Author:     Martin Kepplinger <[email protected]>
AuthorDate: Thu, 14 Sep 2017 08:01:38 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Fri, 15 Sep 2017 11:31:43 +0200

objtool: Fix memory leak in elf_create_rela_section()

Let's free the allocated char array 'relaname' before returning, in order to avoid leaking memory.

---
 tools/objtool/elf.c | 1 +
 1 file changed, 1 insertion(+)
tools/objtool/elf.c +1 -0
index 6e9f980..1e89a5f 100644
@@ -508,6 +508,7 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base)
 	strcat(relaname, base->name);
 
 	sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0);
+	free(relaname);
 	if (!sec)
 		return NULL;