virtio-ccw: remove stale comments on endiannes

PATCH Applied Halil Pasic 2 participants 2 messages Sep 14, 2017

Share & tools

Halil Pasic

author

2017-09-14 10:55 UTC #0 lore raw

PATCH 1/1 virtio-ccw: remove stale comments on endiannes

We have two stale comments suggesting one should think about virtio config space endiannes a bit longer. We have just done that, and came to the conclusion we are fine as is: it's the responsibility of the virtio device and not of the transport (and that is how it works now). Putting the responsibility into the transport isn't even possible, because the transport would have to know about the config space layout of each device.

Let us remove the stale comments.

Signed-off-by Halil Pasic <[email protected]>

---
 hw/s390x/virtio-ccw.c | 2 --
 1 file changed, 2 deletions(-)

hw/s390x/virtio-ccw.c +0 -2

index b1976fdd19..2262b0cc9a 100644
@@ -487,7 +487,6 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)
             ret = -EFAULT;
         } else {
             virtio_bus_get_vdev_config(&dev->bus, vdev->config);
-            /* XXX config space endianness */
             cpu_physical_memory_write(ccw.cda, vdev->config, len);
             sch->curr_status.scsw.count = ccw.count - len;
             ret = 0;

@@ -510,7 +509,6 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)
                 ret = -EFAULT;
             } else {
                 len = hw_len;
-                /* XXX config space endianness */
                 memcpy(vdev->config, config, len);
                 cpu_physical_memory_unmap(config, hw_len, 0, hw_len);
                 virtio_bus_set_vdev_config(&dev->bus, vdev->config);

Signature · 1 line

2.13.5

Cornelia Huck

Applied

2017-09-14 11:15 UTC #1 lore raw

Quoted 7 lines · On Thu, 14 Sep 2017 12:55:35 +0200 Halil Pasic <[email protected]> wrote:

We have two stale comments suggesting one should think about virtio config space endiannes a bit longer. We have just done that, and came to the conclusion we are fine as is: it's the responsibility of the virtio device and not of the transport (and that is how it works now). Putting the responsibility into the transport isn't even possible, because the transport would have to know about the config space layout of each device.

s/endianes/endianess/

Quoted 7 lines

Let us remove the stale comments.
Signed-off-by Halil Pasic <[email protected]>
Suggested-by Cornelia Huck <[email protected]>
---
 hw/s390x/virtio-ccw.c | 2 --
 1 file changed, 2 deletions(-)

Thanks, applied.