Skip to contentSkip to conversation

clk: sunxi-ng: Fix missing CLK_SET_RATE_PARENT in ccu-sun4i-a10.c

PATCH In review Alexander Syring 3 participants 3 messages Sep 14, 2017 – Sep 15, 2017

Subsystems (2)
Common clk Arm/Allwinner sunXi SoC support
lore
Share & tools
lore

Alexander Syring

author
#0 lore raw

PATCH 1/1 clk: sunxi-ng: Fix missing CLK_SET_RATE_PARENT in ccu-sun4i-a10.c

When using cpufreq-dt with default govenor other than "performance" system freezes while booting.
Adding CLK_SET_RATE_PARENT | CLK_IS_CRITICAL to clk_cpu fixes the problem.

Tested on Cubietruck (A20).

Fixes c84f5683f6E ("clk: sunxi-ng: Add sun4i/sun7i CCU driver")
Reported-by Alexander Syring <[email protected]>
Signed-off-by Alexander Syring <[email protected]>
---
 drivers/clk/sunxi-ng/ccu-sun4i-a10.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/sunxi-ng/ccu-sun4i-a10.c +1 -1
index 286b0049b7b6..a48fde191c0a 100644
@@ -223,7 +223,7 @@ static struct ccu_mux cpu_clk = {
 		.hw.init	= CLK_HW_INIT_PARENTS("cpu",
 						      cpu_parents,
 						      &ccu_mux_ops,
-						      CLK_IS_CRITICAL),
+						      CLK_SET_RATE_PARENT | CLK_IS_CRITICAL),
 	}
 };
Signature · 1 line
2.11.0
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Alexander Syring

When using cpufreq-dt with default govenor other than "performance" system freezes while booting.
Adding CLK_SET_RATE_PARENT | CLK_IS_CRITICAL to clk_cpu fixes the problem.

Tested on Cubietruck (A20).

Fixes c84f5683f6E ("clk: sunxi-ng: Add sun4i/sun7i CCU driver")
Reported-by Alexander Syring <[email protected]>

You typically don't need this if you yourself are the reporter.

Quoted 1 line
Signed-off-by Alexander Syring <[email protected]>
Acked-by Chen-Yu Tsai <[email protected]>
Quoted 20 lines
---
 drivers/clk/sunxi-ng/ccu-sun4i-a10.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/sunxi-ng/ccu-sun4i-a10.c +1 -2
index 286b0049b7b6..a48fde191c0a 100644
@@ -223,7 +223,7 @@ static struct ccu_mux cpu_clk = {
                .hw.init        = CLK_HW_INIT_PARENTS("cpu",
                                                      cpu_parents,
                                                      &ccu_mux_ops,
-                                                     CLK_IS_CRITICAL),
+                                                     CLK_SET_RATE_PARENT | CLK_IS_CRITICAL),
        }
 };
 
--

2.11.0

#2 lore raw
Quoted 6 lines · Chen-Yu Tsai
Quoted 5 lines · Alexander Syring

When using cpufreq-dt with default govenor other than "performance" system freezes while booting.
Adding CLK_SET_RATE_PARENT | CLK_IS_CRITICAL to clk_cpu fixes the problem.

Quoted 7 lines
Quoted 5 lines

Tested on Cubietruck (A20).

Fixes c84f5683f6E ("clk: sunxi-ng: Add sun4i/sun7i CCU driver")
Reported-by Alexander Syring <[email protected]>

You typically don't need this if you yourself are the reporter.

Queued for 4.15.

Thanks!
Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170915/a3c00af5/attachment.sig>