cmd: blk: Use LBAFU in the common block command

PATCH Superseded Bin Meng 2 participants 3 messages Sep 13, 2017 – Sep 15, 2017

Share & tools

Bin Meng

author

2017-09-13 02:00 UTC #0 lore raw

PATCH v2 1/1 cmd: blk: Use LBAFU in the common block command

There is already a macro LBAFU to aid formatted print with lbaint_t variables. Let's use it in the common block command codes.

Signed-off-by Bin Meng <[email protected]>

---

Changes in v2:
- rebase on top of u-boot/master

 cmd/blk_common.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

cmd/blk_common.c +4 -6

index 86c75e7..0c0c23e 100644
@@ -68,9 +68,8 @@ int blk_common_cmd(int argc, char * const argv[], enum if_type if_type,
 			ulong cnt = simple_strtoul(argv[4], NULL, 16);
 			ulong n;
 
-			printf("\n%s read: device %d block # %lld, count %ld ... ",
-			       if_name, *cur_devnump, (unsigned long long)blk,
-			       cnt);
+			printf("\n%s read: device %d block # "LBAFU", count %lu ... ",
+			       if_name, *cur_devnump, blk, cnt);
 
 			n = blk_read_devnum(if_type, *cur_devnump, blk, cnt,
 					    (ulong *)addr);

@@ -84,9 +83,8 @@ int blk_common_cmd(int argc, char * const argv[], enum if_type if_type,
 			ulong cnt = simple_strtoul(argv[4], NULL, 16);
 			ulong n;
 
-			printf("\n%s write: device %d block # %lld, count %ld ... ",
-			       if_name, *cur_devnump, (unsigned long long)blk,
-			       cnt);
+			printf("\n%s write: device %d block # "LBAFU", count %lu ... ",
+			       if_name, *cur_devnump, blk, cnt);
 
 			n = blk_write_devnum(if_type, *cur_devnump, blk, cnt,
 					     (ulong *)addr);

Signature · 1 line

2.9.2

Bin Meng

author

2017-09-15 01:24 UTC #1 lore raw

PATCH v2 1/1 cmd: blk: Use LBAFU in the common block command

Hi Tom,

Quoted 5 lines · Bin Meng

There is already a macro LBAFU to aid formatted print with lbaint_t variables. Let's use it in the common block command codes.
Signed-off-by Bin Meng <[email protected]>

Quoted 8 lines

---
Changes in v2:
- rebase on top of u-boot/master
 cmd/blk_common.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

Will you apply this one?

Regards,
Bin

Tom Rini

2017-09-15 12:32 UTC #2 lore raw

PATCH v2 1/1 cmd: blk: Use LBAFU in the common block command

In reply to Bin Meng

Quoted 4 lines · Bin Meng

There is already a macro LBAFU to aid formatted print with lbaint_t variables. Let's use it in the common block command codes.
Signed-off-by Bin Meng <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170915/ab560acd/attachment.sig>