arm64: dts: renesas: eagle: add EtherAVB support

PATCH New Sergei Shtylyov 3 participants 12 messages Sep 15, 2017 – Oct 10, 2017

Subsystems (2)

Device tree bindings Arm/RISC-V/Renesas architecture

lore

Share & tools

lore

Sergei Shtylyov

author

2017-09-15 19:43 UTC #0 lore raw

PATCH v2 8/8 arm64: dts: renesas: eagle: add EtherAVB support

Define the Eagle board dependent part of the EtherAVB device node. Enable DHCP and NFS root for the kernel booting.

Based on the original (and large) patch by Vladimir Barinov.

Signed-off-by Vladimir Barinov <[email protected]>

Signed-off-by Sergei Shtylyov <[email protected]>

---
Changes in version 2:
- uncommented the "renesas,no-ether-link" property;
- removed the "max-speed" property from the PHY node.

 arch/arm64/boot/dts/renesas/r8a77970-eagle.dts |   14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +13 -1

Index: renesas/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
===================================================================
@@ -18,10 +18,11 @@
 
 	aliases {
 		serial0 = &scif0;
+		ethernet0 = &avb;
 	};
 
 	chosen {
-		bootargs = "ignore_loglevel";
+		bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
 		stdout-path = "serial0:115200n8";
 	};

@@ -43,3 +44,14 @@
 &scif0 {
 	status = "okay";
 };
+
+&avb {
+	renesas,no-ether-link;
+	phy-handle = <&phy0>;
+	status = "okay";
+
+	phy0: ethernet-phy at 0 {
+		rxc-skew-ps = <1500>;
+		reg = <0>;
+	};
+};

Geert Uytterhoeven

2017-09-21 13:08 UTC #1 lore raw

PATCH v2 8/8 arm64: dts: renesas: eagle: add EtherAVB support

Hi Sergei,

Quoted 26 lines · Sergei Shtylyov

Define the Eagle board dependent part of the EtherAVB device node. Enable DHCP and NFS root for the kernel booting.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by Vladimir Barinov <[email protected]>
Signed-off-by Sergei Shtylyov <[email protected]>
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +2 -1
@@ -18,10 +18,11 @@
 
        aliases {
                serial0 = &scif0;
+               ethernet0 = &avb;
        };
 
        chosen {
-               bootargs = "ignore_loglevel";
+               bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
                stdout-path = "serial0:115200n8";
        };
 
@@ -43,3 +44,14 @@
 &scif0 {
        status = "okay";

arch/arm64/boot/dts/renesas/r8a77970-eagle.dts line 55

Quoted 10 lines

arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +9 -0

 };
+
+&avb {
+       renesas,no-ether-link;
+       phy-handle = <&phy0>;
+       status = "okay";
+
+       phy0: ethernet-phy at 0 {
+               rxc-skew-ps = <1500>;
+               reg = <0>;

Any specific reason why you don't want to wire up the interrupt?

                interrupt-parent = <&gpio2>;
                interrupts = <11 IRQ_TYPE_LEVEL_LOW>;

arch/arm64/boot/dts/renesas/r8a77970-eagle.dts line 57

Quoted 2 lines

arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +2 -0
+       };
+};

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Sergei Shtylyov

author

2017-09-21 16:03 UTC #2 lore raw

PATCH v2 8/8 arm64: dts: renesas: eagle: add EtherAVB support

Quoted 10 lines · Geert Uytterhoeven

Quoted 10 lines
Define the Eagle board dependent part of the EtherAVB device node. Enable DHCP and NFS root for the kernel booting.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by Vladimir Barinov <[email protected]>
Signed-off-by Sergei Shtylyov <[email protected]>
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +0 -0

[...]

Quoted 16 lines

arch/arm64/boot/dts/renesas/r8a77970-eagle.dts line 55
Quoted 13 lines
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +9 -0
@@ -43,3 +44,14 @@
  &scif0 {
         status = "okay";
  };
+
+&avb {
+       renesas,no-ether-link;
+       phy-handle = <&phy0>;
+       status = "okay";
+
+       phy0: ethernet-phy at 0 {
+               rxc-skew-ps = <1500>;
+               reg = <0>;
Any specific reason why you don't want to wire up the interrupt?

Quoted 1 line

                 interrupt-parent = <&gpio2>;

I thought it's quite obvious -- we don't have GPIOs yet, and GPIOs seem to
require PFC.

Quoted 8 lines

                 interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts line 57
Quoted 2 lines
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +2 -0
+       };
+};
Gr{oetje,eeting}s,
Geert

MBR, Sergei

Geert Uytterhoeven

2017-09-21 16:09 UTC #3 lore raw

PATCH v2 8/8 arm64: dts: renesas: eagle: add EtherAVB support

Hi Sergei,

Quoted 32 lines · Sergei Shtylyov

Quoted 11 lines · Geert Uytterhoeven
Quoted 11 lines
Define the Eagle board dependent part of the EtherAVB device node. Enable DHCP and NFS root for the kernel booting.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by Vladimir Barinov <[email protected]>
Signed-off-by Sergei Shtylyov <[email protected]>
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +0 -0
[...]
Quoted 18 lines
Quoted 4 lines
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +0 -0
@@ -43,3 +44,14 @@
  &scif0 {
         status = "okay";
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts line 55
Quoted 10 lines
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +9 -0
  };
+
+&avb {
+       renesas,no-ether-link;
+       phy-handle = <&phy0>;
+       status = "okay";
+
+       phy0: ethernet-phy at 0 {
+               rxc-skew-ps = <1500>;
+               reg = <0>;
Any specific reason why you don't want to wire up the interrupt?

Quoted 5 lines

Quoted 1 line
                 interrupt-parent = <&gpio2>;
I thought it's quite obvious -- we don't have GPIOs yet, and GPIOs seem
to require PFC.

Of course. And these can be added later.

Reviewed-by Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Simon Horman

Applied

2017-10-05 09:05 UTC #4 lore raw

PATCH v2 8/8 arm64: dts: renesas: eagle: add EtherAVB support

Quoted 39 lines · Geert Uytterhoeven

Hi Sergei,
Quoted 35 lines · Sergei Shtylyov
Quoted 11 lines · Geert Uytterhoeven
Quoted 11 lines
Define the Eagle board dependent part of the EtherAVB device node. Enable DHCP and NFS root for the kernel booting.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by Vladimir Barinov <[email protected]>
Signed-off-by Sergei Shtylyov <[email protected]>
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +0 -0
[...]
Quoted 19 lines
Quoted 4 lines
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +0 -0
@@ -43,3 +44,14 @@
  &scif0 {
         status = "okay";
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts line 55
Quoted 10 lines
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +9 -0
  };
+
+&avb {
+       renesas,no-ether-link;
+       phy-handle = <&phy0>;
+       status = "okay";
+
+       phy0: ethernet-phy at 0 {
+               rxc-skew-ps = <1500>;
+               reg = <0>;
Any specific reason why you don't want to wire up the interrupt?
                 interrupt-parent = <&gpio2>;

Quoted 6 lines

Quoted 2 lines
I thought it's quite obvious -- we don't have GPIOs yet, and GPIOs seem
to require PFC.
Of course. And these can be added later.
Reviewed-by Geert Uytterhoeven <[email protected]>

Thanks, applied.

Sergei Shtylyov

author

2017-10-05 17:18 UTC #5 lore raw

PATCH v2 8/8 arm64: dts: renesas: eagle: add EtherAVB support

Quoted 34 lines · Simon Horman

Quoted 34 lines
Quoted 34 lines
Quoted 11 lines
Quoted 11 lines
Define the Eagle board dependent part of the EtherAVB device node. Enable DHCP and NFS root for the kernel booting.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by Vladimir Barinov <[email protected]>
Signed-off-by Sergei Shtylyov <[email protected]>
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +0 -0
[...]
Quoted 19 lines
Quoted 4 lines
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +0 -0
@@ -43,3 +44,14 @@
   &scif0 {
          status = "okay";
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts line 55
Quoted 10 lines
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +9 -0
   };
+
+&avb {
+       renesas,no-ether-link;
+       phy-handle = <&phy0>;
+       status = "okay";
+
+       phy0: ethernet-phy at 0 {
+               rxc-skew-ps = <1500>;
+               reg = <0>;
Any specific reason why you don't want to wire up the interrupt?
                  interrupt-parent = <&gpio2>;

Quoted 8 lines

Quoted 6 lines
Quoted 2 lines
I thought it's quite obvious -- we don't have GPIOs yet, and GPIOs seem
to require PFC.
Of course. And these can be added later.
Reviewed-by Geert Uytterhoeven <[email protected]>
Thanks, applied.

Still not seeing any devel branch updates/tags -- have you pushed it?

MBR, Sergei

Simon Horman

2017-10-06 09:31 UTC #6 lore raw

PATCH v2 8/8 arm64: dts: renesas: eagle: add EtherAVB support

Quoted 39 lines · Sergei Shtylyov

Quoted 37 lines · Simon Horman
Quoted 37 lines
Quoted 36 lines
Quoted 11 lines
Quoted 11 lines
Define the Eagle board dependent part of the EtherAVB device node. Enable DHCP and NFS root for the kernel booting.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by Vladimir Barinov <[email protected]>
Signed-off-by Sergei Shtylyov <[email protected]>
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +0 -0
[...]
Quoted 18 lines
Quoted 4 lines
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +0 -0
@@ -43,3 +44,14 @@
  &scif0 {
         status = "okay";
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts line 55
Quoted 10 lines
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +9 -0
  };
+
+&avb {
+       renesas,no-ether-link;
+       phy-handle = <&phy0>;
+       status = "okay";
+
+       phy0: ethernet-phy at 0 {
+               rxc-skew-ps = <1500>;
+               reg = <0>;
Any specific reason why you don't want to wire up the interrupt?
Quoted 1 line
                 interrupt-parent = <&gpio2>;
I thought it's quite obvious -- we don't have GPIOs yet, and GPIOs seem
to require PFC.

Quoted 7 lines

Quoted 5 lines
Quoted 3 lines
Of course. And these can be added later.
Reviewed-by Geert Uytterhoeven <[email protected]>
Thanks, applied.
Still not seeing any devel branch updates/tags -- have you pushed it?

Sorry, there was a bit of a delay. But it is there.

Sergei Shtylyov

author

2017-10-06 09:34 UTC #7 lore raw

PATCH v2 8/8 arm64: dts: renesas: eagle: add EtherAVB support

Quoted 39 lines · Simon Horman

Quoted 39 lines
Quoted 39 lines
Quoted 39 lines
Quoted 31 lines
Quoted 11 lines
Quoted 11 lines
Define the Eagle board dependent part of the EtherAVB device node. Enable DHCP and NFS root for the kernel booting.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by Vladimir Barinov <[email protected]>
Signed-off-by Sergei Shtylyov <[email protected]>
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +0 -0
[...]
Quoted 18 lines
Quoted 4 lines
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +0 -0
@@ -43,3 +44,14 @@
   &scif0 {
          status = "okay";
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts line 55
Quoted 10 lines
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +9 -0
   };
+
+&avb {
+       renesas,no-ether-link;
+       phy-handle = <&phy0>;
+       status = "okay";
+
+       phy0: ethernet-phy at 0 {
+               rxc-skew-ps = <1500>;
+               reg = <0>;
Any specific reason why you don't want to wire up the interrupt?
Quoted 5 lines
Quoted 1 line
                  interrupt-parent = <&gpio2>;
I thought it's quite obvious -- we don't have GPIOs yet, and GPIOs seem
to require PFC.
Of course. And these can be added later.

Quoted 7 lines

Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Reviewed-by Geert Uytterhoeven <[email protected]>
Thanks, applied.
Still not seeing any devel branch updates/tags -- have you pushed it?
Sorry, there was a bit of a delay. But it is there.

Yeah, I saw it later yesterday, thanks!

MBR, Sergei

Sergei Shtylyov

author

2017-10-09 17:57 UTC #8 lore raw

PATCH v2 8/8 arm64: dts: renesas: eagle: add EtherAVB support

In reply to Simon Horman

Quoted 35 lines · Simon Horman

Quoted 35 lines
Quoted 35 lines · Geert Uytterhoeven
Quoted 11 lines
Quoted 11 lines
Define the Eagle board dependent part of the EtherAVB device node. Enable DHCP and NFS root for the kernel booting.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by Vladimir Barinov <[email protected]>
Signed-off-by Sergei Shtylyov <[email protected]>
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +0 -0
[...]
Quoted 19 lines
Quoted 4 lines
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +0 -0
@@ -43,3 +44,14 @@
   &scif0 {
          status = "okay";
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts line 55
Quoted 10 lines
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +9 -0
   };
+
+&avb {
+       renesas,no-ether-link;
+       phy-handle = <&phy0>;
+       status = "okay";
+
+       phy0: ethernet-phy at 0 {
+               rxc-skew-ps = <1500>;
+               reg = <0>;
Any specific reason why you don't want to wire up the interrupt?
                  interrupt-parent = <&gpio2>;

Quoted 8 lines

Quoted 6 lines
Quoted 2 lines
I thought it's quite obvious -- we don't have GPIOs yet, and GPIOs seem
to require PFC.
Of course. And these can be added later.
Reviewed-by Geert Uytterhoeven <[email protected]>
Thanks, applied.

    Unfortunately, you applied an outdated version of this patch. :-(

MBR, Sergei

Simon Horman

2017-10-10 07:33 UTC #9 lore raw

PATCH v2 8/8 arm64: dts: renesas: eagle: add EtherAVB support

Quoted 40 lines · Sergei Shtylyov

Quoted 38 lines · Simon Horman
Quoted 38 lines
Quoted 37 lines · Geert Uytterhoeven
Quoted 11 lines
Quoted 11 lines
Define the Eagle board dependent part of the EtherAVB device node. Enable DHCP and NFS root for the kernel booting.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by Vladimir Barinov <[email protected]>
Signed-off-by Sergei Shtylyov <[email protected]>
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +0 -0
[...]
Quoted 18 lines
Quoted 4 lines
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +0 -0
@@ -43,3 +44,14 @@
  &scif0 {
         status = "okay";
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts line 55
Quoted 10 lines
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +9 -0
  };
+
+&avb {
+       renesas,no-ether-link;
+       phy-handle = <&phy0>;
+       status = "okay";
+
+       phy0: ethernet-phy at 0 {
+               rxc-skew-ps = <1500>;
+               reg = <0>;
Any specific reason why you don't want to wire up the interrupt?
Quoted 1 line
                 interrupt-parent = <&gpio2>;
I thought it's quite obvious -- we don't have GPIOs yet, and GPIOs seem
to require PFC.

Quoted 7 lines

Quoted 5 lines
Quoted 3 lines
Of course. And these can be added later.
Reviewed-by Geert Uytterhoeven <[email protected]>
Thanks, applied.
   Unfortunately, you applied an outdated version of this patch. :-(

Sorry, I think patchwork has been playing up of late - or my use of it!

Could you repost the correct patch so I am sure to get the right one the second time around?

Simon Horman

2017-10-10 07:48 UTC #10 lore raw

PATCH v2 8/8 arm64: dts: renesas: eagle: add EtherAVB support

Quoted 45 lines · Simon Horman

Quoted 44 lines · Sergei Shtylyov
Quoted 42 lines · Simon Horman
Quoted 41 lines
Quoted 32 lines · Geert Uytterhoeven
Quoted 11 lines
Quoted 11 lines
Define the Eagle board dependent part of the EtherAVB device node. Enable DHCP and NFS root for the kernel booting.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by Vladimir Barinov <[email protected]>
Signed-off-by Sergei Shtylyov <[email protected]>
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +0 -0
[...]
Quoted 18 lines
Quoted 4 lines
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +0 -0
@@ -43,3 +44,14 @@
  &scif0 {
         status = "okay";
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts line 55
Quoted 10 lines
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +9 -0
  };
+
+&avb {
+       renesas,no-ether-link;
+       phy-handle = <&phy0>;
+       status = "okay";
+
+       phy0: ethernet-phy at 0 {
+               rxc-skew-ps = <1500>;
+               reg = <0>;
Any specific reason why you don't want to wire up the interrupt?
Quoted 5 lines
Quoted 1 line
                 interrupt-parent = <&gpio2>;
I thought it's quite obvious -- we don't have GPIOs yet, and GPIOs seem
to require PFC.
Of course. And these can be added later.
Reviewed-by Geert Uytterhoeven <[email protected]>

Quoted 8 lines

Quoted 3 lines
Quoted 1 line
Thanks, applied.
   Unfortunately, you applied an outdated version of this patch. :-(
Sorry, I think patchwork has been playing up of late - or my use of it!
Could you repost the correct patch so I am sure to get the right one the second time around?

Please ignore that request. I'll go ahead and apply v2.

Simon Horman

2017-10-10 08:03 UTC #11 lore raw

PATCH v2 8/8 arm64: dts: renesas: eagle: add EtherAVB support

Quoted 48 lines · Simon Horman

Quoted 47 lines · Simon Horman
Quoted 46 lines · Sergei Shtylyov
Quoted 43 lines · Simon Horman
Quoted 35 lines
Quoted 35 lines · Geert Uytterhoeven
Quoted 11 lines
Quoted 11 lines
Define the Eagle board dependent part of the EtherAVB device node. Enable DHCP and NFS root for the kernel booting.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by Vladimir Barinov <[email protected]>
Signed-off-by Sergei Shtylyov <[email protected]>
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +0 -0
[...]
Quoted 19 lines
Quoted 4 lines
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +0 -0
@@ -43,3 +44,14 @@
  &scif0 {
         status = "okay";
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts line 55
Quoted 10 lines
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +9 -0
  };
+
+&avb {
+       renesas,no-ether-link;
+       phy-handle = <&phy0>;
+       status = "okay";
+
+       phy0: ethernet-phy at 0 {
+               rxc-skew-ps = <1500>;
+               reg = <0>;
Any specific reason why you don't want to wire up the interrupt?
                 interrupt-parent = <&gpio2>;
Quoted 6 lines
Quoted 2 lines
I thought it's quite obvious -- we don't have GPIOs yet, and GPIOs seem
to require PFC.
Of course. And these can be added later.
Reviewed-by Geert Uytterhoeven <[email protected]>
Thanks, applied.

Quoted 8 lines

Quoted 6 lines
Quoted 1 line
   Unfortunately, you applied an outdated version of this patch. :-(
Sorry, I think patchwork has been playing up of late - or my use of it!
Could you repost the correct patch so I am sure to get the right one the second time around?
Please ignore that request. I'll go ahead and apply v2.

Done, please check renesas-next-20171010-v4.14-rc1